Bug #341
Feature #14: tags for projects
Clicking on a tag does not show tag in filter area
| Status: | In Progress | Start date: | 2011-11-18 | ||
|---|---|---|---|---|---|
| Priority: | Low | Due date: | |||
| Assignee: |  Luis Figueira | % Done: | 90% | ||
| Category: | - | ||||
| Target version: | - |
Description
If you get to the project list by clicking on a tag, the project list is (correctly) filtered by tag -- but the filter area doesn't reflect this, it shows no tags.
History
#1
Updated by Luis Figueira over 12 years ago
- Assignee changed from Luis Figueira to Chris Cannam
Fixed in eebd5b1f5eb0.
#2
Updated by Luis Figueira over 12 years ago
- Status changed from New to Resolved
#3
Updated by Chris Cannam over 12 years ago
- Status changed from Resolved to In Progress
Verified that the fix works, but two problems still:
- Minor problem: the Filters box may be invisible (because its toggling pane is closed)
- Major problem with hopefully minor fix: the tags are not filtered against HTML injection, e.g. /projects?project[tag_list]=<b>bold</b> will render the tag in bold
#4
Updated by Luis Figueira over 12 years ago
The Filters Fieldset is now visible (829052890acb);
#5
Updated by Luis Figueira over 12 years ago
- Status changed from In Progress to Feedback
stripping all html tags (JS only) - 9f2bc483b7ec
#6
Updated by Chris Cannam over 12 years ago
- Status changed from Feedback to In Progress
- Assignee changed from Chris Cannam to Luis Figueira
Confirmed that
http://test.soundsoftware.ac.uk/cannam/projects?project[tag_list]=small%3Cb%3Egnawing%3C/b%3Ethings
now gives a tag with the HTML stripped.
However,
http://test.soundsoftware.ac.uk/cannam/projects?project[tag_list]=small+gnawing+things
still gives a tag with + instead of spaces -- this is a problem because that's what you get if you click on a tag that has spaces in it in the projects list.
Also, if I actually type "small<b>gnawing</b>things" into the tag text field and hit Return, the gnawing bit comes up in bold, the tags are not stripped.
#7
Updated by Chris Cannam over 12 years ago
- Priority changed from Normal to Low
- % Done changed from 0 to 90
OK, happy with it now -- except for one tiny thing,
http://test.soundsoftware.ac.uk/cannam/projects?project[tag_list]=small+gnawing+things
still shows the + signs in the tag in the filter area (even though it searches for the correct tag with its spaces)