Bug #1962

Should refuse to open annotation files

Added by Chris Cannam over 4 years ago. Updated over 4 years ago.

Status:NewStart date:2019-11-22
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

Tony should be able to open audio files or Tony session files - no other format.

At the moment it will happily try to open an annotation file from any of the typical file-open mechanisms, if the user overrides the default file extension as applicable.

exclude-annotation-files.diff Magnifier - Patch to refuse opening annotation files 2.67 KB, downloaded 37 times Chris Cannam, 2019-11-22 11:07 AM

History

#1 Updated by Chris Cannam over 4 years ago

Hm, now that I start "fixing" this, I'm thinking there are some real use cases for the bug/misfeature/unintentional feature here. If this was v1.0 it would certainly make sense to fix it, but I'm a bit worried there may be people who are actually relying on it by now.

#2 Updated by Chris Cannam over 4 years ago

Here's a patch that implements this, but I'm going to have to think about it a bit more.

It may be better just to exclude them from the default set of selected files in the open file dialog - which is trivial to do, just pass FileFinder::SessionOrAudioFile instead of FileFinder::AnyFile to getOpenFileName.

#3 Updated by Chris Cannam over 4 years ago

Made that last change (default file type) in the repo now.

Also available in: Atom PDF