Feature #885

cancelling selection (via Esc) should also revert to pre-selection pitch candidates

Added by Chris Cannam about 10 years ago. Updated about 10 years ago.

Status:ClosedStart date:2014-03-04
Priority:ImmediateDue date:
Assignee:Chris Cannam% Done:

0%

Category:-
Target version:-

Description

Justin writes in a comment to #874:

I think we need to make a distinction between the "original" curve and the "current" curve. The original is the one returned by pYin prior to any editing. The current is the pitch curve in its current state (potentially after editing), but BEFORE the user entered "candidate mode". My point is, when the user hits Esc (assuming we implement this), they probably want to revert to the "current" curve, not to the "original" curve (think of a case where the user is editing overlapping parts of the curve for some reason).

This seems very sensible I think. That is,

  • If you make a selection, change the current pitch candidate within it, and then hide the pitch candidates with Ctrl+Return, your change should remain in force, but
  • If you make a selection, change the current pitch candidate within it, and then abandon the selection by hitting Esc, your change should be reverted to whatever it was before you made the selection

History

#1 Updated by Chris Cannam about 10 years ago

  • Status changed from New to Resolved

This is now implemented in 34797795a76c

#2 Updated by Chris Cannam about 10 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF