Bug #371

Feature #318: "Download this revision" in repository page

Download link ignores branch, tag selection

Added by Chris Cannam almost 13 years ago. Updated almost 13 years ago.

Status:ClosedStart date:2012-02-02
Priority:HighDue date:
Assignee:Chris Cannam% Done:

0%

Category:-
Target version:-

Description

The "Download as Zip" link ignores the currently selected branch and tag.

(It does appear to work correctly if you go to a specific revision via the commit ID link and click it from there -- it's just the selected branch/tag dropdowns that aren't being taken into account)

History

#1 Updated by Chris Cannam almost 13 years ago

  • Status changed from New to Resolved

Fixed in b293eb7e5c94.

The rev string was being converted to a changeset object, which was used for the archive link. But the archive link generation only involved extracting the id from the changeset (same as the initial rev string) and using that. And if the rev string was not a changeset hash but a branch or tag, then the initial conversion to changeset object would fail so we would end up without a rev at all.

Fixed by using the original rev string in archive link.

#2 Updated by Chris Cannam almost 13 years ago

  • Status changed from Resolved to Closed

Fix now live.

Also available in: Atom PDF