Mercurial > hg > svcore

changeset 1753:d954dfccd922 by-id

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Comments
author Chris Cannam
date Fri, 05 Jul 2019 16:55:20 +0100
parents 6d09d68165a4
children 8529763e2258
files base/ById.h
diffstat 1 files changed, 3 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/base/ById.h	Fri Jul 05 15:28:07 2019 +0100
+++ b/base/ById.h	Fri Jul 05 16:55:20 2019 +0100
@@ -31,16 +31,15 @@
 
 //!!! further possibilities:
 //
-//    - id can only be queried when an object is added to ById (maybe
-//      add() returns the id, and there is a ById::idOf, but the
-//      object has no public getId())
-//
 //    - get() returns a pointer wrapper that cannot be shared/copied
 //      again by the caller (except by the usual C++ trickery)
 //
 // also to do: review how often we are calling getAs<...> when we
 // could just be using get
 
+//!!! NB we still haven't solved the problem of what to do for a
+//!!! user-initiated cancel of a transform
+
 struct IdAlloc {
 
     // The value NO_ID (-1) is never allocated