# HG changeset patch # User Chris Cannam # Date 1562342120 -3600 # Node ID d954dfccd9228e44e000efada4be76f6d1a6c4f1 # Parent 6d09d68165a47e7649dbb96f44213710f5dec5df Comments diff -r 6d09d68165a4 -r d954dfccd922 base/ById.h --- a/base/ById.h Fri Jul 05 15:28:07 2019 +0100 +++ b/base/ById.h Fri Jul 05 16:55:20 2019 +0100 @@ -31,16 +31,15 @@ //!!! further possibilities: // -// - id can only be queried when an object is added to ById (maybe -// add() returns the id, and there is a ById::idOf, but the -// object has no public getId()) -// // - get() returns a pointer wrapper that cannot be shared/copied // again by the caller (except by the usual C++ trickery) // // also to do: review how often we are calling getAs<...> when we // could just be using get +//!!! NB we still haven't solved the problem of what to do for a +//!!! user-initiated cancel of a transform + struct IdAlloc { // The value NO_ID (-1) is never allocated