Mercurial > hg > audiodb

changeset 81:1d2eecdc9639

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Comment regarding leakiness of server error handling. (Will become important soon. Probably easiest handled by a check in the destructor.)
author mas01cr
date Mon, 01 Oct 2007 18:37:35 +0000
parents beff1e23e95a
children ead66378fed4
files audioDB.cpp
diffstat 1 files changed, 4 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/audioDB.cpp	Mon Oct 01 14:55:18 2007 +0000
+++ b/audioDB.cpp	Mon Oct 01 18:37:35 2007 +0000
@@ -4,6 +4,10 @@
 
 void audioDB::error(const char* a, const char* b, const char *sysFunc) {
   if(isServer) {
+    /* FIXME: I think this is leaky -- we never delete err.  actually
+       deleting it is tricky, though; it gets placed into some
+       soap-internal struct with uncertain extent... -- CSR,
+       2007-10-01 */
     char *err = new char[256]; /* FIXME: overflows */
     snprintf(err, 255, "%s: %s\n%s", a, b, sysFunc ? strerror(errno) : "");
     /* FIXME: actually we could usefully do with a properly structured