# HG changeset patch
# User mas01cr
# Date 1191263855 0
# Node ID 1d2eecdc9639cdea01ac961f3869552670abe9f4
# Parent  beff1e23e95a55d38290832822b4d3af02fdee81
Comment regarding leakiness of server error handling.

(Will become important soon.  Probably easiest handled by a check in
the destructor.)

diff -r beff1e23e95a -r 1d2eecdc9639 audioDB.cpp
--- a/audioDB.cpp	Mon Oct 01 14:55:18 2007 +0000
+++ b/audioDB.cpp	Mon Oct 01 18:37:35 2007 +0000
@@ -4,6 +4,10 @@
 
 void audioDB::error(const char* a, const char* b, const char *sysFunc) {
   if(isServer) {
+    /* FIXME: I think this is leaky -- we never delete err.  actually
+       deleting it is tricky, though; it gets placed into some
+       soap-internal struct with uncertain extent... -- CSR,
+       2007-10-01 */
     char *err = new char[256]; /* FIXME: overflows */
     snprintf(err, 255, "%s: %s\n%s", a, b, sysFunc ? strerror(errno) : "");
     /* FIXME: actually we could usefully do with a properly structured