Mercurial > hg > svgui

changeset 1559:e6e7a8dc3b38 spectrogram-export

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Update in-progress comments only
author Chris Cannam
date Wed, 08 Jan 2020 15:29:02 +0000
parents 760ada8e3972
children 27f3e64489e1
files layer/Colour3DPlotExporter.cpp
diffstat 1 files changed, 7 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
--- a/layer/Colour3DPlotExporter.cpp	Tue Jan 07 14:57:40 2020 +0000
+++ b/layer/Colour3DPlotExporter.cpp	Wed Jan 08 15:29:02 2020 +0000
@@ -90,11 +90,8 @@
     //!!! todo: what about the other export types besides
     //!!! delimited-data-string ?
 
-    //!!! todo: scripted regression tests for layer exports (of all
-    //!!! types)
-
-    //!!! todo: export selected region only (we have the necessaries
-    //!!! here, but it needs support higher up)
+    //!!! todo: export selections only (we have the necessaries here,
+    //!!! but it needs support higher up)
 
     //!!! todo: option to include timestamps for columns
     
@@ -121,15 +118,17 @@
 
         // Unlike Colour3DPlotRenderer, we don't want to scale or
         // normalise
+
+        //!!! (but might we want to threshold? we get a lot of
+        //!!! spurious output [i.e. elements not readily visible on
+        //!!! screen] for peak freqs)
         
-        //!!! (should we be handling phase layer type?)
+        //!!! (+ should we be handling phase layer type?)
 
         auto column = model->getColumn(i);
         column = ColumnOp::Column(column.data() + minbin,
                                   column.data() + minbin + nbins);
         
-        //!!! todo: peaks, frequencies (the things we came here for)
-
         QStringList list;
 
         if (binDisplay == BinDisplay::PeakFrequencies) {