# HG changeset patch
# User Chris Cannam
# Date 1578497342 0
# Node ID e6e7a8dc3b3814d5e956fd47bca9be3d05f9850c
# Parent  760ada8e3972b9cd8a50d406330d167e0a44a609
Update in-progress comments only

diff -r 760ada8e3972 -r e6e7a8dc3b38 layer/Colour3DPlotExporter.cpp
--- a/layer/Colour3DPlotExporter.cpp	Tue Jan 07 14:57:40 2020 +0000
+++ b/layer/Colour3DPlotExporter.cpp	Wed Jan 08 15:29:02 2020 +0000
@@ -90,11 +90,8 @@
     //!!! todo: what about the other export types besides
     //!!! delimited-data-string ?
 
-    //!!! todo: scripted regression tests for layer exports (of all
-    //!!! types)
-
-    //!!! todo: export selected region only (we have the necessaries
-    //!!! here, but it needs support higher up)
+    //!!! todo: export selections only (we have the necessaries here,
+    //!!! but it needs support higher up)
 
     //!!! todo: option to include timestamps for columns
     
@@ -121,15 +118,17 @@
 
         // Unlike Colour3DPlotRenderer, we don't want to scale or
         // normalise
+
+        //!!! (but might we want to threshold? we get a lot of
+        //!!! spurious output [i.e. elements not readily visible on
+        //!!! screen] for peak freqs)
         
-        //!!! (should we be handling phase layer type?)
+        //!!! (+ should we be handling phase layer type?)
 
         auto column = model->getColumn(i);
         column = ColumnOp::Column(column.data() + minbin,
                                   column.data() + minbin + nbins);
         
-        //!!! todo: peaks, frequencies (the things we came here for)
-
         QStringList list;
 
         if (binDisplay == BinDisplay::PeakFrequencies) {