annotate base/ById.cpp @ 1806:c7e9e63c7bae

Avoid some compiler warnings
author Chris Cannam
date Wed, 16 Oct 2019 15:26:01 +0100
parents 4fec4527e50e
children 710b4e44901b
rev   line source
Chris@1742 1 /* -*- c-basic-offset: 4 indent-tabs-mode: nil -*- vi:set ts=8 sts=4 sw=4: */
Chris@1742 2
Chris@1742 3 /*
Chris@1742 4 Sonic Visualiser
Chris@1742 5 An audio file viewer and annotation editor.
Chris@1742 6 Centre for Digital Music, Queen Mary, University of London.
Chris@1742 7
Chris@1742 8 This program is free software; you can redistribute it and/or
Chris@1742 9 modify it under the terms of the GNU General Public License as
Chris@1742 10 published by the Free Software Foundation; either version 2 of the
Chris@1742 11 License, or (at your option) any later version. See the file
Chris@1742 12 COPYING included with this distribution for more information.
Chris@1742 13 */
Chris@1742 14
Chris@1742 15 #include "ById.h"
Chris@1742 16
Chris@1742 17 #include <unordered_map>
Chris@1742 18 #include <typeinfo>
Chris@1742 19
Chris@1768 20 //#define DEBUG_BY_ID 1
Chris@1768 21
Chris@1742 22 int IdAlloc::getNextId()
Chris@1742 23 {
Chris@1742 24 static int nextId = 0;
Chris@1742 25 static QMutex mutex;
Chris@1742 26 QMutexLocker locker(&mutex);
Chris@1742 27 int i = nextId;
Chris@1742 28 if (nextId == INT_MAX) {
Chris@1742 29 nextId = INT_MIN;
Chris@1742 30 } else {
Chris@1742 31 ++nextId;
Chris@1742 32 if (nextId == 0 || nextId == NO_ID) {
Chris@1742 33 throw std::runtime_error("Internal ID limit exceeded!");
Chris@1742 34 }
Chris@1742 35 }
Chris@1742 36 return i;
Chris@1742 37 }
Chris@1742 38
Chris@1806 39 // "warning: expression with side effects will be evaluated despite
Chris@1806 40 // being used as an operand to 'typeid'"
Chris@1806 41 #pragma GCC diagnostic ignored "-Wpotentially-evaluated-expression"
Chris@1806 42
Chris@1742 43 class AnyById::Impl
Chris@1742 44 {
Chris@1742 45 public:
Chris@1742 46 ~Impl() {
Chris@1742 47 QMutexLocker locker(&m_mutex);
Chris@1742 48 bool empty = true;
Chris@1742 49 for (const auto &p: m_items) {
Chris@1742 50 if (p.second && p.second.use_count() > 0) {
Chris@1742 51 empty = false;
Chris@1742 52 break;
Chris@1742 53 }
Chris@1742 54 }
Chris@1742 55 if (!empty) {
Chris@1742 56 SVCERR << "WARNING: ById map is not empty at close; some items have not been released" << endl;
Chris@1742 57 SVCERR << " Unreleased items are:" << endl;
Chris@1742 58 for (const auto &p: m_items) {
Chris@1759 59 auto ptr = p.second;
Chris@1759 60 if (ptr && ptr.use_count() > 0) {
Chris@1759 61 QString message = QString("id #%1: type %2")
Chris@1759 62 .arg(p.first).arg(typeid(*ptr.get()).name());
Chris@1759 63 if (auto qobj = std::dynamic_pointer_cast<QObject>(ptr)) {
Chris@1759 64 message += QString(", object name \"%1\"")
Chris@1759 65 .arg(qobj->objectName());
Chris@1759 66 }
Chris@1759 67 message += QString(", use count %1").arg(ptr.use_count());
Chris@1759 68 SVCERR << " - " << message << endl;
Chris@1742 69 }
Chris@1742 70 }
Chris@1742 71 }
Chris@1742 72 }
Chris@1742 73
Chris@1752 74 int add(std::shared_ptr<WithId> item) {
Chris@1752 75 int id = item->getUntypedId();
Chris@1744 76 if (id == IdAlloc::NO_ID) {
Chris@1752 77 throw std::logic_error("item id should never be NO_ID");
Chris@1744 78 }
Chris@1768 79 #ifdef DEBUG_BY_ID
Chris@1761 80 SVCERR << "ById::add(#" << id << ") of type "
Chris@1761 81 << typeid(*item.get()).name() << endl;
Chris@1768 82 #endif
Chris@1742 83 QMutexLocker locker(&m_mutex);
Chris@1742 84 if (m_items.find(id) != m_items.end()) {
Chris@1742 85 SVCERR << "ById::add: item with id " << id
Chris@1742 86 << " is already recorded (existing item type is "
Chris@1742 87 << typeid(*m_items.find(id)->second.get()).name()
Chris@1742 88 << ", proposed is "
Chris@1742 89 << typeid(*item.get()).name() << ")" << endl;
Chris@1742 90 throw std::logic_error("item id is already recorded in add");
Chris@1742 91 }
Chris@1742 92 m_items[id] = item;
Chris@1752 93 return id;
Chris@1742 94 }
Chris@1742 95
Chris@1742 96 void release(int id) {
Chris@1744 97 if (id == IdAlloc::NO_ID) {
Chris@1744 98 return;
Chris@1744 99 }
Chris@1768 100 #ifdef DEBUG_BY_ID
Chris@1761 101 SVCERR << "ById::release(#" << id << ")" << endl;
Chris@1768 102 #endif
Chris@1742 103 QMutexLocker locker(&m_mutex);
Chris@1742 104 if (m_items.find(id) == m_items.end()) {
Chris@1742 105 SVCERR << "ById::release: unknown item id " << id << endl;
Chris@1742 106 throw std::logic_error("unknown item id in release");
Chris@1742 107 }
Chris@1742 108 m_items.erase(id);
Chris@1742 109 }
Chris@1742 110
Chris@1742 111 std::shared_ptr<WithId> get(int id) const {
Chris@1744 112 if (id == IdAlloc::NO_ID) {
Chris@1744 113 return {}; // this id cannot be added: avoid locking
Chris@1744 114 }
Chris@1742 115 QMutexLocker locker(&m_mutex);
Chris@1742 116 const auto &itr = m_items.find(id);
Chris@1742 117 if (itr != m_items.end()) {
Chris@1742 118 return itr->second;
Chris@1742 119 } else {
Chris@1742 120 return {};
Chris@1742 121 }
Chris@1742 122 }
Chris@1742 123
Chris@1742 124 private:
Chris@1742 125 mutable QMutex m_mutex;
Chris@1742 126 std::unordered_map<int, std::shared_ptr<WithId>> m_items;
Chris@1742 127 };
Chris@1742 128
Chris@1752 129 int
Chris@1752 130 AnyById::add(std::shared_ptr<WithId> item)
Chris@1742 131 {
Chris@1752 132 return impl().add(item);
Chris@1742 133 }
Chris@1742 134
Chris@1742 135 void
Chris@1742 136 AnyById::release(int id)
Chris@1742 137 {
Chris@1742 138 impl().release(id);
Chris@1742 139 }
Chris@1742 140
Chris@1742 141 std::shared_ptr<WithId>
Chris@1742 142 AnyById::get(int id)
Chris@1742 143 {
Chris@1742 144 return impl().get(id);
Chris@1742 145 }
Chris@1742 146
Chris@1742 147 AnyById::Impl &
Chris@1742 148 AnyById::impl()
Chris@1742 149 {
Chris@1742 150 static Impl impl;
Chris@1742 151 return impl;
Chris@1742 152 }