Mercurial > hg > soundsoftware-site

changeset 604:48c027b30576 feature_36

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Corrected pseudo-save css rules; optimized javascript.
author luisf <luis.figueira@eecs.qmul.ac.uk>
date Thu, 18 Aug 2011 15:05:16 +0100
parents 7b39f35803f3
children 8fc59e8ddd63
files vendor/plugins/redmine_bibliography/app/views/publications/_authorship_fields.rhtml vendor/plugins/redmine_bibliography/assets/javascripts/authors.js vendor/plugins/redmine_bibliography/assets/stylesheets/bibliography.css
diffstat 3 files changed, 18 insertions(+), 36 deletions(-) [+]
line wrap: on
line diff
--- a/vendor/plugins/redmine_bibliography/app/views/publications/_authorship_fields.rhtml	Thu Aug 18 13:02:03 2011 +0100
+++ b/vendor/plugins/redmine_bibliography/app/views/publications/_authorship_fields.rhtml	Thu Aug 18 15:05:16 2011 +0100
@@ -43,9 +43,7 @@
 
   </div>
 
-
   <%= button_to l(:label_save_author), {}, :onclick => "toggle_save_author(#{form_object_id(f.object_name)}); return false;" %>
 
-
   <%= link_to_remove_fields l("remove_author"), f %>
-</div>
+</div>
\ No newline at end of file
--- a/vendor/plugins/redmine_bibliography/assets/javascripts/authors.js	Thu Aug 18 13:02:03 2011 +0100
+++ b/vendor/plugins/redmine_bibliography/assets/javascripts/authors.js	Thu Aug 18 15:05:16 2011 +0100
@@ -12,33 +12,15 @@
 }
 
 function identify_author_status(status, object_id) {
-	name_field = $('publication_authorships_attributes_' + object_id + '_name_on_paper');
-    email_field = $('publication_authorships_attributes_' + object_id + '_email');
-    institution_field = $('publication_authorships_attributes_' + object_id + '_institution');
-
-	switch(status)
-	{
-		case "yes":
-			name_field.readOnly = true;
-			email_field.readOnly = true;
-			institution_field.readOnly = true;
-		break;
-		case "no":
-			name_field.value = "";
-			email_field.value = "";
-			institution_field.value = "";
+	$('publication_authorships_attributes_' + object_id + '_edit_author_info').select('input').each(function(s) {
+		if(status == "no"){
+			s.value = "";
+			s.readOnly = false;
+		};
 		
-			name_field.readOnly = false;
-			email_field.readOnly = false;
-			institution_field.readOnly = false;
-
-		break;
-		case "correct":
-			name_field.readOnly = false;
-			email_field.readOnly = false;
-			institution_field.readOnly = false;
-		break;
-	}
+		if(status == "correct"){s.readOnly = false;};
+		if(status == "yes"){s.readOnly = true;};
+	});
 }
 
 function toggle_div(div_id){	
@@ -46,15 +28,15 @@
 }
 
 function toggle_input_field(field_id){
-	$(field_id).addClassName('readonly');
-	$(field_id).next('em').hide();
+	field_id.addClassName('readonly').next('em').hide();
+	field_id.readOnly = true;
 }
 
 function toggle_save_author(form_object_id){
-	toggle_input_field("publication_authorships_attributes_" + form_object_id + "_name_on_paper");
-	toggle_input_field("publication_authorships_attributes_" + form_object_id + "_institution");
-	toggle_input_field("publication_authorships_attributes_" + form_object_id + "_email");
-
+	$('publication_authorships_attributes_' + form_object_id + '_edit_author_info').select('input').each(function(s) {
+	  toggle_input_field(s);
+	});
+	
 	toggle_div("publication_authorships_attributes_" + form_object_id +"_search_author");
 }
 
--- a/vendor/plugins/redmine_bibliography/assets/stylesheets/bibliography.css	Thu Aug 18 13:02:03 2011 +0100
+++ b/vendor/plugins/redmine_bibliography/assets/stylesheets/bibliography.css	Thu Aug 18 15:05:16 2011 +0100
@@ -5,5 +5,7 @@
 }
 
 input.readonly {
-        border: none;
+	border: none;
+	background-color: transparent;
+	
 }
\ No newline at end of file