annotate .svn/pristine/a8/a88278fbf9ee40843844de288b0641fb040fe957.svn-base @ 1524:82fac3dcf466 redmine-2.5-integration

Fix failure to interpret Javascript when autocompleting members for project
author Chris Cannam <chris.cannam@soundsoftware.ac.uk>
date Thu, 11 Sep 2014 10:24:38 +0100
parents dffacf8a6908
children
rev   line source
Chris@1517 1 # Redmine - project management software
Chris@1517 2 # Copyright (C) 2006-2014 Jean-Philippe Lang
Chris@1517 3 #
Chris@1517 4 # This program is free software; you can redistribute it and/or
Chris@1517 5 # modify it under the terms of the GNU General Public License
Chris@1517 6 # as published by the Free Software Foundation; either version 2
Chris@1517 7 # of the License, or (at your option) any later version.
Chris@1517 8 #
Chris@1517 9 # This program is distributed in the hope that it will be useful,
Chris@1517 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1517 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@1517 12 # GNU General Public License for more details.
Chris@1517 13 #
Chris@1517 14 # You should have received a copy of the GNU General Public License
Chris@1517 15 # along with this program; if not, write to the Free Software
Chris@1517 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@1517 17
Chris@1517 18 require File.expand_path('../../test_helper', __FILE__)
Chris@1517 19
Chris@1517 20 class IssueRelationTest < ActiveSupport::TestCase
Chris@1517 21 fixtures :projects,
Chris@1517 22 :users,
Chris@1517 23 :roles,
Chris@1517 24 :members,
Chris@1517 25 :member_roles,
Chris@1517 26 :issues,
Chris@1517 27 :issue_statuses,
Chris@1517 28 :issue_relations,
Chris@1517 29 :enabled_modules,
Chris@1517 30 :enumerations,
Chris@1517 31 :trackers,
Chris@1517 32 :projects_trackers
Chris@1517 33
Chris@1517 34 include Redmine::I18n
Chris@1517 35
Chris@1517 36 def test_create
Chris@1517 37 from = Issue.find(1)
Chris@1517 38 to = Issue.find(2)
Chris@1517 39
Chris@1517 40 relation = IssueRelation.new :issue_from => from, :issue_to => to,
Chris@1517 41 :relation_type => IssueRelation::TYPE_PRECEDES
Chris@1517 42 assert relation.save
Chris@1517 43 relation.reload
Chris@1517 44 assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type
Chris@1517 45 assert_equal from, relation.issue_from
Chris@1517 46 assert_equal to, relation.issue_to
Chris@1517 47 end
Chris@1517 48
Chris@1517 49 def test_create_minimum
Chris@1517 50 relation = IssueRelation.new :issue_from => Issue.find(1), :issue_to => Issue.find(2)
Chris@1517 51 assert relation.save
Chris@1517 52 assert_equal IssueRelation::TYPE_RELATES, relation.relation_type
Chris@1517 53 end
Chris@1517 54
Chris@1517 55 def test_follows_relation_should_be_reversed
Chris@1517 56 from = Issue.find(1)
Chris@1517 57 to = Issue.find(2)
Chris@1517 58
Chris@1517 59 relation = IssueRelation.new :issue_from => from, :issue_to => to,
Chris@1517 60 :relation_type => IssueRelation::TYPE_FOLLOWS
Chris@1517 61 assert relation.save
Chris@1517 62 relation.reload
Chris@1517 63 assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type
Chris@1517 64 assert_equal to, relation.issue_from
Chris@1517 65 assert_equal from, relation.issue_to
Chris@1517 66 end
Chris@1517 67
Chris@1517 68 def test_follows_relation_should_not_be_reversed_if_validation_fails
Chris@1517 69 from = Issue.find(1)
Chris@1517 70 to = Issue.find(2)
Chris@1517 71
Chris@1517 72 relation = IssueRelation.new :issue_from => from, :issue_to => to,
Chris@1517 73 :relation_type => IssueRelation::TYPE_FOLLOWS,
Chris@1517 74 :delay => 'xx'
Chris@1517 75 assert !relation.save
Chris@1517 76 assert_equal IssueRelation::TYPE_FOLLOWS, relation.relation_type
Chris@1517 77 assert_equal from, relation.issue_from
Chris@1517 78 assert_equal to, relation.issue_to
Chris@1517 79 end
Chris@1517 80
Chris@1517 81 def test_relation_type_for
Chris@1517 82 from = Issue.find(1)
Chris@1517 83 to = Issue.find(2)
Chris@1517 84
Chris@1517 85 relation = IssueRelation.new :issue_from => from, :issue_to => to,
Chris@1517 86 :relation_type => IssueRelation::TYPE_PRECEDES
Chris@1517 87 assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type_for(from)
Chris@1517 88 assert_equal IssueRelation::TYPE_FOLLOWS, relation.relation_type_for(to)
Chris@1517 89 end
Chris@1517 90
Chris@1517 91 def test_set_issue_to_dates_without_issue_to
Chris@1517 92 r = IssueRelation.new(:issue_from => Issue.new(:start_date => Date.today),
Chris@1517 93 :relation_type => IssueRelation::TYPE_PRECEDES,
Chris@1517 94 :delay => 1)
Chris@1517 95 assert_nil r.set_issue_to_dates
Chris@1517 96 end
Chris@1517 97
Chris@1517 98 def test_set_issue_to_dates_without_issues
Chris@1517 99 r = IssueRelation.new(:relation_type => IssueRelation::TYPE_PRECEDES, :delay => 1)
Chris@1517 100 assert_nil r.set_issue_to_dates
Chris@1517 101 end
Chris@1517 102
Chris@1517 103 def test_validates_circular_dependency
Chris@1517 104 IssueRelation.delete_all
Chris@1517 105 assert IssueRelation.create!(
Chris@1517 106 :issue_from => Issue.find(1), :issue_to => Issue.find(2),
Chris@1517 107 :relation_type => IssueRelation::TYPE_PRECEDES
Chris@1517 108 )
Chris@1517 109 assert IssueRelation.create!(
Chris@1517 110 :issue_from => Issue.find(2), :issue_to => Issue.find(3),
Chris@1517 111 :relation_type => IssueRelation::TYPE_PRECEDES
Chris@1517 112 )
Chris@1517 113 r = IssueRelation.new(
Chris@1517 114 :issue_from => Issue.find(3), :issue_to => Issue.find(1),
Chris@1517 115 :relation_type => IssueRelation::TYPE_PRECEDES
Chris@1517 116 )
Chris@1517 117 assert !r.save
Chris@1517 118 assert_not_equal [], r.errors[:base]
Chris@1517 119 end
Chris@1517 120
Chris@1517 121 def test_validates_circular_dependency_of_subtask
Chris@1517 122 set_language_if_valid 'en'
Chris@1517 123 issue1 = Issue.generate!
Chris@1517 124 issue2 = Issue.generate!
Chris@1517 125 IssueRelation.create!(
Chris@1517 126 :issue_from => issue1, :issue_to => issue2,
Chris@1517 127 :relation_type => IssueRelation::TYPE_PRECEDES
Chris@1517 128 )
Chris@1517 129 child = Issue.generate!(:parent_issue_id => issue2.id)
Chris@1517 130 issue1.reload
Chris@1517 131 child.reload
Chris@1517 132
Chris@1517 133 r = IssueRelation.new(
Chris@1517 134 :issue_from => child, :issue_to => issue1,
Chris@1517 135 :relation_type => IssueRelation::TYPE_PRECEDES
Chris@1517 136 )
Chris@1517 137 assert !r.save
Chris@1517 138 assert_include 'This relation would create a circular dependency', r.errors.full_messages
Chris@1517 139 end
Chris@1517 140
Chris@1517 141 def test_subtasks_should_allow_precedes_relation
Chris@1517 142 parent = Issue.generate!
Chris@1517 143 child1 = Issue.generate!(:parent_issue_id => parent.id)
Chris@1517 144 child2 = Issue.generate!(:parent_issue_id => parent.id)
Chris@1517 145
Chris@1517 146 r = IssueRelation.new(
Chris@1517 147 :issue_from => child1, :issue_to => child2,
Chris@1517 148 :relation_type => IssueRelation::TYPE_PRECEDES
Chris@1517 149 )
Chris@1517 150 assert r.valid?
Chris@1517 151 assert r.save
Chris@1517 152 end
Chris@1517 153
Chris@1517 154 def test_validates_circular_dependency_on_reverse_relations
Chris@1517 155 IssueRelation.delete_all
Chris@1517 156 assert IssueRelation.create!(
Chris@1517 157 :issue_from => Issue.find(1), :issue_to => Issue.find(3),
Chris@1517 158 :relation_type => IssueRelation::TYPE_BLOCKS
Chris@1517 159 )
Chris@1517 160 assert IssueRelation.create!(
Chris@1517 161 :issue_from => Issue.find(1), :issue_to => Issue.find(2),
Chris@1517 162 :relation_type => IssueRelation::TYPE_BLOCKED
Chris@1517 163 )
Chris@1517 164 r = IssueRelation.new(
Chris@1517 165 :issue_from => Issue.find(2), :issue_to => Issue.find(1),
Chris@1517 166 :relation_type => IssueRelation::TYPE_BLOCKED
Chris@1517 167 )
Chris@1517 168 assert !r.save
Chris@1517 169 assert_not_equal [], r.errors[:base]
Chris@1517 170 end
Chris@1517 171
Chris@1517 172 def test_create_should_make_journal_entry
Chris@1517 173 from = Issue.find(1)
Chris@1517 174 to = Issue.find(2)
Chris@1517 175 from_journals = from.journals.size
Chris@1517 176 to_journals = to.journals.size
Chris@1517 177 relation = IssueRelation.new(:issue_from => from, :issue_to => to,
Chris@1517 178 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1517 179 assert relation.save
Chris@1517 180 from.reload
Chris@1517 181 to.reload
Chris@1517 182 relation.reload
Chris@1517 183 assert_equal from.journals.size, (from_journals + 1)
Chris@1517 184 assert_equal to.journals.size, (to_journals + 1)
Chris@1517 185 assert_equal 'relation', from.journals.last.details.last.property
Chris@1517 186 assert_equal 'precedes', from.journals.last.details.last.prop_key
Chris@1517 187 assert_equal '2', from.journals.last.details.last.value
Chris@1517 188 assert_nil from.journals.last.details.last.old_value
Chris@1517 189 assert_equal 'relation', to.journals.last.details.last.property
Chris@1517 190 assert_equal 'follows', to.journals.last.details.last.prop_key
Chris@1517 191 assert_equal '1', to.journals.last.details.last.value
Chris@1517 192 assert_nil to.journals.last.details.last.old_value
Chris@1517 193 end
Chris@1517 194
Chris@1517 195 def test_delete_should_make_journal_entry
Chris@1517 196 relation = IssueRelation.find(1)
Chris@1517 197 from = relation.issue_from
Chris@1517 198 to = relation.issue_to
Chris@1517 199 from_journals = from.journals.size
Chris@1517 200 to_journals = to.journals.size
Chris@1517 201 assert relation.destroy
Chris@1517 202 from.reload
Chris@1517 203 to.reload
Chris@1517 204 assert_equal from.journals.size, (from_journals + 1)
Chris@1517 205 assert_equal to.journals.size, (to_journals + 1)
Chris@1517 206 assert_equal 'relation', from.journals.last.details.last.property
Chris@1517 207 assert_equal 'blocks', from.journals.last.details.last.prop_key
Chris@1517 208 assert_equal '9', from.journals.last.details.last.old_value
Chris@1517 209 assert_nil from.journals.last.details.last.value
Chris@1517 210 assert_equal 'relation', to.journals.last.details.last.property
Chris@1517 211 assert_equal 'blocked', to.journals.last.details.last.prop_key
Chris@1517 212 assert_equal '10', to.journals.last.details.last.old_value
Chris@1517 213 assert_nil to.journals.last.details.last.value
Chris@1517 214 end
Chris@1517 215 end