Chris@1517: # Redmine - project management software Chris@1517: # Copyright (C) 2006-2014 Jean-Philippe Lang Chris@1517: # Chris@1517: # This program is free software; you can redistribute it and/or Chris@1517: # modify it under the terms of the GNU General Public License Chris@1517: # as published by the Free Software Foundation; either version 2 Chris@1517: # of the License, or (at your option) any later version. Chris@1517: # Chris@1517: # This program is distributed in the hope that it will be useful, Chris@1517: # but WITHOUT ANY WARRANTY; without even the implied warranty of Chris@1517: # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the Chris@1517: # GNU General Public License for more details. Chris@1517: # Chris@1517: # You should have received a copy of the GNU General Public License Chris@1517: # along with this program; if not, write to the Free Software Chris@1517: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. Chris@1517: Chris@1517: require File.expand_path('../../test_helper', __FILE__) Chris@1517: Chris@1517: class IssueRelationTest < ActiveSupport::TestCase Chris@1517: fixtures :projects, Chris@1517: :users, Chris@1517: :roles, Chris@1517: :members, Chris@1517: :member_roles, Chris@1517: :issues, Chris@1517: :issue_statuses, Chris@1517: :issue_relations, Chris@1517: :enabled_modules, Chris@1517: :enumerations, Chris@1517: :trackers, Chris@1517: :projects_trackers Chris@1517: Chris@1517: include Redmine::I18n Chris@1517: Chris@1517: def test_create Chris@1517: from = Issue.find(1) Chris@1517: to = Issue.find(2) Chris@1517: Chris@1517: relation = IssueRelation.new :issue_from => from, :issue_to => to, Chris@1517: :relation_type => IssueRelation::TYPE_PRECEDES Chris@1517: assert relation.save Chris@1517: relation.reload Chris@1517: assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type Chris@1517: assert_equal from, relation.issue_from Chris@1517: assert_equal to, relation.issue_to Chris@1517: end Chris@1517: Chris@1517: def test_create_minimum Chris@1517: relation = IssueRelation.new :issue_from => Issue.find(1), :issue_to => Issue.find(2) Chris@1517: assert relation.save Chris@1517: assert_equal IssueRelation::TYPE_RELATES, relation.relation_type Chris@1517: end Chris@1517: Chris@1517: def test_follows_relation_should_be_reversed Chris@1517: from = Issue.find(1) Chris@1517: to = Issue.find(2) Chris@1517: Chris@1517: relation = IssueRelation.new :issue_from => from, :issue_to => to, Chris@1517: :relation_type => IssueRelation::TYPE_FOLLOWS Chris@1517: assert relation.save Chris@1517: relation.reload Chris@1517: assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type Chris@1517: assert_equal to, relation.issue_from Chris@1517: assert_equal from, relation.issue_to Chris@1517: end Chris@1517: Chris@1517: def test_follows_relation_should_not_be_reversed_if_validation_fails Chris@1517: from = Issue.find(1) Chris@1517: to = Issue.find(2) Chris@1517: Chris@1517: relation = IssueRelation.new :issue_from => from, :issue_to => to, Chris@1517: :relation_type => IssueRelation::TYPE_FOLLOWS, Chris@1517: :delay => 'xx' Chris@1517: assert !relation.save Chris@1517: assert_equal IssueRelation::TYPE_FOLLOWS, relation.relation_type Chris@1517: assert_equal from, relation.issue_from Chris@1517: assert_equal to, relation.issue_to Chris@1517: end Chris@1517: Chris@1517: def test_relation_type_for Chris@1517: from = Issue.find(1) Chris@1517: to = Issue.find(2) Chris@1517: Chris@1517: relation = IssueRelation.new :issue_from => from, :issue_to => to, Chris@1517: :relation_type => IssueRelation::TYPE_PRECEDES Chris@1517: assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type_for(from) Chris@1517: assert_equal IssueRelation::TYPE_FOLLOWS, relation.relation_type_for(to) Chris@1517: end Chris@1517: Chris@1517: def test_set_issue_to_dates_without_issue_to Chris@1517: r = IssueRelation.new(:issue_from => Issue.new(:start_date => Date.today), Chris@1517: :relation_type => IssueRelation::TYPE_PRECEDES, Chris@1517: :delay => 1) Chris@1517: assert_nil r.set_issue_to_dates Chris@1517: end Chris@1517: Chris@1517: def test_set_issue_to_dates_without_issues Chris@1517: r = IssueRelation.new(:relation_type => IssueRelation::TYPE_PRECEDES, :delay => 1) Chris@1517: assert_nil r.set_issue_to_dates Chris@1517: end Chris@1517: Chris@1517: def test_validates_circular_dependency Chris@1517: IssueRelation.delete_all Chris@1517: assert IssueRelation.create!( Chris@1517: :issue_from => Issue.find(1), :issue_to => Issue.find(2), Chris@1517: :relation_type => IssueRelation::TYPE_PRECEDES Chris@1517: ) Chris@1517: assert IssueRelation.create!( Chris@1517: :issue_from => Issue.find(2), :issue_to => Issue.find(3), Chris@1517: :relation_type => IssueRelation::TYPE_PRECEDES Chris@1517: ) Chris@1517: r = IssueRelation.new( Chris@1517: :issue_from => Issue.find(3), :issue_to => Issue.find(1), Chris@1517: :relation_type => IssueRelation::TYPE_PRECEDES Chris@1517: ) Chris@1517: assert !r.save Chris@1517: assert_not_equal [], r.errors[:base] Chris@1517: end Chris@1517: Chris@1517: def test_validates_circular_dependency_of_subtask Chris@1517: set_language_if_valid 'en' Chris@1517: issue1 = Issue.generate! Chris@1517: issue2 = Issue.generate! Chris@1517: IssueRelation.create!( Chris@1517: :issue_from => issue1, :issue_to => issue2, Chris@1517: :relation_type => IssueRelation::TYPE_PRECEDES Chris@1517: ) Chris@1517: child = Issue.generate!(:parent_issue_id => issue2.id) Chris@1517: issue1.reload Chris@1517: child.reload Chris@1517: Chris@1517: r = IssueRelation.new( Chris@1517: :issue_from => child, :issue_to => issue1, Chris@1517: :relation_type => IssueRelation::TYPE_PRECEDES Chris@1517: ) Chris@1517: assert !r.save Chris@1517: assert_include 'This relation would create a circular dependency', r.errors.full_messages Chris@1517: end Chris@1517: Chris@1517: def test_subtasks_should_allow_precedes_relation Chris@1517: parent = Issue.generate! Chris@1517: child1 = Issue.generate!(:parent_issue_id => parent.id) Chris@1517: child2 = Issue.generate!(:parent_issue_id => parent.id) Chris@1517: Chris@1517: r = IssueRelation.new( Chris@1517: :issue_from => child1, :issue_to => child2, Chris@1517: :relation_type => IssueRelation::TYPE_PRECEDES Chris@1517: ) Chris@1517: assert r.valid? Chris@1517: assert r.save Chris@1517: end Chris@1517: Chris@1517: def test_validates_circular_dependency_on_reverse_relations Chris@1517: IssueRelation.delete_all Chris@1517: assert IssueRelation.create!( Chris@1517: :issue_from => Issue.find(1), :issue_to => Issue.find(3), Chris@1517: :relation_type => IssueRelation::TYPE_BLOCKS Chris@1517: ) Chris@1517: assert IssueRelation.create!( Chris@1517: :issue_from => Issue.find(1), :issue_to => Issue.find(2), Chris@1517: :relation_type => IssueRelation::TYPE_BLOCKED Chris@1517: ) Chris@1517: r = IssueRelation.new( Chris@1517: :issue_from => Issue.find(2), :issue_to => Issue.find(1), Chris@1517: :relation_type => IssueRelation::TYPE_BLOCKED Chris@1517: ) Chris@1517: assert !r.save Chris@1517: assert_not_equal [], r.errors[:base] Chris@1517: end Chris@1517: Chris@1517: def test_create_should_make_journal_entry Chris@1517: from = Issue.find(1) Chris@1517: to = Issue.find(2) Chris@1517: from_journals = from.journals.size Chris@1517: to_journals = to.journals.size Chris@1517: relation = IssueRelation.new(:issue_from => from, :issue_to => to, Chris@1517: :relation_type => IssueRelation::TYPE_PRECEDES) Chris@1517: assert relation.save Chris@1517: from.reload Chris@1517: to.reload Chris@1517: relation.reload Chris@1517: assert_equal from.journals.size, (from_journals + 1) Chris@1517: assert_equal to.journals.size, (to_journals + 1) Chris@1517: assert_equal 'relation', from.journals.last.details.last.property Chris@1517: assert_equal 'precedes', from.journals.last.details.last.prop_key Chris@1517: assert_equal '2', from.journals.last.details.last.value Chris@1517: assert_nil from.journals.last.details.last.old_value Chris@1517: assert_equal 'relation', to.journals.last.details.last.property Chris@1517: assert_equal 'follows', to.journals.last.details.last.prop_key Chris@1517: assert_equal '1', to.journals.last.details.last.value Chris@1517: assert_nil to.journals.last.details.last.old_value Chris@1517: end Chris@1517: Chris@1517: def test_delete_should_make_journal_entry Chris@1517: relation = IssueRelation.find(1) Chris@1517: from = relation.issue_from Chris@1517: to = relation.issue_to Chris@1517: from_journals = from.journals.size Chris@1517: to_journals = to.journals.size Chris@1517: assert relation.destroy Chris@1517: from.reload Chris@1517: to.reload Chris@1517: assert_equal from.journals.size, (from_journals + 1) Chris@1517: assert_equal to.journals.size, (to_journals + 1) Chris@1517: assert_equal 'relation', from.journals.last.details.last.property Chris@1517: assert_equal 'blocks', from.journals.last.details.last.prop_key Chris@1517: assert_equal '9', from.journals.last.details.last.old_value Chris@1517: assert_nil from.journals.last.details.last.value Chris@1517: assert_equal 'relation', to.journals.last.details.last.property Chris@1517: assert_equal 'blocked', to.journals.last.details.last.prop_key Chris@1517: assert_equal '10', to.journals.last.details.last.old_value Chris@1517: assert_nil to.journals.last.details.last.value Chris@1517: end Chris@1517: end