annotate .svn/pristine/7b/7b79b397a58396e6741da83eb4295f4a9b8a4385.svn-base @ 1464:261b3d9a4903 redmine-2.4

Update to Redmine 2.4 branch rev 12663
author Chris Cannam
date Tue, 14 Jan 2014 14:37:42 +0000
parents
children
rev   line source
Chris@1464 1 # Redmine - project management software
Chris@1464 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
Chris@1464 3 #
Chris@1464 4 # This program is free software; you can redistribute it and/or
Chris@1464 5 # modify it under the terms of the GNU General Public License
Chris@1464 6 # as published by the Free Software Foundation; either version 2
Chris@1464 7 # of the License, or (at your option) any later version.
Chris@1464 8 #
Chris@1464 9 # This program is distributed in the hope that it will be useful,
Chris@1464 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1464 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@1464 12 # GNU General Public License for more details.
Chris@1464 13 #
Chris@1464 14 # You should have received a copy of the GNU General Public License
Chris@1464 15 # along with this program; if not, write to the Free Software
Chris@1464 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@1464 17
Chris@1464 18 require File.expand_path('../../test_helper', __FILE__)
Chris@1464 19
Chris@1464 20 class IssueTest < ActiveSupport::TestCase
Chris@1464 21 fixtures :projects, :users, :members, :member_roles, :roles,
Chris@1464 22 :groups_users,
Chris@1464 23 :trackers, :projects_trackers,
Chris@1464 24 :enabled_modules,
Chris@1464 25 :versions,
Chris@1464 26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
Chris@1464 27 :enumerations,
Chris@1464 28 :issues, :journals, :journal_details,
Chris@1464 29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
Chris@1464 30 :time_entries
Chris@1464 31
Chris@1464 32 include Redmine::I18n
Chris@1464 33
Chris@1464 34 def teardown
Chris@1464 35 User.current = nil
Chris@1464 36 end
Chris@1464 37
Chris@1464 38 def test_initialize
Chris@1464 39 issue = Issue.new
Chris@1464 40
Chris@1464 41 assert_nil issue.project_id
Chris@1464 42 assert_nil issue.tracker_id
Chris@1464 43 assert_nil issue.author_id
Chris@1464 44 assert_nil issue.assigned_to_id
Chris@1464 45 assert_nil issue.category_id
Chris@1464 46
Chris@1464 47 assert_equal IssueStatus.default, issue.status
Chris@1464 48 assert_equal IssuePriority.default, issue.priority
Chris@1464 49 end
Chris@1464 50
Chris@1464 51 def test_create
Chris@1464 52 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1464 53 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1464 54 :subject => 'test_create',
Chris@1464 55 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
Chris@1464 56 assert issue.save
Chris@1464 57 issue.reload
Chris@1464 58 assert_equal 1.5, issue.estimated_hours
Chris@1464 59 end
Chris@1464 60
Chris@1464 61 def test_create_minimal
Chris@1464 62 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1464 63 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1464 64 :subject => 'test_create')
Chris@1464 65 assert issue.save
Chris@1464 66 assert issue.description.nil?
Chris@1464 67 assert_nil issue.estimated_hours
Chris@1464 68 end
Chris@1464 69
Chris@1464 70 def test_start_date_format_should_be_validated
Chris@1464 71 set_language_if_valid 'en'
Chris@1464 72 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
Chris@1464 73 issue = Issue.new(:start_date => invalid_date)
Chris@1464 74 assert !issue.valid?
Chris@1464 75 assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
Chris@1464 76 end
Chris@1464 77 end
Chris@1464 78
Chris@1464 79 def test_due_date_format_should_be_validated
Chris@1464 80 set_language_if_valid 'en'
Chris@1464 81 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
Chris@1464 82 issue = Issue.new(:due_date => invalid_date)
Chris@1464 83 assert !issue.valid?
Chris@1464 84 assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
Chris@1464 85 end
Chris@1464 86 end
Chris@1464 87
Chris@1464 88 def test_due_date_lesser_than_start_date_should_not_validate
Chris@1464 89 set_language_if_valid 'en'
Chris@1464 90 issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
Chris@1464 91 assert !issue.valid?
Chris@1464 92 assert_include 'Due date must be greater than start date', issue.errors.full_messages
Chris@1464 93 end
Chris@1464 94
Chris@1464 95 def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
Chris@1464 96 issue = Issue.generate(:start_date => '2013-06-04')
Chris@1464 97 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
Chris@1464 98 assert !issue.valid?
Chris@1464 99 assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
Chris@1464 100 end
Chris@1464 101
Chris@1464 102 def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
Chris@1464 103 issue = Issue.generate!(:start_date => '2013-06-04')
Chris@1464 104 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
Chris@1464 105 issue.start_date = '2013-06-07'
Chris@1464 106 assert !issue.valid?
Chris@1464 107 assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
Chris@1464 108 end
Chris@1464 109
Chris@1464 110 def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
Chris@1464 111 issue = Issue.generate!(:start_date => '2013-06-04')
Chris@1464 112 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
Chris@1464 113 assert issue.valid?
Chris@1464 114 end
Chris@1464 115
Chris@1464 116 def test_estimated_hours_should_be_validated
Chris@1464 117 set_language_if_valid 'en'
Chris@1464 118 ['-2'].each do |invalid|
Chris@1464 119 issue = Issue.new(:estimated_hours => invalid)
Chris@1464 120 assert !issue.valid?
Chris@1464 121 assert_include 'Estimated time is invalid', issue.errors.full_messages
Chris@1464 122 end
Chris@1464 123 end
Chris@1464 124
Chris@1464 125 def test_create_with_required_custom_field
Chris@1464 126 set_language_if_valid 'en'
Chris@1464 127 field = IssueCustomField.find_by_name('Database')
Chris@1464 128 field.update_attribute(:is_required, true)
Chris@1464 129
Chris@1464 130 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 131 :status_id => 1, :subject => 'test_create',
Chris@1464 132 :description => 'IssueTest#test_create_with_required_custom_field')
Chris@1464 133 assert issue.available_custom_fields.include?(field)
Chris@1464 134 # No value for the custom field
Chris@1464 135 assert !issue.save
Chris@1464 136 assert_equal ["Database can't be blank"], issue.errors.full_messages
Chris@1464 137 # Blank value
Chris@1464 138 issue.custom_field_values = { field.id => '' }
Chris@1464 139 assert !issue.save
Chris@1464 140 assert_equal ["Database can't be blank"], issue.errors.full_messages
Chris@1464 141 # Invalid value
Chris@1464 142 issue.custom_field_values = { field.id => 'SQLServer' }
Chris@1464 143 assert !issue.save
Chris@1464 144 assert_equal ["Database is not included in the list"], issue.errors.full_messages
Chris@1464 145 # Valid value
Chris@1464 146 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1464 147 assert issue.save
Chris@1464 148 issue.reload
Chris@1464 149 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
Chris@1464 150 end
Chris@1464 151
Chris@1464 152 def test_create_with_group_assignment
Chris@1464 153 with_settings :issue_group_assignment => '1' do
Chris@1464 154 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
Chris@1464 155 :subject => 'Group assignment',
Chris@1464 156 :assigned_to_id => 11).save
Chris@1464 157 issue = Issue.first(:order => 'id DESC')
Chris@1464 158 assert_kind_of Group, issue.assigned_to
Chris@1464 159 assert_equal Group.find(11), issue.assigned_to
Chris@1464 160 end
Chris@1464 161 end
Chris@1464 162
Chris@1464 163 def test_create_with_parent_issue_id
Chris@1464 164 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1464 165 :author_id => 1, :subject => 'Group assignment',
Chris@1464 166 :parent_issue_id => 1)
Chris@1464 167 assert_save issue
Chris@1464 168 assert_equal 1, issue.parent_issue_id
Chris@1464 169 assert_equal Issue.find(1), issue.parent
Chris@1464 170 end
Chris@1464 171
Chris@1464 172 def test_create_with_sharp_parent_issue_id
Chris@1464 173 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1464 174 :author_id => 1, :subject => 'Group assignment',
Chris@1464 175 :parent_issue_id => "#1")
Chris@1464 176 assert_save issue
Chris@1464 177 assert_equal 1, issue.parent_issue_id
Chris@1464 178 assert_equal Issue.find(1), issue.parent
Chris@1464 179 end
Chris@1464 180
Chris@1464 181 def test_create_with_invalid_parent_issue_id
Chris@1464 182 set_language_if_valid 'en'
Chris@1464 183 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1464 184 :author_id => 1, :subject => 'Group assignment',
Chris@1464 185 :parent_issue_id => '01ABC')
Chris@1464 186 assert !issue.save
Chris@1464 187 assert_equal '01ABC', issue.parent_issue_id
Chris@1464 188 assert_include 'Parent task is invalid', issue.errors.full_messages
Chris@1464 189 end
Chris@1464 190
Chris@1464 191 def test_create_with_invalid_sharp_parent_issue_id
Chris@1464 192 set_language_if_valid 'en'
Chris@1464 193 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1464 194 :author_id => 1, :subject => 'Group assignment',
Chris@1464 195 :parent_issue_id => '#01ABC')
Chris@1464 196 assert !issue.save
Chris@1464 197 assert_equal '#01ABC', issue.parent_issue_id
Chris@1464 198 assert_include 'Parent task is invalid', issue.errors.full_messages
Chris@1464 199 end
Chris@1464 200
Chris@1464 201 def assert_visibility_match(user, issues)
Chris@1464 202 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
Chris@1464 203 end
Chris@1464 204
Chris@1464 205 def test_visible_scope_for_anonymous
Chris@1464 206 # Anonymous user should see issues of public projects only
Chris@1464 207 issues = Issue.visible(User.anonymous).all
Chris@1464 208 assert issues.any?
Chris@1464 209 assert_nil issues.detect {|issue| !issue.project.is_public?}
Chris@1464 210 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1464 211 assert_visibility_match User.anonymous, issues
Chris@1464 212 end
Chris@1464 213
Chris@1464 214 def test_visible_scope_for_anonymous_without_view_issues_permissions
Chris@1464 215 # Anonymous user should not see issues without permission
Chris@1464 216 Role.anonymous.remove_permission!(:view_issues)
Chris@1464 217 issues = Issue.visible(User.anonymous).all
Chris@1464 218 assert issues.empty?
Chris@1464 219 assert_visibility_match User.anonymous, issues
Chris@1464 220 end
Chris@1464 221
Chris@1464 222 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
Chris@1464 223 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
Chris@1464 224 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
Chris@1464 225 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
Chris@1464 226 assert !issue.visible?(User.anonymous)
Chris@1464 227 end
Chris@1464 228
Chris@1464 229 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
Chris@1464 230 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
Chris@1464 231 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
Chris@1464 232 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
Chris@1464 233 assert !issue.visible?(User.anonymous)
Chris@1464 234 end
Chris@1464 235
Chris@1464 236 def test_visible_scope_for_non_member
Chris@1464 237 user = User.find(9)
Chris@1464 238 assert user.projects.empty?
Chris@1464 239 # Non member user should see issues of public projects only
Chris@1464 240 issues = Issue.visible(user).all
Chris@1464 241 assert issues.any?
Chris@1464 242 assert_nil issues.detect {|issue| !issue.project.is_public?}
Chris@1464 243 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1464 244 assert_visibility_match user, issues
Chris@1464 245 end
Chris@1464 246
Chris@1464 247 def test_visible_scope_for_non_member_with_own_issues_visibility
Chris@1464 248 Role.non_member.update_attribute :issues_visibility, 'own'
Chris@1464 249 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
Chris@1464 250 user = User.find(9)
Chris@1464 251
Chris@1464 252 issues = Issue.visible(user).all
Chris@1464 253 assert issues.any?
Chris@1464 254 assert_nil issues.detect {|issue| issue.author != user}
Chris@1464 255 assert_visibility_match user, issues
Chris@1464 256 end
Chris@1464 257
Chris@1464 258 def test_visible_scope_for_non_member_without_view_issues_permissions
Chris@1464 259 # Non member user should not see issues without permission
Chris@1464 260 Role.non_member.remove_permission!(:view_issues)
Chris@1464 261 user = User.find(9)
Chris@1464 262 assert user.projects.empty?
Chris@1464 263 issues = Issue.visible(user).all
Chris@1464 264 assert issues.empty?
Chris@1464 265 assert_visibility_match user, issues
Chris@1464 266 end
Chris@1464 267
Chris@1464 268 def test_visible_scope_for_member
Chris@1464 269 user = User.find(9)
Chris@1464 270 # User should see issues of projects for which user has view_issues permissions only
Chris@1464 271 Role.non_member.remove_permission!(:view_issues)
Chris@1464 272 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
Chris@1464 273 issues = Issue.visible(user).all
Chris@1464 274 assert issues.any?
Chris@1464 275 assert_nil issues.detect {|issue| issue.project_id != 3}
Chris@1464 276 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1464 277 assert_visibility_match user, issues
Chris@1464 278 end
Chris@1464 279
Chris@1464 280 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
Chris@1464 281 user = User.find(8)
Chris@1464 282 assert user.groups.any?
Chris@1464 283 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
Chris@1464 284 Role.non_member.remove_permission!(:view_issues)
Chris@1464 285
Chris@1464 286 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1464 287 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1464 288 :subject => 'Assignment test',
Chris@1464 289 :assigned_to => user.groups.first,
Chris@1464 290 :is_private => true)
Chris@1464 291
Chris@1464 292 Role.find(2).update_attribute :issues_visibility, 'default'
Chris@1464 293 issues = Issue.visible(User.find(8)).all
Chris@1464 294 assert issues.any?
Chris@1464 295 assert issues.include?(issue)
Chris@1464 296
Chris@1464 297 Role.find(2).update_attribute :issues_visibility, 'own'
Chris@1464 298 issues = Issue.visible(User.find(8)).all
Chris@1464 299 assert issues.any?
Chris@1464 300 assert issues.include?(issue)
Chris@1464 301 end
Chris@1464 302
Chris@1464 303 def test_visible_scope_for_admin
Chris@1464 304 user = User.find(1)
Chris@1464 305 user.members.each(&:destroy)
Chris@1464 306 assert user.projects.empty?
Chris@1464 307 issues = Issue.visible(user).all
Chris@1464 308 assert issues.any?
Chris@1464 309 # Admin should see issues on private projects that admin does not belong to
Chris@1464 310 assert issues.detect {|issue| !issue.project.is_public?}
Chris@1464 311 # Admin should see private issues of other users
Chris@1464 312 assert issues.detect {|issue| issue.is_private? && issue.author != user}
Chris@1464 313 assert_visibility_match user, issues
Chris@1464 314 end
Chris@1464 315
Chris@1464 316 def test_visible_scope_with_project
Chris@1464 317 project = Project.find(1)
Chris@1464 318 issues = Issue.visible(User.find(2), :project => project).all
Chris@1464 319 projects = issues.collect(&:project).uniq
Chris@1464 320 assert_equal 1, projects.size
Chris@1464 321 assert_equal project, projects.first
Chris@1464 322 end
Chris@1464 323
Chris@1464 324 def test_visible_scope_with_project_and_subprojects
Chris@1464 325 project = Project.find(1)
Chris@1464 326 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
Chris@1464 327 projects = issues.collect(&:project).uniq
Chris@1464 328 assert projects.size > 1
Chris@1464 329 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
Chris@1464 330 end
Chris@1464 331
Chris@1464 332 def test_visible_and_nested_set_scopes
Chris@1464 333 assert_equal 0, Issue.find(1).descendants.visible.all.size
Chris@1464 334 end
Chris@1464 335
Chris@1464 336 def test_open_scope
Chris@1464 337 issues = Issue.open.all
Chris@1464 338 assert_nil issues.detect(&:closed?)
Chris@1464 339 end
Chris@1464 340
Chris@1464 341 def test_open_scope_with_arg
Chris@1464 342 issues = Issue.open(false).all
Chris@1464 343 assert_equal issues, issues.select(&:closed?)
Chris@1464 344 end
Chris@1464 345
Chris@1464 346 def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
Chris@1464 347 version = Version.find(2)
Chris@1464 348 assert version.fixed_issues.any?
Chris@1464 349 assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
Chris@1464 350 end
Chris@1464 351
Chris@1464 352 def test_fixed_version_scope_with_empty_array_should_return_no_result
Chris@1464 353 assert_equal 0, Issue.fixed_version([]).count
Chris@1464 354 end
Chris@1464 355
Chris@1464 356 def test_errors_full_messages_should_include_custom_fields_errors
Chris@1464 357 field = IssueCustomField.find_by_name('Database')
Chris@1464 358
Chris@1464 359 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 360 :status_id => 1, :subject => 'test_create',
Chris@1464 361 :description => 'IssueTest#test_create_with_required_custom_field')
Chris@1464 362 assert issue.available_custom_fields.include?(field)
Chris@1464 363 # Invalid value
Chris@1464 364 issue.custom_field_values = { field.id => 'SQLServer' }
Chris@1464 365
Chris@1464 366 assert !issue.valid?
Chris@1464 367 assert_equal 1, issue.errors.full_messages.size
Chris@1464 368 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
Chris@1464 369 issue.errors.full_messages.first
Chris@1464 370 end
Chris@1464 371
Chris@1464 372 def test_update_issue_with_required_custom_field
Chris@1464 373 field = IssueCustomField.find_by_name('Database')
Chris@1464 374 field.update_attribute(:is_required, true)
Chris@1464 375
Chris@1464 376 issue = Issue.find(1)
Chris@1464 377 assert_nil issue.custom_value_for(field)
Chris@1464 378 assert issue.available_custom_fields.include?(field)
Chris@1464 379 # No change to custom values, issue can be saved
Chris@1464 380 assert issue.save
Chris@1464 381 # Blank value
Chris@1464 382 issue.custom_field_values = { field.id => '' }
Chris@1464 383 assert !issue.save
Chris@1464 384 # Valid value
Chris@1464 385 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1464 386 assert issue.save
Chris@1464 387 issue.reload
Chris@1464 388 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
Chris@1464 389 end
Chris@1464 390
Chris@1464 391 def test_should_not_update_attributes_if_custom_fields_validation_fails
Chris@1464 392 issue = Issue.find(1)
Chris@1464 393 field = IssueCustomField.find_by_name('Database')
Chris@1464 394 assert issue.available_custom_fields.include?(field)
Chris@1464 395
Chris@1464 396 issue.custom_field_values = { field.id => 'Invalid' }
Chris@1464 397 issue.subject = 'Should be not be saved'
Chris@1464 398 assert !issue.save
Chris@1464 399
Chris@1464 400 issue.reload
Chris@1464 401 assert_equal "Can't print recipes", issue.subject
Chris@1464 402 end
Chris@1464 403
Chris@1464 404 def test_should_not_recreate_custom_values_objects_on_update
Chris@1464 405 field = IssueCustomField.find_by_name('Database')
Chris@1464 406
Chris@1464 407 issue = Issue.find(1)
Chris@1464 408 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1464 409 assert issue.save
Chris@1464 410 custom_value = issue.custom_value_for(field)
Chris@1464 411 issue.reload
Chris@1464 412 issue.custom_field_values = { field.id => 'MySQL' }
Chris@1464 413 assert issue.save
Chris@1464 414 issue.reload
Chris@1464 415 assert_equal custom_value.id, issue.custom_value_for(field).id
Chris@1464 416 end
Chris@1464 417
Chris@1464 418 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
Chris@1464 419 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 420 :status_id => 1, :subject => 'Test',
Chris@1464 421 :custom_field_values => {'2' => 'Test'})
Chris@1464 422 assert !Tracker.find(2).custom_field_ids.include?(2)
Chris@1464 423
Chris@1464 424 issue = Issue.find(issue.id)
Chris@1464 425 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
Chris@1464 426
Chris@1464 427 issue = Issue.find(issue.id)
Chris@1464 428 custom_value = issue.custom_value_for(2)
Chris@1464 429 assert_not_nil custom_value
Chris@1464 430 assert_equal 'Test', custom_value.value
Chris@1464 431 end
Chris@1464 432
Chris@1464 433 def test_assigning_tracker_id_should_reload_custom_fields_values
Chris@1464 434 issue = Issue.new(:project => Project.find(1))
Chris@1464 435 assert issue.custom_field_values.empty?
Chris@1464 436 issue.tracker_id = 1
Chris@1464 437 assert issue.custom_field_values.any?
Chris@1464 438 end
Chris@1464 439
Chris@1464 440 def test_assigning_attributes_should_assign_project_and_tracker_first
Chris@1464 441 seq = sequence('seq')
Chris@1464 442 issue = Issue.new
Chris@1464 443 issue.expects(:project_id=).in_sequence(seq)
Chris@1464 444 issue.expects(:tracker_id=).in_sequence(seq)
Chris@1464 445 issue.expects(:subject=).in_sequence(seq)
Chris@1464 446 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
Chris@1464 447 end
Chris@1464 448
Chris@1464 449 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
Chris@1464 450 attributes = ActiveSupport::OrderedHash.new
Chris@1464 451 attributes['custom_field_values'] = { '1' => 'MySQL' }
Chris@1464 452 attributes['tracker_id'] = '1'
Chris@1464 453 issue = Issue.new(:project => Project.find(1))
Chris@1464 454 issue.attributes = attributes
Chris@1464 455 assert_equal 'MySQL', issue.custom_field_value(1)
Chris@1464 456 end
Chris@1464 457
Chris@1464 458 def test_reload_should_reload_custom_field_values
Chris@1464 459 issue = Issue.generate!
Chris@1464 460 issue.custom_field_values = {'2' => 'Foo'}
Chris@1464 461 issue.save!
Chris@1464 462
Chris@1464 463 issue = Issue.order('id desc').first
Chris@1464 464 assert_equal 'Foo', issue.custom_field_value(2)
Chris@1464 465
Chris@1464 466 issue.custom_field_values = {'2' => 'Bar'}
Chris@1464 467 assert_equal 'Bar', issue.custom_field_value(2)
Chris@1464 468
Chris@1464 469 issue.reload
Chris@1464 470 assert_equal 'Foo', issue.custom_field_value(2)
Chris@1464 471 end
Chris@1464 472
Chris@1464 473 def test_should_update_issue_with_disabled_tracker
Chris@1464 474 p = Project.find(1)
Chris@1464 475 issue = Issue.find(1)
Chris@1464 476
Chris@1464 477 p.trackers.delete(issue.tracker)
Chris@1464 478 assert !p.trackers.include?(issue.tracker)
Chris@1464 479
Chris@1464 480 issue.reload
Chris@1464 481 issue.subject = 'New subject'
Chris@1464 482 assert issue.save
Chris@1464 483 end
Chris@1464 484
Chris@1464 485 def test_should_not_set_a_disabled_tracker
Chris@1464 486 p = Project.find(1)
Chris@1464 487 p.trackers.delete(Tracker.find(2))
Chris@1464 488
Chris@1464 489 issue = Issue.find(1)
Chris@1464 490 issue.tracker_id = 2
Chris@1464 491 issue.subject = 'New subject'
Chris@1464 492 assert !issue.save
Chris@1464 493 assert_not_equal [], issue.errors[:tracker_id]
Chris@1464 494 end
Chris@1464 495
Chris@1464 496 def test_category_based_assignment
Chris@1464 497 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1464 498 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1464 499 :subject => 'Assignment test',
Chris@1464 500 :description => 'Assignment test', :category_id => 1)
Chris@1464 501 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
Chris@1464 502 end
Chris@1464 503
Chris@1464 504 def test_new_statuses_allowed_to
Chris@1464 505 WorkflowTransition.delete_all
Chris@1464 506 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1464 507 :old_status_id => 1, :new_status_id => 2,
Chris@1464 508 :author => false, :assignee => false)
Chris@1464 509 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1464 510 :old_status_id => 1, :new_status_id => 3,
Chris@1464 511 :author => true, :assignee => false)
Chris@1464 512 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1464 513 :old_status_id => 1, :new_status_id => 4,
Chris@1464 514 :author => false, :assignee => true)
Chris@1464 515 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1464 516 :old_status_id => 1, :new_status_id => 5,
Chris@1464 517 :author => true, :assignee => true)
Chris@1464 518 status = IssueStatus.find(1)
Chris@1464 519 role = Role.find(1)
Chris@1464 520 tracker = Tracker.find(1)
Chris@1464 521 user = User.find(2)
Chris@1464 522
Chris@1464 523 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1464 524 :project_id => 1, :author_id => 1)
Chris@1464 525 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1464 526
Chris@1464 527 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1464 528 :project_id => 1, :author => user)
Chris@1464 529 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1464 530
Chris@1464 531 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1464 532 :project_id => 1, :author_id => 1,
Chris@1464 533 :assigned_to => user)
Chris@1464 534 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1464 535
Chris@1464 536 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1464 537 :project_id => 1, :author => user,
Chris@1464 538 :assigned_to => user)
Chris@1464 539 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1464 540
Chris@1464 541 group = Group.generate!
Chris@1464 542 group.users << user
Chris@1464 543 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1464 544 :project_id => 1, :author => user,
Chris@1464 545 :assigned_to => group)
Chris@1464 546 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1464 547 end
Chris@1464 548
Chris@1464 549 def test_new_statuses_allowed_to_should_consider_group_assignment
Chris@1464 550 WorkflowTransition.delete_all
Chris@1464 551 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1464 552 :old_status_id => 1, :new_status_id => 4,
Chris@1464 553 :author => false, :assignee => true)
Chris@1464 554 user = User.find(2)
Chris@1464 555 group = Group.generate!
Chris@1464 556 group.users << user
Chris@1464 557
Chris@1464 558 issue = Issue.generate!(:author_id => 1, :assigned_to => group)
Chris@1464 559 assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
Chris@1464 560 end
Chris@1464 561
Chris@1464 562 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
Chris@1464 563 admin = User.find(1)
Chris@1464 564 issue = Issue.find(1)
Chris@1464 565 assert !admin.member_of?(issue.project)
Chris@1464 566 expected_statuses = [issue.status] +
Chris@1464 567 WorkflowTransition.find_all_by_old_status_id(
Chris@1464 568 issue.status_id).map(&:new_status).uniq.sort
Chris@1464 569 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
Chris@1464 570 end
Chris@1464 571
Chris@1464 572 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
Chris@1464 573 issue = Issue.find(1).copy
Chris@1464 574 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
Chris@1464 575
Chris@1464 576 issue = Issue.find(2).copy
Chris@1464 577 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
Chris@1464 578 end
Chris@1464 579
Chris@1464 580 def test_safe_attributes_names_should_not_include_disabled_field
Chris@1464 581 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
Chris@1464 582
Chris@1464 583 issue = Issue.new(:tracker => tracker)
Chris@1464 584 assert_include 'tracker_id', issue.safe_attribute_names
Chris@1464 585 assert_include 'status_id', issue.safe_attribute_names
Chris@1464 586 assert_include 'subject', issue.safe_attribute_names
Chris@1464 587 assert_include 'description', issue.safe_attribute_names
Chris@1464 588 assert_include 'custom_field_values', issue.safe_attribute_names
Chris@1464 589 assert_include 'custom_fields', issue.safe_attribute_names
Chris@1464 590 assert_include 'lock_version', issue.safe_attribute_names
Chris@1464 591
Chris@1464 592 tracker.core_fields.each do |field|
Chris@1464 593 assert_include field, issue.safe_attribute_names
Chris@1464 594 end
Chris@1464 595
Chris@1464 596 tracker.disabled_core_fields.each do |field|
Chris@1464 597 assert_not_include field, issue.safe_attribute_names
Chris@1464 598 end
Chris@1464 599 end
Chris@1464 600
Chris@1464 601 def test_safe_attributes_should_ignore_disabled_fields
Chris@1464 602 tracker = Tracker.find(1)
Chris@1464 603 tracker.core_fields = %w(assigned_to_id due_date)
Chris@1464 604 tracker.save!
Chris@1464 605
Chris@1464 606 issue = Issue.new(:tracker => tracker)
Chris@1464 607 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
Chris@1464 608 assert_nil issue.start_date
Chris@1464 609 assert_equal Date.parse('2012-07-14'), issue.due_date
Chris@1464 610 end
Chris@1464 611
Chris@1464 612 def test_safe_attributes_should_accept_target_tracker_enabled_fields
Chris@1464 613 source = Tracker.find(1)
Chris@1464 614 source.core_fields = []
Chris@1464 615 source.save!
Chris@1464 616 target = Tracker.find(2)
Chris@1464 617 target.core_fields = %w(assigned_to_id due_date)
Chris@1464 618 target.save!
Chris@1464 619
Chris@1464 620 issue = Issue.new(:tracker => source)
Chris@1464 621 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
Chris@1464 622 assert_equal target, issue.tracker
Chris@1464 623 assert_equal Date.parse('2012-07-14'), issue.due_date
Chris@1464 624 end
Chris@1464 625
Chris@1464 626 def test_safe_attributes_should_not_include_readonly_fields
Chris@1464 627 WorkflowPermission.delete_all
Chris@1464 628 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 629 :role_id => 1, :field_name => 'due_date',
Chris@1464 630 :rule => 'readonly')
Chris@1464 631 user = User.find(2)
Chris@1464 632
Chris@1464 633 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1464 634 assert_equal %w(due_date), issue.read_only_attribute_names(user)
Chris@1464 635 assert_not_include 'due_date', issue.safe_attribute_names(user)
Chris@1464 636
Chris@1464 637 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
Chris@1464 638 assert_equal Date.parse('2012-07-14'), issue.start_date
Chris@1464 639 assert_nil issue.due_date
Chris@1464 640 end
Chris@1464 641
Chris@1464 642 def test_safe_attributes_should_not_include_readonly_custom_fields
Chris@1464 643 cf1 = IssueCustomField.create!(:name => 'Writable field',
Chris@1464 644 :field_format => 'string',
Chris@1464 645 :is_for_all => true, :tracker_ids => [1])
Chris@1464 646 cf2 = IssueCustomField.create!(:name => 'Readonly field',
Chris@1464 647 :field_format => 'string',
Chris@1464 648 :is_for_all => true, :tracker_ids => [1])
Chris@1464 649 WorkflowPermission.delete_all
Chris@1464 650 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 651 :role_id => 1, :field_name => cf2.id.to_s,
Chris@1464 652 :rule => 'readonly')
Chris@1464 653 user = User.find(2)
Chris@1464 654 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1464 655 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
Chris@1464 656 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
Chris@1464 657
Chris@1464 658 issue.send :safe_attributes=, {'custom_field_values' => {
Chris@1464 659 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
Chris@1464 660 }}, user
Chris@1464 661 assert_equal 'value1', issue.custom_field_value(cf1)
Chris@1464 662 assert_nil issue.custom_field_value(cf2)
Chris@1464 663
Chris@1464 664 issue.send :safe_attributes=, {'custom_fields' => [
Chris@1464 665 {'id' => cf1.id.to_s, 'value' => 'valuea'},
Chris@1464 666 {'id' => cf2.id.to_s, 'value' => 'valueb'}
Chris@1464 667 ]}, user
Chris@1464 668 assert_equal 'valuea', issue.custom_field_value(cf1)
Chris@1464 669 assert_nil issue.custom_field_value(cf2)
Chris@1464 670 end
Chris@1464 671
Chris@1464 672 def test_editable_custom_field_values_should_return_non_readonly_custom_values
Chris@1464 673 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
Chris@1464 674 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1464 675 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
Chris@1464 676 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1464 677 WorkflowPermission.delete_all
Chris@1464 678 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
Chris@1464 679 :field_name => cf2.id.to_s, :rule => 'readonly')
Chris@1464 680 user = User.find(2)
Chris@1464 681
Chris@1464 682 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1464 683 values = issue.editable_custom_field_values(user)
Chris@1464 684 assert values.detect {|value| value.custom_field == cf1}
Chris@1464 685 assert_nil values.detect {|value| value.custom_field == cf2}
Chris@1464 686
Chris@1464 687 issue.tracker_id = 2
Chris@1464 688 values = issue.editable_custom_field_values(user)
Chris@1464 689 assert values.detect {|value| value.custom_field == cf1}
Chris@1464 690 assert values.detect {|value| value.custom_field == cf2}
Chris@1464 691 end
Chris@1464 692
Chris@1464 693 def test_safe_attributes_should_accept_target_tracker_writable_fields
Chris@1464 694 WorkflowPermission.delete_all
Chris@1464 695 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 696 :role_id => 1, :field_name => 'due_date',
Chris@1464 697 :rule => 'readonly')
Chris@1464 698 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1464 699 :role_id => 1, :field_name => 'start_date',
Chris@1464 700 :rule => 'readonly')
Chris@1464 701 user = User.find(2)
Chris@1464 702
Chris@1464 703 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1464 704
Chris@1464 705 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
Chris@1464 706 'due_date' => '2012-07-14'}, user
Chris@1464 707 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1464 708 assert_nil issue.due_date
Chris@1464 709
Chris@1464 710 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
Chris@1464 711 'due_date' => '2012-07-16',
Chris@1464 712 'tracker_id' => 2}, user
Chris@1464 713 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1464 714 assert_equal Date.parse('2012-07-16'), issue.due_date
Chris@1464 715 end
Chris@1464 716
Chris@1464 717 def test_safe_attributes_should_accept_target_status_writable_fields
Chris@1464 718 WorkflowPermission.delete_all
Chris@1464 719 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 720 :role_id => 1, :field_name => 'due_date',
Chris@1464 721 :rule => 'readonly')
Chris@1464 722 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
Chris@1464 723 :role_id => 1, :field_name => 'start_date',
Chris@1464 724 :rule => 'readonly')
Chris@1464 725 user = User.find(2)
Chris@1464 726
Chris@1464 727 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1464 728
Chris@1464 729 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
Chris@1464 730 'due_date' => '2012-07-14'},
Chris@1464 731 user
Chris@1464 732 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1464 733 assert_nil issue.due_date
Chris@1464 734
Chris@1464 735 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
Chris@1464 736 'due_date' => '2012-07-16',
Chris@1464 737 'status_id' => 2},
Chris@1464 738 user
Chris@1464 739 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1464 740 assert_equal Date.parse('2012-07-16'), issue.due_date
Chris@1464 741 end
Chris@1464 742
Chris@1464 743 def test_required_attributes_should_be_validated
Chris@1464 744 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
Chris@1464 745 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1464 746
Chris@1464 747 WorkflowPermission.delete_all
Chris@1464 748 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 749 :role_id => 1, :field_name => 'due_date',
Chris@1464 750 :rule => 'required')
Chris@1464 751 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 752 :role_id => 1, :field_name => 'category_id',
Chris@1464 753 :rule => 'required')
Chris@1464 754 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 755 :role_id => 1, :field_name => cf.id.to_s,
Chris@1464 756 :rule => 'required')
Chris@1464 757
Chris@1464 758 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1464 759 :role_id => 1, :field_name => 'start_date',
Chris@1464 760 :rule => 'required')
Chris@1464 761 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1464 762 :role_id => 1, :field_name => cf.id.to_s,
Chris@1464 763 :rule => 'required')
Chris@1464 764 user = User.find(2)
Chris@1464 765
Chris@1464 766 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1464 767 :status_id => 1, :subject => 'Required fields',
Chris@1464 768 :author => user)
Chris@1464 769 assert_equal [cf.id.to_s, "category_id", "due_date"],
Chris@1464 770 issue.required_attribute_names(user).sort
Chris@1464 771 assert !issue.save, "Issue was saved"
Chris@1464 772 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
Chris@1464 773 issue.errors.full_messages.sort
Chris@1464 774
Chris@1464 775 issue.tracker_id = 2
Chris@1464 776 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
Chris@1464 777 assert !issue.save, "Issue was saved"
Chris@1464 778 assert_equal ["Foo can't be blank", "Start date can't be blank"],
Chris@1464 779 issue.errors.full_messages.sort
Chris@1464 780
Chris@1464 781 issue.start_date = Date.today
Chris@1464 782 issue.custom_field_values = {cf.id.to_s => 'bar'}
Chris@1464 783 assert issue.save
Chris@1464 784 end
Chris@1464 785
Chris@1464 786 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
Chris@1464 787 WorkflowPermission.delete_all
Chris@1464 788 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 789 :role_id => 1, :field_name => 'due_date',
Chris@1464 790 :rule => 'required')
Chris@1464 791 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 792 :role_id => 1, :field_name => 'start_date',
Chris@1464 793 :rule => 'required')
Chris@1464 794 user = User.find(2)
Chris@1464 795 member = Member.find(1)
Chris@1464 796 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1464 797
Chris@1464 798 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
Chris@1464 799
Chris@1464 800 member.role_ids = [1, 2]
Chris@1464 801 member.save!
Chris@1464 802 assert_equal [], issue.required_attribute_names(user.reload)
Chris@1464 803
Chris@1464 804 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 805 :role_id => 2, :field_name => 'due_date',
Chris@1464 806 :rule => 'required')
Chris@1464 807 assert_equal %w(due_date), issue.required_attribute_names(user)
Chris@1464 808
Chris@1464 809 member.role_ids = [1, 2, 3]
Chris@1464 810 member.save!
Chris@1464 811 assert_equal [], issue.required_attribute_names(user.reload)
Chris@1464 812
Chris@1464 813 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 814 :role_id => 2, :field_name => 'due_date',
Chris@1464 815 :rule => 'readonly')
Chris@1464 816 # required + readonly => required
Chris@1464 817 assert_equal %w(due_date), issue.required_attribute_names(user)
Chris@1464 818 end
Chris@1464 819
Chris@1464 820 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
Chris@1464 821 WorkflowPermission.delete_all
Chris@1464 822 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 823 :role_id => 1, :field_name => 'due_date',
Chris@1464 824 :rule => 'readonly')
Chris@1464 825 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 826 :role_id => 1, :field_name => 'start_date',
Chris@1464 827 :rule => 'readonly')
Chris@1464 828 user = User.find(2)
Chris@1464 829 member = Member.find(1)
Chris@1464 830 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1464 831
Chris@1464 832 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
Chris@1464 833
Chris@1464 834 member.role_ids = [1, 2]
Chris@1464 835 member.save!
Chris@1464 836 assert_equal [], issue.read_only_attribute_names(user.reload)
Chris@1464 837
Chris@1464 838 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 839 :role_id => 2, :field_name => 'due_date',
Chris@1464 840 :rule => 'readonly')
Chris@1464 841 assert_equal %w(due_date), issue.read_only_attribute_names(user)
Chris@1464 842 end
Chris@1464 843
Chris@1464 844 def test_copy
Chris@1464 845 issue = Issue.new.copy_from(1)
Chris@1464 846 assert issue.copy?
Chris@1464 847 assert issue.save
Chris@1464 848 issue.reload
Chris@1464 849 orig = Issue.find(1)
Chris@1464 850 assert_equal orig.subject, issue.subject
Chris@1464 851 assert_equal orig.tracker, issue.tracker
Chris@1464 852 assert_equal "125", issue.custom_value_for(2).value
Chris@1464 853 end
Chris@1464 854
Chris@1464 855 def test_copy_should_copy_status
Chris@1464 856 orig = Issue.find(8)
Chris@1464 857 assert orig.status != IssueStatus.default
Chris@1464 858
Chris@1464 859 issue = Issue.new.copy_from(orig)
Chris@1464 860 assert issue.save
Chris@1464 861 issue.reload
Chris@1464 862 assert_equal orig.status, issue.status
Chris@1464 863 end
Chris@1464 864
Chris@1464 865 def test_copy_should_add_relation_with_copied_issue
Chris@1464 866 copied = Issue.find(1)
Chris@1464 867 issue = Issue.new.copy_from(copied)
Chris@1464 868 assert issue.save
Chris@1464 869 issue.reload
Chris@1464 870
Chris@1464 871 assert_equal 1, issue.relations.size
Chris@1464 872 relation = issue.relations.first
Chris@1464 873 assert_equal 'copied_to', relation.relation_type
Chris@1464 874 assert_equal copied, relation.issue_from
Chris@1464 875 assert_equal issue, relation.issue_to
Chris@1464 876 end
Chris@1464 877
Chris@1464 878 def test_copy_should_copy_subtasks
Chris@1464 879 issue = Issue.generate_with_descendants!
Chris@1464 880
Chris@1464 881 copy = issue.reload.copy
Chris@1464 882 copy.author = User.find(7)
Chris@1464 883 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1464 884 assert copy.save
Chris@1464 885 end
Chris@1464 886 copy.reload
Chris@1464 887 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
Chris@1464 888 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
Chris@1464 889 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
Chris@1464 890 assert_equal copy.author, child_copy.author
Chris@1464 891 end
Chris@1464 892
Chris@1464 893 def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
Chris@1464 894 parent = Issue.generate!
Chris@1464 895 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
Chris@1464 896 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
Chris@1464 897
Chris@1464 898 copy = parent.reload.copy
Chris@1464 899 copy.parent_issue_id = parent.id
Chris@1464 900 copy.author = User.find(7)
Chris@1464 901 assert_difference 'Issue.count', 3 do
Chris@1464 902 assert copy.save
Chris@1464 903 end
Chris@1464 904 parent.reload
Chris@1464 905 copy.reload
Chris@1464 906 assert_equal parent, copy.parent
Chris@1464 907 assert_equal 3, parent.children.count
Chris@1464 908 assert_equal 5, parent.descendants.count
Chris@1464 909 assert_equal 2, copy.children.count
Chris@1464 910 assert_equal 2, copy.descendants.count
Chris@1464 911 end
Chris@1464 912
Chris@1464 913 def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
Chris@1464 914 parent = Issue.generate!
Chris@1464 915 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
Chris@1464 916 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
Chris@1464 917
Chris@1464 918 copy = parent.reload.copy
Chris@1464 919 copy.parent_issue_id = child1.id
Chris@1464 920 copy.author = User.find(7)
Chris@1464 921 assert_difference 'Issue.count', 3 do
Chris@1464 922 assert copy.save
Chris@1464 923 end
Chris@1464 924 parent.reload
Chris@1464 925 child1.reload
Chris@1464 926 copy.reload
Chris@1464 927 assert_equal child1, copy.parent
Chris@1464 928 assert_equal 2, parent.children.count
Chris@1464 929 assert_equal 5, parent.descendants.count
Chris@1464 930 assert_equal 1, child1.children.count
Chris@1464 931 assert_equal 3, child1.descendants.count
Chris@1464 932 assert_equal 2, copy.children.count
Chris@1464 933 assert_equal 2, copy.descendants.count
Chris@1464 934 end
Chris@1464 935
Chris@1464 936 def test_copy_should_copy_subtasks_to_target_project
Chris@1464 937 issue = Issue.generate_with_descendants!
Chris@1464 938
Chris@1464 939 copy = issue.copy(:project_id => 3)
Chris@1464 940 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1464 941 assert copy.save
Chris@1464 942 end
Chris@1464 943 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
Chris@1464 944 end
Chris@1464 945
Chris@1464 946 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
Chris@1464 947 issue = Issue.generate_with_descendants!
Chris@1464 948
Chris@1464 949 copy = issue.reload.copy
Chris@1464 950 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1464 951 assert copy.save
Chris@1464 952 assert copy.save
Chris@1464 953 end
Chris@1464 954 end
Chris@1464 955
Chris@1464 956 def test_should_not_call_after_project_change_on_creation
Chris@1464 957 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
Chris@1464 958 :subject => 'Test', :author_id => 1)
Chris@1464 959 issue.expects(:after_project_change).never
Chris@1464 960 issue.save!
Chris@1464 961 end
Chris@1464 962
Chris@1464 963 def test_should_not_call_after_project_change_on_update
Chris@1464 964 issue = Issue.find(1)
Chris@1464 965 issue.project = Project.find(1)
Chris@1464 966 issue.subject = 'No project change'
Chris@1464 967 issue.expects(:after_project_change).never
Chris@1464 968 issue.save!
Chris@1464 969 end
Chris@1464 970
Chris@1464 971 def test_should_call_after_project_change_on_project_change
Chris@1464 972 issue = Issue.find(1)
Chris@1464 973 issue.project = Project.find(2)
Chris@1464 974 issue.expects(:after_project_change).once
Chris@1464 975 issue.save!
Chris@1464 976 end
Chris@1464 977
Chris@1464 978 def test_adding_journal_should_update_timestamp
Chris@1464 979 issue = Issue.find(1)
Chris@1464 980 updated_on_was = issue.updated_on
Chris@1464 981
Chris@1464 982 issue.init_journal(User.first, "Adding notes")
Chris@1464 983 assert_difference 'Journal.count' do
Chris@1464 984 assert issue.save
Chris@1464 985 end
Chris@1464 986 issue.reload
Chris@1464 987
Chris@1464 988 assert_not_equal updated_on_was, issue.updated_on
Chris@1464 989 end
Chris@1464 990
Chris@1464 991 def test_should_close_duplicates
Chris@1464 992 # Create 3 issues
Chris@1464 993 issue1 = Issue.generate!
Chris@1464 994 issue2 = Issue.generate!
Chris@1464 995 issue3 = Issue.generate!
Chris@1464 996
Chris@1464 997 # 2 is a dupe of 1
Chris@1464 998 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
Chris@1464 999 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1464 1000 # And 3 is a dupe of 2
Chris@1464 1001 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
Chris@1464 1002 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1464 1003 # And 3 is a dupe of 1 (circular duplicates)
Chris@1464 1004 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
Chris@1464 1005 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1464 1006
Chris@1464 1007 assert issue1.reload.duplicates.include?(issue2)
Chris@1464 1008
Chris@1464 1009 # Closing issue 1
Chris@1464 1010 issue1.init_journal(User.first, "Closing issue1")
Chris@1464 1011 issue1.status = IssueStatus.where(:is_closed => true).first
Chris@1464 1012 assert issue1.save
Chris@1464 1013 # 2 and 3 should be also closed
Chris@1464 1014 assert issue2.reload.closed?
Chris@1464 1015 assert issue3.reload.closed?
Chris@1464 1016 end
Chris@1464 1017
Chris@1464 1018 def test_should_not_close_duplicated_issue
Chris@1464 1019 issue1 = Issue.generate!
Chris@1464 1020 issue2 = Issue.generate!
Chris@1464 1021
Chris@1464 1022 # 2 is a dupe of 1
Chris@1464 1023 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
Chris@1464 1024 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1464 1025 # 2 is a dup of 1 but 1 is not a duplicate of 2
Chris@1464 1026 assert !issue2.reload.duplicates.include?(issue1)
Chris@1464 1027
Chris@1464 1028 # Closing issue 2
Chris@1464 1029 issue2.init_journal(User.first, "Closing issue2")
Chris@1464 1030 issue2.status = IssueStatus.where(:is_closed => true).first
Chris@1464 1031 assert issue2.save
Chris@1464 1032 # 1 should not be also closed
Chris@1464 1033 assert !issue1.reload.closed?
Chris@1464 1034 end
Chris@1464 1035
Chris@1464 1036 def test_assignable_versions
Chris@1464 1037 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 1038 :status_id => 1, :fixed_version_id => 1,
Chris@1464 1039 :subject => 'New issue')
Chris@1464 1040 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
Chris@1464 1041 end
Chris@1464 1042
Chris@1464 1043 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
Chris@1464 1044 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 1045 :status_id => 1, :fixed_version_id => 1,
Chris@1464 1046 :subject => 'New issue')
Chris@1464 1047 assert !issue.save
Chris@1464 1048 assert_not_equal [], issue.errors[:fixed_version_id]
Chris@1464 1049 end
Chris@1464 1050
Chris@1464 1051 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
Chris@1464 1052 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 1053 :status_id => 1, :fixed_version_id => 2,
Chris@1464 1054 :subject => 'New issue')
Chris@1464 1055 assert !issue.save
Chris@1464 1056 assert_not_equal [], issue.errors[:fixed_version_id]
Chris@1464 1057 end
Chris@1464 1058
Chris@1464 1059 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
Chris@1464 1060 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 1061 :status_id => 1, :fixed_version_id => 3,
Chris@1464 1062 :subject => 'New issue')
Chris@1464 1063 assert issue.save
Chris@1464 1064 end
Chris@1464 1065
Chris@1464 1066 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
Chris@1464 1067 issue = Issue.find(11)
Chris@1464 1068 assert_equal 'closed', issue.fixed_version.status
Chris@1464 1069 issue.subject = 'Subject changed'
Chris@1464 1070 assert issue.save
Chris@1464 1071 end
Chris@1464 1072
Chris@1464 1073 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
Chris@1464 1074 issue = Issue.find(11)
Chris@1464 1075 issue.status_id = 1
Chris@1464 1076 assert !issue.save
Chris@1464 1077 assert_not_equal [], issue.errors[:base]
Chris@1464 1078 end
Chris@1464 1079
Chris@1464 1080 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
Chris@1464 1081 issue = Issue.find(11)
Chris@1464 1082 issue.status_id = 1
Chris@1464 1083 issue.fixed_version_id = 3
Chris@1464 1084 assert issue.save
Chris@1464 1085 end
Chris@1464 1086
Chris@1464 1087 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
Chris@1464 1088 issue = Issue.find(12)
Chris@1464 1089 assert_equal 'locked', issue.fixed_version.status
Chris@1464 1090 issue.status_id = 1
Chris@1464 1091 assert issue.save
Chris@1464 1092 end
Chris@1464 1093
Chris@1464 1094 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
Chris@1464 1095 issue = Issue.find(2)
Chris@1464 1096 assert_equal 2, issue.fixed_version_id
Chris@1464 1097 issue.project_id = 3
Chris@1464 1098 assert_nil issue.fixed_version_id
Chris@1464 1099 issue.fixed_version_id = 2
Chris@1464 1100 assert !issue.save
Chris@1464 1101 assert_include 'Target version is not included in the list', issue.errors.full_messages
Chris@1464 1102 end
Chris@1464 1103
Chris@1464 1104 def test_should_keep_shared_version_when_changing_project
Chris@1464 1105 Version.find(2).update_attribute :sharing, 'tree'
Chris@1464 1106
Chris@1464 1107 issue = Issue.find(2)
Chris@1464 1108 assert_equal 2, issue.fixed_version_id
Chris@1464 1109 issue.project_id = 3
Chris@1464 1110 assert_equal 2, issue.fixed_version_id
Chris@1464 1111 assert issue.save
Chris@1464 1112 end
Chris@1464 1113
Chris@1464 1114 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
Chris@1464 1115 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
Chris@1464 1116 end
Chris@1464 1117
Chris@1464 1118 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
Chris@1464 1119 Project.find(2).disable_module! :issue_tracking
Chris@1464 1120 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
Chris@1464 1121 end
Chris@1464 1122
Chris@1464 1123 def test_move_to_another_project_with_same_category
Chris@1464 1124 issue = Issue.find(1)
Chris@1464 1125 issue.project = Project.find(2)
Chris@1464 1126 assert issue.save
Chris@1464 1127 issue.reload
Chris@1464 1128 assert_equal 2, issue.project_id
Chris@1464 1129 # Category changes
Chris@1464 1130 assert_equal 4, issue.category_id
Chris@1464 1131 # Make sure time entries were move to the target project
Chris@1464 1132 assert_equal 2, issue.time_entries.first.project_id
Chris@1464 1133 end
Chris@1464 1134
Chris@1464 1135 def test_move_to_another_project_without_same_category
Chris@1464 1136 issue = Issue.find(2)
Chris@1464 1137 issue.project = Project.find(2)
Chris@1464 1138 assert issue.save
Chris@1464 1139 issue.reload
Chris@1464 1140 assert_equal 2, issue.project_id
Chris@1464 1141 # Category cleared
Chris@1464 1142 assert_nil issue.category_id
Chris@1464 1143 end
Chris@1464 1144
Chris@1464 1145 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
Chris@1464 1146 issue = Issue.find(1)
Chris@1464 1147 issue.update_attribute(:fixed_version_id, 1)
Chris@1464 1148 issue.project = Project.find(2)
Chris@1464 1149 assert issue.save
Chris@1464 1150 issue.reload
Chris@1464 1151 assert_equal 2, issue.project_id
Chris@1464 1152 # Cleared fixed_version
Chris@1464 1153 assert_equal nil, issue.fixed_version
Chris@1464 1154 end
Chris@1464 1155
Chris@1464 1156 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
Chris@1464 1157 issue = Issue.find(1)
Chris@1464 1158 issue.update_attribute(:fixed_version_id, 4)
Chris@1464 1159 issue.project = Project.find(5)
Chris@1464 1160 assert issue.save
Chris@1464 1161 issue.reload
Chris@1464 1162 assert_equal 5, issue.project_id
Chris@1464 1163 # Keep fixed_version
Chris@1464 1164 assert_equal 4, issue.fixed_version_id
Chris@1464 1165 end
Chris@1464 1166
Chris@1464 1167 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
Chris@1464 1168 issue = Issue.find(1)
Chris@1464 1169 issue.update_attribute(:fixed_version_id, 1)
Chris@1464 1170 issue.project = Project.find(5)
Chris@1464 1171 assert issue.save
Chris@1464 1172 issue.reload
Chris@1464 1173 assert_equal 5, issue.project_id
Chris@1464 1174 # Cleared fixed_version
Chris@1464 1175 assert_equal nil, issue.fixed_version
Chris@1464 1176 end
Chris@1464 1177
Chris@1464 1178 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
Chris@1464 1179 issue = Issue.find(1)
Chris@1464 1180 issue.update_attribute(:fixed_version_id, 7)
Chris@1464 1181 issue.project = Project.find(2)
Chris@1464 1182 assert issue.save
Chris@1464 1183 issue.reload
Chris@1464 1184 assert_equal 2, issue.project_id
Chris@1464 1185 # Keep fixed_version
Chris@1464 1186 assert_equal 7, issue.fixed_version_id
Chris@1464 1187 end
Chris@1464 1188
Chris@1464 1189 def test_move_to_another_project_should_keep_parent_if_valid
Chris@1464 1190 issue = Issue.find(1)
Chris@1464 1191 issue.update_attribute(:parent_issue_id, 2)
Chris@1464 1192 issue.project = Project.find(3)
Chris@1464 1193 assert issue.save
Chris@1464 1194 issue.reload
Chris@1464 1195 assert_equal 2, issue.parent_id
Chris@1464 1196 end
Chris@1464 1197
Chris@1464 1198 def test_move_to_another_project_should_clear_parent_if_not_valid
Chris@1464 1199 issue = Issue.find(1)
Chris@1464 1200 issue.update_attribute(:parent_issue_id, 2)
Chris@1464 1201 issue.project = Project.find(2)
Chris@1464 1202 assert issue.save
Chris@1464 1203 issue.reload
Chris@1464 1204 assert_nil issue.parent_id
Chris@1464 1205 end
Chris@1464 1206
Chris@1464 1207 def test_move_to_another_project_with_disabled_tracker
Chris@1464 1208 issue = Issue.find(1)
Chris@1464 1209 target = Project.find(2)
Chris@1464 1210 target.tracker_ids = [3]
Chris@1464 1211 target.save
Chris@1464 1212 issue.project = target
Chris@1464 1213 assert issue.save
Chris@1464 1214 issue.reload
Chris@1464 1215 assert_equal 2, issue.project_id
Chris@1464 1216 assert_equal 3, issue.tracker_id
Chris@1464 1217 end
Chris@1464 1218
Chris@1464 1219 def test_copy_to_the_same_project
Chris@1464 1220 issue = Issue.find(1)
Chris@1464 1221 copy = issue.copy
Chris@1464 1222 assert_difference 'Issue.count' do
Chris@1464 1223 copy.save!
Chris@1464 1224 end
Chris@1464 1225 assert_kind_of Issue, copy
Chris@1464 1226 assert_equal issue.project, copy.project
Chris@1464 1227 assert_equal "125", copy.custom_value_for(2).value
Chris@1464 1228 end
Chris@1464 1229
Chris@1464 1230 def test_copy_to_another_project_and_tracker
Chris@1464 1231 issue = Issue.find(1)
Chris@1464 1232 copy = issue.copy(:project_id => 3, :tracker_id => 2)
Chris@1464 1233 assert_difference 'Issue.count' do
Chris@1464 1234 copy.save!
Chris@1464 1235 end
Chris@1464 1236 copy.reload
Chris@1464 1237 assert_kind_of Issue, copy
Chris@1464 1238 assert_equal Project.find(3), copy.project
Chris@1464 1239 assert_equal Tracker.find(2), copy.tracker
Chris@1464 1240 # Custom field #2 is not associated with target tracker
Chris@1464 1241 assert_nil copy.custom_value_for(2)
Chris@1464 1242 end
Chris@1464 1243
Chris@1464 1244 test "#copy should not create a journal" do
Chris@1464 1245 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
Chris@1464 1246 copy.save!
Chris@1464 1247 assert_equal 0, copy.reload.journals.size
Chris@1464 1248 end
Chris@1464 1249
Chris@1464 1250 test "#copy should allow assigned_to changes" do
Chris@1464 1251 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
Chris@1464 1252 assert_equal 3, copy.assigned_to_id
Chris@1464 1253 end
Chris@1464 1254
Chris@1464 1255 test "#copy should allow status changes" do
Chris@1464 1256 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
Chris@1464 1257 assert_equal 2, copy.status_id
Chris@1464 1258 end
Chris@1464 1259
Chris@1464 1260 test "#copy should allow start date changes" do
Chris@1464 1261 date = Date.today
Chris@1464 1262 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
Chris@1464 1263 assert_equal date, copy.start_date
Chris@1464 1264 end
Chris@1464 1265
Chris@1464 1266 test "#copy should allow due date changes" do
Chris@1464 1267 date = Date.today
Chris@1464 1268 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
Chris@1464 1269 assert_equal date, copy.due_date
Chris@1464 1270 end
Chris@1464 1271
Chris@1464 1272 test "#copy should set current user as author" do
Chris@1464 1273 User.current = User.find(9)
Chris@1464 1274 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
Chris@1464 1275 assert_equal User.current, copy.author
Chris@1464 1276 end
Chris@1464 1277
Chris@1464 1278 test "#copy should create a journal with notes" do
Chris@1464 1279 date = Date.today
Chris@1464 1280 notes = "Notes added when copying"
Chris@1464 1281 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
Chris@1464 1282 copy.init_journal(User.current, notes)
Chris@1464 1283 copy.save!
Chris@1464 1284
Chris@1464 1285 assert_equal 1, copy.journals.size
Chris@1464 1286 journal = copy.journals.first
Chris@1464 1287 assert_equal 0, journal.details.size
Chris@1464 1288 assert_equal notes, journal.notes
Chris@1464 1289 end
Chris@1464 1290
Chris@1464 1291 def test_valid_parent_project
Chris@1464 1292 issue = Issue.find(1)
Chris@1464 1293 issue_in_same_project = Issue.find(2)
Chris@1464 1294 issue_in_child_project = Issue.find(5)
Chris@1464 1295 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
Chris@1464 1296 issue_in_other_child_project = Issue.find(6)
Chris@1464 1297 issue_in_different_tree = Issue.find(4)
Chris@1464 1298
Chris@1464 1299 with_settings :cross_project_subtasks => '' do
Chris@1464 1300 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1464 1301 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
Chris@1464 1302 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1464 1303 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1464 1304 end
Chris@1464 1305
Chris@1464 1306 with_settings :cross_project_subtasks => 'system' do
Chris@1464 1307 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1464 1308 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
Chris@1464 1309 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
Chris@1464 1310 end
Chris@1464 1311
Chris@1464 1312 with_settings :cross_project_subtasks => 'tree' do
Chris@1464 1313 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1464 1314 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
Chris@1464 1315 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1464 1316 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1464 1317
Chris@1464 1318 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
Chris@1464 1319 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
Chris@1464 1320 end
Chris@1464 1321
Chris@1464 1322 with_settings :cross_project_subtasks => 'descendants' do
Chris@1464 1323 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1464 1324 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
Chris@1464 1325 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1464 1326 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1464 1327
Chris@1464 1328 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
Chris@1464 1329 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
Chris@1464 1330 end
Chris@1464 1331 end
Chris@1464 1332
Chris@1464 1333 def test_recipients_should_include_previous_assignee
Chris@1464 1334 user = User.find(3)
Chris@1464 1335 user.members.update_all ["mail_notification = ?", false]
Chris@1464 1336 user.update_attribute :mail_notification, 'only_assigned'
Chris@1464 1337
Chris@1464 1338 issue = Issue.find(2)
Chris@1464 1339 issue.assigned_to = nil
Chris@1464 1340 assert_include user.mail, issue.recipients
Chris@1464 1341 issue.save!
Chris@1464 1342 assert !issue.recipients.include?(user.mail)
Chris@1464 1343 end
Chris@1464 1344
Chris@1464 1345 def test_recipients_should_not_include_users_that_cannot_view_the_issue
Chris@1464 1346 issue = Issue.find(12)
Chris@1464 1347 assert issue.recipients.include?(issue.author.mail)
Chris@1464 1348 # copy the issue to a private project
Chris@1464 1349 copy = issue.copy(:project_id => 5, :tracker_id => 2)
Chris@1464 1350 # author is not a member of project anymore
Chris@1464 1351 assert !copy.recipients.include?(copy.author.mail)
Chris@1464 1352 end
Chris@1464 1353
Chris@1464 1354 def test_recipients_should_include_the_assigned_group_members
Chris@1464 1355 group_member = User.generate!
Chris@1464 1356 group = Group.generate!
Chris@1464 1357 group.users << group_member
Chris@1464 1358
Chris@1464 1359 issue = Issue.find(12)
Chris@1464 1360 issue.assigned_to = group
Chris@1464 1361 assert issue.recipients.include?(group_member.mail)
Chris@1464 1362 end
Chris@1464 1363
Chris@1464 1364 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
Chris@1464 1365 user = User.find(3)
Chris@1464 1366 issue = Issue.find(9)
Chris@1464 1367 Watcher.create!(:user => user, :watchable => issue)
Chris@1464 1368 assert issue.watched_by?(user)
Chris@1464 1369 assert !issue.watcher_recipients.include?(user.mail)
Chris@1464 1370 end
Chris@1464 1371
Chris@1464 1372 def test_issue_destroy
Chris@1464 1373 Issue.find(1).destroy
Chris@1464 1374 assert_nil Issue.find_by_id(1)
Chris@1464 1375 assert_nil TimeEntry.find_by_issue_id(1)
Chris@1464 1376 end
Chris@1464 1377
Chris@1464 1378 def test_destroying_a_deleted_issue_should_not_raise_an_error
Chris@1464 1379 issue = Issue.find(1)
Chris@1464 1380 Issue.find(1).destroy
Chris@1464 1381
Chris@1464 1382 assert_nothing_raised do
Chris@1464 1383 assert_no_difference 'Issue.count' do
Chris@1464 1384 issue.destroy
Chris@1464 1385 end
Chris@1464 1386 assert issue.destroyed?
Chris@1464 1387 end
Chris@1464 1388 end
Chris@1464 1389
Chris@1464 1390 def test_destroying_a_stale_issue_should_not_raise_an_error
Chris@1464 1391 issue = Issue.find(1)
Chris@1464 1392 Issue.find(1).update_attribute :subject, "Updated"
Chris@1464 1393
Chris@1464 1394 assert_nothing_raised do
Chris@1464 1395 assert_difference 'Issue.count', -1 do
Chris@1464 1396 issue.destroy
Chris@1464 1397 end
Chris@1464 1398 assert issue.destroyed?
Chris@1464 1399 end
Chris@1464 1400 end
Chris@1464 1401
Chris@1464 1402 def test_blocked
Chris@1464 1403 blocked_issue = Issue.find(9)
Chris@1464 1404 blocking_issue = Issue.find(10)
Chris@1464 1405
Chris@1464 1406 assert blocked_issue.blocked?
Chris@1464 1407 assert !blocking_issue.blocked?
Chris@1464 1408 end
Chris@1464 1409
Chris@1464 1410 def test_blocked_issues_dont_allow_closed_statuses
Chris@1464 1411 blocked_issue = Issue.find(9)
Chris@1464 1412
Chris@1464 1413 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
Chris@1464 1414 assert !allowed_statuses.empty?
Chris@1464 1415 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
Chris@1464 1416 assert closed_statuses.empty?
Chris@1464 1417 end
Chris@1464 1418
Chris@1464 1419 def test_unblocked_issues_allow_closed_statuses
Chris@1464 1420 blocking_issue = Issue.find(10)
Chris@1464 1421
Chris@1464 1422 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
Chris@1464 1423 assert !allowed_statuses.empty?
Chris@1464 1424 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
Chris@1464 1425 assert !closed_statuses.empty?
Chris@1464 1426 end
Chris@1464 1427
Chris@1464 1428 def test_reschedule_an_issue_without_dates
Chris@1464 1429 with_settings :non_working_week_days => [] do
Chris@1464 1430 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1464 1431 issue.reschedule_on '2012-10-09'.to_date
Chris@1464 1432 assert_equal '2012-10-09'.to_date, issue.start_date
Chris@1464 1433 assert_equal '2012-10-09'.to_date, issue.due_date
Chris@1464 1434 end
Chris@1464 1435
Chris@1464 1436 with_settings :non_working_week_days => %w(6 7) do
Chris@1464 1437 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1464 1438 issue.reschedule_on '2012-10-09'.to_date
Chris@1464 1439 assert_equal '2012-10-09'.to_date, issue.start_date
Chris@1464 1440 assert_equal '2012-10-09'.to_date, issue.due_date
Chris@1464 1441
Chris@1464 1442 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1464 1443 issue.reschedule_on '2012-10-13'.to_date
Chris@1464 1444 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1464 1445 assert_equal '2012-10-15'.to_date, issue.due_date
Chris@1464 1446 end
Chris@1464 1447 end
Chris@1464 1448
Chris@1464 1449 def test_reschedule_an_issue_with_start_date
Chris@1464 1450 with_settings :non_working_week_days => [] do
Chris@1464 1451 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1464 1452 issue.reschedule_on '2012-10-13'.to_date
Chris@1464 1453 assert_equal '2012-10-13'.to_date, issue.start_date
Chris@1464 1454 assert_equal '2012-10-13'.to_date, issue.due_date
Chris@1464 1455 end
Chris@1464 1456
Chris@1464 1457 with_settings :non_working_week_days => %w(6 7) do
Chris@1464 1458 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1464 1459 issue.reschedule_on '2012-10-11'.to_date
Chris@1464 1460 assert_equal '2012-10-11'.to_date, issue.start_date
Chris@1464 1461 assert_equal '2012-10-11'.to_date, issue.due_date
Chris@1464 1462
Chris@1464 1463 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1464 1464 issue.reschedule_on '2012-10-13'.to_date
Chris@1464 1465 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1464 1466 assert_equal '2012-10-15'.to_date, issue.due_date
Chris@1464 1467 end
Chris@1464 1468 end
Chris@1464 1469
Chris@1464 1470 def test_reschedule_an_issue_with_start_and_due_dates
Chris@1464 1471 with_settings :non_working_week_days => [] do
Chris@1464 1472 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
Chris@1464 1473 issue.reschedule_on '2012-10-13'.to_date
Chris@1464 1474 assert_equal '2012-10-13'.to_date, issue.start_date
Chris@1464 1475 assert_equal '2012-10-19'.to_date, issue.due_date
Chris@1464 1476 end
Chris@1464 1477
Chris@1464 1478 with_settings :non_working_week_days => %w(6 7) do
Chris@1464 1479 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
Chris@1464 1480 issue.reschedule_on '2012-10-11'.to_date
Chris@1464 1481 assert_equal '2012-10-11'.to_date, issue.start_date
Chris@1464 1482 assert_equal '2012-10-23'.to_date, issue.due_date
Chris@1464 1483
Chris@1464 1484 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
Chris@1464 1485 issue.reschedule_on '2012-10-13'.to_date
Chris@1464 1486 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1464 1487 assert_equal '2012-10-25'.to_date, issue.due_date
Chris@1464 1488 end
Chris@1464 1489 end
Chris@1464 1490
Chris@1464 1491 def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
Chris@1464 1492 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1493 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1494 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1464 1495 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1496 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1464 1497
Chris@1464 1498 issue1.reload
Chris@1464 1499 issue1.due_date = '2012-10-23'
Chris@1464 1500 issue1.save!
Chris@1464 1501 issue2.reload
Chris@1464 1502 assert_equal Date.parse('2012-10-24'), issue2.start_date
Chris@1464 1503 assert_equal Date.parse('2012-10-26'), issue2.due_date
Chris@1464 1504 end
Chris@1464 1505
Chris@1464 1506 def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
Chris@1464 1507 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1508 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1509 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1464 1510 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1511 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1464 1512
Chris@1464 1513 issue1.reload
Chris@1464 1514 issue1.start_date = '2012-09-17'
Chris@1464 1515 issue1.due_date = '2012-09-18'
Chris@1464 1516 issue1.save!
Chris@1464 1517 issue2.reload
Chris@1464 1518 assert_equal Date.parse('2012-09-19'), issue2.start_date
Chris@1464 1519 assert_equal Date.parse('2012-09-21'), issue2.due_date
Chris@1464 1520 end
Chris@1464 1521
Chris@1464 1522 def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
Chris@1464 1523 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1524 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1525 issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
Chris@1464 1526 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1464 1527 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1528 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
Chris@1464 1529 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1530 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1464 1531
Chris@1464 1532 issue1.reload
Chris@1464 1533 issue1.start_date = '2012-09-17'
Chris@1464 1534 issue1.due_date = '2012-09-18'
Chris@1464 1535 issue1.save!
Chris@1464 1536 issue2.reload
Chris@1464 1537 # Issue 2 must start after Issue 3
Chris@1464 1538 assert_equal Date.parse('2012-10-03'), issue2.start_date
Chris@1464 1539 assert_equal Date.parse('2012-10-05'), issue2.due_date
Chris@1464 1540 end
Chris@1464 1541
Chris@1464 1542 def test_rescheduling_a_stale_issue_should_not_raise_an_error
Chris@1464 1543 with_settings :non_working_week_days => [] do
Chris@1464 1544 stale = Issue.find(1)
Chris@1464 1545 issue = Issue.find(1)
Chris@1464 1546 issue.subject = "Updated"
Chris@1464 1547 issue.save!
Chris@1464 1548 date = 10.days.from_now.to_date
Chris@1464 1549 assert_nothing_raised do
Chris@1464 1550 stale.reschedule_on!(date)
Chris@1464 1551 end
Chris@1464 1552 assert_equal date, stale.reload.start_date
Chris@1464 1553 end
Chris@1464 1554 end
Chris@1464 1555
Chris@1464 1556 def test_child_issue_should_consider_parent_soonest_start_on_create
Chris@1464 1557 set_language_if_valid 'en'
Chris@1464 1558 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1559 issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
Chris@1464 1560 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1464 1561 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1562 issue1.reload
Chris@1464 1563 issue2.reload
Chris@1464 1564 assert_equal Date.parse('2012-10-18'), issue2.start_date
Chris@1464 1565
Chris@1464 1566 child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
Chris@1464 1567 :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
Chris@1464 1568 assert !child.valid?
Chris@1464 1569 assert_include 'Start date cannot be earlier than 10/18/2012 because of preceding issues', child.errors.full_messages
Chris@1464 1570 assert_equal Date.parse('2012-10-18'), child.soonest_start
Chris@1464 1571 child.start_date = '2012-10-18'
Chris@1464 1572 assert child.save
Chris@1464 1573 end
Chris@1464 1574
Chris@1464 1575 def test_setting_parent_to_a_dependent_issue_should_not_validate
Chris@1464 1576 set_language_if_valid 'en'
Chris@1464 1577 issue1 = Issue.generate!
Chris@1464 1578 issue2 = Issue.generate!
Chris@1464 1579 issue3 = Issue.generate!
Chris@1464 1580 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1581 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1582 issue3.reload
Chris@1464 1583 issue3.parent_issue_id = issue2.id
Chris@1464 1584 assert !issue3.valid?
Chris@1464 1585 assert_include 'Parent task is invalid', issue3.errors.full_messages
Chris@1464 1586 end
Chris@1464 1587
Chris@1464 1588 def test_setting_parent_should_not_allow_circular_dependency
Chris@1464 1589 set_language_if_valid 'en'
Chris@1464 1590 issue1 = Issue.generate!
Chris@1464 1591 issue2 = Issue.generate!
Chris@1464 1592 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1593 issue3 = Issue.generate!
Chris@1464 1594 issue2.reload
Chris@1464 1595 issue2.parent_issue_id = issue3.id
Chris@1464 1596 issue2.save!
Chris@1464 1597 issue4 = Issue.generate!
Chris@1464 1598 IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1599 issue4.reload
Chris@1464 1600 issue4.parent_issue_id = issue1.id
Chris@1464 1601 assert !issue4.valid?
Chris@1464 1602 assert_include 'Parent task is invalid', issue4.errors.full_messages
Chris@1464 1603 end
Chris@1464 1604
Chris@1464 1605 def test_overdue
Chris@1464 1606 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
Chris@1464 1607 assert !Issue.new(:due_date => Date.today).overdue?
Chris@1464 1608 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
Chris@1464 1609 assert !Issue.new(:due_date => nil).overdue?
Chris@1464 1610 assert !Issue.new(:due_date => 1.day.ago.to_date,
Chris@1464 1611 :status => IssueStatus.where(:is_closed => true).first
Chris@1464 1612 ).overdue?
Chris@1464 1613 end
Chris@1464 1614
Chris@1464 1615 test "#behind_schedule? should be false if the issue has no start_date" do
Chris@1464 1616 assert !Issue.new(:start_date => nil,
Chris@1464 1617 :due_date => 1.day.from_now.to_date,
Chris@1464 1618 :done_ratio => 0).behind_schedule?
Chris@1464 1619 end
Chris@1464 1620
Chris@1464 1621 test "#behind_schedule? should be false if the issue has no end_date" do
Chris@1464 1622 assert !Issue.new(:start_date => 1.day.from_now.to_date,
Chris@1464 1623 :due_date => nil,
Chris@1464 1624 :done_ratio => 0).behind_schedule?
Chris@1464 1625 end
Chris@1464 1626
Chris@1464 1627 test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
Chris@1464 1628 assert !Issue.new(:start_date => 50.days.ago.to_date,
Chris@1464 1629 :due_date => 50.days.from_now.to_date,
Chris@1464 1630 :done_ratio => 90).behind_schedule?
Chris@1464 1631 end
Chris@1464 1632
Chris@1464 1633 test "#behind_schedule? should be true if the issue hasn't been started at all" do
Chris@1464 1634 assert Issue.new(:start_date => 1.day.ago.to_date,
Chris@1464 1635 :due_date => 1.day.from_now.to_date,
Chris@1464 1636 :done_ratio => 0).behind_schedule?
Chris@1464 1637 end
Chris@1464 1638
Chris@1464 1639 test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
Chris@1464 1640 assert Issue.new(:start_date => 100.days.ago.to_date,
Chris@1464 1641 :due_date => Date.today,
Chris@1464 1642 :done_ratio => 90).behind_schedule?
Chris@1464 1643 end
Chris@1464 1644
Chris@1464 1645 test "#assignable_users should be Users" do
Chris@1464 1646 assert_kind_of User, Issue.find(1).assignable_users.first
Chris@1464 1647 end
Chris@1464 1648
Chris@1464 1649 test "#assignable_users should include the issue author" do
Chris@1464 1650 non_project_member = User.generate!
Chris@1464 1651 issue = Issue.generate!(:author => non_project_member)
Chris@1464 1652
Chris@1464 1653 assert issue.assignable_users.include?(non_project_member)
Chris@1464 1654 end
Chris@1464 1655
Chris@1464 1656 test "#assignable_users should include the current assignee" do
Chris@1464 1657 user = User.generate!
Chris@1464 1658 issue = Issue.generate!(:assigned_to => user)
Chris@1464 1659 user.lock!
Chris@1464 1660
Chris@1464 1661 assert Issue.find(issue.id).assignable_users.include?(user)
Chris@1464 1662 end
Chris@1464 1663
Chris@1464 1664 test "#assignable_users should not show the issue author twice" do
Chris@1464 1665 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
Chris@1464 1666 assert_equal 2, assignable_user_ids.length
Chris@1464 1667
Chris@1464 1668 assignable_user_ids.each do |user_id|
Chris@1464 1669 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
Chris@1464 1670 "User #{user_id} appears more or less than once"
Chris@1464 1671 end
Chris@1464 1672 end
Chris@1464 1673
Chris@1464 1674 test "#assignable_users with issue_group_assignment should include groups" do
Chris@1464 1675 issue = Issue.new(:project => Project.find(2))
Chris@1464 1676
Chris@1464 1677 with_settings :issue_group_assignment => '1' do
Chris@1464 1678 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
Chris@1464 1679 assert issue.assignable_users.include?(Group.find(11))
Chris@1464 1680 end
Chris@1464 1681 end
Chris@1464 1682
Chris@1464 1683 test "#assignable_users without issue_group_assignment should not include groups" do
Chris@1464 1684 issue = Issue.new(:project => Project.find(2))
Chris@1464 1685
Chris@1464 1686 with_settings :issue_group_assignment => '0' do
Chris@1464 1687 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
Chris@1464 1688 assert !issue.assignable_users.include?(Group.find(11))
Chris@1464 1689 end
Chris@1464 1690 end
Chris@1464 1691
Chris@1464 1692 def test_create_should_send_email_notification
Chris@1464 1693 ActionMailer::Base.deliveries.clear
Chris@1464 1694 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1464 1695 :author_id => 3, :status_id => 1,
Chris@1464 1696 :priority => IssuePriority.all.first,
Chris@1464 1697 :subject => 'test_create', :estimated_hours => '1:30')
Chris@1464 1698
Chris@1464 1699 assert issue.save
Chris@1464 1700 assert_equal 1, ActionMailer::Base.deliveries.size
Chris@1464 1701 end
Chris@1464 1702
Chris@1464 1703 def test_update_should_notify_previous_assignee
Chris@1464 1704 ActionMailer::Base.deliveries.clear
Chris@1464 1705 user = User.find(3)
Chris@1464 1706 user.members.update_all ["mail_notification = ?", false]
Chris@1464 1707 user.update_attribute :mail_notification, 'only_assigned'
Chris@1464 1708
Chris@1464 1709 issue = Issue.find(2)
Chris@1464 1710 issue.init_journal User.find(1)
Chris@1464 1711 issue.assigned_to = nil
Chris@1464 1712 issue.save!
Chris@1464 1713 assert_include user.mail, ActionMailer::Base.deliveries.last.bcc
Chris@1464 1714 end
Chris@1464 1715
Chris@1464 1716 def test_stale_issue_should_not_send_email_notification
Chris@1464 1717 ActionMailer::Base.deliveries.clear
Chris@1464 1718 issue = Issue.find(1)
Chris@1464 1719 stale = Issue.find(1)
Chris@1464 1720
Chris@1464 1721 issue.init_journal(User.find(1))
Chris@1464 1722 issue.subject = 'Subjet update'
Chris@1464 1723 assert issue.save
Chris@1464 1724 assert_equal 1, ActionMailer::Base.deliveries.size
Chris@1464 1725 ActionMailer::Base.deliveries.clear
Chris@1464 1726
Chris@1464 1727 stale.init_journal(User.find(1))
Chris@1464 1728 stale.subject = 'Another subjet update'
Chris@1464 1729 assert_raise ActiveRecord::StaleObjectError do
Chris@1464 1730 stale.save
Chris@1464 1731 end
Chris@1464 1732 assert ActionMailer::Base.deliveries.empty?
Chris@1464 1733 end
Chris@1464 1734
Chris@1464 1735 def test_journalized_description
Chris@1464 1736 IssueCustomField.delete_all
Chris@1464 1737
Chris@1464 1738 i = Issue.first
Chris@1464 1739 old_description = i.description
Chris@1464 1740 new_description = "This is the new description"
Chris@1464 1741
Chris@1464 1742 i.init_journal(User.find(2))
Chris@1464 1743 i.description = new_description
Chris@1464 1744 assert_difference 'Journal.count', 1 do
Chris@1464 1745 assert_difference 'JournalDetail.count', 1 do
Chris@1464 1746 i.save!
Chris@1464 1747 end
Chris@1464 1748 end
Chris@1464 1749
Chris@1464 1750 detail = JournalDetail.first(:order => 'id DESC')
Chris@1464 1751 assert_equal i, detail.journal.journalized
Chris@1464 1752 assert_equal 'attr', detail.property
Chris@1464 1753 assert_equal 'description', detail.prop_key
Chris@1464 1754 assert_equal old_description, detail.old_value
Chris@1464 1755 assert_equal new_description, detail.value
Chris@1464 1756 end
Chris@1464 1757
Chris@1464 1758 def test_blank_descriptions_should_not_be_journalized
Chris@1464 1759 IssueCustomField.delete_all
Chris@1464 1760 Issue.update_all("description = NULL", "id=1")
Chris@1464 1761
Chris@1464 1762 i = Issue.find(1)
Chris@1464 1763 i.init_journal(User.find(2))
Chris@1464 1764 i.subject = "blank description"
Chris@1464 1765 i.description = "\r\n"
Chris@1464 1766
Chris@1464 1767 assert_difference 'Journal.count', 1 do
Chris@1464 1768 assert_difference 'JournalDetail.count', 1 do
Chris@1464 1769 i.save!
Chris@1464 1770 end
Chris@1464 1771 end
Chris@1464 1772 end
Chris@1464 1773
Chris@1464 1774 def test_journalized_multi_custom_field
Chris@1464 1775 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
Chris@1464 1776 :is_filter => true, :is_for_all => true,
Chris@1464 1777 :tracker_ids => [1],
Chris@1464 1778 :possible_values => ['value1', 'value2', 'value3'],
Chris@1464 1779 :multiple => true)
Chris@1464 1780
Chris@1464 1781 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
Chris@1464 1782 :subject => 'Test', :author_id => 1)
Chris@1464 1783
Chris@1464 1784 assert_difference 'Journal.count' do
Chris@1464 1785 assert_difference 'JournalDetail.count' do
Chris@1464 1786 issue.init_journal(User.first)
Chris@1464 1787 issue.custom_field_values = {field.id => ['value1']}
Chris@1464 1788 issue.save!
Chris@1464 1789 end
Chris@1464 1790 assert_difference 'JournalDetail.count' do
Chris@1464 1791 issue.init_journal(User.first)
Chris@1464 1792 issue.custom_field_values = {field.id => ['value1', 'value2']}
Chris@1464 1793 issue.save!
Chris@1464 1794 end
Chris@1464 1795 assert_difference 'JournalDetail.count', 2 do
Chris@1464 1796 issue.init_journal(User.first)
Chris@1464 1797 issue.custom_field_values = {field.id => ['value3', 'value2']}
Chris@1464 1798 issue.save!
Chris@1464 1799 end
Chris@1464 1800 assert_difference 'JournalDetail.count', 2 do
Chris@1464 1801 issue.init_journal(User.first)
Chris@1464 1802 issue.custom_field_values = {field.id => nil}
Chris@1464 1803 issue.save!
Chris@1464 1804 end
Chris@1464 1805 end
Chris@1464 1806 end
Chris@1464 1807
Chris@1464 1808 def test_description_eol_should_be_normalized
Chris@1464 1809 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
Chris@1464 1810 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
Chris@1464 1811 end
Chris@1464 1812
Chris@1464 1813 def test_saving_twice_should_not_duplicate_journal_details
Chris@1464 1814 i = Issue.first
Chris@1464 1815 i.init_journal(User.find(2), 'Some notes')
Chris@1464 1816 # initial changes
Chris@1464 1817 i.subject = 'New subject'
Chris@1464 1818 i.done_ratio = i.done_ratio + 10
Chris@1464 1819 assert_difference 'Journal.count' do
Chris@1464 1820 assert i.save
Chris@1464 1821 end
Chris@1464 1822 # 1 more change
Chris@1464 1823 i.priority = IssuePriority.where("id <> ?", i.priority_id).first
Chris@1464 1824 assert_no_difference 'Journal.count' do
Chris@1464 1825 assert_difference 'JournalDetail.count', 1 do
Chris@1464 1826 i.save
Chris@1464 1827 end
Chris@1464 1828 end
Chris@1464 1829 # no more change
Chris@1464 1830 assert_no_difference 'Journal.count' do
Chris@1464 1831 assert_no_difference 'JournalDetail.count' do
Chris@1464 1832 i.save
Chris@1464 1833 end
Chris@1464 1834 end
Chris@1464 1835 end
Chris@1464 1836
Chris@1464 1837 def test_all_dependent_issues
Chris@1464 1838 IssueRelation.delete_all
Chris@1464 1839 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1464 1840 :issue_to => Issue.find(2),
Chris@1464 1841 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1842 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1464 1843 :issue_to => Issue.find(3),
Chris@1464 1844 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1845 assert IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1464 1846 :issue_to => Issue.find(8),
Chris@1464 1847 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1848
Chris@1464 1849 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1464 1850 end
Chris@1464 1851
Chris@1464 1852 def test_all_dependent_issues_with_subtask
Chris@1464 1853 IssueRelation.delete_all
Chris@1464 1854
Chris@1464 1855 project = Project.generate!(:name => "testproject")
Chris@1464 1856
Chris@1464 1857 parentIssue = Issue.generate!(:project => project)
Chris@1464 1858 childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1464 1859 childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1464 1860
Chris@1464 1861 assert_equal [childIssue1.id, childIssue2.id].sort, parentIssue.all_dependent_issues.collect(&:id).uniq.sort
Chris@1464 1862 end
Chris@1464 1863
Chris@1464 1864 def test_all_dependent_issues_does_not_include_self
Chris@1464 1865 IssueRelation.delete_all
Chris@1464 1866
Chris@1464 1867 project = Project.generate!(:name => "testproject")
Chris@1464 1868
Chris@1464 1869 parentIssue = Issue.generate!(:project => project)
Chris@1464 1870 childIssue = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1464 1871
Chris@1464 1872 assert_equal [childIssue.id], parentIssue.all_dependent_issues.collect(&:id)
Chris@1464 1873 end
Chris@1464 1874
Chris@1464 1875 def test_all_dependent_issues_with_parenttask_and_sibling
Chris@1464 1876 IssueRelation.delete_all
Chris@1464 1877
Chris@1464 1878 project = Project.generate!(:name => "testproject")
Chris@1464 1879
Chris@1464 1880 parentIssue = Issue.generate!(:project => project)
Chris@1464 1881 childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1464 1882 childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1464 1883
Chris@1464 1884 assert_equal [parentIssue.id].sort, childIssue1.all_dependent_issues.collect(&:id)
Chris@1464 1885 end
Chris@1464 1886
Chris@1464 1887 def test_all_dependent_issues_with_relation_to_leaf_in_other_tree
Chris@1464 1888 IssueRelation.delete_all
Chris@1464 1889
Chris@1464 1890 project = Project.generate!(:name => "testproject")
Chris@1464 1891
Chris@1464 1892 parentIssue1 = Issue.generate!(:project => project)
Chris@1464 1893 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1464 1894 childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1464 1895
Chris@1464 1896 parentIssue2 = Issue.generate!(:project => project)
Chris@1464 1897 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1464 1898 childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1464 1899
Chris@1464 1900
Chris@1464 1901 assert IssueRelation.create(:issue_from => parentIssue1,
Chris@1464 1902 :issue_to => childIssue2_2,
Chris@1464 1903 :relation_type => IssueRelation::TYPE_BLOCKS)
Chris@1464 1904
Chris@1464 1905 assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_2.id].sort,
Chris@1464 1906 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
Chris@1464 1907 end
Chris@1464 1908
Chris@1464 1909 def test_all_dependent_issues_with_relation_to_parent_in_other_tree
Chris@1464 1910 IssueRelation.delete_all
Chris@1464 1911
Chris@1464 1912 project = Project.generate!(:name => "testproject")
Chris@1464 1913
Chris@1464 1914 parentIssue1 = Issue.generate!(:project => project)
Chris@1464 1915 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1464 1916 childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1464 1917
Chris@1464 1918 parentIssue2 = Issue.generate!(:project => project)
Chris@1464 1919 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1464 1920 childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1464 1921
Chris@1464 1922
Chris@1464 1923 assert IssueRelation.create(:issue_from => parentIssue1,
Chris@1464 1924 :issue_to => parentIssue2,
Chris@1464 1925 :relation_type => IssueRelation::TYPE_BLOCKS)
Chris@1464 1926
Chris@1464 1927 assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_1.id, childIssue2_2.id].sort,
Chris@1464 1928 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
Chris@1464 1929 end
Chris@1464 1930
Chris@1464 1931 def test_all_dependent_issues_with_transitive_relation
Chris@1464 1932 IssueRelation.delete_all
Chris@1464 1933
Chris@1464 1934 project = Project.generate!(:name => "testproject")
Chris@1464 1935
Chris@1464 1936 parentIssue1 = Issue.generate!(:project => project)
Chris@1464 1937 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1464 1938
Chris@1464 1939 parentIssue2 = Issue.generate!(:project => project)
Chris@1464 1940 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1464 1941
Chris@1464 1942 independentIssue = Issue.generate!(:project => project)
Chris@1464 1943
Chris@1464 1944 assert IssueRelation.create(:issue_from => parentIssue1,
Chris@1464 1945 :issue_to => childIssue2_1,
Chris@1464 1946 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 1947
Chris@1464 1948 assert IssueRelation.create(:issue_from => childIssue2_1,
Chris@1464 1949 :issue_to => independentIssue,
Chris@1464 1950 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 1951
Chris@1464 1952 assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
Chris@1464 1953 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
Chris@1464 1954 end
Chris@1464 1955
Chris@1464 1956 def test_all_dependent_issues_with_transitive_relation2
Chris@1464 1957 IssueRelation.delete_all
Chris@1464 1958
Chris@1464 1959 project = Project.generate!(:name => "testproject")
Chris@1464 1960
Chris@1464 1961 parentIssue1 = Issue.generate!(:project => project)
Chris@1464 1962 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1464 1963
Chris@1464 1964 parentIssue2 = Issue.generate!(:project => project)
Chris@1464 1965 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1464 1966
Chris@1464 1967 independentIssue = Issue.generate!(:project => project)
Chris@1464 1968
Chris@1464 1969 assert IssueRelation.create(:issue_from => parentIssue1,
Chris@1464 1970 :issue_to => independentIssue,
Chris@1464 1971 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 1972
Chris@1464 1973 assert IssueRelation.create(:issue_from => independentIssue,
Chris@1464 1974 :issue_to => childIssue2_1,
Chris@1464 1975 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 1976
Chris@1464 1977 assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
Chris@1464 1978 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
Chris@1464 1979
Chris@1464 1980 end
Chris@1464 1981
Chris@1464 1982 def test_all_dependent_issues_with_persistent_circular_dependency
Chris@1464 1983 IssueRelation.delete_all
Chris@1464 1984 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1464 1985 :issue_to => Issue.find(2),
Chris@1464 1986 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1987 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1464 1988 :issue_to => Issue.find(3),
Chris@1464 1989 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1990
Chris@1464 1991 r = IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1464 1992 :issue_to => Issue.find(7),
Chris@1464 1993 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1994 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
Chris@1464 1995
Chris@1464 1996 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1464 1997 end
Chris@1464 1998
Chris@1464 1999 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
Chris@1464 2000 IssueRelation.delete_all
Chris@1464 2001 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1464 2002 :issue_to => Issue.find(2),
Chris@1464 2003 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 2004 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1464 2005 :issue_to => Issue.find(3),
Chris@1464 2006 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 2007 assert IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1464 2008 :issue_to => Issue.find(8),
Chris@1464 2009 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 2010
Chris@1464 2011 r = IssueRelation.create!(:issue_from => Issue.find(8),
Chris@1464 2012 :issue_to => Issue.find(7),
Chris@1464 2013 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 2014 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
Chris@1464 2015
Chris@1464 2016 r = IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1464 2017 :issue_to => Issue.find(7),
Chris@1464 2018 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 2019 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
Chris@1464 2020
Chris@1464 2021 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1464 2022 end
Chris@1464 2023
Chris@1464 2024 test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
Chris@1464 2025 @issue = Issue.find(1)
Chris@1464 2026 @issue_status = IssueStatus.find(1)
Chris@1464 2027 @issue_status.update_attribute(:default_done_ratio, 50)
Chris@1464 2028 @issue2 = Issue.find(2)
Chris@1464 2029 @issue_status2 = IssueStatus.find(2)
Chris@1464 2030 @issue_status2.update_attribute(:default_done_ratio, 0)
Chris@1464 2031
Chris@1464 2032 with_settings :issue_done_ratio => 'issue_field' do
Chris@1464 2033 assert_equal 0, @issue.done_ratio
Chris@1464 2034 assert_equal 30, @issue2.done_ratio
Chris@1464 2035 end
Chris@1464 2036
Chris@1464 2037 with_settings :issue_done_ratio => 'issue_status' do
Chris@1464 2038 assert_equal 50, @issue.done_ratio
Chris@1464 2039 assert_equal 0, @issue2.done_ratio
Chris@1464 2040 end
Chris@1464 2041 end
Chris@1464 2042
Chris@1464 2043 test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
Chris@1464 2044 @issue = Issue.find(1)
Chris@1464 2045 @issue_status = IssueStatus.find(1)
Chris@1464 2046 @issue_status.update_attribute(:default_done_ratio, 50)
Chris@1464 2047 @issue2 = Issue.find(2)
Chris@1464 2048 @issue_status2 = IssueStatus.find(2)
Chris@1464 2049 @issue_status2.update_attribute(:default_done_ratio, 0)
Chris@1464 2050
Chris@1464 2051 with_settings :issue_done_ratio => 'issue_field' do
Chris@1464 2052 @issue.update_done_ratio_from_issue_status
Chris@1464 2053 @issue2.update_done_ratio_from_issue_status
Chris@1464 2054
Chris@1464 2055 assert_equal 0, @issue.read_attribute(:done_ratio)
Chris@1464 2056 assert_equal 30, @issue2.read_attribute(:done_ratio)
Chris@1464 2057 end
Chris@1464 2058
Chris@1464 2059 with_settings :issue_done_ratio => 'issue_status' do
Chris@1464 2060 @issue.update_done_ratio_from_issue_status
Chris@1464 2061 @issue2.update_done_ratio_from_issue_status
Chris@1464 2062
Chris@1464 2063 assert_equal 50, @issue.read_attribute(:done_ratio)
Chris@1464 2064 assert_equal 0, @issue2.read_attribute(:done_ratio)
Chris@1464 2065 end
Chris@1464 2066 end
Chris@1464 2067
Chris@1464 2068 test "#by_tracker" do
Chris@1464 2069 User.current = User.anonymous
Chris@1464 2070 groups = Issue.by_tracker(Project.find(1))
Chris@1464 2071 assert_equal 3, groups.count
Chris@1464 2072 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2073 end
Chris@1464 2074
Chris@1464 2075 test "#by_version" do
Chris@1464 2076 User.current = User.anonymous
Chris@1464 2077 groups = Issue.by_version(Project.find(1))
Chris@1464 2078 assert_equal 3, groups.count
Chris@1464 2079 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2080 end
Chris@1464 2081
Chris@1464 2082 test "#by_priority" do
Chris@1464 2083 User.current = User.anonymous
Chris@1464 2084 groups = Issue.by_priority(Project.find(1))
Chris@1464 2085 assert_equal 4, groups.count
Chris@1464 2086 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2087 end
Chris@1464 2088
Chris@1464 2089 test "#by_category" do
Chris@1464 2090 User.current = User.anonymous
Chris@1464 2091 groups = Issue.by_category(Project.find(1))
Chris@1464 2092 assert_equal 2, groups.count
Chris@1464 2093 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2094 end
Chris@1464 2095
Chris@1464 2096 test "#by_assigned_to" do
Chris@1464 2097 User.current = User.anonymous
Chris@1464 2098 groups = Issue.by_assigned_to(Project.find(1))
Chris@1464 2099 assert_equal 2, groups.count
Chris@1464 2100 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2101 end
Chris@1464 2102
Chris@1464 2103 test "#by_author" do
Chris@1464 2104 User.current = User.anonymous
Chris@1464 2105 groups = Issue.by_author(Project.find(1))
Chris@1464 2106 assert_equal 4, groups.count
Chris@1464 2107 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2108 end
Chris@1464 2109
Chris@1464 2110 test "#by_subproject" do
Chris@1464 2111 User.current = User.anonymous
Chris@1464 2112 groups = Issue.by_subproject(Project.find(1))
Chris@1464 2113 # Private descendant not visible
Chris@1464 2114 assert_equal 1, groups.count
Chris@1464 2115 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2116 end
Chris@1464 2117
Chris@1464 2118 def test_recently_updated_scope
Chris@1464 2119 #should return the last updated issue
Chris@1464 2120 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
Chris@1464 2121 end
Chris@1464 2122
Chris@1464 2123 def test_on_active_projects_scope
Chris@1464 2124 assert Project.find(2).archive
Chris@1464 2125
Chris@1464 2126 before = Issue.on_active_project.length
Chris@1464 2127 # test inclusion to results
Chris@1464 2128 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
Chris@1464 2129 assert_equal before + 1, Issue.on_active_project.length
Chris@1464 2130
Chris@1464 2131 # Move to an archived project
Chris@1464 2132 issue.project = Project.find(2)
Chris@1464 2133 assert issue.save
Chris@1464 2134 assert_equal before, Issue.on_active_project.length
Chris@1464 2135 end
Chris@1464 2136
Chris@1464 2137 test "Issue#recipients should include project recipients" do
Chris@1464 2138 issue = Issue.generate!
Chris@1464 2139 assert issue.project.recipients.present?
Chris@1464 2140 issue.project.recipients.each do |project_recipient|
Chris@1464 2141 assert issue.recipients.include?(project_recipient)
Chris@1464 2142 end
Chris@1464 2143 end
Chris@1464 2144
Chris@1464 2145 test "Issue#recipients should include the author if the author is active" do
Chris@1464 2146 issue = Issue.generate!(:author => User.generate!)
Chris@1464 2147 assert issue.author, "No author set for Issue"
Chris@1464 2148 assert issue.recipients.include?(issue.author.mail)
Chris@1464 2149 end
Chris@1464 2150
Chris@1464 2151 test "Issue#recipients should include the assigned to user if the assigned to user is active" do
Chris@1464 2152 issue = Issue.generate!(:assigned_to => User.generate!)
Chris@1464 2153 assert issue.assigned_to, "No assigned_to set for Issue"
Chris@1464 2154 assert issue.recipients.include?(issue.assigned_to.mail)
Chris@1464 2155 end
Chris@1464 2156
Chris@1464 2157 test "Issue#recipients should not include users who opt out of all email" do
Chris@1464 2158 issue = Issue.generate!(:author => User.generate!)
Chris@1464 2159 issue.author.update_attribute(:mail_notification, :none)
Chris@1464 2160 assert !issue.recipients.include?(issue.author.mail)
Chris@1464 2161 end
Chris@1464 2162
Chris@1464 2163 test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
Chris@1464 2164 issue = Issue.generate!(:author => User.generate!)
Chris@1464 2165 issue.author.update_attribute(:mail_notification, :only_assigned)
Chris@1464 2166 assert !issue.recipients.include?(issue.author.mail)
Chris@1464 2167 end
Chris@1464 2168
Chris@1464 2169 test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
Chris@1464 2170 issue = Issue.generate!(:assigned_to => User.generate!)
Chris@1464 2171 issue.assigned_to.update_attribute(:mail_notification, :only_owner)
Chris@1464 2172 assert !issue.recipients.include?(issue.assigned_to.mail)
Chris@1464 2173 end
Chris@1464 2174
Chris@1464 2175 def test_last_journal_id_with_journals_should_return_the_journal_id
Chris@1464 2176 assert_equal 2, Issue.find(1).last_journal_id
Chris@1464 2177 end
Chris@1464 2178
Chris@1464 2179 def test_last_journal_id_without_journals_should_return_nil
Chris@1464 2180 assert_nil Issue.find(3).last_journal_id
Chris@1464 2181 end
Chris@1464 2182
Chris@1464 2183 def test_journals_after_should_return_journals_with_greater_id
Chris@1464 2184 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
Chris@1464 2185 assert_equal [], Issue.find(1).journals_after('2')
Chris@1464 2186 end
Chris@1464 2187
Chris@1464 2188 def test_journals_after_with_blank_arg_should_return_all_journals
Chris@1464 2189 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
Chris@1464 2190 end
Chris@1464 2191
Chris@1464 2192 def test_css_classes_should_include_tracker
Chris@1464 2193 issue = Issue.new(:tracker => Tracker.find(2))
Chris@1464 2194 classes = issue.css_classes.split(' ')
Chris@1464 2195 assert_include 'tracker-2', classes
Chris@1464 2196 end
Chris@1464 2197
Chris@1464 2198 def test_css_classes_should_include_priority
Chris@1464 2199 issue = Issue.new(:priority => IssuePriority.find(8))
Chris@1464 2200 classes = issue.css_classes.split(' ')
Chris@1464 2201 assert_include 'priority-8', classes
Chris@1464 2202 assert_include 'priority-highest', classes
Chris@1464 2203 end
Chris@1464 2204
Chris@1464 2205 def test_css_classes_should_include_user_assignment
Chris@1464 2206 issue = Issue.generate(:assigned_to_id => 2)
Chris@1464 2207 assert_include 'assigned-to-me', issue.css_classes(User.find(2))
Chris@1464 2208 assert_not_include 'assigned-to-me', issue.css_classes(User.find(3))
Chris@1464 2209 end
Chris@1464 2210
Chris@1464 2211 def test_css_classes_should_include_user_group_assignment
Chris@1464 2212 issue = Issue.generate(:assigned_to_id => 10)
Chris@1464 2213 assert_include 'assigned-to-my-group', issue.css_classes(Group.find(10).users.first)
Chris@1464 2214 assert_not_include 'assigned-to-my-group', issue.css_classes(User.find(3))
Chris@1464 2215 end
Chris@1464 2216
Chris@1464 2217 def test_save_attachments_with_hash_should_save_attachments_in_keys_order
Chris@1464 2218 set_tmp_attachments_directory
Chris@1464 2219 issue = Issue.generate!
Chris@1464 2220 issue.save_attachments({
Chris@1464 2221 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
Chris@1464 2222 '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
Chris@1464 2223 '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
Chris@1464 2224 })
Chris@1464 2225 issue.attach_saved_attachments
Chris@1464 2226
Chris@1464 2227 assert_equal 3, issue.reload.attachments.count
Chris@1464 2228 assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
Chris@1464 2229 end
Chris@1464 2230
Chris@1464 2231 def test_closed_on_should_be_nil_when_creating_an_open_issue
Chris@1464 2232 issue = Issue.generate!(:status_id => 1).reload
Chris@1464 2233 assert !issue.closed?
Chris@1464 2234 assert_nil issue.closed_on
Chris@1464 2235 end
Chris@1464 2236
Chris@1464 2237 def test_closed_on_should_be_set_when_creating_a_closed_issue
Chris@1464 2238 issue = Issue.generate!(:status_id => 5).reload
Chris@1464 2239 assert issue.closed?
Chris@1464 2240 assert_not_nil issue.closed_on
Chris@1464 2241 assert_equal issue.updated_on, issue.closed_on
Chris@1464 2242 assert_equal issue.created_on, issue.closed_on
Chris@1464 2243 end
Chris@1464 2244
Chris@1464 2245 def test_closed_on_should_be_nil_when_updating_an_open_issue
Chris@1464 2246 issue = Issue.find(1)
Chris@1464 2247 issue.subject = 'Not closed yet'
Chris@1464 2248 issue.save!
Chris@1464 2249 issue.reload
Chris@1464 2250 assert_nil issue.closed_on
Chris@1464 2251 end
Chris@1464 2252
Chris@1464 2253 def test_closed_on_should_be_set_when_closing_an_open_issue
Chris@1464 2254 issue = Issue.find(1)
Chris@1464 2255 issue.subject = 'Now closed'
Chris@1464 2256 issue.status_id = 5
Chris@1464 2257 issue.save!
Chris@1464 2258 issue.reload
Chris@1464 2259 assert_not_nil issue.closed_on
Chris@1464 2260 assert_equal issue.updated_on, issue.closed_on
Chris@1464 2261 end
Chris@1464 2262
Chris@1464 2263 def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
Chris@1464 2264 issue = Issue.open(false).first
Chris@1464 2265 was_closed_on = issue.closed_on
Chris@1464 2266 assert_not_nil was_closed_on
Chris@1464 2267 issue.subject = 'Updating a closed issue'
Chris@1464 2268 issue.save!
Chris@1464 2269 issue.reload
Chris@1464 2270 assert_equal was_closed_on, issue.closed_on
Chris@1464 2271 end
Chris@1464 2272
Chris@1464 2273 def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
Chris@1464 2274 issue = Issue.open(false).first
Chris@1464 2275 was_closed_on = issue.closed_on
Chris@1464 2276 assert_not_nil was_closed_on
Chris@1464 2277 issue.subject = 'Reopening a closed issue'
Chris@1464 2278 issue.status_id = 1
Chris@1464 2279 issue.save!
Chris@1464 2280 issue.reload
Chris@1464 2281 assert !issue.closed?
Chris@1464 2282 assert_equal was_closed_on, issue.closed_on
Chris@1464 2283 end
Chris@1464 2284
Chris@1464 2285 def test_status_was_should_return_nil_for_new_issue
Chris@1464 2286 issue = Issue.new
Chris@1464 2287 assert_nil issue.status_was
Chris@1464 2288 end
Chris@1464 2289
Chris@1464 2290 def test_status_was_should_return_status_before_change
Chris@1464 2291 issue = Issue.find(1)
Chris@1464 2292 issue.status = IssueStatus.find(2)
Chris@1464 2293 assert_equal IssueStatus.find(1), issue.status_was
Chris@1464 2294 end
Chris@1464 2295
Chris@1464 2296 def test_status_was_should_be_reset_on_save
Chris@1464 2297 issue = Issue.find(1)
Chris@1464 2298 issue.status = IssueStatus.find(2)
Chris@1464 2299 assert_equal IssueStatus.find(1), issue.status_was
Chris@1464 2300 assert issue.save!
Chris@1464 2301 assert_equal IssueStatus.find(2), issue.status_was
Chris@1464 2302 end
Chris@1464 2303 end