annotate .svn/pristine/07/0781c86b247e4cfc1df644f5ac2c5e1a6fb8ca1d.svn-base @ 1464:261b3d9a4903 redmine-2.4

Update to Redmine 2.4 branch rev 12663
author Chris Cannam
date Tue, 14 Jan 2014 14:37:42 +0000
parents
children
rev   line source
Chris@1464 1 # Redmine - project management software
Chris@1464 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
Chris@1464 3 #
Chris@1464 4 # This program is free software; you can redistribute it and/or
Chris@1464 5 # modify it under the terms of the GNU General Public License
Chris@1464 6 # as published by the Free Software Foundation; either version 2
Chris@1464 7 # of the License, or (at your option) any later version.
Chris@1464 8 #
Chris@1464 9 # This program is distributed in the hope that it will be useful,
Chris@1464 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
Chris@1464 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Chris@1464 12 # GNU General Public License for more details.
Chris@1464 13 #
Chris@1464 14 # You should have received a copy of the GNU General Public License
Chris@1464 15 # along with this program; if not, write to the Free Software
Chris@1464 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Chris@1464 17
Chris@1464 18 require File.expand_path('../../test_helper', __FILE__)
Chris@1464 19
Chris@1464 20 class IssueTest < ActiveSupport::TestCase
Chris@1464 21 fixtures :projects, :users, :members, :member_roles, :roles,
Chris@1464 22 :groups_users,
Chris@1464 23 :trackers, :projects_trackers,
Chris@1464 24 :enabled_modules,
Chris@1464 25 :versions,
Chris@1464 26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
Chris@1464 27 :enumerations,
Chris@1464 28 :issues, :journals, :journal_details,
Chris@1464 29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
Chris@1464 30 :time_entries
Chris@1464 31
Chris@1464 32 include Redmine::I18n
Chris@1464 33
Chris@1464 34 def teardown
Chris@1464 35 User.current = nil
Chris@1464 36 end
Chris@1464 37
Chris@1464 38 def test_initialize
Chris@1464 39 issue = Issue.new
Chris@1464 40
Chris@1464 41 assert_nil issue.project_id
Chris@1464 42 assert_nil issue.tracker_id
Chris@1464 43 assert_nil issue.author_id
Chris@1464 44 assert_nil issue.assigned_to_id
Chris@1464 45 assert_nil issue.category_id
Chris@1464 46
Chris@1464 47 assert_equal IssueStatus.default, issue.status
Chris@1464 48 assert_equal IssuePriority.default, issue.priority
Chris@1464 49 end
Chris@1464 50
Chris@1464 51 def test_create
Chris@1464 52 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1464 53 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1464 54 :subject => 'test_create',
Chris@1464 55 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
Chris@1464 56 assert issue.save
Chris@1464 57 issue.reload
Chris@1464 58 assert_equal 1.5, issue.estimated_hours
Chris@1464 59 end
Chris@1464 60
Chris@1464 61 def test_create_minimal
Chris@1464 62 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1464 63 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1464 64 :subject => 'test_create')
Chris@1464 65 assert issue.save
Chris@1464 66 assert issue.description.nil?
Chris@1464 67 assert_nil issue.estimated_hours
Chris@1464 68 end
Chris@1464 69
Chris@1464 70 def test_start_date_format_should_be_validated
Chris@1464 71 set_language_if_valid 'en'
Chris@1464 72 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
Chris@1464 73 issue = Issue.new(:start_date => invalid_date)
Chris@1464 74 assert !issue.valid?
Chris@1464 75 assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
Chris@1464 76 end
Chris@1464 77 end
Chris@1464 78
Chris@1464 79 def test_due_date_format_should_be_validated
Chris@1464 80 set_language_if_valid 'en'
Chris@1464 81 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
Chris@1464 82 issue = Issue.new(:due_date => invalid_date)
Chris@1464 83 assert !issue.valid?
Chris@1464 84 assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
Chris@1464 85 end
Chris@1464 86 end
Chris@1464 87
Chris@1464 88 def test_due_date_lesser_than_start_date_should_not_validate
Chris@1464 89 set_language_if_valid 'en'
Chris@1464 90 issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
Chris@1464 91 assert !issue.valid?
Chris@1464 92 assert_include 'Due date must be greater than start date', issue.errors.full_messages
Chris@1464 93 end
Chris@1464 94
Chris@1464 95 def test_estimated_hours_should_be_validated
Chris@1464 96 set_language_if_valid 'en'
Chris@1464 97 ['-2'].each do |invalid|
Chris@1464 98 issue = Issue.new(:estimated_hours => invalid)
Chris@1464 99 assert !issue.valid?
Chris@1464 100 assert_include 'Estimated time is invalid', issue.errors.full_messages
Chris@1464 101 end
Chris@1464 102 end
Chris@1464 103
Chris@1464 104 def test_create_with_required_custom_field
Chris@1464 105 set_language_if_valid 'en'
Chris@1464 106 field = IssueCustomField.find_by_name('Database')
Chris@1464 107 field.update_attribute(:is_required, true)
Chris@1464 108
Chris@1464 109 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 110 :status_id => 1, :subject => 'test_create',
Chris@1464 111 :description => 'IssueTest#test_create_with_required_custom_field')
Chris@1464 112 assert issue.available_custom_fields.include?(field)
Chris@1464 113 # No value for the custom field
Chris@1464 114 assert !issue.save
Chris@1464 115 assert_equal ["Database can't be blank"], issue.errors.full_messages
Chris@1464 116 # Blank value
Chris@1464 117 issue.custom_field_values = { field.id => '' }
Chris@1464 118 assert !issue.save
Chris@1464 119 assert_equal ["Database can't be blank"], issue.errors.full_messages
Chris@1464 120 # Invalid value
Chris@1464 121 issue.custom_field_values = { field.id => 'SQLServer' }
Chris@1464 122 assert !issue.save
Chris@1464 123 assert_equal ["Database is not included in the list"], issue.errors.full_messages
Chris@1464 124 # Valid value
Chris@1464 125 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1464 126 assert issue.save
Chris@1464 127 issue.reload
Chris@1464 128 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
Chris@1464 129 end
Chris@1464 130
Chris@1464 131 def test_create_with_group_assignment
Chris@1464 132 with_settings :issue_group_assignment => '1' do
Chris@1464 133 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
Chris@1464 134 :subject => 'Group assignment',
Chris@1464 135 :assigned_to_id => 11).save
Chris@1464 136 issue = Issue.first(:order => 'id DESC')
Chris@1464 137 assert_kind_of Group, issue.assigned_to
Chris@1464 138 assert_equal Group.find(11), issue.assigned_to
Chris@1464 139 end
Chris@1464 140 end
Chris@1464 141
Chris@1464 142 def test_create_with_parent_issue_id
Chris@1464 143 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1464 144 :author_id => 1, :subject => 'Group assignment',
Chris@1464 145 :parent_issue_id => 1)
Chris@1464 146 assert_save issue
Chris@1464 147 assert_equal 1, issue.parent_issue_id
Chris@1464 148 assert_equal Issue.find(1), issue.parent
Chris@1464 149 end
Chris@1464 150
Chris@1464 151 def test_create_with_sharp_parent_issue_id
Chris@1464 152 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1464 153 :author_id => 1, :subject => 'Group assignment',
Chris@1464 154 :parent_issue_id => "#1")
Chris@1464 155 assert_save issue
Chris@1464 156 assert_equal 1, issue.parent_issue_id
Chris@1464 157 assert_equal Issue.find(1), issue.parent
Chris@1464 158 end
Chris@1464 159
Chris@1464 160 def test_create_with_invalid_parent_issue_id
Chris@1464 161 set_language_if_valid 'en'
Chris@1464 162 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1464 163 :author_id => 1, :subject => 'Group assignment',
Chris@1464 164 :parent_issue_id => '01ABC')
Chris@1464 165 assert !issue.save
Chris@1464 166 assert_equal '01ABC', issue.parent_issue_id
Chris@1464 167 assert_include 'Parent task is invalid', issue.errors.full_messages
Chris@1464 168 end
Chris@1464 169
Chris@1464 170 def test_create_with_invalid_sharp_parent_issue_id
Chris@1464 171 set_language_if_valid 'en'
Chris@1464 172 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1464 173 :author_id => 1, :subject => 'Group assignment',
Chris@1464 174 :parent_issue_id => '#01ABC')
Chris@1464 175 assert !issue.save
Chris@1464 176 assert_equal '#01ABC', issue.parent_issue_id
Chris@1464 177 assert_include 'Parent task is invalid', issue.errors.full_messages
Chris@1464 178 end
Chris@1464 179
Chris@1464 180 def assert_visibility_match(user, issues)
Chris@1464 181 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
Chris@1464 182 end
Chris@1464 183
Chris@1464 184 def test_visible_scope_for_anonymous
Chris@1464 185 # Anonymous user should see issues of public projects only
Chris@1464 186 issues = Issue.visible(User.anonymous).all
Chris@1464 187 assert issues.any?
Chris@1464 188 assert_nil issues.detect {|issue| !issue.project.is_public?}
Chris@1464 189 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1464 190 assert_visibility_match User.anonymous, issues
Chris@1464 191 end
Chris@1464 192
Chris@1464 193 def test_visible_scope_for_anonymous_without_view_issues_permissions
Chris@1464 194 # Anonymous user should not see issues without permission
Chris@1464 195 Role.anonymous.remove_permission!(:view_issues)
Chris@1464 196 issues = Issue.visible(User.anonymous).all
Chris@1464 197 assert issues.empty?
Chris@1464 198 assert_visibility_match User.anonymous, issues
Chris@1464 199 end
Chris@1464 200
Chris@1464 201 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
Chris@1464 202 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
Chris@1464 203 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
Chris@1464 204 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
Chris@1464 205 assert !issue.visible?(User.anonymous)
Chris@1464 206 end
Chris@1464 207
Chris@1464 208 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
Chris@1464 209 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
Chris@1464 210 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
Chris@1464 211 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
Chris@1464 212 assert !issue.visible?(User.anonymous)
Chris@1464 213 end
Chris@1464 214
Chris@1464 215 def test_visible_scope_for_non_member
Chris@1464 216 user = User.find(9)
Chris@1464 217 assert user.projects.empty?
Chris@1464 218 # Non member user should see issues of public projects only
Chris@1464 219 issues = Issue.visible(user).all
Chris@1464 220 assert issues.any?
Chris@1464 221 assert_nil issues.detect {|issue| !issue.project.is_public?}
Chris@1464 222 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1464 223 assert_visibility_match user, issues
Chris@1464 224 end
Chris@1464 225
Chris@1464 226 def test_visible_scope_for_non_member_with_own_issues_visibility
Chris@1464 227 Role.non_member.update_attribute :issues_visibility, 'own'
Chris@1464 228 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
Chris@1464 229 user = User.find(9)
Chris@1464 230
Chris@1464 231 issues = Issue.visible(user).all
Chris@1464 232 assert issues.any?
Chris@1464 233 assert_nil issues.detect {|issue| issue.author != user}
Chris@1464 234 assert_visibility_match user, issues
Chris@1464 235 end
Chris@1464 236
Chris@1464 237 def test_visible_scope_for_non_member_without_view_issues_permissions
Chris@1464 238 # Non member user should not see issues without permission
Chris@1464 239 Role.non_member.remove_permission!(:view_issues)
Chris@1464 240 user = User.find(9)
Chris@1464 241 assert user.projects.empty?
Chris@1464 242 issues = Issue.visible(user).all
Chris@1464 243 assert issues.empty?
Chris@1464 244 assert_visibility_match user, issues
Chris@1464 245 end
Chris@1464 246
Chris@1464 247 def test_visible_scope_for_member
Chris@1464 248 user = User.find(9)
Chris@1464 249 # User should see issues of projects for which he has view_issues permissions only
Chris@1464 250 Role.non_member.remove_permission!(:view_issues)
Chris@1464 251 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
Chris@1464 252 issues = Issue.visible(user).all
Chris@1464 253 assert issues.any?
Chris@1464 254 assert_nil issues.detect {|issue| issue.project_id != 3}
Chris@1464 255 assert_nil issues.detect {|issue| issue.is_private?}
Chris@1464 256 assert_visibility_match user, issues
Chris@1464 257 end
Chris@1464 258
Chris@1464 259 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
Chris@1464 260 user = User.find(8)
Chris@1464 261 assert user.groups.any?
Chris@1464 262 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
Chris@1464 263 Role.non_member.remove_permission!(:view_issues)
Chris@1464 264
Chris@1464 265 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1464 266 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1464 267 :subject => 'Assignment test',
Chris@1464 268 :assigned_to => user.groups.first,
Chris@1464 269 :is_private => true)
Chris@1464 270
Chris@1464 271 Role.find(2).update_attribute :issues_visibility, 'default'
Chris@1464 272 issues = Issue.visible(User.find(8)).all
Chris@1464 273 assert issues.any?
Chris@1464 274 assert issues.include?(issue)
Chris@1464 275
Chris@1464 276 Role.find(2).update_attribute :issues_visibility, 'own'
Chris@1464 277 issues = Issue.visible(User.find(8)).all
Chris@1464 278 assert issues.any?
Chris@1464 279 assert issues.include?(issue)
Chris@1464 280 end
Chris@1464 281
Chris@1464 282 def test_visible_scope_for_admin
Chris@1464 283 user = User.find(1)
Chris@1464 284 user.members.each(&:destroy)
Chris@1464 285 assert user.projects.empty?
Chris@1464 286 issues = Issue.visible(user).all
Chris@1464 287 assert issues.any?
Chris@1464 288 # Admin should see issues on private projects that he does not belong to
Chris@1464 289 assert issues.detect {|issue| !issue.project.is_public?}
Chris@1464 290 # Admin should see private issues of other users
Chris@1464 291 assert issues.detect {|issue| issue.is_private? && issue.author != user}
Chris@1464 292 assert_visibility_match user, issues
Chris@1464 293 end
Chris@1464 294
Chris@1464 295 def test_visible_scope_with_project
Chris@1464 296 project = Project.find(1)
Chris@1464 297 issues = Issue.visible(User.find(2), :project => project).all
Chris@1464 298 projects = issues.collect(&:project).uniq
Chris@1464 299 assert_equal 1, projects.size
Chris@1464 300 assert_equal project, projects.first
Chris@1464 301 end
Chris@1464 302
Chris@1464 303 def test_visible_scope_with_project_and_subprojects
Chris@1464 304 project = Project.find(1)
Chris@1464 305 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
Chris@1464 306 projects = issues.collect(&:project).uniq
Chris@1464 307 assert projects.size > 1
Chris@1464 308 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
Chris@1464 309 end
Chris@1464 310
Chris@1464 311 def test_visible_and_nested_set_scopes
Chris@1464 312 assert_equal 0, Issue.find(1).descendants.visible.all.size
Chris@1464 313 end
Chris@1464 314
Chris@1464 315 def test_open_scope
Chris@1464 316 issues = Issue.open.all
Chris@1464 317 assert_nil issues.detect(&:closed?)
Chris@1464 318 end
Chris@1464 319
Chris@1464 320 def test_open_scope_with_arg
Chris@1464 321 issues = Issue.open(false).all
Chris@1464 322 assert_equal issues, issues.select(&:closed?)
Chris@1464 323 end
Chris@1464 324
Chris@1464 325 def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
Chris@1464 326 version = Version.find(2)
Chris@1464 327 assert version.fixed_issues.any?
Chris@1464 328 assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
Chris@1464 329 end
Chris@1464 330
Chris@1464 331 def test_fixed_version_scope_with_empty_array_should_return_no_result
Chris@1464 332 assert_equal 0, Issue.fixed_version([]).count
Chris@1464 333 end
Chris@1464 334
Chris@1464 335 def test_errors_full_messages_should_include_custom_fields_errors
Chris@1464 336 field = IssueCustomField.find_by_name('Database')
Chris@1464 337
Chris@1464 338 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 339 :status_id => 1, :subject => 'test_create',
Chris@1464 340 :description => 'IssueTest#test_create_with_required_custom_field')
Chris@1464 341 assert issue.available_custom_fields.include?(field)
Chris@1464 342 # Invalid value
Chris@1464 343 issue.custom_field_values = { field.id => 'SQLServer' }
Chris@1464 344
Chris@1464 345 assert !issue.valid?
Chris@1464 346 assert_equal 1, issue.errors.full_messages.size
Chris@1464 347 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
Chris@1464 348 issue.errors.full_messages.first
Chris@1464 349 end
Chris@1464 350
Chris@1464 351 def test_update_issue_with_required_custom_field
Chris@1464 352 field = IssueCustomField.find_by_name('Database')
Chris@1464 353 field.update_attribute(:is_required, true)
Chris@1464 354
Chris@1464 355 issue = Issue.find(1)
Chris@1464 356 assert_nil issue.custom_value_for(field)
Chris@1464 357 assert issue.available_custom_fields.include?(field)
Chris@1464 358 # No change to custom values, issue can be saved
Chris@1464 359 assert issue.save
Chris@1464 360 # Blank value
Chris@1464 361 issue.custom_field_values = { field.id => '' }
Chris@1464 362 assert !issue.save
Chris@1464 363 # Valid value
Chris@1464 364 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1464 365 assert issue.save
Chris@1464 366 issue.reload
Chris@1464 367 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
Chris@1464 368 end
Chris@1464 369
Chris@1464 370 def test_should_not_update_attributes_if_custom_fields_validation_fails
Chris@1464 371 issue = Issue.find(1)
Chris@1464 372 field = IssueCustomField.find_by_name('Database')
Chris@1464 373 assert issue.available_custom_fields.include?(field)
Chris@1464 374
Chris@1464 375 issue.custom_field_values = { field.id => 'Invalid' }
Chris@1464 376 issue.subject = 'Should be not be saved'
Chris@1464 377 assert !issue.save
Chris@1464 378
Chris@1464 379 issue.reload
Chris@1464 380 assert_equal "Can't print recipes", issue.subject
Chris@1464 381 end
Chris@1464 382
Chris@1464 383 def test_should_not_recreate_custom_values_objects_on_update
Chris@1464 384 field = IssueCustomField.find_by_name('Database')
Chris@1464 385
Chris@1464 386 issue = Issue.find(1)
Chris@1464 387 issue.custom_field_values = { field.id => 'PostgreSQL' }
Chris@1464 388 assert issue.save
Chris@1464 389 custom_value = issue.custom_value_for(field)
Chris@1464 390 issue.reload
Chris@1464 391 issue.custom_field_values = { field.id => 'MySQL' }
Chris@1464 392 assert issue.save
Chris@1464 393 issue.reload
Chris@1464 394 assert_equal custom_value.id, issue.custom_value_for(field).id
Chris@1464 395 end
Chris@1464 396
Chris@1464 397 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
Chris@1464 398 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 399 :status_id => 1, :subject => 'Test',
Chris@1464 400 :custom_field_values => {'2' => 'Test'})
Chris@1464 401 assert !Tracker.find(2).custom_field_ids.include?(2)
Chris@1464 402
Chris@1464 403 issue = Issue.find(issue.id)
Chris@1464 404 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
Chris@1464 405
Chris@1464 406 issue = Issue.find(issue.id)
Chris@1464 407 custom_value = issue.custom_value_for(2)
Chris@1464 408 assert_not_nil custom_value
Chris@1464 409 assert_equal 'Test', custom_value.value
Chris@1464 410 end
Chris@1464 411
Chris@1464 412 def test_assigning_tracker_id_should_reload_custom_fields_values
Chris@1464 413 issue = Issue.new(:project => Project.find(1))
Chris@1464 414 assert issue.custom_field_values.empty?
Chris@1464 415 issue.tracker_id = 1
Chris@1464 416 assert issue.custom_field_values.any?
Chris@1464 417 end
Chris@1464 418
Chris@1464 419 def test_assigning_attributes_should_assign_project_and_tracker_first
Chris@1464 420 seq = sequence('seq')
Chris@1464 421 issue = Issue.new
Chris@1464 422 issue.expects(:project_id=).in_sequence(seq)
Chris@1464 423 issue.expects(:tracker_id=).in_sequence(seq)
Chris@1464 424 issue.expects(:subject=).in_sequence(seq)
Chris@1464 425 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
Chris@1464 426 end
Chris@1464 427
Chris@1464 428 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
Chris@1464 429 attributes = ActiveSupport::OrderedHash.new
Chris@1464 430 attributes['custom_field_values'] = { '1' => 'MySQL' }
Chris@1464 431 attributes['tracker_id'] = '1'
Chris@1464 432 issue = Issue.new(:project => Project.find(1))
Chris@1464 433 issue.attributes = attributes
Chris@1464 434 assert_equal 'MySQL', issue.custom_field_value(1)
Chris@1464 435 end
Chris@1464 436
Chris@1464 437 def test_reload_should_reload_custom_field_values
Chris@1464 438 issue = Issue.generate!
Chris@1464 439 issue.custom_field_values = {'2' => 'Foo'}
Chris@1464 440 issue.save!
Chris@1464 441
Chris@1464 442 issue = Issue.order('id desc').first
Chris@1464 443 assert_equal 'Foo', issue.custom_field_value(2)
Chris@1464 444
Chris@1464 445 issue.custom_field_values = {'2' => 'Bar'}
Chris@1464 446 assert_equal 'Bar', issue.custom_field_value(2)
Chris@1464 447
Chris@1464 448 issue.reload
Chris@1464 449 assert_equal 'Foo', issue.custom_field_value(2)
Chris@1464 450 end
Chris@1464 451
Chris@1464 452 def test_should_update_issue_with_disabled_tracker
Chris@1464 453 p = Project.find(1)
Chris@1464 454 issue = Issue.find(1)
Chris@1464 455
Chris@1464 456 p.trackers.delete(issue.tracker)
Chris@1464 457 assert !p.trackers.include?(issue.tracker)
Chris@1464 458
Chris@1464 459 issue.reload
Chris@1464 460 issue.subject = 'New subject'
Chris@1464 461 assert issue.save
Chris@1464 462 end
Chris@1464 463
Chris@1464 464 def test_should_not_set_a_disabled_tracker
Chris@1464 465 p = Project.find(1)
Chris@1464 466 p.trackers.delete(Tracker.find(2))
Chris@1464 467
Chris@1464 468 issue = Issue.find(1)
Chris@1464 469 issue.tracker_id = 2
Chris@1464 470 issue.subject = 'New subject'
Chris@1464 471 assert !issue.save
Chris@1464 472 assert_not_equal [], issue.errors[:tracker_id]
Chris@1464 473 end
Chris@1464 474
Chris@1464 475 def test_category_based_assignment
Chris@1464 476 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
Chris@1464 477 :status_id => 1, :priority => IssuePriority.all.first,
Chris@1464 478 :subject => 'Assignment test',
Chris@1464 479 :description => 'Assignment test', :category_id => 1)
Chris@1464 480 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
Chris@1464 481 end
Chris@1464 482
Chris@1464 483 def test_new_statuses_allowed_to
Chris@1464 484 WorkflowTransition.delete_all
Chris@1464 485 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1464 486 :old_status_id => 1, :new_status_id => 2,
Chris@1464 487 :author => false, :assignee => false)
Chris@1464 488 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1464 489 :old_status_id => 1, :new_status_id => 3,
Chris@1464 490 :author => true, :assignee => false)
Chris@1464 491 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1464 492 :old_status_id => 1, :new_status_id => 4,
Chris@1464 493 :author => false, :assignee => true)
Chris@1464 494 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1464 495 :old_status_id => 1, :new_status_id => 5,
Chris@1464 496 :author => true, :assignee => true)
Chris@1464 497 status = IssueStatus.find(1)
Chris@1464 498 role = Role.find(1)
Chris@1464 499 tracker = Tracker.find(1)
Chris@1464 500 user = User.find(2)
Chris@1464 501
Chris@1464 502 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1464 503 :project_id => 1, :author_id => 1)
Chris@1464 504 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1464 505
Chris@1464 506 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1464 507 :project_id => 1, :author => user)
Chris@1464 508 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1464 509
Chris@1464 510 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1464 511 :project_id => 1, :author_id => 1,
Chris@1464 512 :assigned_to => user)
Chris@1464 513 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1464 514
Chris@1464 515 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1464 516 :project_id => 1, :author => user,
Chris@1464 517 :assigned_to => user)
Chris@1464 518 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1464 519
Chris@1464 520 group = Group.generate!
Chris@1464 521 group.users << user
Chris@1464 522 issue = Issue.generate!(:tracker => tracker, :status => status,
Chris@1464 523 :project_id => 1, :author => user,
Chris@1464 524 :assigned_to => group)
Chris@1464 525 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
Chris@1464 526 end
Chris@1464 527
Chris@1464 528 def test_new_statuses_allowed_to_should_consider_group_assignment
Chris@1464 529 WorkflowTransition.delete_all
Chris@1464 530 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
Chris@1464 531 :old_status_id => 1, :new_status_id => 4,
Chris@1464 532 :author => false, :assignee => true)
Chris@1464 533 user = User.find(2)
Chris@1464 534 group = Group.generate!
Chris@1464 535 group.users << user
Chris@1464 536
Chris@1464 537 issue = Issue.generate!(:author_id => 1, :assigned_to => group)
Chris@1464 538 assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
Chris@1464 539 end
Chris@1464 540
Chris@1464 541 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
Chris@1464 542 admin = User.find(1)
Chris@1464 543 issue = Issue.find(1)
Chris@1464 544 assert !admin.member_of?(issue.project)
Chris@1464 545 expected_statuses = [issue.status] +
Chris@1464 546 WorkflowTransition.find_all_by_old_status_id(
Chris@1464 547 issue.status_id).map(&:new_status).uniq.sort
Chris@1464 548 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
Chris@1464 549 end
Chris@1464 550
Chris@1464 551 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
Chris@1464 552 issue = Issue.find(1).copy
Chris@1464 553 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
Chris@1464 554
Chris@1464 555 issue = Issue.find(2).copy
Chris@1464 556 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
Chris@1464 557 end
Chris@1464 558
Chris@1464 559 def test_safe_attributes_names_should_not_include_disabled_field
Chris@1464 560 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
Chris@1464 561
Chris@1464 562 issue = Issue.new(:tracker => tracker)
Chris@1464 563 assert_include 'tracker_id', issue.safe_attribute_names
Chris@1464 564 assert_include 'status_id', issue.safe_attribute_names
Chris@1464 565 assert_include 'subject', issue.safe_attribute_names
Chris@1464 566 assert_include 'description', issue.safe_attribute_names
Chris@1464 567 assert_include 'custom_field_values', issue.safe_attribute_names
Chris@1464 568 assert_include 'custom_fields', issue.safe_attribute_names
Chris@1464 569 assert_include 'lock_version', issue.safe_attribute_names
Chris@1464 570
Chris@1464 571 tracker.core_fields.each do |field|
Chris@1464 572 assert_include field, issue.safe_attribute_names
Chris@1464 573 end
Chris@1464 574
Chris@1464 575 tracker.disabled_core_fields.each do |field|
Chris@1464 576 assert_not_include field, issue.safe_attribute_names
Chris@1464 577 end
Chris@1464 578 end
Chris@1464 579
Chris@1464 580 def test_safe_attributes_should_ignore_disabled_fields
Chris@1464 581 tracker = Tracker.find(1)
Chris@1464 582 tracker.core_fields = %w(assigned_to_id due_date)
Chris@1464 583 tracker.save!
Chris@1464 584
Chris@1464 585 issue = Issue.new(:tracker => tracker)
Chris@1464 586 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
Chris@1464 587 assert_nil issue.start_date
Chris@1464 588 assert_equal Date.parse('2012-07-14'), issue.due_date
Chris@1464 589 end
Chris@1464 590
Chris@1464 591 def test_safe_attributes_should_accept_target_tracker_enabled_fields
Chris@1464 592 source = Tracker.find(1)
Chris@1464 593 source.core_fields = []
Chris@1464 594 source.save!
Chris@1464 595 target = Tracker.find(2)
Chris@1464 596 target.core_fields = %w(assigned_to_id due_date)
Chris@1464 597 target.save!
Chris@1464 598
Chris@1464 599 issue = Issue.new(:tracker => source)
Chris@1464 600 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
Chris@1464 601 assert_equal target, issue.tracker
Chris@1464 602 assert_equal Date.parse('2012-07-14'), issue.due_date
Chris@1464 603 end
Chris@1464 604
Chris@1464 605 def test_safe_attributes_should_not_include_readonly_fields
Chris@1464 606 WorkflowPermission.delete_all
Chris@1464 607 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 608 :role_id => 1, :field_name => 'due_date',
Chris@1464 609 :rule => 'readonly')
Chris@1464 610 user = User.find(2)
Chris@1464 611
Chris@1464 612 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1464 613 assert_equal %w(due_date), issue.read_only_attribute_names(user)
Chris@1464 614 assert_not_include 'due_date', issue.safe_attribute_names(user)
Chris@1464 615
Chris@1464 616 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
Chris@1464 617 assert_equal Date.parse('2012-07-14'), issue.start_date
Chris@1464 618 assert_nil issue.due_date
Chris@1464 619 end
Chris@1464 620
Chris@1464 621 def test_safe_attributes_should_not_include_readonly_custom_fields
Chris@1464 622 cf1 = IssueCustomField.create!(:name => 'Writable field',
Chris@1464 623 :field_format => 'string',
Chris@1464 624 :is_for_all => true, :tracker_ids => [1])
Chris@1464 625 cf2 = IssueCustomField.create!(:name => 'Readonly field',
Chris@1464 626 :field_format => 'string',
Chris@1464 627 :is_for_all => true, :tracker_ids => [1])
Chris@1464 628 WorkflowPermission.delete_all
Chris@1464 629 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 630 :role_id => 1, :field_name => cf2.id.to_s,
Chris@1464 631 :rule => 'readonly')
Chris@1464 632 user = User.find(2)
Chris@1464 633 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1464 634 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
Chris@1464 635 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
Chris@1464 636
Chris@1464 637 issue.send :safe_attributes=, {'custom_field_values' => {
Chris@1464 638 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
Chris@1464 639 }}, user
Chris@1464 640 assert_equal 'value1', issue.custom_field_value(cf1)
Chris@1464 641 assert_nil issue.custom_field_value(cf2)
Chris@1464 642
Chris@1464 643 issue.send :safe_attributes=, {'custom_fields' => [
Chris@1464 644 {'id' => cf1.id.to_s, 'value' => 'valuea'},
Chris@1464 645 {'id' => cf2.id.to_s, 'value' => 'valueb'}
Chris@1464 646 ]}, user
Chris@1464 647 assert_equal 'valuea', issue.custom_field_value(cf1)
Chris@1464 648 assert_nil issue.custom_field_value(cf2)
Chris@1464 649 end
Chris@1464 650
Chris@1464 651 def test_editable_custom_field_values_should_return_non_readonly_custom_values
Chris@1464 652 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
Chris@1464 653 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1464 654 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
Chris@1464 655 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1464 656 WorkflowPermission.delete_all
Chris@1464 657 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
Chris@1464 658 :field_name => cf2.id.to_s, :rule => 'readonly')
Chris@1464 659 user = User.find(2)
Chris@1464 660
Chris@1464 661 issue = Issue.new(:project_id => 1, :tracker_id => 1)
Chris@1464 662 values = issue.editable_custom_field_values(user)
Chris@1464 663 assert values.detect {|value| value.custom_field == cf1}
Chris@1464 664 assert_nil values.detect {|value| value.custom_field == cf2}
Chris@1464 665
Chris@1464 666 issue.tracker_id = 2
Chris@1464 667 values = issue.editable_custom_field_values(user)
Chris@1464 668 assert values.detect {|value| value.custom_field == cf1}
Chris@1464 669 assert values.detect {|value| value.custom_field == cf2}
Chris@1464 670 end
Chris@1464 671
Chris@1464 672 def test_safe_attributes_should_accept_target_tracker_writable_fields
Chris@1464 673 WorkflowPermission.delete_all
Chris@1464 674 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 675 :role_id => 1, :field_name => 'due_date',
Chris@1464 676 :rule => 'readonly')
Chris@1464 677 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1464 678 :role_id => 1, :field_name => 'start_date',
Chris@1464 679 :rule => 'readonly')
Chris@1464 680 user = User.find(2)
Chris@1464 681
Chris@1464 682 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1464 683
Chris@1464 684 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
Chris@1464 685 'due_date' => '2012-07-14'}, user
Chris@1464 686 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1464 687 assert_nil issue.due_date
Chris@1464 688
Chris@1464 689 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
Chris@1464 690 'due_date' => '2012-07-16',
Chris@1464 691 'tracker_id' => 2}, user
Chris@1464 692 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1464 693 assert_equal Date.parse('2012-07-16'), issue.due_date
Chris@1464 694 end
Chris@1464 695
Chris@1464 696 def test_safe_attributes_should_accept_target_status_writable_fields
Chris@1464 697 WorkflowPermission.delete_all
Chris@1464 698 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 699 :role_id => 1, :field_name => 'due_date',
Chris@1464 700 :rule => 'readonly')
Chris@1464 701 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
Chris@1464 702 :role_id => 1, :field_name => 'start_date',
Chris@1464 703 :rule => 'readonly')
Chris@1464 704 user = User.find(2)
Chris@1464 705
Chris@1464 706 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1464 707
Chris@1464 708 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
Chris@1464 709 'due_date' => '2012-07-14'},
Chris@1464 710 user
Chris@1464 711 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1464 712 assert_nil issue.due_date
Chris@1464 713
Chris@1464 714 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
Chris@1464 715 'due_date' => '2012-07-16',
Chris@1464 716 'status_id' => 2},
Chris@1464 717 user
Chris@1464 718 assert_equal Date.parse('2012-07-12'), issue.start_date
Chris@1464 719 assert_equal Date.parse('2012-07-16'), issue.due_date
Chris@1464 720 end
Chris@1464 721
Chris@1464 722 def test_required_attributes_should_be_validated
Chris@1464 723 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
Chris@1464 724 :is_for_all => true, :tracker_ids => [1, 2])
Chris@1464 725
Chris@1464 726 WorkflowPermission.delete_all
Chris@1464 727 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 728 :role_id => 1, :field_name => 'due_date',
Chris@1464 729 :rule => 'required')
Chris@1464 730 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 731 :role_id => 1, :field_name => 'category_id',
Chris@1464 732 :rule => 'required')
Chris@1464 733 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 734 :role_id => 1, :field_name => cf.id.to_s,
Chris@1464 735 :rule => 'required')
Chris@1464 736
Chris@1464 737 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1464 738 :role_id => 1, :field_name => 'start_date',
Chris@1464 739 :rule => 'required')
Chris@1464 740 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
Chris@1464 741 :role_id => 1, :field_name => cf.id.to_s,
Chris@1464 742 :rule => 'required')
Chris@1464 743 user = User.find(2)
Chris@1464 744
Chris@1464 745 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1464 746 :status_id => 1, :subject => 'Required fields',
Chris@1464 747 :author => user)
Chris@1464 748 assert_equal [cf.id.to_s, "category_id", "due_date"],
Chris@1464 749 issue.required_attribute_names(user).sort
Chris@1464 750 assert !issue.save, "Issue was saved"
Chris@1464 751 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
Chris@1464 752 issue.errors.full_messages.sort
Chris@1464 753
Chris@1464 754 issue.tracker_id = 2
Chris@1464 755 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
Chris@1464 756 assert !issue.save, "Issue was saved"
Chris@1464 757 assert_equal ["Foo can't be blank", "Start date can't be blank"],
Chris@1464 758 issue.errors.full_messages.sort
Chris@1464 759
Chris@1464 760 issue.start_date = Date.today
Chris@1464 761 issue.custom_field_values = {cf.id.to_s => 'bar'}
Chris@1464 762 assert issue.save
Chris@1464 763 end
Chris@1464 764
Chris@1464 765 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
Chris@1464 766 WorkflowPermission.delete_all
Chris@1464 767 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 768 :role_id => 1, :field_name => 'due_date',
Chris@1464 769 :rule => 'required')
Chris@1464 770 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 771 :role_id => 1, :field_name => 'start_date',
Chris@1464 772 :rule => 'required')
Chris@1464 773 user = User.find(2)
Chris@1464 774 member = Member.find(1)
Chris@1464 775 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1464 776
Chris@1464 777 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
Chris@1464 778
Chris@1464 779 member.role_ids = [1, 2]
Chris@1464 780 member.save!
Chris@1464 781 assert_equal [], issue.required_attribute_names(user.reload)
Chris@1464 782
Chris@1464 783 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 784 :role_id => 2, :field_name => 'due_date',
Chris@1464 785 :rule => 'required')
Chris@1464 786 assert_equal %w(due_date), issue.required_attribute_names(user)
Chris@1464 787
Chris@1464 788 member.role_ids = [1, 2, 3]
Chris@1464 789 member.save!
Chris@1464 790 assert_equal [], issue.required_attribute_names(user.reload)
Chris@1464 791
Chris@1464 792 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 793 :role_id => 2, :field_name => 'due_date',
Chris@1464 794 :rule => 'readonly')
Chris@1464 795 # required + readonly => required
Chris@1464 796 assert_equal %w(due_date), issue.required_attribute_names(user)
Chris@1464 797 end
Chris@1464 798
Chris@1464 799 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
Chris@1464 800 WorkflowPermission.delete_all
Chris@1464 801 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 802 :role_id => 1, :field_name => 'due_date',
Chris@1464 803 :rule => 'readonly')
Chris@1464 804 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 805 :role_id => 1, :field_name => 'start_date',
Chris@1464 806 :rule => 'readonly')
Chris@1464 807 user = User.find(2)
Chris@1464 808 member = Member.find(1)
Chris@1464 809 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
Chris@1464 810
Chris@1464 811 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
Chris@1464 812
Chris@1464 813 member.role_ids = [1, 2]
Chris@1464 814 member.save!
Chris@1464 815 assert_equal [], issue.read_only_attribute_names(user.reload)
Chris@1464 816
Chris@1464 817 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
Chris@1464 818 :role_id => 2, :field_name => 'due_date',
Chris@1464 819 :rule => 'readonly')
Chris@1464 820 assert_equal %w(due_date), issue.read_only_attribute_names(user)
Chris@1464 821 end
Chris@1464 822
Chris@1464 823 def test_copy
Chris@1464 824 issue = Issue.new.copy_from(1)
Chris@1464 825 assert issue.copy?
Chris@1464 826 assert issue.save
Chris@1464 827 issue.reload
Chris@1464 828 orig = Issue.find(1)
Chris@1464 829 assert_equal orig.subject, issue.subject
Chris@1464 830 assert_equal orig.tracker, issue.tracker
Chris@1464 831 assert_equal "125", issue.custom_value_for(2).value
Chris@1464 832 end
Chris@1464 833
Chris@1464 834 def test_copy_should_copy_status
Chris@1464 835 orig = Issue.find(8)
Chris@1464 836 assert orig.status != IssueStatus.default
Chris@1464 837
Chris@1464 838 issue = Issue.new.copy_from(orig)
Chris@1464 839 assert issue.save
Chris@1464 840 issue.reload
Chris@1464 841 assert_equal orig.status, issue.status
Chris@1464 842 end
Chris@1464 843
Chris@1464 844 def test_copy_should_add_relation_with_copied_issue
Chris@1464 845 copied = Issue.find(1)
Chris@1464 846 issue = Issue.new.copy_from(copied)
Chris@1464 847 assert issue.save
Chris@1464 848 issue.reload
Chris@1464 849
Chris@1464 850 assert_equal 1, issue.relations.size
Chris@1464 851 relation = issue.relations.first
Chris@1464 852 assert_equal 'copied_to', relation.relation_type
Chris@1464 853 assert_equal copied, relation.issue_from
Chris@1464 854 assert_equal issue, relation.issue_to
Chris@1464 855 end
Chris@1464 856
Chris@1464 857 def test_copy_should_copy_subtasks
Chris@1464 858 issue = Issue.generate_with_descendants!
Chris@1464 859
Chris@1464 860 copy = issue.reload.copy
Chris@1464 861 copy.author = User.find(7)
Chris@1464 862 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1464 863 assert copy.save
Chris@1464 864 end
Chris@1464 865 copy.reload
Chris@1464 866 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
Chris@1464 867 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
Chris@1464 868 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
Chris@1464 869 assert_equal copy.author, child_copy.author
Chris@1464 870 end
Chris@1464 871
Chris@1464 872 def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
Chris@1464 873 parent = Issue.generate!
Chris@1464 874 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
Chris@1464 875 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
Chris@1464 876
Chris@1464 877 copy = parent.reload.copy
Chris@1464 878 copy.parent_issue_id = parent.id
Chris@1464 879 copy.author = User.find(7)
Chris@1464 880 assert_difference 'Issue.count', 3 do
Chris@1464 881 assert copy.save
Chris@1464 882 end
Chris@1464 883 parent.reload
Chris@1464 884 copy.reload
Chris@1464 885 assert_equal parent, copy.parent
Chris@1464 886 assert_equal 3, parent.children.count
Chris@1464 887 assert_equal 5, parent.descendants.count
Chris@1464 888 assert_equal 2, copy.children.count
Chris@1464 889 assert_equal 2, copy.descendants.count
Chris@1464 890 end
Chris@1464 891
Chris@1464 892 def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
Chris@1464 893 parent = Issue.generate!
Chris@1464 894 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
Chris@1464 895 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
Chris@1464 896
Chris@1464 897 copy = parent.reload.copy
Chris@1464 898 copy.parent_issue_id = child1.id
Chris@1464 899 copy.author = User.find(7)
Chris@1464 900 assert_difference 'Issue.count', 3 do
Chris@1464 901 assert copy.save
Chris@1464 902 end
Chris@1464 903 parent.reload
Chris@1464 904 child1.reload
Chris@1464 905 copy.reload
Chris@1464 906 assert_equal child1, copy.parent
Chris@1464 907 assert_equal 2, parent.children.count
Chris@1464 908 assert_equal 5, parent.descendants.count
Chris@1464 909 assert_equal 1, child1.children.count
Chris@1464 910 assert_equal 3, child1.descendants.count
Chris@1464 911 assert_equal 2, copy.children.count
Chris@1464 912 assert_equal 2, copy.descendants.count
Chris@1464 913 end
Chris@1464 914
Chris@1464 915 def test_copy_should_copy_subtasks_to_target_project
Chris@1464 916 issue = Issue.generate_with_descendants!
Chris@1464 917
Chris@1464 918 copy = issue.copy(:project_id => 3)
Chris@1464 919 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1464 920 assert copy.save
Chris@1464 921 end
Chris@1464 922 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
Chris@1464 923 end
Chris@1464 924
Chris@1464 925 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
Chris@1464 926 issue = Issue.generate_with_descendants!
Chris@1464 927
Chris@1464 928 copy = issue.reload.copy
Chris@1464 929 assert_difference 'Issue.count', 1+issue.descendants.count do
Chris@1464 930 assert copy.save
Chris@1464 931 assert copy.save
Chris@1464 932 end
Chris@1464 933 end
Chris@1464 934
Chris@1464 935 def test_should_not_call_after_project_change_on_creation
Chris@1464 936 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
Chris@1464 937 :subject => 'Test', :author_id => 1)
Chris@1464 938 issue.expects(:after_project_change).never
Chris@1464 939 issue.save!
Chris@1464 940 end
Chris@1464 941
Chris@1464 942 def test_should_not_call_after_project_change_on_update
Chris@1464 943 issue = Issue.find(1)
Chris@1464 944 issue.project = Project.find(1)
Chris@1464 945 issue.subject = 'No project change'
Chris@1464 946 issue.expects(:after_project_change).never
Chris@1464 947 issue.save!
Chris@1464 948 end
Chris@1464 949
Chris@1464 950 def test_should_call_after_project_change_on_project_change
Chris@1464 951 issue = Issue.find(1)
Chris@1464 952 issue.project = Project.find(2)
Chris@1464 953 issue.expects(:after_project_change).once
Chris@1464 954 issue.save!
Chris@1464 955 end
Chris@1464 956
Chris@1464 957 def test_adding_journal_should_update_timestamp
Chris@1464 958 issue = Issue.find(1)
Chris@1464 959 updated_on_was = issue.updated_on
Chris@1464 960
Chris@1464 961 issue.init_journal(User.first, "Adding notes")
Chris@1464 962 assert_difference 'Journal.count' do
Chris@1464 963 assert issue.save
Chris@1464 964 end
Chris@1464 965 issue.reload
Chris@1464 966
Chris@1464 967 assert_not_equal updated_on_was, issue.updated_on
Chris@1464 968 end
Chris@1464 969
Chris@1464 970 def test_should_close_duplicates
Chris@1464 971 # Create 3 issues
Chris@1464 972 issue1 = Issue.generate!
Chris@1464 973 issue2 = Issue.generate!
Chris@1464 974 issue3 = Issue.generate!
Chris@1464 975
Chris@1464 976 # 2 is a dupe of 1
Chris@1464 977 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
Chris@1464 978 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1464 979 # And 3 is a dupe of 2
Chris@1464 980 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
Chris@1464 981 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1464 982 # And 3 is a dupe of 1 (circular duplicates)
Chris@1464 983 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
Chris@1464 984 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1464 985
Chris@1464 986 assert issue1.reload.duplicates.include?(issue2)
Chris@1464 987
Chris@1464 988 # Closing issue 1
Chris@1464 989 issue1.init_journal(User.first, "Closing issue1")
Chris@1464 990 issue1.status = IssueStatus.where(:is_closed => true).first
Chris@1464 991 assert issue1.save
Chris@1464 992 # 2 and 3 should be also closed
Chris@1464 993 assert issue2.reload.closed?
Chris@1464 994 assert issue3.reload.closed?
Chris@1464 995 end
Chris@1464 996
Chris@1464 997 def test_should_not_close_duplicated_issue
Chris@1464 998 issue1 = Issue.generate!
Chris@1464 999 issue2 = Issue.generate!
Chris@1464 1000
Chris@1464 1001 # 2 is a dupe of 1
Chris@1464 1002 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
Chris@1464 1003 :relation_type => IssueRelation::TYPE_DUPLICATES)
Chris@1464 1004 # 2 is a dup of 1 but 1 is not a duplicate of 2
Chris@1464 1005 assert !issue2.reload.duplicates.include?(issue1)
Chris@1464 1006
Chris@1464 1007 # Closing issue 2
Chris@1464 1008 issue2.init_journal(User.first, "Closing issue2")
Chris@1464 1009 issue2.status = IssueStatus.where(:is_closed => true).first
Chris@1464 1010 assert issue2.save
Chris@1464 1011 # 1 should not be also closed
Chris@1464 1012 assert !issue1.reload.closed?
Chris@1464 1013 end
Chris@1464 1014
Chris@1464 1015 def test_assignable_versions
Chris@1464 1016 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 1017 :status_id => 1, :fixed_version_id => 1,
Chris@1464 1018 :subject => 'New issue')
Chris@1464 1019 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
Chris@1464 1020 end
Chris@1464 1021
Chris@1464 1022 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
Chris@1464 1023 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 1024 :status_id => 1, :fixed_version_id => 1,
Chris@1464 1025 :subject => 'New issue')
Chris@1464 1026 assert !issue.save
Chris@1464 1027 assert_not_equal [], issue.errors[:fixed_version_id]
Chris@1464 1028 end
Chris@1464 1029
Chris@1464 1030 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
Chris@1464 1031 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 1032 :status_id => 1, :fixed_version_id => 2,
Chris@1464 1033 :subject => 'New issue')
Chris@1464 1034 assert !issue.save
Chris@1464 1035 assert_not_equal [], issue.errors[:fixed_version_id]
Chris@1464 1036 end
Chris@1464 1037
Chris@1464 1038 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
Chris@1464 1039 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
Chris@1464 1040 :status_id => 1, :fixed_version_id => 3,
Chris@1464 1041 :subject => 'New issue')
Chris@1464 1042 assert issue.save
Chris@1464 1043 end
Chris@1464 1044
Chris@1464 1045 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
Chris@1464 1046 issue = Issue.find(11)
Chris@1464 1047 assert_equal 'closed', issue.fixed_version.status
Chris@1464 1048 issue.subject = 'Subject changed'
Chris@1464 1049 assert issue.save
Chris@1464 1050 end
Chris@1464 1051
Chris@1464 1052 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
Chris@1464 1053 issue = Issue.find(11)
Chris@1464 1054 issue.status_id = 1
Chris@1464 1055 assert !issue.save
Chris@1464 1056 assert_not_equal [], issue.errors[:base]
Chris@1464 1057 end
Chris@1464 1058
Chris@1464 1059 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
Chris@1464 1060 issue = Issue.find(11)
Chris@1464 1061 issue.status_id = 1
Chris@1464 1062 issue.fixed_version_id = 3
Chris@1464 1063 assert issue.save
Chris@1464 1064 end
Chris@1464 1065
Chris@1464 1066 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
Chris@1464 1067 issue = Issue.find(12)
Chris@1464 1068 assert_equal 'locked', issue.fixed_version.status
Chris@1464 1069 issue.status_id = 1
Chris@1464 1070 assert issue.save
Chris@1464 1071 end
Chris@1464 1072
Chris@1464 1073 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
Chris@1464 1074 issue = Issue.find(2)
Chris@1464 1075 assert_equal 2, issue.fixed_version_id
Chris@1464 1076 issue.project_id = 3
Chris@1464 1077 assert_nil issue.fixed_version_id
Chris@1464 1078 issue.fixed_version_id = 2
Chris@1464 1079 assert !issue.save
Chris@1464 1080 assert_include 'Target version is not included in the list', issue.errors.full_messages
Chris@1464 1081 end
Chris@1464 1082
Chris@1464 1083 def test_should_keep_shared_version_when_changing_project
Chris@1464 1084 Version.find(2).update_attribute :sharing, 'tree'
Chris@1464 1085
Chris@1464 1086 issue = Issue.find(2)
Chris@1464 1087 assert_equal 2, issue.fixed_version_id
Chris@1464 1088 issue.project_id = 3
Chris@1464 1089 assert_equal 2, issue.fixed_version_id
Chris@1464 1090 assert issue.save
Chris@1464 1091 end
Chris@1464 1092
Chris@1464 1093 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
Chris@1464 1094 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
Chris@1464 1095 end
Chris@1464 1096
Chris@1464 1097 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
Chris@1464 1098 Project.find(2).disable_module! :issue_tracking
Chris@1464 1099 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
Chris@1464 1100 end
Chris@1464 1101
Chris@1464 1102 def test_move_to_another_project_with_same_category
Chris@1464 1103 issue = Issue.find(1)
Chris@1464 1104 issue.project = Project.find(2)
Chris@1464 1105 assert issue.save
Chris@1464 1106 issue.reload
Chris@1464 1107 assert_equal 2, issue.project_id
Chris@1464 1108 # Category changes
Chris@1464 1109 assert_equal 4, issue.category_id
Chris@1464 1110 # Make sure time entries were move to the target project
Chris@1464 1111 assert_equal 2, issue.time_entries.first.project_id
Chris@1464 1112 end
Chris@1464 1113
Chris@1464 1114 def test_move_to_another_project_without_same_category
Chris@1464 1115 issue = Issue.find(2)
Chris@1464 1116 issue.project = Project.find(2)
Chris@1464 1117 assert issue.save
Chris@1464 1118 issue.reload
Chris@1464 1119 assert_equal 2, issue.project_id
Chris@1464 1120 # Category cleared
Chris@1464 1121 assert_nil issue.category_id
Chris@1464 1122 end
Chris@1464 1123
Chris@1464 1124 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
Chris@1464 1125 issue = Issue.find(1)
Chris@1464 1126 issue.update_attribute(:fixed_version_id, 1)
Chris@1464 1127 issue.project = Project.find(2)
Chris@1464 1128 assert issue.save
Chris@1464 1129 issue.reload
Chris@1464 1130 assert_equal 2, issue.project_id
Chris@1464 1131 # Cleared fixed_version
Chris@1464 1132 assert_equal nil, issue.fixed_version
Chris@1464 1133 end
Chris@1464 1134
Chris@1464 1135 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
Chris@1464 1136 issue = Issue.find(1)
Chris@1464 1137 issue.update_attribute(:fixed_version_id, 4)
Chris@1464 1138 issue.project = Project.find(5)
Chris@1464 1139 assert issue.save
Chris@1464 1140 issue.reload
Chris@1464 1141 assert_equal 5, issue.project_id
Chris@1464 1142 # Keep fixed_version
Chris@1464 1143 assert_equal 4, issue.fixed_version_id
Chris@1464 1144 end
Chris@1464 1145
Chris@1464 1146 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
Chris@1464 1147 issue = Issue.find(1)
Chris@1464 1148 issue.update_attribute(:fixed_version_id, 1)
Chris@1464 1149 issue.project = Project.find(5)
Chris@1464 1150 assert issue.save
Chris@1464 1151 issue.reload
Chris@1464 1152 assert_equal 5, issue.project_id
Chris@1464 1153 # Cleared fixed_version
Chris@1464 1154 assert_equal nil, issue.fixed_version
Chris@1464 1155 end
Chris@1464 1156
Chris@1464 1157 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
Chris@1464 1158 issue = Issue.find(1)
Chris@1464 1159 issue.update_attribute(:fixed_version_id, 7)
Chris@1464 1160 issue.project = Project.find(2)
Chris@1464 1161 assert issue.save
Chris@1464 1162 issue.reload
Chris@1464 1163 assert_equal 2, issue.project_id
Chris@1464 1164 # Keep fixed_version
Chris@1464 1165 assert_equal 7, issue.fixed_version_id
Chris@1464 1166 end
Chris@1464 1167
Chris@1464 1168 def test_move_to_another_project_should_keep_parent_if_valid
Chris@1464 1169 issue = Issue.find(1)
Chris@1464 1170 issue.update_attribute(:parent_issue_id, 2)
Chris@1464 1171 issue.project = Project.find(3)
Chris@1464 1172 assert issue.save
Chris@1464 1173 issue.reload
Chris@1464 1174 assert_equal 2, issue.parent_id
Chris@1464 1175 end
Chris@1464 1176
Chris@1464 1177 def test_move_to_another_project_should_clear_parent_if_not_valid
Chris@1464 1178 issue = Issue.find(1)
Chris@1464 1179 issue.update_attribute(:parent_issue_id, 2)
Chris@1464 1180 issue.project = Project.find(2)
Chris@1464 1181 assert issue.save
Chris@1464 1182 issue.reload
Chris@1464 1183 assert_nil issue.parent_id
Chris@1464 1184 end
Chris@1464 1185
Chris@1464 1186 def test_move_to_another_project_with_disabled_tracker
Chris@1464 1187 issue = Issue.find(1)
Chris@1464 1188 target = Project.find(2)
Chris@1464 1189 target.tracker_ids = [3]
Chris@1464 1190 target.save
Chris@1464 1191 issue.project = target
Chris@1464 1192 assert issue.save
Chris@1464 1193 issue.reload
Chris@1464 1194 assert_equal 2, issue.project_id
Chris@1464 1195 assert_equal 3, issue.tracker_id
Chris@1464 1196 end
Chris@1464 1197
Chris@1464 1198 def test_copy_to_the_same_project
Chris@1464 1199 issue = Issue.find(1)
Chris@1464 1200 copy = issue.copy
Chris@1464 1201 assert_difference 'Issue.count' do
Chris@1464 1202 copy.save!
Chris@1464 1203 end
Chris@1464 1204 assert_kind_of Issue, copy
Chris@1464 1205 assert_equal issue.project, copy.project
Chris@1464 1206 assert_equal "125", copy.custom_value_for(2).value
Chris@1464 1207 end
Chris@1464 1208
Chris@1464 1209 def test_copy_to_another_project_and_tracker
Chris@1464 1210 issue = Issue.find(1)
Chris@1464 1211 copy = issue.copy(:project_id => 3, :tracker_id => 2)
Chris@1464 1212 assert_difference 'Issue.count' do
Chris@1464 1213 copy.save!
Chris@1464 1214 end
Chris@1464 1215 copy.reload
Chris@1464 1216 assert_kind_of Issue, copy
Chris@1464 1217 assert_equal Project.find(3), copy.project
Chris@1464 1218 assert_equal Tracker.find(2), copy.tracker
Chris@1464 1219 # Custom field #2 is not associated with target tracker
Chris@1464 1220 assert_nil copy.custom_value_for(2)
Chris@1464 1221 end
Chris@1464 1222
Chris@1464 1223 test "#copy should not create a journal" do
Chris@1464 1224 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
Chris@1464 1225 copy.save!
Chris@1464 1226 assert_equal 0, copy.reload.journals.size
Chris@1464 1227 end
Chris@1464 1228
Chris@1464 1229 test "#copy should allow assigned_to changes" do
Chris@1464 1230 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
Chris@1464 1231 assert_equal 3, copy.assigned_to_id
Chris@1464 1232 end
Chris@1464 1233
Chris@1464 1234 test "#copy should allow status changes" do
Chris@1464 1235 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
Chris@1464 1236 assert_equal 2, copy.status_id
Chris@1464 1237 end
Chris@1464 1238
Chris@1464 1239 test "#copy should allow start date changes" do
Chris@1464 1240 date = Date.today
Chris@1464 1241 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
Chris@1464 1242 assert_equal date, copy.start_date
Chris@1464 1243 end
Chris@1464 1244
Chris@1464 1245 test "#copy should allow due date changes" do
Chris@1464 1246 date = Date.today
Chris@1464 1247 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
Chris@1464 1248 assert_equal date, copy.due_date
Chris@1464 1249 end
Chris@1464 1250
Chris@1464 1251 test "#copy should set current user as author" do
Chris@1464 1252 User.current = User.find(9)
Chris@1464 1253 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
Chris@1464 1254 assert_equal User.current, copy.author
Chris@1464 1255 end
Chris@1464 1256
Chris@1464 1257 test "#copy should create a journal with notes" do
Chris@1464 1258 date = Date.today
Chris@1464 1259 notes = "Notes added when copying"
Chris@1464 1260 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
Chris@1464 1261 copy.init_journal(User.current, notes)
Chris@1464 1262 copy.save!
Chris@1464 1263
Chris@1464 1264 assert_equal 1, copy.journals.size
Chris@1464 1265 journal = copy.journals.first
Chris@1464 1266 assert_equal 0, journal.details.size
Chris@1464 1267 assert_equal notes, journal.notes
Chris@1464 1268 end
Chris@1464 1269
Chris@1464 1270 def test_valid_parent_project
Chris@1464 1271 issue = Issue.find(1)
Chris@1464 1272 issue_in_same_project = Issue.find(2)
Chris@1464 1273 issue_in_child_project = Issue.find(5)
Chris@1464 1274 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
Chris@1464 1275 issue_in_other_child_project = Issue.find(6)
Chris@1464 1276 issue_in_different_tree = Issue.find(4)
Chris@1464 1277
Chris@1464 1278 with_settings :cross_project_subtasks => '' do
Chris@1464 1279 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1464 1280 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
Chris@1464 1281 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1464 1282 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1464 1283 end
Chris@1464 1284
Chris@1464 1285 with_settings :cross_project_subtasks => 'system' do
Chris@1464 1286 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1464 1287 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
Chris@1464 1288 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
Chris@1464 1289 end
Chris@1464 1290
Chris@1464 1291 with_settings :cross_project_subtasks => 'tree' do
Chris@1464 1292 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1464 1293 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
Chris@1464 1294 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1464 1295 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1464 1296
Chris@1464 1297 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
Chris@1464 1298 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
Chris@1464 1299 end
Chris@1464 1300
Chris@1464 1301 with_settings :cross_project_subtasks => 'descendants' do
Chris@1464 1302 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
Chris@1464 1303 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
Chris@1464 1304 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
Chris@1464 1305 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
Chris@1464 1306
Chris@1464 1307 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
Chris@1464 1308 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
Chris@1464 1309 end
Chris@1464 1310 end
Chris@1464 1311
Chris@1464 1312 def test_recipients_should_include_previous_assignee
Chris@1464 1313 user = User.find(3)
Chris@1464 1314 user.members.update_all ["mail_notification = ?", false]
Chris@1464 1315 user.update_attribute :mail_notification, 'only_assigned'
Chris@1464 1316
Chris@1464 1317 issue = Issue.find(2)
Chris@1464 1318 issue.assigned_to = nil
Chris@1464 1319 assert_include user.mail, issue.recipients
Chris@1464 1320 issue.save!
Chris@1464 1321 assert !issue.recipients.include?(user.mail)
Chris@1464 1322 end
Chris@1464 1323
Chris@1464 1324 def test_recipients_should_not_include_users_that_cannot_view_the_issue
Chris@1464 1325 issue = Issue.find(12)
Chris@1464 1326 assert issue.recipients.include?(issue.author.mail)
Chris@1464 1327 # copy the issue to a private project
Chris@1464 1328 copy = issue.copy(:project_id => 5, :tracker_id => 2)
Chris@1464 1329 # author is not a member of project anymore
Chris@1464 1330 assert !copy.recipients.include?(copy.author.mail)
Chris@1464 1331 end
Chris@1464 1332
Chris@1464 1333 def test_recipients_should_include_the_assigned_group_members
Chris@1464 1334 group_member = User.generate!
Chris@1464 1335 group = Group.generate!
Chris@1464 1336 group.users << group_member
Chris@1464 1337
Chris@1464 1338 issue = Issue.find(12)
Chris@1464 1339 issue.assigned_to = group
Chris@1464 1340 assert issue.recipients.include?(group_member.mail)
Chris@1464 1341 end
Chris@1464 1342
Chris@1464 1343 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
Chris@1464 1344 user = User.find(3)
Chris@1464 1345 issue = Issue.find(9)
Chris@1464 1346 Watcher.create!(:user => user, :watchable => issue)
Chris@1464 1347 assert issue.watched_by?(user)
Chris@1464 1348 assert !issue.watcher_recipients.include?(user.mail)
Chris@1464 1349 end
Chris@1464 1350
Chris@1464 1351 def test_issue_destroy
Chris@1464 1352 Issue.find(1).destroy
Chris@1464 1353 assert_nil Issue.find_by_id(1)
Chris@1464 1354 assert_nil TimeEntry.find_by_issue_id(1)
Chris@1464 1355 end
Chris@1464 1356
Chris@1464 1357 def test_destroying_a_deleted_issue_should_not_raise_an_error
Chris@1464 1358 issue = Issue.find(1)
Chris@1464 1359 Issue.find(1).destroy
Chris@1464 1360
Chris@1464 1361 assert_nothing_raised do
Chris@1464 1362 assert_no_difference 'Issue.count' do
Chris@1464 1363 issue.destroy
Chris@1464 1364 end
Chris@1464 1365 assert issue.destroyed?
Chris@1464 1366 end
Chris@1464 1367 end
Chris@1464 1368
Chris@1464 1369 def test_destroying_a_stale_issue_should_not_raise_an_error
Chris@1464 1370 issue = Issue.find(1)
Chris@1464 1371 Issue.find(1).update_attribute :subject, "Updated"
Chris@1464 1372
Chris@1464 1373 assert_nothing_raised do
Chris@1464 1374 assert_difference 'Issue.count', -1 do
Chris@1464 1375 issue.destroy
Chris@1464 1376 end
Chris@1464 1377 assert issue.destroyed?
Chris@1464 1378 end
Chris@1464 1379 end
Chris@1464 1380
Chris@1464 1381 def test_blocked
Chris@1464 1382 blocked_issue = Issue.find(9)
Chris@1464 1383 blocking_issue = Issue.find(10)
Chris@1464 1384
Chris@1464 1385 assert blocked_issue.blocked?
Chris@1464 1386 assert !blocking_issue.blocked?
Chris@1464 1387 end
Chris@1464 1388
Chris@1464 1389 def test_blocked_issues_dont_allow_closed_statuses
Chris@1464 1390 blocked_issue = Issue.find(9)
Chris@1464 1391
Chris@1464 1392 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
Chris@1464 1393 assert !allowed_statuses.empty?
Chris@1464 1394 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
Chris@1464 1395 assert closed_statuses.empty?
Chris@1464 1396 end
Chris@1464 1397
Chris@1464 1398 def test_unblocked_issues_allow_closed_statuses
Chris@1464 1399 blocking_issue = Issue.find(10)
Chris@1464 1400
Chris@1464 1401 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
Chris@1464 1402 assert !allowed_statuses.empty?
Chris@1464 1403 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
Chris@1464 1404 assert !closed_statuses.empty?
Chris@1464 1405 end
Chris@1464 1406
Chris@1464 1407 def test_reschedule_an_issue_without_dates
Chris@1464 1408 with_settings :non_working_week_days => [] do
Chris@1464 1409 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1464 1410 issue.reschedule_on '2012-10-09'.to_date
Chris@1464 1411 assert_equal '2012-10-09'.to_date, issue.start_date
Chris@1464 1412 assert_equal '2012-10-09'.to_date, issue.due_date
Chris@1464 1413 end
Chris@1464 1414
Chris@1464 1415 with_settings :non_working_week_days => %w(6 7) do
Chris@1464 1416 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1464 1417 issue.reschedule_on '2012-10-09'.to_date
Chris@1464 1418 assert_equal '2012-10-09'.to_date, issue.start_date
Chris@1464 1419 assert_equal '2012-10-09'.to_date, issue.due_date
Chris@1464 1420
Chris@1464 1421 issue = Issue.new(:start_date => nil, :due_date => nil)
Chris@1464 1422 issue.reschedule_on '2012-10-13'.to_date
Chris@1464 1423 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1464 1424 assert_equal '2012-10-15'.to_date, issue.due_date
Chris@1464 1425 end
Chris@1464 1426 end
Chris@1464 1427
Chris@1464 1428 def test_reschedule_an_issue_with_start_date
Chris@1464 1429 with_settings :non_working_week_days => [] do
Chris@1464 1430 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1464 1431 issue.reschedule_on '2012-10-13'.to_date
Chris@1464 1432 assert_equal '2012-10-13'.to_date, issue.start_date
Chris@1464 1433 assert_equal '2012-10-13'.to_date, issue.due_date
Chris@1464 1434 end
Chris@1464 1435
Chris@1464 1436 with_settings :non_working_week_days => %w(6 7) do
Chris@1464 1437 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1464 1438 issue.reschedule_on '2012-10-11'.to_date
Chris@1464 1439 assert_equal '2012-10-11'.to_date, issue.start_date
Chris@1464 1440 assert_equal '2012-10-11'.to_date, issue.due_date
Chris@1464 1441
Chris@1464 1442 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
Chris@1464 1443 issue.reschedule_on '2012-10-13'.to_date
Chris@1464 1444 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1464 1445 assert_equal '2012-10-15'.to_date, issue.due_date
Chris@1464 1446 end
Chris@1464 1447 end
Chris@1464 1448
Chris@1464 1449 def test_reschedule_an_issue_with_start_and_due_dates
Chris@1464 1450 with_settings :non_working_week_days => [] do
Chris@1464 1451 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
Chris@1464 1452 issue.reschedule_on '2012-10-13'.to_date
Chris@1464 1453 assert_equal '2012-10-13'.to_date, issue.start_date
Chris@1464 1454 assert_equal '2012-10-19'.to_date, issue.due_date
Chris@1464 1455 end
Chris@1464 1456
Chris@1464 1457 with_settings :non_working_week_days => %w(6 7) do
Chris@1464 1458 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
Chris@1464 1459 issue.reschedule_on '2012-10-11'.to_date
Chris@1464 1460 assert_equal '2012-10-11'.to_date, issue.start_date
Chris@1464 1461 assert_equal '2012-10-23'.to_date, issue.due_date
Chris@1464 1462
Chris@1464 1463 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
Chris@1464 1464 issue.reschedule_on '2012-10-13'.to_date
Chris@1464 1465 assert_equal '2012-10-15'.to_date, issue.start_date
Chris@1464 1466 assert_equal '2012-10-25'.to_date, issue.due_date
Chris@1464 1467 end
Chris@1464 1468 end
Chris@1464 1469
Chris@1464 1470 def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
Chris@1464 1471 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1472 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1473 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1464 1474 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1475 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1464 1476
Chris@1464 1477 issue1.due_date = '2012-10-23'
Chris@1464 1478 issue1.save!
Chris@1464 1479 issue2.reload
Chris@1464 1480 assert_equal Date.parse('2012-10-24'), issue2.start_date
Chris@1464 1481 assert_equal Date.parse('2012-10-26'), issue2.due_date
Chris@1464 1482 end
Chris@1464 1483
Chris@1464 1484 def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
Chris@1464 1485 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1486 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1487 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1464 1488 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1489 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1464 1490
Chris@1464 1491 issue1.start_date = '2012-09-17'
Chris@1464 1492 issue1.due_date = '2012-09-18'
Chris@1464 1493 issue1.save!
Chris@1464 1494 issue2.reload
Chris@1464 1495 assert_equal Date.parse('2012-09-19'), issue2.start_date
Chris@1464 1496 assert_equal Date.parse('2012-09-21'), issue2.due_date
Chris@1464 1497 end
Chris@1464 1498
Chris@1464 1499 def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
Chris@1464 1500 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1501 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1502 issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
Chris@1464 1503 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1464 1504 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1505 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
Chris@1464 1506 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1507 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
Chris@1464 1508
Chris@1464 1509 issue1.start_date = '2012-09-17'
Chris@1464 1510 issue1.due_date = '2012-09-18'
Chris@1464 1511 issue1.save!
Chris@1464 1512 issue2.reload
Chris@1464 1513 # Issue 2 must start after Issue 3
Chris@1464 1514 assert_equal Date.parse('2012-10-03'), issue2.start_date
Chris@1464 1515 assert_equal Date.parse('2012-10-05'), issue2.due_date
Chris@1464 1516 end
Chris@1464 1517
Chris@1464 1518 def test_rescheduling_a_stale_issue_should_not_raise_an_error
Chris@1464 1519 with_settings :non_working_week_days => [] do
Chris@1464 1520 stale = Issue.find(1)
Chris@1464 1521 issue = Issue.find(1)
Chris@1464 1522 issue.subject = "Updated"
Chris@1464 1523 issue.save!
Chris@1464 1524 date = 10.days.from_now.to_date
Chris@1464 1525 assert_nothing_raised do
Chris@1464 1526 stale.reschedule_on!(date)
Chris@1464 1527 end
Chris@1464 1528 assert_equal date, stale.reload.start_date
Chris@1464 1529 end
Chris@1464 1530 end
Chris@1464 1531
Chris@1464 1532 def test_child_issue_should_consider_parent_soonest_start_on_create
Chris@1464 1533 set_language_if_valid 'en'
Chris@1464 1534 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
Chris@1464 1535 issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
Chris@1464 1536 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
Chris@1464 1537 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1538 issue1.reload
Chris@1464 1539 issue2.reload
Chris@1464 1540 assert_equal Date.parse('2012-10-18'), issue2.start_date
Chris@1464 1541
Chris@1464 1542 child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
Chris@1464 1543 :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
Chris@1464 1544 assert !child.valid?
Chris@1464 1545 assert_include 'Start date is invalid', child.errors.full_messages
Chris@1464 1546 assert_equal Date.parse('2012-10-18'), child.soonest_start
Chris@1464 1547 child.start_date = '2012-10-18'
Chris@1464 1548 assert child.save
Chris@1464 1549 end
Chris@1464 1550
Chris@1464 1551 def test_setting_parent_to_a_dependent_issue_should_not_validate
Chris@1464 1552 set_language_if_valid 'en'
Chris@1464 1553 issue1 = Issue.generate!
Chris@1464 1554 issue2 = Issue.generate!
Chris@1464 1555 issue3 = Issue.generate!
Chris@1464 1556 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1557 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1558 issue3.reload
Chris@1464 1559 issue3.parent_issue_id = issue2.id
Chris@1464 1560 assert !issue3.valid?
Chris@1464 1561 assert_include 'Parent task is invalid', issue3.errors.full_messages
Chris@1464 1562 end
Chris@1464 1563
Chris@1464 1564 def test_setting_parent_should_not_allow_circular_dependency
Chris@1464 1565 set_language_if_valid 'en'
Chris@1464 1566 issue1 = Issue.generate!
Chris@1464 1567 issue2 = Issue.generate!
Chris@1464 1568 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1569 issue3 = Issue.generate!
Chris@1464 1570 issue2.reload
Chris@1464 1571 issue2.parent_issue_id = issue3.id
Chris@1464 1572 issue2.save!
Chris@1464 1573 issue4 = Issue.generate!
Chris@1464 1574 IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1575 issue4.reload
Chris@1464 1576 issue4.parent_issue_id = issue1.id
Chris@1464 1577 assert !issue4.valid?
Chris@1464 1578 assert_include 'Parent task is invalid', issue4.errors.full_messages
Chris@1464 1579 end
Chris@1464 1580
Chris@1464 1581 def test_overdue
Chris@1464 1582 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
Chris@1464 1583 assert !Issue.new(:due_date => Date.today).overdue?
Chris@1464 1584 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
Chris@1464 1585 assert !Issue.new(:due_date => nil).overdue?
Chris@1464 1586 assert !Issue.new(:due_date => 1.day.ago.to_date,
Chris@1464 1587 :status => IssueStatus.where(:is_closed => true).first
Chris@1464 1588 ).overdue?
Chris@1464 1589 end
Chris@1464 1590
Chris@1464 1591 test "#behind_schedule? should be false if the issue has no start_date" do
Chris@1464 1592 assert !Issue.new(:start_date => nil,
Chris@1464 1593 :due_date => 1.day.from_now.to_date,
Chris@1464 1594 :done_ratio => 0).behind_schedule?
Chris@1464 1595 end
Chris@1464 1596
Chris@1464 1597 test "#behind_schedule? should be false if the issue has no end_date" do
Chris@1464 1598 assert !Issue.new(:start_date => 1.day.from_now.to_date,
Chris@1464 1599 :due_date => nil,
Chris@1464 1600 :done_ratio => 0).behind_schedule?
Chris@1464 1601 end
Chris@1464 1602
Chris@1464 1603 test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
Chris@1464 1604 assert !Issue.new(:start_date => 50.days.ago.to_date,
Chris@1464 1605 :due_date => 50.days.from_now.to_date,
Chris@1464 1606 :done_ratio => 90).behind_schedule?
Chris@1464 1607 end
Chris@1464 1608
Chris@1464 1609 test "#behind_schedule? should be true if the issue hasn't been started at all" do
Chris@1464 1610 assert Issue.new(:start_date => 1.day.ago.to_date,
Chris@1464 1611 :due_date => 1.day.from_now.to_date,
Chris@1464 1612 :done_ratio => 0).behind_schedule?
Chris@1464 1613 end
Chris@1464 1614
Chris@1464 1615 test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
Chris@1464 1616 assert Issue.new(:start_date => 100.days.ago.to_date,
Chris@1464 1617 :due_date => Date.today,
Chris@1464 1618 :done_ratio => 90).behind_schedule?
Chris@1464 1619 end
Chris@1464 1620
Chris@1464 1621 test "#assignable_users should be Users" do
Chris@1464 1622 assert_kind_of User, Issue.find(1).assignable_users.first
Chris@1464 1623 end
Chris@1464 1624
Chris@1464 1625 test "#assignable_users should include the issue author" do
Chris@1464 1626 non_project_member = User.generate!
Chris@1464 1627 issue = Issue.generate!(:author => non_project_member)
Chris@1464 1628
Chris@1464 1629 assert issue.assignable_users.include?(non_project_member)
Chris@1464 1630 end
Chris@1464 1631
Chris@1464 1632 test "#assignable_users should include the current assignee" do
Chris@1464 1633 user = User.generate!
Chris@1464 1634 issue = Issue.generate!(:assigned_to => user)
Chris@1464 1635 user.lock!
Chris@1464 1636
Chris@1464 1637 assert Issue.find(issue.id).assignable_users.include?(user)
Chris@1464 1638 end
Chris@1464 1639
Chris@1464 1640 test "#assignable_users should not show the issue author twice" do
Chris@1464 1641 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
Chris@1464 1642 assert_equal 2, assignable_user_ids.length
Chris@1464 1643
Chris@1464 1644 assignable_user_ids.each do |user_id|
Chris@1464 1645 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
Chris@1464 1646 "User #{user_id} appears more or less than once"
Chris@1464 1647 end
Chris@1464 1648 end
Chris@1464 1649
Chris@1464 1650 test "#assignable_users with issue_group_assignment should include groups" do
Chris@1464 1651 issue = Issue.new(:project => Project.find(2))
Chris@1464 1652
Chris@1464 1653 with_settings :issue_group_assignment => '1' do
Chris@1464 1654 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
Chris@1464 1655 assert issue.assignable_users.include?(Group.find(11))
Chris@1464 1656 end
Chris@1464 1657 end
Chris@1464 1658
Chris@1464 1659 test "#assignable_users without issue_group_assignment should not include groups" do
Chris@1464 1660 issue = Issue.new(:project => Project.find(2))
Chris@1464 1661
Chris@1464 1662 with_settings :issue_group_assignment => '0' do
Chris@1464 1663 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
Chris@1464 1664 assert !issue.assignable_users.include?(Group.find(11))
Chris@1464 1665 end
Chris@1464 1666 end
Chris@1464 1667
Chris@1464 1668 def test_create_should_send_email_notification
Chris@1464 1669 ActionMailer::Base.deliveries.clear
Chris@1464 1670 issue = Issue.new(:project_id => 1, :tracker_id => 1,
Chris@1464 1671 :author_id => 3, :status_id => 1,
Chris@1464 1672 :priority => IssuePriority.all.first,
Chris@1464 1673 :subject => 'test_create', :estimated_hours => '1:30')
Chris@1464 1674
Chris@1464 1675 assert issue.save
Chris@1464 1676 assert_equal 1, ActionMailer::Base.deliveries.size
Chris@1464 1677 end
Chris@1464 1678
Chris@1464 1679 def test_stale_issue_should_not_send_email_notification
Chris@1464 1680 ActionMailer::Base.deliveries.clear
Chris@1464 1681 issue = Issue.find(1)
Chris@1464 1682 stale = Issue.find(1)
Chris@1464 1683
Chris@1464 1684 issue.init_journal(User.find(1))
Chris@1464 1685 issue.subject = 'Subjet update'
Chris@1464 1686 assert issue.save
Chris@1464 1687 assert_equal 1, ActionMailer::Base.deliveries.size
Chris@1464 1688 ActionMailer::Base.deliveries.clear
Chris@1464 1689
Chris@1464 1690 stale.init_journal(User.find(1))
Chris@1464 1691 stale.subject = 'Another subjet update'
Chris@1464 1692 assert_raise ActiveRecord::StaleObjectError do
Chris@1464 1693 stale.save
Chris@1464 1694 end
Chris@1464 1695 assert ActionMailer::Base.deliveries.empty?
Chris@1464 1696 end
Chris@1464 1697
Chris@1464 1698 def test_journalized_description
Chris@1464 1699 IssueCustomField.delete_all
Chris@1464 1700
Chris@1464 1701 i = Issue.first
Chris@1464 1702 old_description = i.description
Chris@1464 1703 new_description = "This is the new description"
Chris@1464 1704
Chris@1464 1705 i.init_journal(User.find(2))
Chris@1464 1706 i.description = new_description
Chris@1464 1707 assert_difference 'Journal.count', 1 do
Chris@1464 1708 assert_difference 'JournalDetail.count', 1 do
Chris@1464 1709 i.save!
Chris@1464 1710 end
Chris@1464 1711 end
Chris@1464 1712
Chris@1464 1713 detail = JournalDetail.first(:order => 'id DESC')
Chris@1464 1714 assert_equal i, detail.journal.journalized
Chris@1464 1715 assert_equal 'attr', detail.property
Chris@1464 1716 assert_equal 'description', detail.prop_key
Chris@1464 1717 assert_equal old_description, detail.old_value
Chris@1464 1718 assert_equal new_description, detail.value
Chris@1464 1719 end
Chris@1464 1720
Chris@1464 1721 def test_blank_descriptions_should_not_be_journalized
Chris@1464 1722 IssueCustomField.delete_all
Chris@1464 1723 Issue.update_all("description = NULL", "id=1")
Chris@1464 1724
Chris@1464 1725 i = Issue.find(1)
Chris@1464 1726 i.init_journal(User.find(2))
Chris@1464 1727 i.subject = "blank description"
Chris@1464 1728 i.description = "\r\n"
Chris@1464 1729
Chris@1464 1730 assert_difference 'Journal.count', 1 do
Chris@1464 1731 assert_difference 'JournalDetail.count', 1 do
Chris@1464 1732 i.save!
Chris@1464 1733 end
Chris@1464 1734 end
Chris@1464 1735 end
Chris@1464 1736
Chris@1464 1737 def test_journalized_multi_custom_field
Chris@1464 1738 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
Chris@1464 1739 :is_filter => true, :is_for_all => true,
Chris@1464 1740 :tracker_ids => [1],
Chris@1464 1741 :possible_values => ['value1', 'value2', 'value3'],
Chris@1464 1742 :multiple => true)
Chris@1464 1743
Chris@1464 1744 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
Chris@1464 1745 :subject => 'Test', :author_id => 1)
Chris@1464 1746
Chris@1464 1747 assert_difference 'Journal.count' do
Chris@1464 1748 assert_difference 'JournalDetail.count' do
Chris@1464 1749 issue.init_journal(User.first)
Chris@1464 1750 issue.custom_field_values = {field.id => ['value1']}
Chris@1464 1751 issue.save!
Chris@1464 1752 end
Chris@1464 1753 assert_difference 'JournalDetail.count' do
Chris@1464 1754 issue.init_journal(User.first)
Chris@1464 1755 issue.custom_field_values = {field.id => ['value1', 'value2']}
Chris@1464 1756 issue.save!
Chris@1464 1757 end
Chris@1464 1758 assert_difference 'JournalDetail.count', 2 do
Chris@1464 1759 issue.init_journal(User.first)
Chris@1464 1760 issue.custom_field_values = {field.id => ['value3', 'value2']}
Chris@1464 1761 issue.save!
Chris@1464 1762 end
Chris@1464 1763 assert_difference 'JournalDetail.count', 2 do
Chris@1464 1764 issue.init_journal(User.first)
Chris@1464 1765 issue.custom_field_values = {field.id => nil}
Chris@1464 1766 issue.save!
Chris@1464 1767 end
Chris@1464 1768 end
Chris@1464 1769 end
Chris@1464 1770
Chris@1464 1771 def test_description_eol_should_be_normalized
Chris@1464 1772 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
Chris@1464 1773 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
Chris@1464 1774 end
Chris@1464 1775
Chris@1464 1776 def test_saving_twice_should_not_duplicate_journal_details
Chris@1464 1777 i = Issue.first
Chris@1464 1778 i.init_journal(User.find(2), 'Some notes')
Chris@1464 1779 # initial changes
Chris@1464 1780 i.subject = 'New subject'
Chris@1464 1781 i.done_ratio = i.done_ratio + 10
Chris@1464 1782 assert_difference 'Journal.count' do
Chris@1464 1783 assert i.save
Chris@1464 1784 end
Chris@1464 1785 # 1 more change
Chris@1464 1786 i.priority = IssuePriority.where("id <> ?", i.priority_id).first
Chris@1464 1787 assert_no_difference 'Journal.count' do
Chris@1464 1788 assert_difference 'JournalDetail.count', 1 do
Chris@1464 1789 i.save
Chris@1464 1790 end
Chris@1464 1791 end
Chris@1464 1792 # no more change
Chris@1464 1793 assert_no_difference 'Journal.count' do
Chris@1464 1794 assert_no_difference 'JournalDetail.count' do
Chris@1464 1795 i.save
Chris@1464 1796 end
Chris@1464 1797 end
Chris@1464 1798 end
Chris@1464 1799
Chris@1464 1800 def test_all_dependent_issues
Chris@1464 1801 IssueRelation.delete_all
Chris@1464 1802 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1464 1803 :issue_to => Issue.find(2),
Chris@1464 1804 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1805 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1464 1806 :issue_to => Issue.find(3),
Chris@1464 1807 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1808 assert IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1464 1809 :issue_to => Issue.find(8),
Chris@1464 1810 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1811
Chris@1464 1812 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1464 1813 end
Chris@1464 1814
Chris@1464 1815 def test_all_dependent_issues_with_subtask
Chris@1464 1816 IssueRelation.delete_all
Chris@1464 1817
Chris@1464 1818 project = Project.generate!(:name => "testproject")
Chris@1464 1819
Chris@1464 1820 parentIssue = Issue.generate!(:project => project)
Chris@1464 1821 childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1464 1822 childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1464 1823
Chris@1464 1824 assert_equal [childIssue1.id, childIssue2.id].sort, parentIssue.all_dependent_issues.collect(&:id).uniq.sort
Chris@1464 1825 end
Chris@1464 1826
Chris@1464 1827 def test_all_dependent_issues_does_not_include_self
Chris@1464 1828 IssueRelation.delete_all
Chris@1464 1829
Chris@1464 1830 project = Project.generate!(:name => "testproject")
Chris@1464 1831
Chris@1464 1832 parentIssue = Issue.generate!(:project => project)
Chris@1464 1833 childIssue = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1464 1834
Chris@1464 1835 assert_equal [childIssue.id], parentIssue.all_dependent_issues.collect(&:id)
Chris@1464 1836 end
Chris@1464 1837
Chris@1464 1838 def test_all_dependent_issues_with_parenttask_and_sibling
Chris@1464 1839 IssueRelation.delete_all
Chris@1464 1840
Chris@1464 1841 project = Project.generate!(:name => "testproject")
Chris@1464 1842
Chris@1464 1843 parentIssue = Issue.generate!(:project => project)
Chris@1464 1844 childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1464 1845 childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
Chris@1464 1846
Chris@1464 1847 assert_equal [parentIssue.id].sort, childIssue1.all_dependent_issues.collect(&:id)
Chris@1464 1848 end
Chris@1464 1849
Chris@1464 1850 def test_all_dependent_issues_with_relation_to_leaf_in_other_tree
Chris@1464 1851 IssueRelation.delete_all
Chris@1464 1852
Chris@1464 1853 project = Project.generate!(:name => "testproject")
Chris@1464 1854
Chris@1464 1855 parentIssue1 = Issue.generate!(:project => project)
Chris@1464 1856 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1464 1857 childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1464 1858
Chris@1464 1859 parentIssue2 = Issue.generate!(:project => project)
Chris@1464 1860 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1464 1861 childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1464 1862
Chris@1464 1863
Chris@1464 1864 assert IssueRelation.create(:issue_from => parentIssue1,
Chris@1464 1865 :issue_to => childIssue2_2,
Chris@1464 1866 :relation_type => IssueRelation::TYPE_BLOCKS)
Chris@1464 1867
Chris@1464 1868 assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_2.id].sort,
Chris@1464 1869 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
Chris@1464 1870 end
Chris@1464 1871
Chris@1464 1872 def test_all_dependent_issues_with_relation_to_parent_in_other_tree
Chris@1464 1873 IssueRelation.delete_all
Chris@1464 1874
Chris@1464 1875 project = Project.generate!(:name => "testproject")
Chris@1464 1876
Chris@1464 1877 parentIssue1 = Issue.generate!(:project => project)
Chris@1464 1878 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1464 1879 childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1464 1880
Chris@1464 1881 parentIssue2 = Issue.generate!(:project => project)
Chris@1464 1882 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1464 1883 childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1464 1884
Chris@1464 1885
Chris@1464 1886 assert IssueRelation.create(:issue_from => parentIssue1,
Chris@1464 1887 :issue_to => parentIssue2,
Chris@1464 1888 :relation_type => IssueRelation::TYPE_BLOCKS)
Chris@1464 1889
Chris@1464 1890 assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_1.id, childIssue2_2.id].sort,
Chris@1464 1891 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
Chris@1464 1892 end
Chris@1464 1893
Chris@1464 1894 def test_all_dependent_issues_with_transitive_relation
Chris@1464 1895 IssueRelation.delete_all
Chris@1464 1896
Chris@1464 1897 project = Project.generate!(:name => "testproject")
Chris@1464 1898
Chris@1464 1899 parentIssue1 = Issue.generate!(:project => project)
Chris@1464 1900 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1464 1901
Chris@1464 1902 parentIssue2 = Issue.generate!(:project => project)
Chris@1464 1903 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1464 1904
Chris@1464 1905 independentIssue = Issue.generate!(:project => project)
Chris@1464 1906
Chris@1464 1907 assert IssueRelation.create(:issue_from => parentIssue1,
Chris@1464 1908 :issue_to => childIssue2_1,
Chris@1464 1909 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 1910
Chris@1464 1911 assert IssueRelation.create(:issue_from => childIssue2_1,
Chris@1464 1912 :issue_to => independentIssue,
Chris@1464 1913 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 1914
Chris@1464 1915 assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
Chris@1464 1916 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
Chris@1464 1917 end
Chris@1464 1918
Chris@1464 1919 def test_all_dependent_issues_with_transitive_relation2
Chris@1464 1920 IssueRelation.delete_all
Chris@1464 1921
Chris@1464 1922 project = Project.generate!(:name => "testproject")
Chris@1464 1923
Chris@1464 1924 parentIssue1 = Issue.generate!(:project => project)
Chris@1464 1925 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
Chris@1464 1926
Chris@1464 1927 parentIssue2 = Issue.generate!(:project => project)
Chris@1464 1928 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
Chris@1464 1929
Chris@1464 1930 independentIssue = Issue.generate!(:project => project)
Chris@1464 1931
Chris@1464 1932 assert IssueRelation.create(:issue_from => parentIssue1,
Chris@1464 1933 :issue_to => independentIssue,
Chris@1464 1934 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 1935
Chris@1464 1936 assert IssueRelation.create(:issue_from => independentIssue,
Chris@1464 1937 :issue_to => childIssue2_1,
Chris@1464 1938 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 1939
Chris@1464 1940 assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
Chris@1464 1941 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
Chris@1464 1942
Chris@1464 1943 end
Chris@1464 1944
Chris@1464 1945 def test_all_dependent_issues_with_persistent_circular_dependency
Chris@1464 1946 IssueRelation.delete_all
Chris@1464 1947 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1464 1948 :issue_to => Issue.find(2),
Chris@1464 1949 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1950 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1464 1951 :issue_to => Issue.find(3),
Chris@1464 1952 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1953
Chris@1464 1954 r = IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1464 1955 :issue_to => Issue.find(7),
Chris@1464 1956 :relation_type => IssueRelation::TYPE_PRECEDES)
Chris@1464 1957 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
Chris@1464 1958
Chris@1464 1959 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1464 1960 end
Chris@1464 1961
Chris@1464 1962 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
Chris@1464 1963 IssueRelation.delete_all
Chris@1464 1964 assert IssueRelation.create!(:issue_from => Issue.find(1),
Chris@1464 1965 :issue_to => Issue.find(2),
Chris@1464 1966 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 1967 assert IssueRelation.create!(:issue_from => Issue.find(2),
Chris@1464 1968 :issue_to => Issue.find(3),
Chris@1464 1969 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 1970 assert IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1464 1971 :issue_to => Issue.find(8),
Chris@1464 1972 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 1973
Chris@1464 1974 r = IssueRelation.create!(:issue_from => Issue.find(8),
Chris@1464 1975 :issue_to => Issue.find(7),
Chris@1464 1976 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 1977 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
Chris@1464 1978
Chris@1464 1979 r = IssueRelation.create!(:issue_from => Issue.find(3),
Chris@1464 1980 :issue_to => Issue.find(7),
Chris@1464 1981 :relation_type => IssueRelation::TYPE_RELATES)
Chris@1464 1982 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
Chris@1464 1983
Chris@1464 1984 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
Chris@1464 1985 end
Chris@1464 1986
Chris@1464 1987 test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
Chris@1464 1988 @issue = Issue.find(1)
Chris@1464 1989 @issue_status = IssueStatus.find(1)
Chris@1464 1990 @issue_status.update_attribute(:default_done_ratio, 50)
Chris@1464 1991 @issue2 = Issue.find(2)
Chris@1464 1992 @issue_status2 = IssueStatus.find(2)
Chris@1464 1993 @issue_status2.update_attribute(:default_done_ratio, 0)
Chris@1464 1994
Chris@1464 1995 with_settings :issue_done_ratio => 'issue_field' do
Chris@1464 1996 assert_equal 0, @issue.done_ratio
Chris@1464 1997 assert_equal 30, @issue2.done_ratio
Chris@1464 1998 end
Chris@1464 1999
Chris@1464 2000 with_settings :issue_done_ratio => 'issue_status' do
Chris@1464 2001 assert_equal 50, @issue.done_ratio
Chris@1464 2002 assert_equal 0, @issue2.done_ratio
Chris@1464 2003 end
Chris@1464 2004 end
Chris@1464 2005
Chris@1464 2006 test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
Chris@1464 2007 @issue = Issue.find(1)
Chris@1464 2008 @issue_status = IssueStatus.find(1)
Chris@1464 2009 @issue_status.update_attribute(:default_done_ratio, 50)
Chris@1464 2010 @issue2 = Issue.find(2)
Chris@1464 2011 @issue_status2 = IssueStatus.find(2)
Chris@1464 2012 @issue_status2.update_attribute(:default_done_ratio, 0)
Chris@1464 2013
Chris@1464 2014 with_settings :issue_done_ratio => 'issue_field' do
Chris@1464 2015 @issue.update_done_ratio_from_issue_status
Chris@1464 2016 @issue2.update_done_ratio_from_issue_status
Chris@1464 2017
Chris@1464 2018 assert_equal 0, @issue.read_attribute(:done_ratio)
Chris@1464 2019 assert_equal 30, @issue2.read_attribute(:done_ratio)
Chris@1464 2020 end
Chris@1464 2021
Chris@1464 2022 with_settings :issue_done_ratio => 'issue_status' do
Chris@1464 2023 @issue.update_done_ratio_from_issue_status
Chris@1464 2024 @issue2.update_done_ratio_from_issue_status
Chris@1464 2025
Chris@1464 2026 assert_equal 50, @issue.read_attribute(:done_ratio)
Chris@1464 2027 assert_equal 0, @issue2.read_attribute(:done_ratio)
Chris@1464 2028 end
Chris@1464 2029 end
Chris@1464 2030
Chris@1464 2031 test "#by_tracker" do
Chris@1464 2032 User.current = User.anonymous
Chris@1464 2033 groups = Issue.by_tracker(Project.find(1))
Chris@1464 2034 assert_equal 3, groups.size
Chris@1464 2035 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2036 end
Chris@1464 2037
Chris@1464 2038 test "#by_version" do
Chris@1464 2039 User.current = User.anonymous
Chris@1464 2040 groups = Issue.by_version(Project.find(1))
Chris@1464 2041 assert_equal 3, groups.size
Chris@1464 2042 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2043 end
Chris@1464 2044
Chris@1464 2045 test "#by_priority" do
Chris@1464 2046 User.current = User.anonymous
Chris@1464 2047 groups = Issue.by_priority(Project.find(1))
Chris@1464 2048 assert_equal 4, groups.size
Chris@1464 2049 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2050 end
Chris@1464 2051
Chris@1464 2052 test "#by_category" do
Chris@1464 2053 User.current = User.anonymous
Chris@1464 2054 groups = Issue.by_category(Project.find(1))
Chris@1464 2055 assert_equal 2, groups.size
Chris@1464 2056 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2057 end
Chris@1464 2058
Chris@1464 2059 test "#by_assigned_to" do
Chris@1464 2060 User.current = User.anonymous
Chris@1464 2061 groups = Issue.by_assigned_to(Project.find(1))
Chris@1464 2062 assert_equal 2, groups.size
Chris@1464 2063 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2064 end
Chris@1464 2065
Chris@1464 2066 test "#by_author" do
Chris@1464 2067 User.current = User.anonymous
Chris@1464 2068 groups = Issue.by_author(Project.find(1))
Chris@1464 2069 assert_equal 4, groups.size
Chris@1464 2070 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2071 end
Chris@1464 2072
Chris@1464 2073 test "#by_subproject" do
Chris@1464 2074 User.current = User.anonymous
Chris@1464 2075 groups = Issue.by_subproject(Project.find(1))
Chris@1464 2076 # Private descendant not visible
Chris@1464 2077 assert_equal 1, groups.size
Chris@1464 2078 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
Chris@1464 2079 end
Chris@1464 2080
Chris@1464 2081 def test_recently_updated_scope
Chris@1464 2082 #should return the last updated issue
Chris@1464 2083 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
Chris@1464 2084 end
Chris@1464 2085
Chris@1464 2086 def test_on_active_projects_scope
Chris@1464 2087 assert Project.find(2).archive
Chris@1464 2088
Chris@1464 2089 before = Issue.on_active_project.length
Chris@1464 2090 # test inclusion to results
Chris@1464 2091 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
Chris@1464 2092 assert_equal before + 1, Issue.on_active_project.length
Chris@1464 2093
Chris@1464 2094 # Move to an archived project
Chris@1464 2095 issue.project = Project.find(2)
Chris@1464 2096 assert issue.save
Chris@1464 2097 assert_equal before, Issue.on_active_project.length
Chris@1464 2098 end
Chris@1464 2099
Chris@1464 2100 test "Issue#recipients should include project recipients" do
Chris@1464 2101 issue = Issue.generate!
Chris@1464 2102 assert issue.project.recipients.present?
Chris@1464 2103 issue.project.recipients.each do |project_recipient|
Chris@1464 2104 assert issue.recipients.include?(project_recipient)
Chris@1464 2105 end
Chris@1464 2106 end
Chris@1464 2107
Chris@1464 2108 test "Issue#recipients should include the author if the author is active" do
Chris@1464 2109 issue = Issue.generate!(:author => User.generate!)
Chris@1464 2110 assert issue.author, "No author set for Issue"
Chris@1464 2111 assert issue.recipients.include?(issue.author.mail)
Chris@1464 2112 end
Chris@1464 2113
Chris@1464 2114 test "Issue#recipients should include the assigned to user if the assigned to user is active" do
Chris@1464 2115 issue = Issue.generate!(:assigned_to => User.generate!)
Chris@1464 2116 assert issue.assigned_to, "No assigned_to set for Issue"
Chris@1464 2117 assert issue.recipients.include?(issue.assigned_to.mail)
Chris@1464 2118 end
Chris@1464 2119
Chris@1464 2120 test "Issue#recipients should not include users who opt out of all email" do
Chris@1464 2121 issue = Issue.generate!(:author => User.generate!)
Chris@1464 2122 issue.author.update_attribute(:mail_notification, :none)
Chris@1464 2123 assert !issue.recipients.include?(issue.author.mail)
Chris@1464 2124 end
Chris@1464 2125
Chris@1464 2126 test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
Chris@1464 2127 issue = Issue.generate!(:author => User.generate!)
Chris@1464 2128 issue.author.update_attribute(:mail_notification, :only_assigned)
Chris@1464 2129 assert !issue.recipients.include?(issue.author.mail)
Chris@1464 2130 end
Chris@1464 2131
Chris@1464 2132 test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
Chris@1464 2133 issue = Issue.generate!(:assigned_to => User.generate!)
Chris@1464 2134 issue.assigned_to.update_attribute(:mail_notification, :only_owner)
Chris@1464 2135 assert !issue.recipients.include?(issue.assigned_to.mail)
Chris@1464 2136 end
Chris@1464 2137
Chris@1464 2138 def test_last_journal_id_with_journals_should_return_the_journal_id
Chris@1464 2139 assert_equal 2, Issue.find(1).last_journal_id
Chris@1464 2140 end
Chris@1464 2141
Chris@1464 2142 def test_last_journal_id_without_journals_should_return_nil
Chris@1464 2143 assert_nil Issue.find(3).last_journal_id
Chris@1464 2144 end
Chris@1464 2145
Chris@1464 2146 def test_journals_after_should_return_journals_with_greater_id
Chris@1464 2147 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
Chris@1464 2148 assert_equal [], Issue.find(1).journals_after('2')
Chris@1464 2149 end
Chris@1464 2150
Chris@1464 2151 def test_journals_after_with_blank_arg_should_return_all_journals
Chris@1464 2152 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
Chris@1464 2153 end
Chris@1464 2154
Chris@1464 2155 def test_css_classes_should_include_tracker
Chris@1464 2156 issue = Issue.new(:tracker => Tracker.find(2))
Chris@1464 2157 classes = issue.css_classes.split(' ')
Chris@1464 2158 assert_include 'tracker-2', classes
Chris@1464 2159 end
Chris@1464 2160
Chris@1464 2161 def test_css_classes_should_include_priority
Chris@1464 2162 issue = Issue.new(:priority => IssuePriority.find(8))
Chris@1464 2163 classes = issue.css_classes.split(' ')
Chris@1464 2164 assert_include 'priority-8', classes
Chris@1464 2165 assert_include 'priority-highest', classes
Chris@1464 2166 end
Chris@1464 2167
Chris@1464 2168 def test_save_attachments_with_hash_should_save_attachments_in_keys_order
Chris@1464 2169 set_tmp_attachments_directory
Chris@1464 2170 issue = Issue.generate!
Chris@1464 2171 issue.save_attachments({
Chris@1464 2172 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
Chris@1464 2173 '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
Chris@1464 2174 '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
Chris@1464 2175 })
Chris@1464 2176 issue.attach_saved_attachments
Chris@1464 2177
Chris@1464 2178 assert_equal 3, issue.reload.attachments.count
Chris@1464 2179 assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
Chris@1464 2180 end
Chris@1464 2181
Chris@1464 2182 def test_closed_on_should_be_nil_when_creating_an_open_issue
Chris@1464 2183 issue = Issue.generate!(:status_id => 1).reload
Chris@1464 2184 assert !issue.closed?
Chris@1464 2185 assert_nil issue.closed_on
Chris@1464 2186 end
Chris@1464 2187
Chris@1464 2188 def test_closed_on_should_be_set_when_creating_a_closed_issue
Chris@1464 2189 issue = Issue.generate!(:status_id => 5).reload
Chris@1464 2190 assert issue.closed?
Chris@1464 2191 assert_not_nil issue.closed_on
Chris@1464 2192 assert_equal issue.updated_on, issue.closed_on
Chris@1464 2193 assert_equal issue.created_on, issue.closed_on
Chris@1464 2194 end
Chris@1464 2195
Chris@1464 2196 def test_closed_on_should_be_nil_when_updating_an_open_issue
Chris@1464 2197 issue = Issue.find(1)
Chris@1464 2198 issue.subject = 'Not closed yet'
Chris@1464 2199 issue.save!
Chris@1464 2200 issue.reload
Chris@1464 2201 assert_nil issue.closed_on
Chris@1464 2202 end
Chris@1464 2203
Chris@1464 2204 def test_closed_on_should_be_set_when_closing_an_open_issue
Chris@1464 2205 issue = Issue.find(1)
Chris@1464 2206 issue.subject = 'Now closed'
Chris@1464 2207 issue.status_id = 5
Chris@1464 2208 issue.save!
Chris@1464 2209 issue.reload
Chris@1464 2210 assert_not_nil issue.closed_on
Chris@1464 2211 assert_equal issue.updated_on, issue.closed_on
Chris@1464 2212 end
Chris@1464 2213
Chris@1464 2214 def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
Chris@1464 2215 issue = Issue.open(false).first
Chris@1464 2216 was_closed_on = issue.closed_on
Chris@1464 2217 assert_not_nil was_closed_on
Chris@1464 2218 issue.subject = 'Updating a closed issue'
Chris@1464 2219 issue.save!
Chris@1464 2220 issue.reload
Chris@1464 2221 assert_equal was_closed_on, issue.closed_on
Chris@1464 2222 end
Chris@1464 2223
Chris@1464 2224 def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
Chris@1464 2225 issue = Issue.open(false).first
Chris@1464 2226 was_closed_on = issue.closed_on
Chris@1464 2227 assert_not_nil was_closed_on
Chris@1464 2228 issue.subject = 'Reopening a closed issue'
Chris@1464 2229 issue.status_id = 1
Chris@1464 2230 issue.save!
Chris@1464 2231 issue.reload
Chris@1464 2232 assert !issue.closed?
Chris@1464 2233 assert_equal was_closed_on, issue.closed_on
Chris@1464 2234 end
Chris@1464 2235
Chris@1464 2236 def test_status_was_should_return_nil_for_new_issue
Chris@1464 2237 issue = Issue.new
Chris@1464 2238 assert_nil issue.status_was
Chris@1464 2239 end
Chris@1464 2240
Chris@1464 2241 def test_status_was_should_return_status_before_change
Chris@1464 2242 issue = Issue.find(1)
Chris@1464 2243 issue.status = IssueStatus.find(2)
Chris@1464 2244 assert_equal IssueStatus.find(1), issue.status_was
Chris@1464 2245 end
Chris@1464 2246
Chris@1464 2247 def test_status_was_should_be_reset_on_save
Chris@1464 2248 issue = Issue.find(1)
Chris@1464 2249 issue.status = IssueStatus.find(2)
Chris@1464 2250 assert_equal IssueStatus.find(1), issue.status_was
Chris@1464 2251 assert issue.save!
Chris@1464 2252 assert_equal IssueStatus.find(2), issue.status_was
Chris@1464 2253 end
Chris@1464 2254 end