Mercurial > hg > silvet

changeset 58:d00a6f6c7fc9

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Comment
author Chris Cannam
date Tue, 08 Apr 2014 17:45:26 +0100
parents 49c0a139f165
children d5f5c91f4afe
files src/Silvet.cpp
diffstat 1 files changed, 5 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/src/Silvet.cpp	Tue Apr 08 13:36:07 2014 +0100
+++ b/src/Silvet.cpp	Tue Apr 08 17:45:26 2014 +0100
@@ -435,9 +435,11 @@
 
     Grid out;
 
-    //!!! nb we count the CQ latency in terms of processing hops, but
-    //!!! actually it isn't guaranteed to be an exact number (in fact
-    //!!! it probably isn't) so this is imprecise -- fix
+    // We count the CQ latency in terms of processing hops, but
+    // actually it probably isn't an exact number of hops so this
+    // isn't quite accurate. But the small constant offset is
+    // practically irrelevant compared to the jitter from the 40ms
+    // frame size we reduce to in a moment
     int latentColumns = m_cq->getLatency() / m_cq->getColumnHop();
 
     for (int i = 0; i < width; ++i) {
@@ -481,8 +483,6 @@
 
             // then we only use every fourth filtered column, for 25
             // columns per second in the eventual grid
-            //!!! why, if we're filtering the time columns, don't we just
-            // reduce to this frame rate before filtering at all?
 
             if (m_reducedColumnCount % 4 == 0) {
                 out.push_back(outCol);