diff src/EM.cpp @ 150:d2bc51cc7f57

Some comments on things to try next...
author Chris Cannam
date Wed, 14 May 2014 18:09:06 +0100
parents f25b8e7de0ed
children fc06b6f33021
line wrap: on
line diff
--- a/src/EM.cpp	Wed May 14 18:08:47 2014 +0100
+++ b/src/EM.cpp	Wed May 14 18:09:06 2014 +0100
@@ -39,6 +39,8 @@
     m_binCount(SILVET_TEMPLATE_HEIGHT),
     m_sourceCount(SILVET_TEMPLATE_COUNT),
     m_pitchSparsity(1.1),
+    //!!! note: slightly less source sparsity might help; also
+    //!!! consider a modest shift sparsity e.g. 1.1
     m_sourceSparsity(1.3),
     m_lowestPitch(silvet_templates_lowest_note),
     m_highestPitch(silvet_templates_highest_note)
@@ -180,6 +182,9 @@
         }
     }
 
+    //!!! try normalising so as to sum to unity and then taking L2
+    //!!! norm of the two (for measure of how close they are)
+
     for (int i = 0; i < m_binCount; ++i) {
         m_q[i] = column[i] / m_estimate[i];
     }