comparison src/EM.cpp @ 150:d2bc51cc7f57

Some comments on things to try next...

     m_noteCount(SILVET_TEMPLATE_NOTE_COUNT),
     m_shiftCount(useShifts ? SILVET_TEMPLATE_MAX_SHIFT * 2 + 1 : 1),
     m_binCount(SILVET_TEMPLATE_HEIGHT),
     m_sourceCount(SILVET_TEMPLATE_COUNT),
     m_pitchSparsity(1.1),
+    //!!! note: slightly less source sparsity might help; also
+    //!!! consider a modest shift sparsity e.g. 1.1
     m_sourceSparsity(1.3),
     m_lowestPitch(silvet_templates_lowest_note),
     m_highestPitch(silvet_templates_highest_note)
 {
     m_pitches = allocate<double>(m_noteCount);

                 v_add_with_gain(m_estimate, w, factor, m_binCount);
             }
         }
     }
 
+    //!!! try normalising so as to sum to unity and then taking L2
+    //!!! norm of the two (for measure of how close they are)
+
     for (int i = 0; i < m_binCount; ++i) {
         m_q[i] = column[i] / m_estimate[i];
     }
 }