annotate src/Silvet.cpp @ 46:d7f1c10f4e1d

Fix noise-reduction filtering (it was going the wrong way)
author Chris Cannam
date Mon, 07 Apr 2014 14:18:22 +0100
parents b49597c93132
children ccb1a437a828 9b17bbd16a5f
rev   line source
Chris@31 1 /* -*- c-basic-offset: 4 indent-tabs-mode: nil -*- vi:set ts=8 sts=4 sw=4: */
Chris@31 2
Chris@31 3 /*
Chris@31 4 Silvet
Chris@31 5
Chris@31 6 A Vamp plugin for note transcription.
Chris@31 7 Centre for Digital Music, Queen Mary University of London.
Chris@31 8
Chris@31 9 This program is free software; you can redistribute it and/or
Chris@31 10 modify it under the terms of the GNU General Public License as
Chris@31 11 published by the Free Software Foundation; either version 2 of the
Chris@31 12 License, or (at your option) any later version. See the file
Chris@31 13 COPYING included with this distribution for more information.
Chris@31 14 */
Chris@31 15
Chris@31 16 #include "Silvet.h"
Chris@34 17 #include "EM.h"
Chris@31 18
Chris@32 19 #include "maths/MedianFilter.h"
Chris@31 20 #include "dsp/rateconversion/Resampler.h"
Chris@31 21
Chris@32 22 #include "constant-q-cpp/cpp-qm-dsp/CQInterpolated.h"
Chris@31 23
Chris@31 24 #include <vector>
Chris@31 25
Chris@32 26 #include <cstdio>
Chris@32 27
Chris@31 28 using std::vector;
Chris@31 29 using std::cerr;
Chris@31 30 using std::endl;
Chris@40 31 using Vamp::RealTime;
Chris@31 32
Chris@31 33 static int processingSampleRate = 44100;
Chris@31 34 static int processingBPO = 60;
Chris@32 35 static int processingHeight = 545;
Chris@38 36 static int processingNotes = 88;
Chris@31 37
Chris@31 38 Silvet::Silvet(float inputSampleRate) :
Chris@31 39 Plugin(inputSampleRate),
Chris@31 40 m_resampler(0),
Chris@31 41 m_cq(0)
Chris@31 42 {
Chris@31 43 }
Chris@31 44
Chris@31 45 Silvet::~Silvet()
Chris@31 46 {
Chris@31 47 delete m_resampler;
Chris@31 48 delete m_cq;
Chris@41 49 for (int i = 0; i < (int)m_postFilter.size(); ++i) {
Chris@41 50 delete m_postFilter[i];
Chris@41 51 }
Chris@31 52 }
Chris@31 53
Chris@31 54 string
Chris@31 55 Silvet::getIdentifier() const
Chris@31 56 {
Chris@31 57 return "silvet";
Chris@31 58 }
Chris@31 59
Chris@31 60 string
Chris@31 61 Silvet::getName() const
Chris@31 62 {
Chris@31 63 return "Silvet Note Transcription";
Chris@31 64 }
Chris@31 65
Chris@31 66 string
Chris@31 67 Silvet::getDescription() const
Chris@31 68 {
Chris@31 69 // Return something helpful here!
Chris@31 70 return "";
Chris@31 71 }
Chris@31 72
Chris@31 73 string
Chris@31 74 Silvet::getMaker() const
Chris@31 75 {
Chris@31 76 // Your name here
Chris@31 77 return "";
Chris@31 78 }
Chris@31 79
Chris@31 80 int
Chris@31 81 Silvet::getPluginVersion() const
Chris@31 82 {
Chris@31 83 return 1;
Chris@31 84 }
Chris@31 85
Chris@31 86 string
Chris@31 87 Silvet::getCopyright() const
Chris@31 88 {
Chris@31 89 // This function is not ideally named. It does not necessarily
Chris@31 90 // need to say who made the plugin -- getMaker does that -- but it
Chris@31 91 // should indicate the terms under which it is distributed. For
Chris@31 92 // example, "Copyright (year). All Rights Reserved", or "GPL"
Chris@31 93 return "";
Chris@31 94 }
Chris@31 95
Chris@31 96 Silvet::InputDomain
Chris@31 97 Silvet::getInputDomain() const
Chris@31 98 {
Chris@31 99 return TimeDomain;
Chris@31 100 }
Chris@31 101
Chris@31 102 size_t
Chris@31 103 Silvet::getPreferredBlockSize() const
Chris@31 104 {
Chris@31 105 return 0;
Chris@31 106 }
Chris@31 107
Chris@31 108 size_t
Chris@31 109 Silvet::getPreferredStepSize() const
Chris@31 110 {
Chris@31 111 return 0;
Chris@31 112 }
Chris@31 113
Chris@31 114 size_t
Chris@31 115 Silvet::getMinChannelCount() const
Chris@31 116 {
Chris@31 117 return 1;
Chris@31 118 }
Chris@31 119
Chris@31 120 size_t
Chris@31 121 Silvet::getMaxChannelCount() const
Chris@31 122 {
Chris@31 123 return 1;
Chris@31 124 }
Chris@31 125
Chris@31 126 Silvet::ParameterList
Chris@31 127 Silvet::getParameterDescriptors() const
Chris@31 128 {
Chris@31 129 ParameterList list;
Chris@31 130 return list;
Chris@31 131 }
Chris@31 132
Chris@31 133 float
Chris@31 134 Silvet::getParameter(string identifier) const
Chris@31 135 {
Chris@31 136 return 0;
Chris@31 137 }
Chris@31 138
Chris@31 139 void
Chris@31 140 Silvet::setParameter(string identifier, float value)
Chris@31 141 {
Chris@31 142 }
Chris@31 143
Chris@31 144 Silvet::ProgramList
Chris@31 145 Silvet::getPrograms() const
Chris@31 146 {
Chris@31 147 ProgramList list;
Chris@31 148 return list;
Chris@31 149 }
Chris@31 150
Chris@31 151 string
Chris@31 152 Silvet::getCurrentProgram() const
Chris@31 153 {
Chris@31 154 return "";
Chris@31 155 }
Chris@31 156
Chris@31 157 void
Chris@31 158 Silvet::selectProgram(string name)
Chris@31 159 {
Chris@31 160 }
Chris@31 161
Chris@31 162 Silvet::OutputList
Chris@31 163 Silvet::getOutputDescriptors() const
Chris@31 164 {
Chris@31 165 OutputList list;
Chris@31 166
Chris@31 167 OutputDescriptor d;
Chris@31 168 d.identifier = "transcription";
Chris@31 169 d.name = "Transcription";
Chris@31 170 d.description = ""; //!!!
Chris@41 171 d.unit = "Hz";
Chris@31 172 d.hasFixedBinCount = true;
Chris@31 173 d.binCount = 2;
Chris@41 174 d.binNames.push_back("Frequency");
Chris@31 175 d.binNames.push_back("Velocity");
Chris@31 176 d.hasKnownExtents = false;
Chris@31 177 d.isQuantized = false;
Chris@31 178 d.sampleType = OutputDescriptor::VariableSampleRate;
Chris@32 179 d.sampleRate = m_inputSampleRate / (m_cq ? m_cq->getColumnHop() : 256);
Chris@31 180 d.hasDuration = true;
Chris@32 181 m_notesOutputNo = list.size();
Chris@32 182 list.push_back(d);
Chris@32 183
Chris@32 184 d.identifier = "inputgrid";
Chris@32 185 d.name = "Filtered time-frequency grid";
Chris@32 186 d.description = "The pre-processed constant-Q time-frequency distribution used as input to the PLCA step";
Chris@32 187 d.unit = "";
Chris@32 188 d.hasFixedBinCount = true;
Chris@32 189 d.binCount = processingHeight;
Chris@32 190 d.binNames.clear();
Chris@32 191 if (m_cq) {
Chris@32 192 char name[20];
Chris@32 193 for (int i = 0; i < processingHeight; ++i) {
Chris@32 194 float freq = m_cq->getBinFrequency(i + 55);
Chris@32 195 sprintf(name, "%.1f Hz", freq);
Chris@32 196 d.binNames.push_back(name);
Chris@32 197 }
Chris@32 198 }
Chris@32 199 d.hasKnownExtents = false;
Chris@32 200 d.isQuantized = false;
Chris@32 201 d.sampleType = OutputDescriptor::FixedSampleRate;
Chris@32 202 d.sampleRate = 25;
Chris@32 203 d.hasDuration = false;
Chris@32 204 m_cqOutputNo = list.size();
Chris@31 205 list.push_back(d);
Chris@31 206
Chris@38 207 d.identifier = "pitchdistribution";
Chris@38 208 d.name = "Pitch distribution";
Chris@38 209 d.description = "The estimated pitch contribution matrix";
Chris@38 210 d.unit = "";
Chris@38 211 d.hasFixedBinCount = true;
Chris@38 212 d.binCount = processingNotes;
Chris@38 213 d.binNames.clear();
Chris@38 214 for (int i = 0; i < processingNotes; ++i) {
Chris@38 215 d.binNames.push_back(noteName(i));
Chris@38 216 }
Chris@38 217 d.hasKnownExtents = false;
Chris@38 218 d.isQuantized = false;
Chris@38 219 d.sampleType = OutputDescriptor::FixedSampleRate;
Chris@38 220 d.sampleRate = 25;
Chris@38 221 d.hasDuration = false;
Chris@38 222 m_pitchOutputNo = list.size();
Chris@38 223 list.push_back(d);
Chris@38 224
Chris@31 225 return list;
Chris@31 226 }
Chris@31 227
Chris@38 228 std::string
Chris@38 229 Silvet::noteName(int i) const
Chris@38 230 {
Chris@38 231 static const char *names[] = {
Chris@38 232 "A", "A#", "B", "C", "C#", "D", "D#", "E", "F", "F#", "G", "G#"
Chris@38 233 };
Chris@38 234
Chris@38 235 const char *n = names[i % 12];
Chris@38 236
Chris@38 237 int oct = (i + 9) / 12;
Chris@38 238
Chris@38 239 char buf[20];
Chris@38 240 sprintf(buf, "%s%d", n, oct);
Chris@38 241
Chris@38 242 return buf;
Chris@38 243 }
Chris@38 244
Chris@41 245 float
Chris@41 246 Silvet::noteFrequency(int note) const
Chris@41 247 {
Chris@41 248 return float(27.5 * pow(2.0, note / 12.0));
Chris@41 249 }
Chris@41 250
Chris@31 251 bool
Chris@31 252 Silvet::initialise(size_t channels, size_t stepSize, size_t blockSize)
Chris@31 253 {
Chris@31 254 if (channels < getMinChannelCount() ||
Chris@31 255 channels > getMaxChannelCount()) return false;
Chris@31 256
Chris@31 257 if (stepSize != blockSize) {
Chris@31 258 cerr << "Silvet::initialise: Step size must be the same as block size ("
Chris@31 259 << stepSize << " != " << blockSize << ")" << endl;
Chris@31 260 return false;
Chris@31 261 }
Chris@31 262
Chris@31 263 m_blockSize = blockSize;
Chris@31 264
Chris@31 265 reset();
Chris@31 266
Chris@31 267 return true;
Chris@31 268 }
Chris@31 269
Chris@31 270 void
Chris@31 271 Silvet::reset()
Chris@31 272 {
Chris@31 273 delete m_resampler;
Chris@31 274 delete m_cq;
Chris@31 275
Chris@31 276 if (m_inputSampleRate != processingSampleRate) {
Chris@31 277 m_resampler = new Resampler(m_inputSampleRate, processingSampleRate);
Chris@31 278 } else {
Chris@31 279 m_resampler = 0;
Chris@31 280 }
Chris@31 281
Chris@32 282 m_cq = new CQInterpolated
Chris@32 283 (processingSampleRate, 27.5, processingSampleRate / 3, processingBPO,
Chris@32 284 CQInterpolated::Linear);
Chris@31 285
Chris@41 286 for (int i = 0; i < (int)m_postFilter.size(); ++i) {
Chris@41 287 delete m_postFilter[i];
Chris@41 288 }
Chris@41 289 m_postFilter.clear();
Chris@41 290 for (int i = 0; i < processingNotes; ++i) {
Chris@41 291 m_postFilter.push_back(new MedianFilter<double>(3));
Chris@41 292 }
Chris@41 293 m_pianoRoll.clear();
Chris@32 294 m_columnCount = 0;
Chris@32 295 m_reducedColumnCount = 0;
Chris@40 296 m_startTime = RealTime::zeroTime;
Chris@31 297 }
Chris@31 298
Chris@31 299 Silvet::FeatureSet
Chris@31 300 Silvet::process(const float *const *inputBuffers, Vamp::RealTime timestamp)
Chris@31 301 {
Chris@40 302 if (m_columnCount == 0) {
Chris@40 303 m_startTime = timestamp;
Chris@40 304 }
Chris@40 305
Chris@31 306 vector<double> data;
Chris@40 307 for (int i = 0; i < m_blockSize; ++i) {
Chris@40 308 data.push_back(inputBuffers[0][i]);
Chris@40 309 }
Chris@31 310
Chris@31 311 if (m_resampler) {
Chris@31 312 data = m_resampler->process(data.data(), data.size());
Chris@31 313 }
Chris@31 314
Chris@32 315 Grid cqout = m_cq->process(data);
Chris@34 316 return transcribe(cqout);
Chris@34 317 }
Chris@34 318
Chris@34 319 Silvet::FeatureSet
Chris@34 320 Silvet::getRemainingFeatures()
Chris@34 321 {
Chris@34 322 Grid cqout = m_cq->getRemainingBlocks();
Chris@34 323 return transcribe(cqout);
Chris@34 324 }
Chris@34 325
Chris@34 326 Silvet::FeatureSet
Chris@34 327 Silvet::transcribe(const Grid &cqout)
Chris@34 328 {
Chris@32 329 Grid filtered = preProcess(cqout);
Chris@31 330
Chris@32 331 FeatureSet fs;
Chris@32 332
Chris@32 333 for (int i = 0; i < (int)filtered.size(); ++i) {
Chris@32 334 Feature f;
Chris@32 335 for (int j = 0; j < processingHeight; ++j) {
Chris@32 336 f.values.push_back(float(filtered[i][j]));
Chris@32 337 }
Chris@32 338 fs[m_cqOutputNo].push_back(f);
Chris@32 339 }
Chris@32 340
Chris@34 341 int width = filtered.size();
Chris@34 342
Chris@34 343 int iterations = 12;
Chris@34 344
Chris@34 345 for (int i = 0; i < width; ++i) {
Chris@37 346
Chris@37 347 double sum = 0.0;
Chris@37 348 for (int j = 0; j < processingHeight; ++j) {
Chris@37 349 sum += filtered[i][j];
Chris@37 350 }
Chris@37 351 cerr << "sum = " << sum << endl;
Chris@37 352
Chris@37 353 if (sum < 1e-5) continue;
Chris@37 354
Chris@34 355 EM em;
Chris@34 356 for (int j = 0; j < iterations; ++j) {
Chris@34 357 em.iterate(filtered[i]);
Chris@34 358 }
Chris@37 359
Chris@38 360 vector<double> pitches = em.getPitchDistribution();
Chris@41 361
Chris@41 362 for (int j = 0; j < processingNotes; ++j) {
Chris@41 363 pitches[j] *= sum;
Chris@41 364 }
Chris@41 365
Chris@38 366 Feature f;
Chris@41 367 for (int j = 0; j < processingNotes; ++j) {
Chris@41 368 f.values.push_back(float(pitches[j]));
Chris@38 369 }
Chris@38 370 fs[m_pitchOutputNo].push_back(f);
Chris@38 371
Chris@41 372 FeatureList noteFeatures = postProcess(pitches);
Chris@41 373 for (FeatureList::const_iterator fi = noteFeatures.begin();
Chris@41 374 fi != noteFeatures.end(); ++fi) {
Chris@41 375 fs[m_notesOutputNo].push_back(*fi);
Chris@40 376 }
Chris@34 377 }
Chris@34 378
Chris@32 379 return fs;
Chris@31 380 }
Chris@31 381
Chris@32 382 Silvet::Grid
Chris@32 383 Silvet::preProcess(const Grid &in)
Chris@32 384 {
Chris@32 385 int width = in.size();
Chris@32 386
Chris@32 387 // reduce to 100 columns per second, or one column every 441 samples
Chris@32 388
Chris@32 389 int spacing = processingSampleRate / 100;
Chris@32 390
Chris@32 391 Grid out;
Chris@32 392
Chris@33 393 //!!! nb we count the CQ latency in terms of processing hops, but
Chris@33 394 //!!! actually it isn't guaranteed to be an exact number (in fact
Chris@33 395 //!!! it probably isn't) so this is imprecise -- fix
Chris@33 396 int latentColumns = m_cq->getLatency() / m_cq->getColumnHop();
Chris@33 397
Chris@32 398 for (int i = 0; i < width; ++i) {
Chris@32 399
Chris@33 400 if (m_columnCount < latentColumns) {
Chris@33 401 ++m_columnCount;
Chris@33 402 continue;
Chris@33 403 }
Chris@33 404
Chris@32 405 int prevSampleNo = (m_columnCount - 1) * m_cq->getColumnHop();
Chris@32 406 int sampleNo = m_columnCount * m_cq->getColumnHop();
Chris@32 407
Chris@32 408 bool select = (sampleNo / spacing != prevSampleNo / spacing);
Chris@32 409
Chris@32 410 if (select) {
Chris@32 411 vector<double> inCol = in[i];
Chris@32 412 vector<double> outCol(processingHeight);
Chris@32 413
Chris@32 414 // we reverse the column as we go (the CQ output is
Chris@32 415 // "upside-down", with high frequencies at the start of
Chris@32 416 // each column, and we want it the other way around) and
Chris@32 417 // then ignore the first 55 (lowest-frequency) bins,
Chris@32 418 // giving us 545 bins instead of 600
Chris@32 419
Chris@32 420 for (int j = 0; j < processingHeight; ++j) {
Chris@46 421 int ix = inCol.size() - j - 55;
Chris@46 422 outCol[j] = inCol[ix];
Chris@46 423 }
Chris@32 424
Chris@46 425 vector<double> noiseLevel1 =
Chris@46 426 MedianFilter<double>::filter(40, outCol);
Chris@46 427 for (int j = 0; j < processingHeight; ++j) {
Chris@46 428 noiseLevel1[j] = std::min(outCol[j], noiseLevel1[j]);
Chris@46 429 }
Chris@32 430
Chris@46 431 vector<double> noiseLevel2 =
Chris@46 432 MedianFilter<double>::filter(40, noiseLevel1);
Chris@46 433 for (int j = 0; j < processingHeight; ++j) {
Chris@46 434 outCol[j] = std::max(outCol[j] - noiseLevel2[j], 0.0);
Chris@32 435 }
Chris@32 436
Chris@32 437 // then we only use every fourth filtered column, for 25
Chris@32 438 // columns per second in the eventual grid
Chris@46 439 //!!! why, if we're filtering the time columns, don't we just
Chris@46 440 // reduce to this frame rate before filtering at all?
Chris@32 441
Chris@32 442 if (m_reducedColumnCount % 4 == 0) {
Chris@32 443 out.push_back(outCol);
Chris@32 444 }
Chris@32 445
Chris@32 446 ++m_reducedColumnCount;
Chris@32 447 }
Chris@32 448
Chris@32 449 ++m_columnCount;
Chris@32 450 }
Chris@32 451
Chris@32 452 return out;
Chris@32 453 }
Chris@32 454
Chris@41 455 Vamp::Plugin::FeatureList
Chris@41 456 Silvet::postProcess(const vector<double> &pitches)
Chris@41 457 {
Chris@41 458 vector<double> filtered;
Chris@41 459
Chris@41 460 for (int j = 0; j < processingNotes; ++j) {
Chris@41 461 m_postFilter[j]->push(pitches[j]);
Chris@41 462 filtered.push_back(m_postFilter[j]->get());
Chris@41 463 }
Chris@41 464
Chris@41 465 // Threshold for level and reduce number of candidate pitches
Chris@41 466
Chris@41 467 int polyphony = 5;
Chris@41 468 double threshold = 4.8;
Chris@41 469
Chris@41 470 typedef std::multimap<double, int> ValueIndexMap;
Chris@41 471
Chris@41 472 ValueIndexMap strengths;
Chris@41 473 for (int j = 0; j < processingNotes; ++j) {
Chris@41 474 strengths.insert(ValueIndexMap::value_type(filtered[j], j));
Chris@41 475 }
Chris@41 476
Chris@41 477 set<int> active;
Chris@41 478 ValueIndexMap::const_iterator si = strengths.end();
Chris@41 479 for (int j = 0; j < polyphony; ++j) {
Chris@41 480 --si;
Chris@41 481 if (si->first < threshold) break;
Chris@41 482 cerr << si->second << " : " << si->first << endl;
Chris@41 483 active.insert(si->second);
Chris@41 484 }
Chris@41 485
Chris@41 486 // Minimum duration pruning, and conversion to notes. We can only
Chris@41 487 // report notes that have just ended (i.e. that are absent in the
Chris@41 488 // latest active set but present in the last set in the piano
Chris@41 489 // roll) -- any notes that ended earlier will have been reported
Chris@41 490 // already, and if they haven't ended, we don't know their
Chris@41 491 // duration.
Chris@41 492
Chris@41 493 int width = m_pianoRoll.size();
Chris@41 494
Chris@41 495 int durationThreshold = 2; // columns
Chris@41 496
Chris@41 497 FeatureList noteFeatures;
Chris@41 498
Chris@41 499 if (width < durationThreshold + 1) {
Chris@41 500 m_pianoRoll.push_back(active);
Chris@41 501 return noteFeatures;
Chris@41 502 }
Chris@41 503
Chris@41 504 // we have 25 columns per second
Chris@41 505 double columnDuration = 1.0 / 25.0;
Chris@41 506
Chris@41 507 for (set<int>::const_iterator ni = m_pianoRoll[width-1].begin();
Chris@41 508 ni != m_pianoRoll[width-1].end(); ++ni) {
Chris@41 509
Chris@41 510 int note = *ni;
Chris@41 511
Chris@41 512 if (active.find(note) != active.end()) {
Chris@41 513 // the note is still playing
Chris@41 514 continue;
Chris@41 515 }
Chris@41 516
Chris@41 517 // the note was playing but just ended
Chris@41 518 int end = width;
Chris@41 519 int start = end-1;
Chris@41 520
Chris@41 521 while (m_pianoRoll[start].find(note) != m_pianoRoll[start].end()) {
Chris@41 522 --start;
Chris@41 523 }
Chris@41 524 ++start;
Chris@41 525
Chris@41 526 int duration = width - start;
Chris@41 527 cerr << "duration " << duration << " for just-ended note " << note << endl;
Chris@41 528 if (duration < durationThreshold) {
Chris@41 529 // spurious
Chris@41 530 continue;
Chris@41 531 }
Chris@41 532
Chris@41 533 Feature nf;
Chris@41 534 nf.hasTimestamp = true;
Chris@41 535 nf.timestamp = RealTime::fromSeconds(columnDuration * start);
Chris@41 536 nf.hasDuration = true;
Chris@41 537 nf.duration = RealTime::fromSeconds(columnDuration * duration);
Chris@41 538 nf.values.push_back(noteFrequency(note));
Chris@41 539 nf.values.push_back(80.f); //!!! todo: calculate velocity
Chris@41 540 nf.label = noteName(note);
Chris@41 541 noteFeatures.push_back(nf);
Chris@41 542 }
Chris@41 543
Chris@41 544 m_pianoRoll.push_back(active);
Chris@41 545
Chris@41 546 cerr << "returning " << noteFeatures.size() << " complete notes" << endl;
Chris@41 547
Chris@41 548 return noteFeatures;
Chris@41 549 }
Chris@41 550