Mercurial > hg > piper-cpp
changeset 263:9a044706ab73
Comments on dubiousness of all this
| author | Chris Cannam <cannam@all-day-breakfast.com> |
|---|---|
| date | Fri, 12 Oct 2018 11:12:09 +0100 |
| parents | 853aeab95acf |
| children | 37760b5376b3 |
| files | vamp-support/PreservingPluginHandleMapper.h |
| diffstat | 1 files changed, 3 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/vamp-support/PreservingPluginHandleMapper.h Tue Oct 02 11:56:46 2018 +0100 +++ b/vamp-support/PreservingPluginHandleMapper.h Fri Oct 12 11:12:09 2018 +0100 @@ -44,7 +44,8 @@ //!!! document -- this is a passthrough thing for a single plugin //!!! handle only, it does not use actually valid Plugin pointers at -//!!! all +//!!! all. Or, better, reimplement in a way that doesn't involve +//!!! such alarmingly invalid reinterpret_casts class PreservingPluginHandleMapper : public PluginHandleMapper { @@ -69,6 +70,7 @@ virtual Vamp::Plugin *handleToPlugin(Handle h) const noexcept { if (h == INVALID_HANDLE) return nullptr; m_handle = h; + //!!! see comment at top m_plugin = reinterpret_cast<Vamp::Plugin *>(h); return m_plugin; }