changeset 234:7c1381b8182d tipic

Experimental version using TIPIC features. Not working well - needs review
author Chris Cannam
date Thu, 15 Aug 2019 16:25:48 +0100
parents 4b272c839f7e
children
files Makefile.inc src/MatchPipeline.h src/MatchTipicVampPlugin.cpp src/MatchTipicVampPlugin.h src/MatchVampPlugin.cpp src/MatchVampPlugin.h src/libmain.cpp
diffstat 7 files changed, 962 insertions(+), 29 deletions(-) [+]
line wrap: on
line diff
--- a/Makefile.inc	Fri Jun 10 13:56:05 2016 +0100
+++ b/Makefile.inc	Thu Aug 15 16:25:48 2019 +0100
@@ -4,7 +4,9 @@
 CXX		?= g++
 CC		?= gcc
 
-CXXFLAGS	:= -Isrc -DUSE_COMPACT_TYPES $(CXXFLAGS)
+CXXFLAGS	:= -Isrc -I../tipic/src -I../tipic/qm-dsp -DUSE_COMPACT_TYPES $(CXXFLAGS)
+
+LDFLAGS         += -L../tipic -ltipic
 
 TEST_LDFLAGS	+= -lboost_unit_test_framework
 
--- a/src/MatchPipeline.h	Fri Jun 10 13:56:05 2016 +0100
+++ b/src/MatchPipeline.h	Thu Aug 15 16:25:48 2019 +0100
@@ -41,7 +41,9 @@
      * contains a single reference frequency, but it's possible the
      * two input streams may have different tuning frequencies. A
      * separate frequency for the second input can be provided here as
-     * an optional parameter if needed.
+     * an optional parameter if needed. The tuning frequency is only
+     * used in the feature-extraction stage, so it's not necessary if
+     * input is provided using feedFeatures().
      */
     MatchPipeline(FeatureExtractor::Parameters feParams,
 		  FeatureConditioner::Parameters fcParams,
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/src/MatchTipicVampPlugin.cpp	Thu Aug 15 16:25:48 2019 +0100
@@ -0,0 +1,814 @@
+/* -*- c-basic-offset: 4 indent-tabs-mode: nil -*-  vi:set ts=8 sts=4 sw=4: */
+
+/*
+    Vamp feature extraction plugin using the MATCH audio alignment
+    algorithm with TIPIC features.
+
+    Centre for Digital Music, Queen Mary, University of London.
+    Copyright (c) 2007-2019 Simon Dixon, Chris Cannam, and Queen Mary
+    University of London, Copyright (c) 2014-2015 Tido GmbH.
+    
+    This program is free software; you can redistribute it and/or
+    modify it under the terms of the GNU General Public License as
+    published by the Free Software Foundation; either version 2 of the
+    License, or (at your option) any later version.  See the file
+    COPYING included with this distribution for more information.
+*/
+
+#include "MatchTipicVampPlugin.h"
+
+#include <vamp/vamp.h>
+#include <vamp-sdk/RealTime.h>
+
+#include <vector>
+#include <algorithm>
+
+#ifdef _WIN32
+HANDLE
+MatchTipicVampPlugin::m_serialisingMutex;
+#else
+pthread_mutex_t 
+MatchTipicVampPlugin::m_serialisingMutex;
+#endif
+
+bool
+MatchTipicVampPlugin::m_serialisingMutexInitialised = false;
+
+MatchTipicVampPlugin::MatchTipicVampPlugin(float inputSampleRate) :
+    Plugin(inputSampleRate),
+    m_stepSize(0),
+    m_blockSize(0),
+    m_serialise(false),
+    m_begin(true),
+    m_locked(false),
+    m_smooth(false),
+    m_chroma(true),
+    m_frequencyReference(440.f),
+    m_frequencyOther(440.f),
+    m_params(1.0 / PitchFilterbank::getOutputSampleRate()),
+    m_defaultParams(1.0 / PitchFilterbank::getOutputSampleRate()),
+    m_fcParams(),
+    m_defaultFcParams(),
+    m_dParams(),
+    m_defaultDParams(),
+    m_filterbankReference(nullptr),
+    m_filterbankOther(nullptr),
+    m_crp(nullptr),
+    m_pipeline(nullptr)
+{
+    if (!m_serialisingMutexInitialised) {
+        m_serialisingMutexInitialised = true;
+#ifdef _WIN32
+        m_serialisingMutex = CreateMutex(NULL, FALSE, NULL);
+#else
+        pthread_mutex_init(&m_serialisingMutex, 0);
+#endif
+    }
+
+//    std::cerr << "MatchTipicVampPlugin::MatchTipicVampPlugin(" << this << "): extant = " << ++extant << std::endl;
+}
+
+MatchTipicVampPlugin::~MatchTipicVampPlugin()
+{
+//    std::cerr << "MatchTipicVampPlugin::~MatchTipicVampPlugin(" << this << "): extant = " << --extant << std::endl;
+
+    delete m_pipeline;
+    delete m_crp;
+    delete m_filterbankOther;
+    delete m_filterbankReference;
+
+    if (m_locked) {
+#ifdef _WIN32
+        ReleaseMutex(m_serialisingMutex);
+#else
+        pthread_mutex_unlock(&m_serialisingMutex);
+#endif
+        m_locked = false;
+    }
+}
+
+string
+MatchTipicVampPlugin::getIdentifier() const
+{
+    return "match-tipic";
+}
+
+string
+MatchTipicVampPlugin::getName() const
+{
+    return "Match Performance Aligner With TIPIC Features";
+}
+
+string
+MatchTipicVampPlugin::getDescription() const
+{
+    return "Calculate alignment between two performances in separate channel inputs";
+}
+
+string
+MatchTipicVampPlugin::getMaker() const
+{
+    return "Queen Mary University of London";
+}
+
+int
+MatchTipicVampPlugin::getPluginVersion() const
+{
+    return 1;
+}
+
+string
+MatchTipicVampPlugin::getCopyright() const
+{
+    return "GPL";
+}
+
+MatchTipicVampPlugin::ParameterList
+MatchTipicVampPlugin::getParameterDescriptors() const
+{
+    ParameterList list;
+
+    ParameterDescriptor desc;
+
+    desc.identifier = "freq1";
+    desc.name = "Tuning frequency of first input";
+    desc.description = "Tuning frequency (concert A) for the reference audio.";
+    desc.minValue = 220.0;
+    desc.maxValue = 880.0;
+    desc.defaultValue = 440.0;
+    desc.isQuantized = false;
+    desc.unit = "Hz";
+    list.push_back(desc);
+
+    desc.identifier = "freq2";
+    desc.name = "Tuning frequency of second input";
+    desc.description = "Tuning frequency (concert A) for the other audio.";
+    desc.minValue = 220.0;
+    desc.maxValue = 880.0;
+    desc.defaultValue = 440.0;
+    desc.isQuantized = false;
+    desc.unit = "Hz";
+    list.push_back(desc);
+
+    desc.unit = "";
+    
+    desc.identifier = "usechroma";
+    desc.name = "Feature type";
+    desc.description = "Whether to use pitch features or chroma";
+    desc.minValue = 0;
+    desc.maxValue = 1;
+    desc.defaultValue = 1;
+    desc.isQuantized = true;
+    desc.quantizeStep = 1;
+    desc.valueNames.clear();
+    desc.valueNames.push_back("Pitch features");
+    desc.valueNames.push_back("Chroma");
+    list.push_back(desc);
+
+    desc.valueNames.clear();
+
+    desc.identifier = "usespecdiff";
+    desc.name = "Use feature difference";
+    desc.description = "Whether to use half-wave rectified feature-to-feature difference instead of straight feature";
+    desc.minValue = 0;
+    desc.maxValue = 1;
+    desc.defaultValue = float(m_defaultFcParams.order);
+    desc.isQuantized = true;
+    desc.quantizeStep = 1;
+    list.push_back(desc);
+
+    desc.identifier = "framenorm";
+    desc.name = "Frame normalisation";
+    desc.description = "Type of normalisation to use for features";
+    desc.minValue = 0;
+    desc.maxValue = 2;
+    desc.defaultValue = float(m_defaultFcParams.norm);
+    desc.isQuantized = true;
+    desc.quantizeStep = 1;
+    desc.valueNames.clear();
+    desc.valueNames.push_back("None");
+    desc.valueNames.push_back("Sum to 1");
+    desc.valueNames.push_back("Long-term average");
+    list.push_back(desc);
+    desc.valueNames.clear();
+    desc.defaultValue = float(m_defaultFcParams.silenceThreshold);
+
+    desc.identifier = "metric";
+    desc.name = "Distance metric";
+    desc.description = "Metric for distance calculations.";
+    desc.minValue = 0;
+    desc.maxValue = 2;
+    desc.defaultValue = float(m_defaultDParams.metric);
+    desc.isQuantized = true;
+    desc.quantizeStep = 1;
+    desc.valueNames.clear();
+    desc.valueNames.push_back("Manhattan");
+    desc.valueNames.push_back("Euclidean");
+    desc.valueNames.push_back("Cosine");
+    list.push_back(desc);
+    desc.valueNames.clear();
+
+    desc.identifier = "distnorm";
+    desc.name = "Distance normalisation";
+    desc.description = "Type of normalisation to use for distance metric";
+    desc.minValue = 0;
+    desc.maxValue = 2;
+    desc.defaultValue = float(m_defaultDParams.norm);
+    desc.isQuantized = true;
+    desc.quantizeStep = 1;
+    desc.valueNames.clear();
+    desc.valueNames.push_back("None");
+    desc.valueNames.push_back("Sum of frames");
+    desc.valueNames.push_back("Log sum of frames");
+    list.push_back(desc);
+    desc.valueNames.clear();
+
+#ifdef USE_COMPACT_TYPES
+    desc.identifier = "scale";
+    desc.name = "Distance scale";
+    desc.description = "Scale factor to use when mapping distance metric into byte range for storage";
+    desc.minValue = 1;
+    desc.maxValue = 1000;
+    desc.defaultValue = float(m_defaultDParams.scale);
+    desc.isQuantized = false;
+    list.push_back(desc);
+#endif
+    
+    desc.identifier = "silencethreshold";
+    desc.name = "Silence threshold";
+    desc.description = "Total frame energy threshold below which a feature will be regarded as silent";
+    desc.minValue = 0;
+    desc.maxValue = 0.1f;
+    desc.defaultValue = float(m_defaultFcParams.silenceThreshold);
+    desc.isQuantized = false;
+    list.push_back(desc);
+
+    desc.identifier = "noise";
+    desc.name = "Add noise";
+    desc.description = "Whether to mix in a small constant white noise term when calculating feature distance. This can improve alignment against sources containing cleanly synthesised audio.";
+    desc.minValue = 0;
+    desc.maxValue = 1;
+    desc.defaultValue = float(m_defaultDParams.noise);
+    desc.isQuantized = true;
+    desc.quantizeStep = 1;
+    list.push_back(desc);
+    
+    desc.identifier = "gradientlimit";
+    desc.name = "Gradient limit";
+    desc.description = "Limit of number of frames that will be accepted from one source without a frame from the other source being accepted";
+    desc.minValue = 1;
+    desc.maxValue = 10;
+    desc.defaultValue = float(m_defaultParams.maxRunCount);
+    desc.isQuantized = true;
+    desc.quantizeStep = 1;
+    list.push_back(desc);
+
+    desc.identifier = "zonewidth";
+    desc.name = "Search zone width";
+    desc.description = "Width of the search zone (error margin) either side of the ongoing match position, in seconds";
+    desc.minValue = 1;
+    desc.maxValue = 60;
+    desc.defaultValue = float(m_defaultParams.blockTime);
+    desc.isQuantized = true;
+    desc.quantizeStep = 1;
+    desc.unit = "s";
+    list.push_back(desc);
+
+    desc.identifier = "diagonalweight";
+    desc.name = "Diagonal weight";
+    desc.description = "Weight applied to cost of diagonal step relative to horizontal or vertical step. The default of 2.0 is good for gross tracking of quite different performances; closer to 1.0 produces a smoother path for performances more similar in tempo";
+    desc.minValue = 1.0;
+    desc.maxValue = 2.0;
+    desc.defaultValue = float(m_defaultParams.diagonalWeight);
+    desc.isQuantized = false;
+    desc.unit = "";
+    list.push_back(desc);
+    
+    desc.identifier = "smooth";
+    desc.name = "Use path smoothing";
+    desc.description = "Smooth the path by replacing steps with diagonals. (This was enabled by default in earlier versions of the MATCH plugin, but the default now is to produce an un-smoothed path.)";
+    desc.minValue = 0;
+    desc.maxValue = 1;
+    desc.defaultValue = 0;
+    desc.isQuantized = true;
+    desc.quantizeStep = 1;
+    desc.unit = "";
+    list.push_back(desc);
+
+    desc.identifier = "serialise";
+    desc.name = "Serialise plugin invocations";
+    desc.description = "Reduce potential memory load at the expense of multiprocessor performance by serialising multi-threaded plugin runs";
+    desc.minValue = 0;
+    desc.maxValue = 1;
+    desc.defaultValue = 0;
+    desc.isQuantized = true;
+    desc.quantizeStep = 1;
+    list.push_back(desc);
+    
+    return list;
+}
+
+float
+MatchTipicVampPlugin::getParameter(std::string name) const
+{
+    if (name == "serialise") {
+        return m_serialise ? 1.0 : 0.0; 
+    } else if (name == "framenorm") {
+        return float(m_fcParams.norm);
+    } else if (name == "distnorm") {
+        return float(m_dParams.norm);
+    } else if (name == "usechroma") {
+        return m_chroma ? 1.0 : 0.0;
+    } else if (name == "usespecdiff") {
+        return float(m_fcParams.order);
+    } else if (name == "gradientlimit") {
+        return float(m_params.maxRunCount);
+    } else if (name == "diagonalweight") {
+        return float(m_params.diagonalWeight);
+    } else if (name == "zonewidth") {
+        return float(m_params.blockTime);
+    } else if (name == "smooth") {
+        return m_smooth ? 1.0 : 0.0;
+    } else if (name == "silencethreshold") {
+        return float(m_fcParams.silenceThreshold);
+    } else if (name == "metric") {
+        return float(m_dParams.metric);
+    } else if (name == "noise") {
+        return m_dParams.noise;
+    } else if (name == "scale") {
+        return float(m_dParams.scale);
+    } else if (name == "freq1") {
+        return float(m_frequencyReference);
+    } else if (name == "freq2") {
+        return float(m_frequencyOther);
+    }
+    
+    return 0.0;
+}
+
+void
+MatchTipicVampPlugin::setParameter(std::string name, float value)
+{
+    if (name == "serialise") {
+        m_serialise = (value > 0.5);
+    } else if (name == "framenorm") {
+        m_fcParams.norm = FeatureConditioner::Normalisation(int(value + 0.1));
+    } else if (name == "distnorm") {
+        m_dParams.norm = DistanceMetric::DistanceNormalisation(int(value + 0.1));
+    } else if (name == "usechroma") {
+        m_chroma = (value > 0.5);
+    } else if (name == "usespecdiff") {
+        m_fcParams.order = FeatureConditioner::OutputOrder(int(value + 0.1));
+    } else if (name == "gradientlimit") {
+        m_params.maxRunCount = int(value + 0.1);
+    } else if (name == "diagonalweight") {
+        m_params.diagonalWeight = value;
+    } else if (name == "zonewidth") {
+        m_params.blockTime = value;
+    } else if (name == "smooth") {
+        m_smooth = (value > 0.5);
+    } else if (name == "silencethreshold") {
+        m_fcParams.silenceThreshold = value;
+    } else if (name == "metric") {
+        m_dParams.metric = DistanceMetric::Metric(int(value + 0.1));
+    } else if (name == "noise") {
+        m_dParams.noise = DistanceMetric::NoiseAddition(int(value + 0.1));
+    } else if (name == "scale") {
+        m_dParams.scale = value;
+    } else if (name == "freq1") {
+        m_frequencyReference = value;
+    } else if (name == "freq2") {
+        m_frequencyOther = value;
+    }
+}
+
+size_t
+MatchTipicVampPlugin::getPreferredStepSize() const
+{
+    return 0;
+}
+
+size_t
+MatchTipicVampPlugin::getPreferredBlockSize() const
+{
+    return 0;
+}
+
+bool
+MatchTipicVampPlugin::initialise(size_t channels, size_t stepSize, size_t blockSize)
+{
+    if (channels < getMinChannelCount() ||
+	channels > getMaxChannelCount()) {
+        return false;
+    }
+
+    m_stepSize = int(stepSize);
+    m_blockSize = int(blockSize);
+
+    reset();
+
+    return true;
+}
+
+void
+MatchTipicVampPlugin::reset()
+{
+    m_params.hopTime = 1.0 / PitchFilterbank::getOutputSampleRate();
+
+    delete m_filterbankReference;
+    m_filterbankReference = new PitchFilterbank
+        (int(round(m_inputSampleRate)), m_frequencyReference);
+    
+    delete m_filterbankOther;
+    m_filterbankOther = new PitchFilterbank
+        (int(round(m_inputSampleRate)), m_frequencyOther);
+
+    delete m_crp;
+    m_crp = new CRP({});
+    
+    delete m_pipeline;
+    m_pipeline = new MatchPipeline
+        (FeatureExtractor::Parameters(m_inputSampleRate),
+         m_fcParams, m_dParams, m_params);
+
+    m_begin = true;
+    m_locked = false;
+}
+
+MatchTipicVampPlugin::OutputList
+MatchTipicVampPlugin::getOutputDescriptors() const
+{
+    OutputList list;
+
+    float outRate = float(PitchFilterbank::getOutputSampleRate());
+
+    OutputDescriptor desc;
+    desc.identifier = "path";
+    desc.name = "Path";
+    desc.description = "Alignment path";
+    desc.unit = "";
+    desc.hasFixedBinCount = true;
+    desc.binCount = 1;
+    desc.hasKnownExtents = false;
+    desc.isQuantized = true;
+    desc.quantizeStep = 1;
+    desc.sampleType = OutputDescriptor::VariableSampleRate;
+    desc.sampleRate = outRate;
+    m_pathOutNo = int(list.size());
+    list.push_back(desc);
+
+    desc.identifier = "a_b";
+    desc.name = "A-B Timeline";
+    desc.description = "Timing in performance B corresponding to moments in performance A";
+    desc.unit = "sec";
+    desc.hasFixedBinCount = true;
+    desc.binCount = 1;
+    desc.hasKnownExtents = false;
+    desc.isQuantized = false;
+    desc.sampleType = OutputDescriptor::VariableSampleRate;
+    desc.sampleRate = outRate;
+    m_abOutNo = int(list.size());
+    list.push_back(desc);
+
+    desc.identifier = "b_a";
+    desc.name = "B-A Timeline";
+    desc.description = "Timing in performance A corresponding to moments in performance B";
+    desc.unit = "sec";
+    desc.hasFixedBinCount = true;
+    desc.binCount = 1;
+    desc.hasKnownExtents = false;
+    desc.isQuantized = false;
+    desc.sampleType = OutputDescriptor::VariableSampleRate;
+    desc.sampleRate = outRate;
+    m_baOutNo = int(list.size());
+    list.push_back(desc);
+
+    desc.identifier = "a_b_divergence";
+    desc.name = "A-B Divergence";
+    desc.description = "Difference between timings in performances A and B";
+    desc.unit = "sec";
+    desc.hasFixedBinCount = true;
+    desc.binCount = 1;
+    desc.hasKnownExtents = false;
+    desc.isQuantized = false;
+    desc.sampleType = OutputDescriptor::VariableSampleRate;
+    desc.sampleRate = outRate;
+    m_abDivOutNo = int(list.size());
+    list.push_back(desc);
+
+    desc.identifier = "a_b_temporatio";
+    desc.name = "A-B Tempo Ratio";
+    desc.description = "Ratio of tempi between performances A and B";
+    desc.unit = "";
+    desc.hasFixedBinCount = true;
+    desc.binCount = 1;
+    desc.hasKnownExtents = false;
+    desc.isQuantized = false;
+    desc.sampleType = OutputDescriptor::VariableSampleRate;
+    desc.sampleRate = outRate;
+    m_abRatioOutNo = int(list.size());
+    list.push_back(desc);
+
+    //!!! not true of non-chroma feature, of course! so any
+    //!!! visualisation will be lacking most values
+    int featureSize = 12;
+    
+    desc.identifier = "a_features";
+    desc.name = "Raw A Features";
+    desc.description = "Features extracted from performance A";
+    desc.unit = "";
+    desc.hasFixedBinCount = true;
+    desc.binCount = featureSize;
+    desc.hasKnownExtents = false;
+    desc.isQuantized = false;
+    desc.sampleType = OutputDescriptor::FixedSampleRate;
+    desc.sampleRate = outRate;
+    m_aFeaturesOutNo = int(list.size());
+    list.push_back(desc);
+
+    desc.identifier = "b_features";
+    desc.name = "Raw B Features";
+    desc.description = "Features extracted from performance B";
+    desc.unit = "";
+    desc.hasFixedBinCount = true;
+    desc.binCount = featureSize;
+    desc.hasKnownExtents = false;
+    desc.isQuantized = false;
+    desc.sampleType = OutputDescriptor::FixedSampleRate;
+    desc.sampleRate = outRate;
+    m_bFeaturesOutNo = int(list.size());
+    list.push_back(desc);
+
+    desc.identifier = "a_cfeatures";
+    desc.name = "Conditioned A Features";
+    desc.description = "Features extracted from performance A, after normalisation and conditioning";
+    desc.unit = "";
+    desc.hasFixedBinCount = true;
+    desc.binCount = featureSize;
+    desc.hasKnownExtents = false;
+    desc.isQuantized = false;
+    desc.sampleType = OutputDescriptor::FixedSampleRate;
+    desc.sampleRate = outRate;
+    m_caFeaturesOutNo = int(list.size());
+    list.push_back(desc);
+
+    desc.identifier = "b_cfeatures";
+    desc.name = "Conditioned B Features";
+    desc.description = "Features extracted from performance B, after normalisation and conditioning";
+    desc.unit = "";
+    desc.hasFixedBinCount = true;
+    desc.binCount = featureSize;
+    desc.hasKnownExtents = false;
+    desc.isQuantized = false;
+    desc.sampleType = OutputDescriptor::FixedSampleRate;
+    desc.sampleRate = outRate;
+    m_cbFeaturesOutNo = int(list.size());
+    list.push_back(desc);
+
+    desc.identifier = "overall_cost";
+    desc.name = "Overall Cost";
+    desc.description = "Normalised overall path cost for the cheapest path";
+    desc.unit = "";
+    desc.hasFixedBinCount = true;
+    desc.binCount = 1;
+    desc.hasKnownExtents = false;
+    desc.isQuantized = false;
+    desc.sampleType = OutputDescriptor::FixedSampleRate;
+    desc.sampleRate = 1;
+    m_overallCostOutNo = int(list.size());
+    list.push_back(desc);
+    
+    return list;
+}
+
+MatchTipicVampPlugin::FeatureSet
+MatchTipicVampPlugin::process(const float *const *inputBuffers,
+                              Vamp::RealTime timestamp)
+{
+    if (m_begin) {
+        if (!m_locked && m_serialise) {
+            m_locked = true;
+#ifdef _WIN32
+            WaitForSingleObject(m_serialisingMutex, INFINITE);
+#else
+            pthread_mutex_lock(&m_serialisingMutex);
+#endif
+        }
+        m_startTime = timestamp;
+        m_begin = false;
+    }
+    
+//    std::cerr << timestamp.toString();
+
+    RealSequence in;
+    in.resize(m_blockSize);
+
+    for (int i = 0; i < m_blockSize; ++i) {
+	in[i] = inputBuffers[0][i];
+    }
+    RealBlock pitchReference = m_filterbankReference->process(in);
+    for (const auto &c: pitchReference) {
+        m_pendingPitchFeaturesReference.push_back(c);
+    }
+    
+    for (int i = 0; i < m_blockSize; ++i) {
+	in[i] = inputBuffers[1][i];
+    }
+    RealBlock pitchOther = m_filterbankOther->process(in);
+    for (const auto &c: pitchOther) {
+        m_pendingPitchFeaturesOther.push_back(c);
+    }
+
+    FeatureSet returnFeatures;
+
+    feature_t f1, f2;
+    int featureSize = 0;
+    
+    while (!m_pendingPitchFeaturesReference.empty() &&
+           !m_pendingPitchFeaturesOther.empty()) {
+
+        RealColumn reference, other;
+        
+        RealColumn col = m_pendingPitchFeaturesReference.front();
+        m_pendingPitchFeaturesReference.pop_front();
+
+        if (m_chroma) {
+            reference = m_crp->process(col);
+        } else {
+            reference = col;
+        }
+        
+        col = m_pendingPitchFeaturesOther.front();
+        m_pendingPitchFeaturesOther.pop_front();
+
+        if (m_chroma) {
+            other = m_crp->process(col);
+        } else {
+            other = col;
+        }
+
+        if (featureSize == 0) {
+            featureSize = int(reference.size());
+            f1.resize(featureSize);
+            f2.resize(featureSize);
+        }
+        
+        for (int i = 0; i < featureSize; ++i) {
+            f1[i] = float(reference[i]);
+            f2[i] = float(other[i]);
+        }
+        m_pipeline->feedFeatures(f1, f2);
+
+        feature_t cf1, cf2;
+        m_pipeline->extractConditionedFeatures(cf1, cf2);
+
+        Feature f;
+        f.hasTimestamp = false;
+
+        f.values.clear();
+        for (auto v: f1) f.values.push_back(float(v));
+        returnFeatures[m_aFeaturesOutNo].push_back(f);
+
+        f.values.clear();
+        for (auto v: f2) f.values.push_back(float(v));
+        returnFeatures[m_bFeaturesOutNo].push_back(f);
+
+        f.values.clear();
+        for (auto v: cf1) f.values.push_back(float(v));
+        returnFeatures[m_caFeaturesOutNo].push_back(f);
+
+        f.values.clear();
+        for (auto v: cf2) f.values.push_back(float(v));
+        returnFeatures[m_cbFeaturesOutNo].push_back(f);
+    }
+
+//    std::cerr << ".";
+//    std::cerr << std::endl;
+
+    return returnFeatures;
+}
+
+MatchTipicVampPlugin::FeatureSet
+MatchTipicVampPlugin::getRemainingFeatures()
+{
+    m_pipeline->finish();
+
+    FeatureSet returnFeatures;
+    
+    std::vector<int> pathx;
+    std::vector<int> pathy;
+    int len = m_pipeline->retrievePath(m_smooth, pathx, pathy);
+
+    double cost = m_pipeline->getOverallCost();
+    Feature costFeature;
+    costFeature.hasTimestamp = false;
+    costFeature.values.push_back(float(cost));
+    returnFeatures[m_overallCostOutNo].push_back(costFeature);
+    
+    int prevx = 0;
+    int prevy = 0;
+
+    for (int i = 0; i < len; ++i) {
+
+        int x = pathx[i];
+        int y = pathy[i];
+
+        Vamp::RealTime xt = Vamp::RealTime::fromSeconds
+            (x / PitchFilterbank::getOutputSampleRate());
+        Vamp::RealTime yt = Vamp::RealTime::fromSeconds
+            (y / PitchFilterbank::getOutputSampleRate());
+
+        Feature feature;
+        feature.hasTimestamp = true;
+        feature.timestamp = m_startTime + xt;
+        feature.values.clear();
+        feature.values.push_back(float(yt.sec + double(yt.nsec)/1.0e9));
+        returnFeatures[m_pathOutNo].push_back(feature);
+        
+        if (x != prevx) {
+
+            feature.hasTimestamp = true;
+            feature.timestamp = m_startTime + xt;
+            feature.values.clear();
+            feature.values.push_back(float(yt.sec + yt.msec()/1000.0));
+            returnFeatures[m_abOutNo].push_back(feature);
+
+            Vamp::RealTime diff = yt - xt;
+            feature.values.clear();
+            feature.values.push_back(float(diff.sec + diff.msec()/1000.0));
+            returnFeatures[m_abDivOutNo].push_back(feature);
+
+            if (i > 0) {
+                int lookback = 100; //!!! arbitrary
+                if (lookback > i) lookback = i;
+                int xdiff = x - pathx[i-lookback];
+                int ydiff = y - pathy[i-lookback];
+                if (xdiff != 0 && ydiff != 0) {
+                    float ratio = float(ydiff)/float(xdiff);
+                    if (ratio < 8 && ratio > (1.0/8)) { //!!! just for now, since we aren't dealing properly with silence yet
+                        feature.values.clear();
+                        feature.values.push_back(ratio);
+                        returnFeatures[m_abRatioOutNo].push_back(feature);
+                    }
+                }
+            }
+        }
+
+        if (y != prevy) {
+            feature.hasTimestamp = true;
+            feature.timestamp = m_startTime + yt;
+            feature.values.clear();
+            feature.values.push_back(float(xt.sec + xt.msec()/1000.0));
+            returnFeatures[m_baOutNo].push_back(feature);
+        }
+
+        prevx = x;
+        prevy = y;
+    }
+
+    delete m_pipeline;
+    m_pipeline = 0;
+
+    if (m_locked) {
+#ifdef _WIN32
+        ReleaseMutex(m_serialisingMutex);
+#else
+        pthread_mutex_unlock(&m_serialisingMutex);
+#endif
+        m_locked = false;
+    }
+
+    return returnFeatures;
+    
+
+/*
+    for (int i = 0; i < len; ++i) {
+        std::cerr << i << ": [" << pathx[i] << "," << pathy[i] << "]" << std::endl;
+    }
+
+    std::cerr << std::endl;
+    std::cerr << "File: A" << std::endl;
+    std::cerr << "Marks: -1" << std::endl;
+    std::cerr << "FixedPoints: true 0" << std::endl;
+    std::cerr << "0" << std::endl;
+    std::cerr << "0" << std::endl;
+    std::cerr << "0" << std::endl;
+    std::cerr << "0" << std::endl;
+    std::cerr << "File: B" << std::endl;
+    std::cerr << "Marks: 0" << std::endl;
+    std::cerr << "FixedPoints: true 0" << std::endl;
+    std::cerr << "0.02" << std::endl;
+    std::cerr << "0.02" << std::endl;
+
+    std::cerr << len << std::endl;
+    for (int i = 0; i < len; ++i) {
+        std::cerr << pathx[i] << std::endl;
+    }
+
+    std::cerr << len << std::endl;
+    for (int i = 0; i < len; ++i) {
+        std::cerr << pathy[i] << std::endl;
+    }
+*/
+}
+
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/src/MatchTipicVampPlugin.h	Thu Aug 15 16:25:48 2019 +0100
@@ -0,0 +1,121 @@
+/* -*- c-basic-offset: 4 indent-tabs-mode: nil -*-  vi:set ts=8 sts=4 sw=4: */
+
+/*
+    Vamp feature extraction plugin using the MATCH audio alignment
+    algorithm with TIPIC features.
+
+    Centre for Digital Music, Queen Mary, University of London.
+    Copyright (c) 2007-2019 Simon Dixon, Chris Cannam, and Queen Mary
+    University of London, Copyright (c) 2014-2015 Tido GmbH.
+
+    This program is free software; you can redistribute it and/or
+    modify it under the terms of the GNU General Public License as
+    published by the Free Software Foundation; either version 2 of the
+    License, or (at your option) any later version.  See the file
+    COPYING included with this distribution for more information.
+*/
+
+#ifndef MATCH_TIPIC_VAMP_PLUGIN_H
+#define MATCH_TIPIC_VAMP_PLUGIN_H
+
+#include <vamp-sdk/Plugin.h>
+
+#ifdef _WIN32
+#include <windows.h>
+#else
+#include <pthread.h>
+#endif
+
+#include "MatchPipeline.h"
+
+// TIPIC headers
+#include "PitchFilterbank.h"
+#include "CRP.h"
+
+class MatchTipicVampPlugin : public Vamp::Plugin
+{
+public:
+    MatchTipicVampPlugin(float inputSampleRate);
+    virtual ~MatchTipicVampPlugin();
+
+    bool initialise(size_t channels, size_t stepSize, size_t blockSize);
+    void reset();
+
+    InputDomain getInputDomain() const { return TimeDomain; }
+
+    size_t getPreferredStepSize() const;
+    size_t getPreferredBlockSize() const;
+
+    size_t getMinChannelCount() const { return 2; }
+    size_t getMaxChannelCount() const { return 2; }
+
+    std::string getIdentifier() const;
+    std::string getName() const;
+    std::string getDescription() const;
+    std::string getMaker() const;
+    int getPluginVersion() const;
+    std::string getCopyright() const;
+
+    ParameterList getParameterDescriptors() const;
+    float getParameter(std::string) const;
+    void setParameter(std::string, float);
+
+    OutputList getOutputDescriptors() const;
+
+    FeatureSet process(const float *const *inputBuffers,
+                       Vamp::RealTime timestamp);
+
+    FeatureSet getRemainingFeatures();
+
+protected:
+    Vamp::RealTime m_startTime;
+    int m_stepSize;
+    int m_blockSize;
+    bool m_serialise;
+    bool m_begin;
+    bool m_locked;
+    bool m_smooth;
+    bool m_chroma;
+    float m_frequencyReference;
+    float m_frequencyOther;
+
+    Matcher::Parameters m_params;
+    Matcher::Parameters m_defaultParams;
+
+    FeatureConditioner::Parameters m_fcParams;
+    FeatureConditioner::Parameters m_defaultFcParams;
+
+    DistanceMetric::Parameters m_dParams;
+    DistanceMetric::Parameters m_defaultDParams;
+
+    PitchFilterbank *m_filterbankReference;
+    PitchFilterbank *m_filterbankOther;
+
+    std::deque<RealColumn> m_pendingPitchFeaturesReference;
+    std::deque<RealColumn> m_pendingPitchFeaturesOther;
+
+    CRP *m_crp;
+    MatchPipeline *m_pipeline;
+    
+    mutable int m_pathOutNo;
+    mutable int m_abOutNo;
+    mutable int m_baOutNo;
+    mutable int m_abDivOutNo;
+    mutable int m_abRatioOutNo;
+    mutable int m_aFeaturesOutNo;
+    mutable int m_bFeaturesOutNo;
+    mutable int m_caFeaturesOutNo;
+    mutable int m_cbFeaturesOutNo;
+    mutable int m_overallCostOutNo;
+
+#ifdef _WIN32
+    static HANDLE m_serialisingMutex;
+#else 
+    static pthread_mutex_t m_serialisingMutex;
+#endif
+
+    static bool m_serialisingMutexInitialised;
+};
+
+
+#endif
--- a/src/MatchVampPlugin.cpp	Fri Jun 10 13:56:05 2016 +0100
+++ b/src/MatchVampPlugin.cpp	Thu Aug 15 16:25:48 2019 +0100
@@ -17,13 +17,7 @@
 
 #include "MatchVampPlugin.h"
 
-#include "Matcher.h"
-#include "MatchFeatureFeeder.h"
-#include "FeatureExtractor.h"
-#include "Path.h"
-
 #include <vamp/vamp.h>
-#include <vamp-sdk/PluginAdapter.h>
 #include <vamp-sdk/RealTime.h>
 
 #include <vector>
@@ -58,7 +52,6 @@
     m_begin(true),
     m_locked(false),
     m_smooth(false),
-    m_frameNo(0),
     m_params(defaultStepTime),
     m_defaultParams(defaultStepTime),
     m_feParams(inputSampleRate),
@@ -480,7 +473,6 @@
 {
     delete m_pipeline;
     m_pipeline = 0;
-    m_frameNo = 0;
     createMatchers();
     m_begin = true;
     m_locked = false;
@@ -603,7 +595,7 @@
 
     desc.identifier = "b_cfeatures";
     desc.name = "Conditioned B Features";
-    desc.description = "Spectral features extracted from performance B, after norrmalisation and conditioning";
+    desc.description = "Spectral features extracted from performance B, after normalisation and conditioning";
     desc.unit = "";
     desc.hasFixedBinCount = true;
     desc.binCount = featureSize;
@@ -681,8 +673,6 @@
 //    std::cerr << ".";
 //    std::cerr << std::endl;
 
-    ++m_frameNo;
-    
     return returnFeatures;
 }
 
@@ -809,16 +799,3 @@
     }
 */
 }
-
-static Vamp::PluginAdapter<MatchVampPlugin> mvpAdapter;
-
-const VampPluginDescriptor *vampGetPluginDescriptor(unsigned int version,
-                                                    unsigned int index)
-{
-    if (version < 1) return 0;
-
-    switch (index) {
-    case  0: return mvpAdapter.getDescriptor();
-    default: return 0;
-    }
-}
--- a/src/MatchVampPlugin.h	Fri Jun 10 13:56:05 2016 +0100
+++ b/src/MatchVampPlugin.h	Thu Aug 15 16:25:48 2019 +0100
@@ -65,7 +65,6 @@
 
 protected:
     void createMatchers();
-    bool aboveThreshold(const float *);
 
     MatchPipeline *m_pipeline;
 
@@ -78,8 +77,6 @@
     bool m_locked;
     bool m_smooth;
 
-    int m_frameNo;
-    
     Matcher::Parameters m_params;
     Matcher::Parameters m_defaultParams;
 
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/src/libmain.cpp	Thu Aug 15 16:25:48 2019 +0100
@@ -0,0 +1,20 @@
+
+#include "MatchVampPlugin.h"
+#include "MatchTipicVampPlugin.h"
+
+#include <vamp-sdk/PluginAdapter.h>
+
+static Vamp::PluginAdapter<MatchVampPlugin> mvpAdapter;
+static Vamp::PluginAdapter<MatchTipicVampPlugin> mtvpAdapter;
+
+const VampPluginDescriptor *vampGetPluginDescriptor(unsigned int version,
+                                                    unsigned int index)
+{
+    if (version < 1) return 0;
+
+    switch (index) {
+    case  0: return mvpAdapter.getDescriptor();
+    case  1: return mtvpAdapter.getDescriptor();
+    default: return 0;
+    }
+}