Chris@0
|
1 <?php
|
Chris@0
|
2 /**
|
Chris@0
|
3 * Drupal_Sniffs_FunctionCalls_DbQuerySniff
|
Chris@0
|
4 *
|
Chris@0
|
5 * @category PHP
|
Chris@0
|
6 * @package PHP_CodeSniffer
|
Chris@0
|
7 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
8 */
|
Chris@0
|
9
|
Chris@0
|
10 /**
|
Chris@0
|
11 * Check that UPDATE/DELETE queries are not used in db_query() in Drupal 7.
|
Chris@0
|
12 *
|
Chris@0
|
13 * @category PHP
|
Chris@0
|
14 * @package PHP_CodeSniffer
|
Chris@0
|
15 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
16 */
|
Chris@0
|
17 class DrupalPractice_Sniffs_FunctionCalls_DbQuerySniff extends Drupal_Sniffs_Semantics_FunctionCall
|
Chris@0
|
18 {
|
Chris@0
|
19
|
Chris@0
|
20
|
Chris@0
|
21 /**
|
Chris@0
|
22 * Returns an array of function names this test wants to listen for.
|
Chris@0
|
23 *
|
Chris@0
|
24 * @return array
|
Chris@0
|
25 */
|
Chris@0
|
26 public function registerFunctionNames()
|
Chris@0
|
27 {
|
Chris@0
|
28 return array('db_query');
|
Chris@0
|
29
|
Chris@0
|
30 }//end registerFunctionNames()
|
Chris@0
|
31
|
Chris@0
|
32
|
Chris@0
|
33 /**
|
Chris@0
|
34 * Processes this function call.
|
Chris@0
|
35 *
|
Chris@0
|
36 * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
|
Chris@0
|
37 * @param int $stackPtr The position of the function call in
|
Chris@0
|
38 * the stack.
|
Chris@0
|
39 * @param int $openBracket The position of the opening
|
Chris@0
|
40 * parenthesis in the stack.
|
Chris@0
|
41 * @param int $closeBracket The position of the closing
|
Chris@0
|
42 * parenthesis in the stack.
|
Chris@0
|
43 *
|
Chris@0
|
44 * @return void
|
Chris@0
|
45 */
|
Chris@0
|
46 public function processFunctionCall(
|
Chris@0
|
47 PHP_CodeSniffer_File $phpcsFile,
|
Chris@0
|
48 $stackPtr,
|
Chris@0
|
49 $openBracket,
|
Chris@0
|
50 $closeBracket
|
Chris@0
|
51 ) {
|
Chris@0
|
52 // This check only applies to Drupal 7, not Drupal 6.
|
Chris@0
|
53 if (DrupalPractice_Project::getCoreVersion($phpcsFile) !== '7.x') {
|
Chris@0
|
54 return;
|
Chris@0
|
55 }
|
Chris@0
|
56
|
Chris@0
|
57 $tokens = $phpcsFile->getTokens();
|
Chris@0
|
58 $argument = $this->getArgument(1);
|
Chris@0
|
59
|
Chris@0
|
60 $query_start = '';
|
Chris@0
|
61 for ($start = $argument['start']; $tokens[$start]['code'] === T_CONSTANT_ENCAPSED_STRING && empty($query_start) === true; $start++) {
|
Chris@0
|
62 // Remove quote and white space from the beginning.
|
Chris@0
|
63 $query_start = trim(substr($tokens[$start]['content'], 1));
|
Chris@0
|
64 // Just look at the first word.
|
Chris@0
|
65 $parts = explode(' ', $query_start);
|
Chris@0
|
66 $query_start = $parts[0];
|
Chris@0
|
67
|
Chris@0
|
68 if (in_array(strtoupper($query_start), array('INSERT', 'UPDATE', 'DELETE', 'TRUNCATE')) === true) {
|
Chris@0
|
69 $warning = 'Do not use %s queries with db_query(), use %s instead';
|
Chris@0
|
70 $phpcsFile->addWarning($warning, $start, 'DbQuery', array($query_start, 'db_'.strtolower($query_start).'()'));
|
Chris@0
|
71 }
|
Chris@0
|
72 }
|
Chris@0
|
73
|
Chris@0
|
74 }//end processFunctionCall()
|
Chris@0
|
75
|
Chris@0
|
76
|
Chris@0
|
77 }//end class
|