Chris@0
|
1 <?php
|
Chris@0
|
2
|
Chris@0
|
3 namespace Drupal\image\Tests;
|
Chris@0
|
4
|
Chris@0
|
5 use Drupal\image\Entity\ImageStyle;
|
Chris@0
|
6 use Drupal\simpletest\WebTestBase;
|
Chris@0
|
7
|
Chris@0
|
8 /**
|
Chris@0
|
9 * Tests the functions for generating paths and URLs for image styles.
|
Chris@0
|
10 *
|
Chris@0
|
11 * @group image
|
Chris@0
|
12 */
|
Chris@0
|
13 class ImageStylesPathAndUrlTest extends WebTestBase {
|
Chris@0
|
14
|
Chris@0
|
15 /**
|
Chris@0
|
16 * Modules to enable.
|
Chris@0
|
17 *
|
Chris@0
|
18 * @var array
|
Chris@0
|
19 */
|
Chris@0
|
20 public static $modules = ['image', 'image_module_test'];
|
Chris@0
|
21
|
Chris@0
|
22 /**
|
Chris@0
|
23 * @var \Drupal\image\ImageStyleInterface
|
Chris@0
|
24 */
|
Chris@0
|
25 protected $style;
|
Chris@0
|
26
|
Chris@0
|
27 protected function setUp() {
|
Chris@0
|
28 parent::setUp();
|
Chris@0
|
29
|
Chris@0
|
30 $this->style = ImageStyle::create(['name' => 'style_foo', 'label' => $this->randomString()]);
|
Chris@0
|
31 $this->style->save();
|
Chris@0
|
32 }
|
Chris@0
|
33
|
Chris@0
|
34 /**
|
Chris@0
|
35 * Tests \Drupal\image\ImageStyleInterface::buildUri().
|
Chris@0
|
36 */
|
Chris@0
|
37 public function testImageStylePath() {
|
Chris@0
|
38 $scheme = 'public';
|
Chris@0
|
39 $actual = $this->style->buildUri("$scheme://foo/bar.gif");
|
Chris@0
|
40 $expected = "$scheme://styles/" . $this->style->id() . "/$scheme/foo/bar.gif";
|
Chris@0
|
41 $this->assertEqual($actual, $expected, 'Got the path for a file URI.');
|
Chris@0
|
42
|
Chris@0
|
43 $actual = $this->style->buildUri('foo/bar.gif');
|
Chris@0
|
44 $expected = "$scheme://styles/" . $this->style->id() . "/$scheme/foo/bar.gif";
|
Chris@0
|
45 $this->assertEqual($actual, $expected, 'Got the path for a relative file path.');
|
Chris@0
|
46 }
|
Chris@0
|
47
|
Chris@0
|
48 /**
|
Chris@0
|
49 * Tests an image style URL using the "public://" scheme.
|
Chris@0
|
50 */
|
Chris@0
|
51 public function testImageStyleUrlAndPathPublic() {
|
Chris@0
|
52 $this->doImageStyleUrlAndPathTests('public');
|
Chris@0
|
53 }
|
Chris@0
|
54
|
Chris@0
|
55 /**
|
Chris@0
|
56 * Tests an image style URL using the "private://" scheme.
|
Chris@0
|
57 */
|
Chris@0
|
58 public function testImageStyleUrlAndPathPrivate() {
|
Chris@0
|
59 $this->doImageStyleUrlAndPathTests('private');
|
Chris@0
|
60 }
|
Chris@0
|
61
|
Chris@0
|
62 /**
|
Chris@0
|
63 * Tests an image style URL with the "public://" scheme and unclean URLs.
|
Chris@0
|
64 */
|
Chris@0
|
65 public function testImageStyleUrlAndPathPublicUnclean() {
|
Chris@0
|
66 $this->doImageStyleUrlAndPathTests('public', FALSE);
|
Chris@0
|
67 }
|
Chris@0
|
68
|
Chris@0
|
69 /**
|
Chris@0
|
70 * Tests an image style URL with the "private://" schema and unclean URLs.
|
Chris@0
|
71 */
|
Chris@0
|
72 public function testImageStyleUrlAndPathPrivateUnclean() {
|
Chris@0
|
73 $this->doImageStyleUrlAndPathTests('private', FALSE);
|
Chris@0
|
74 }
|
Chris@0
|
75
|
Chris@0
|
76 /**
|
Chris@0
|
77 * Tests an image style URL with a file URL that has an extra slash in it.
|
Chris@0
|
78 */
|
Chris@0
|
79 public function testImageStyleUrlExtraSlash() {
|
Chris@0
|
80 $this->doImageStyleUrlAndPathTests('public', TRUE, TRUE);
|
Chris@0
|
81 }
|
Chris@0
|
82
|
Chris@0
|
83 /**
|
Chris@0
|
84 * Tests that an invalid source image returns a 404.
|
Chris@0
|
85 */
|
Chris@0
|
86 public function testImageStyleUrlForMissingSourceImage() {
|
Chris@0
|
87 $non_existent_uri = 'public://foo.png';
|
Chris@0
|
88 $generated_url = $this->style->buildUrl($non_existent_uri);
|
Chris@0
|
89 $this->drupalGet($generated_url);
|
Chris@0
|
90 $this->assertResponse(404, 'Accessing an image style URL with a source image that does not exist provides a 404 error response.');
|
Chris@0
|
91 }
|
Chris@0
|
92
|
Chris@0
|
93 /**
|
Chris@0
|
94 * Tests building an image style URL.
|
Chris@0
|
95 */
|
Chris@0
|
96 public function doImageStyleUrlAndPathTests($scheme, $clean_url = TRUE, $extra_slash = FALSE) {
|
Chris@0
|
97 $this->prepareRequestForGenerator($clean_url);
|
Chris@0
|
98
|
Chris@0
|
99 // Make the default scheme neither "public" nor "private" to verify the
|
Chris@0
|
100 // functions work for other than the default scheme.
|
Chris@0
|
101 $this->config('system.file')->set('default_scheme', 'temporary')->save();
|
Chris@0
|
102
|
Chris@0
|
103 // Create the directories for the styles.
|
Chris@0
|
104 $directory = $scheme . '://styles/' . $this->style->id();
|
Chris@0
|
105 $status = file_prepare_directory($directory, FILE_CREATE_DIRECTORY);
|
Chris@0
|
106 $this->assertNotIdentical(FALSE, $status, 'Created the directory for the generated images for the test style.');
|
Chris@0
|
107
|
Chris@0
|
108 // Create a working copy of the file.
|
Chris@0
|
109 $files = $this->drupalGetTestFiles('image');
|
Chris@0
|
110 $file = array_shift($files);
|
Chris@0
|
111 $original_uri = file_unmanaged_copy($file->uri, $scheme . '://', FILE_EXISTS_RENAME);
|
Chris@0
|
112 // Let the image_module_test module know about this file, so it can claim
|
Chris@0
|
113 // ownership in hook_file_download().
|
Chris@0
|
114 \Drupal::state()->set('image.test_file_download', $original_uri);
|
Chris@0
|
115 $this->assertNotIdentical(FALSE, $original_uri, 'Created the generated image file.');
|
Chris@0
|
116
|
Chris@0
|
117 // Get the URL of a file that has not been generated and try to create it.
|
Chris@0
|
118 $generated_uri = $this->style->buildUri($original_uri);
|
Chris@0
|
119 $this->assertFalse(file_exists($generated_uri), 'Generated file does not exist.');
|
Chris@0
|
120 $generate_url = $this->style->buildUrl($original_uri, $clean_url);
|
Chris@0
|
121
|
Chris@0
|
122 // Ensure that the tests still pass when the file is generated by accessing
|
Chris@0
|
123 // a poorly constructed (but still valid) file URL that has an extra slash
|
Chris@0
|
124 // in it.
|
Chris@0
|
125 if ($extra_slash) {
|
Chris@0
|
126 $modified_uri = str_replace('://', ':///', $original_uri);
|
Chris@0
|
127 $this->assertNotEqual($original_uri, $modified_uri, 'An extra slash was added to the generated file URI.');
|
Chris@0
|
128 $generate_url = $this->style->buildUrl($modified_uri, $clean_url);
|
Chris@0
|
129 }
|
Chris@0
|
130 if (!$clean_url) {
|
Chris@0
|
131 $this->assertTrue(strpos($generate_url, 'index.php/') !== FALSE, 'When using non-clean URLS, the system path contains the script name.');
|
Chris@0
|
132 }
|
Chris@0
|
133 // Add some extra chars to the token.
|
Chris@0
|
134 $this->drupalGet(str_replace(IMAGE_DERIVATIVE_TOKEN . '=', IMAGE_DERIVATIVE_TOKEN . '=Zo', $generate_url));
|
Chris@0
|
135 $this->assertResponse(403, 'Image was inaccessible at the URL with an invalid token.');
|
Chris@0
|
136 // Change the parameter name so the token is missing.
|
Chris@0
|
137 $this->drupalGet(str_replace(IMAGE_DERIVATIVE_TOKEN . '=', 'wrongparam=', $generate_url));
|
Chris@0
|
138 $this->assertResponse(403, 'Image was inaccessible at the URL with a missing token.');
|
Chris@0
|
139
|
Chris@0
|
140 // Check that the generated URL is the same when we pass in a relative path
|
Chris@0
|
141 // rather than a URI. We need to temporarily switch the default scheme to
|
Chris@0
|
142 // match the desired scheme before testing this, then switch it back to the
|
Chris@0
|
143 // "temporary" scheme used throughout this test afterwards.
|
Chris@0
|
144 $this->config('system.file')->set('default_scheme', $scheme)->save();
|
Chris@0
|
145 $relative_path = file_uri_target($original_uri);
|
Chris@0
|
146 $generate_url_from_relative_path = $this->style->buildUrl($relative_path, $clean_url);
|
Chris@0
|
147 $this->assertEqual($generate_url, $generate_url_from_relative_path);
|
Chris@0
|
148 $this->config('system.file')->set('default_scheme', 'temporary')->save();
|
Chris@0
|
149
|
Chris@0
|
150 // Fetch the URL that generates the file.
|
Chris@0
|
151 $this->drupalGet($generate_url);
|
Chris@0
|
152 $this->assertResponse(200, 'Image was generated at the URL.');
|
Chris@0
|
153 $this->assertTrue(file_exists($generated_uri), 'Generated file does exist after we accessed it.');
|
Chris@0
|
154 $this->assertRaw(file_get_contents($generated_uri), 'URL returns expected file.');
|
Chris@0
|
155 $image = $this->container->get('image.factory')->get($generated_uri);
|
Chris@0
|
156 $this->assertEqual($this->drupalGetHeader('Content-Type'), $image->getMimeType(), 'Expected Content-Type was reported.');
|
Chris@0
|
157 $this->assertEqual($this->drupalGetHeader('Content-Length'), $image->getFileSize(), 'Expected Content-Length was reported.');
|
Chris@0
|
158
|
Chris@0
|
159 // Check that we did not download the original file.
|
Chris@0
|
160 $original_image = $this->container->get('image.factory')->get($original_uri);
|
Chris@0
|
161 $this->assertNotEqual($this->drupalGetHeader('Content-Length'), $original_image->getFileSize());
|
Chris@0
|
162
|
Chris@0
|
163 if ($scheme == 'private') {
|
Chris@0
|
164 $this->assertEqual($this->drupalGetHeader('Expires'), 'Sun, 19 Nov 1978 05:00:00 GMT', 'Expires header was sent.');
|
Chris@0
|
165 $this->assertNotEqual(strpos($this->drupalGetHeader('Cache-Control'), 'no-cache'), FALSE, 'Cache-Control header contains \'no-cache\' to prevent caching.');
|
Chris@0
|
166 $this->assertEqual($this->drupalGetHeader('X-Image-Owned-By'), 'image_module_test', 'Expected custom header has been added.');
|
Chris@0
|
167
|
Chris@0
|
168 // Make sure that a second request to the already existing derivative
|
Chris@0
|
169 // works too.
|
Chris@0
|
170 $this->drupalGet($generate_url);
|
Chris@0
|
171 $this->assertResponse(200, 'Image was generated at the URL.');
|
Chris@0
|
172
|
Chris@0
|
173 // Check that the second request also returned the generated image.
|
Chris@0
|
174 $this->assertEqual($this->drupalGetHeader('Content-Length'), $image->getFileSize());
|
Chris@0
|
175
|
Chris@0
|
176 // Check that we did not download the original file.
|
Chris@0
|
177 $this->assertNotEqual($this->drupalGetHeader('Content-Length'), $original_image->getFileSize());
|
Chris@0
|
178
|
Chris@0
|
179 // Make sure that access is denied for existing style files if we do not
|
Chris@0
|
180 // have access.
|
Chris@0
|
181 \Drupal::state()->delete('image.test_file_download');
|
Chris@0
|
182 $this->drupalGet($generate_url);
|
Chris@0
|
183 $this->assertResponse(403, 'Confirmed that access is denied for the private image style.');
|
Chris@0
|
184
|
Chris@0
|
185 // Repeat this with a different file that we do not have access to and
|
Chris@0
|
186 // make sure that access is denied.
|
Chris@0
|
187 $file_noaccess = array_shift($files);
|
Chris@0
|
188 $original_uri_noaccess = file_unmanaged_copy($file_noaccess->uri, $scheme . '://', FILE_EXISTS_RENAME);
|
Chris@0
|
189 $generated_uri_noaccess = $scheme . '://styles/' . $this->style->id() . '/' . $scheme . '/' . drupal_basename($original_uri_noaccess);
|
Chris@0
|
190 $this->assertFalse(file_exists($generated_uri_noaccess), 'Generated file does not exist.');
|
Chris@0
|
191 $generate_url_noaccess = $this->style->buildUrl($original_uri_noaccess);
|
Chris@0
|
192
|
Chris@0
|
193 $this->drupalGet($generate_url_noaccess);
|
Chris@0
|
194 $this->assertResponse(403, 'Confirmed that access is denied for the private image style.');
|
Chris@0
|
195 // Verify that images are not appended to the response. Currently this test only uses PNG images.
|
Chris@0
|
196 if (strpos($generate_url, '.png') === FALSE) {
|
Chris@0
|
197 $this->fail('Confirming that private image styles are not appended require PNG file.');
|
Chris@0
|
198 }
|
Chris@0
|
199 else {
|
Chris@0
|
200 // Check for PNG-Signature (cf. http://www.libpng.org/pub/png/book/chapter08.html#png.ch08.div.2) in the
|
Chris@0
|
201 // response body.
|
Chris@0
|
202 $this->assertNoRaw(chr(137) . chr(80) . chr(78) . chr(71) . chr(13) . chr(10) . chr(26) . chr(10), 'No PNG signature found in the response body.');
|
Chris@0
|
203 }
|
Chris@0
|
204 }
|
Chris@0
|
205 else {
|
Chris@0
|
206 $this->assertEqual($this->drupalGetHeader('Expires'), 'Sun, 19 Nov 1978 05:00:00 GMT', 'Expires header was sent.');
|
Chris@0
|
207 $this->assertEqual(strpos($this->drupalGetHeader('Cache-Control'), 'no-cache'), FALSE, 'Cache-Control header contains \'no-cache\' to prevent caching.');
|
Chris@0
|
208
|
Chris@0
|
209 if ($clean_url) {
|
Chris@0
|
210 // Add some extra chars to the token.
|
Chris@0
|
211 $this->drupalGet(str_replace(IMAGE_DERIVATIVE_TOKEN . '=', IMAGE_DERIVATIVE_TOKEN . '=Zo', $generate_url));
|
Chris@0
|
212 $this->assertResponse(200, 'Existing image was accessible at the URL with an invalid token.');
|
Chris@0
|
213 }
|
Chris@0
|
214 }
|
Chris@0
|
215
|
Chris@0
|
216 // Allow insecure image derivatives to be created for the remainder of this
|
Chris@0
|
217 // test.
|
Chris@0
|
218 $this->config('image.settings')->set('allow_insecure_derivatives', TRUE)->save();
|
Chris@0
|
219
|
Chris@0
|
220 // Create another working copy of the file.
|
Chris@0
|
221 $files = $this->drupalGetTestFiles('image');
|
Chris@0
|
222 $file = array_shift($files);
|
Chris@0
|
223 $original_uri = file_unmanaged_copy($file->uri, $scheme . '://', FILE_EXISTS_RENAME);
|
Chris@0
|
224 // Let the image_module_test module know about this file, so it can claim
|
Chris@0
|
225 // ownership in hook_file_download().
|
Chris@0
|
226 \Drupal::state()->set('image.test_file_download', $original_uri);
|
Chris@0
|
227
|
Chris@0
|
228 // Suppress the security token in the URL, then get the URL of a file that
|
Chris@0
|
229 // has not been created and try to create it. Check that the security token
|
Chris@0
|
230 // is not present in the URL but that the image is still accessible.
|
Chris@0
|
231 $this->config('image.settings')->set('suppress_itok_output', TRUE)->save();
|
Chris@0
|
232 $generated_uri = $this->style->buildUri($original_uri);
|
Chris@0
|
233 $this->assertFalse(file_exists($generated_uri), 'Generated file does not exist.');
|
Chris@0
|
234 $generate_url = $this->style->buildUrl($original_uri, $clean_url);
|
Chris@0
|
235 $this->assertIdentical(strpos($generate_url, IMAGE_DERIVATIVE_TOKEN . '='), FALSE, 'The security token does not appear in the image style URL.');
|
Chris@0
|
236 $this->drupalGet($generate_url);
|
Chris@0
|
237 $this->assertResponse(200, 'Image was accessible at the URL with a missing token.');
|
Chris@0
|
238
|
Chris@0
|
239 // Stop supressing the security token in the URL.
|
Chris@0
|
240 $this->config('image.settings')->set('suppress_itok_output', FALSE)->save();
|
Chris@0
|
241 // Ensure allow_insecure_derivatives is enabled.
|
Chris@0
|
242 $this->assertEqual($this->config('image.settings')->get('allow_insecure_derivatives'), TRUE);
|
Chris@0
|
243 // Check that a security token is still required when generating a second
|
Chris@0
|
244 // image derivative using the first one as a source.
|
Chris@0
|
245 $nested_url = $this->style->buildUrl($generated_uri, $clean_url);
|
Chris@0
|
246 $matches_expected_url_format = (boolean) preg_match('/styles\/' . $this->style->id() . '\/' . $scheme . '\/styles\/' . $this->style->id() . '\/' . $scheme . '/', $nested_url);
|
Chris@0
|
247 $this->assertTrue($matches_expected_url_format, "URL for a derivative of an image style matches expected format.");
|
Chris@0
|
248 $nested_url_with_wrong_token = str_replace(IMAGE_DERIVATIVE_TOKEN . '=', 'wrongparam=', $nested_url);
|
Chris@0
|
249 $this->drupalGet($nested_url_with_wrong_token);
|
Chris@0
|
250 $this->assertResponse(403, 'Image generated from an earlier derivative was inaccessible at the URL with a missing token.');
|
Chris@0
|
251 // Check that this restriction cannot be bypassed by adding extra slashes
|
Chris@0
|
252 // to the URL.
|
Chris@0
|
253 $this->drupalGet(substr_replace($nested_url_with_wrong_token, '//styles/', strrpos($nested_url_with_wrong_token, '/styles/'), strlen('/styles/')));
|
Chris@0
|
254 $this->assertResponse(403, 'Image generated from an earlier derivative was inaccessible at the URL with a missing token, even with an extra forward slash in the URL.');
|
Chris@0
|
255 $this->drupalGet(substr_replace($nested_url_with_wrong_token, '////styles/', strrpos($nested_url_with_wrong_token, '/styles/'), strlen('/styles/')));
|
Chris@0
|
256 $this->assertResponse(403, 'Image generated from an earlier derivative was inaccessible at the URL with a missing token, even with multiple forward slashes in the URL.');
|
Chris@0
|
257 // Make sure the image can still be generated if a correct token is used.
|
Chris@0
|
258 $this->drupalGet($nested_url);
|
Chris@0
|
259 $this->assertResponse(200, 'Image was accessible when a correct token was provided in the URL.');
|
Chris@0
|
260
|
Chris@0
|
261 // Check that requesting a nonexistent image does not create any new
|
Chris@0
|
262 // directories in the file system.
|
Chris@0
|
263 $directory = $scheme . '://styles/' . $this->style->id() . '/' . $scheme . '/' . $this->randomMachineName();
|
Chris@0
|
264 $this->drupalGet(file_create_url($directory . '/' . $this->randomString()));
|
Chris@0
|
265 $this->assertFalse(file_exists($directory), 'New directory was not created in the filesystem when requesting an unauthorized image.');
|
Chris@0
|
266 }
|
Chris@0
|
267
|
Chris@0
|
268 }
|