Mercurial > hg > audiodb
view status.cpp @ 402:58b88ab69424 api-inversion
Move the struct adb definition from the auidioDB_API.h into the
audioDB-internals.h header file, leaving only the typedef behind.
Thus a user of the API sees only an incomplete type, which cannot be
instantiated (but /pointers/ to it can); there's then less temptation to
break the abstraction barrier by using structure fields in client code.
Not only that, but we can now safely put C++ stuff in the structure.
Take advantage of this by putting a std::set<std::string> in there, to
hold all the keys currently in the database; populate this field on
audiodb_open() (and delete it on audiodb_close). This will be useful
when we come to implement variants of audiodb_insert().
author | mas01cr |
---|---|
date | Wed, 03 Dec 2008 17:40:15 +0000 |
parents | a65b31660804 |
children | 62a0515f59be |
line wrap: on
line source
#include "audioDB.h" extern "C" { #include "audioDB_API.h" #include "audioDB-internals.h" } int audiodb_status(adb_t *adb, adb_status_t *status) { /* FIXME: it would be nice to be able to test for "is this database pointer valid", but at the moment we punt that to memory discipline. */ unsigned dudCount = 0; unsigned nullCount = 0; size_t trackTableLength = ALIGN_PAGE_UP(adb->header->numFiles * O2_TRACKTABLE_ENTRY_SIZE); unsigned *trackTable = 0; void *tmp = 0; if (adb->header->length > 0) { tmp = mmap(0, trackTableLength, PROT_READ, MAP_SHARED, adb->fd, adb->header->trackTableOffset); if (tmp == (void *) -1) { return 1; } trackTable = (unsigned *) tmp; } for(unsigned k = 0; k < adb->header->numFiles; k++) { /* FIXME: this bare "16" here reveals a problem (or maybe two). * 16 here means the default value of the sequenceLength parameter * initializer (both in C++ and corresponding to the "-l" or * "--sequencelength" command-line argument). * * The problem is that the API as currently designed provides no * way to pass that information in to this routine; there's no * input parameter; nor is there in the SOAP version of this * query. However, there /is/ a way to pass that information on * the command-line -- though that codepath is completely * untested. I can see that it might be useful to provide this * information, but at present it's probably completely unused, so * the compromise for now is to hardwire the 16. */ if(trackTable[k] < 16) { dudCount++; if(!trackTable[k]) { nullCount++; } } } if(adb->header->length > 0) { if(munmap(trackTable, trackTableLength)) { return 1; } } status->numFiles = adb->header->numFiles; status->dim = adb->header->dim; status->length = adb->header->length; status->dudCount = dudCount; status->nullCount = nullCount; status->flags = adb->header->flags; status->data_region_size = adb->header->timesTableOffset - adb->header->dataOffset; return 0; }