Mercurial > hg > audiodb
comparison status.cpp @ 402:58b88ab69424 api-inversion
Move the struct adb definition from the auidioDB_API.h into the
audioDB-internals.h header file, leaving only the typedef behind.
Thus a user of the API sees only an incomplete type, which cannot be
instantiated (but /pointers/ to it can); there's then less temptation to
break the abstraction barrier by using structure fields in client code.
Not only that, but we can now safely put C++ stuff in the structure.
Take advantage of this by putting a std::set<std::string> in there, to
hold all the keys currently in the database; populate this field on
audiodb_open() (and delete it on audiodb_close). This will be useful
when we come to implement variants of audiodb_insert().
author | mas01cr |
---|---|
date | Wed, 03 Dec 2008 17:40:15 +0000 |
parents | a65b31660804 |
children | 62a0515f59be |
comparison
equal
deleted
inserted
replaced
401:a8a5f2ca5380 | 402:58b88ab69424 |
---|---|
1 #include "audioDB.h" | 1 #include "audioDB.h" |
2 extern "C" { | 2 extern "C" { |
3 #include "audioDB_API.h" | 3 #include "audioDB_API.h" |
4 #include "audioDB-internals.h" | |
4 } | 5 } |
5 | 6 |
6 int audiodb_status(adb_t *adb, adb_status_t *status) { | 7 int audiodb_status(adb_t *adb, adb_status_t *status) { |
7 /* FIXME: it would be nice to be able to test for "is this database | 8 /* FIXME: it would be nice to be able to test for "is this database |
8 pointer valid", but at the moment we punt that to memory | 9 pointer valid", but at the moment we punt that to memory |