changeset 306:d70ff27b1968

add note about linked-events mixin Ignore-this: c5677560055960b06b1689b7a89f6d39 darcs-hash:20100404210537-16a00-7ca82f871410639d74103e352ecad60979a128c9.gz
author j.forth <j.forth@gold.ac.uk>
date Sun, 04 Apr 2010 22:05:37 +0100
parents 39f5fc572953
children a85c59bcd88b
files base/classes.lisp
diffstat 1 files changed, 13 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/base/classes.lisp	Sat Oct 24 18:06:12 2009 +0100
+++ b/base/classes.lisp	Sun Apr 04 22:05:37 2010 +0100
@@ -84,7 +84,19 @@
   ((composition :reader composition
 		:writer %set-composition
 		:initarg :composition))
-  (:documentation "This provides a composition slot for events."))
+  (:documentation "This provides a composition slot for events. The
+  generic function initialize-instance can be specialized on an
+  implementation composition to assign the event slots when a
+  composition instance is created. Or the slot can be assigned within
+  the composition constructor function. FIXME: Not sure about this -
+  was there a good reason why events should not know the composition
+  they belong to? MTP-events have a slot for composition-id (an
+  integer number), but here the slot is intended to be assigned the
+  composition object itself. Doing this means that potentially some
+  generic functions could loose the extra composition parameter. I
+  made this change because of SIA projection related stuff, the only
+  function that relies on it in amuse is find-next-event. JF"))
+
 (defclass pitched-event (event pitch) ()
   (:documentation "Event with pitch information"))
 (defclass standard-pitched-event (pitched-event