https://code.soundsoftware.ac.uk/https://code.soundsoftware.ac.uk/favicon.ico?15040038542014-02-04T18:05:54ZSound Software .ac.ukTony: a tool for melody transcription - Bug #868: funny candidate pitch track glitcheshttps://code.soundsoftware.ac.uk/issues/868?journal_id=15922014-02-04T18:05:54ZMatthias Mauch
<ul><li><strong>Assignee</strong> set to <i>Matthias Mauch</i></li></ul> Tony: a tool for melody transcription - Bug #868: funny candidate pitch track glitcheshttps://code.soundsoftware.ac.uk/issues/868?journal_id=15932014-02-04T22:37:44ZMatthias Mauch
<ul><li><strong>File</strong> <a href="/attachments/download/977/pyin.dylib">pyin.dylib</a> added</li></ul><p>Much improved now! There still are some glitches, but they also have to do with Tony not knowing how pYIN changes timestamps -- we'll have to take account of that sometime.</p>
<p>I upload a new version of pyin, will soon push to pyin repo as well.</p> Tony: a tool for melody transcription - Bug #868: funny candidate pitch track glitcheshttps://code.soundsoftware.ac.uk/issues/868?journal_id=15942014-02-05T11:23:12ZChris Cannamcannam@all-day-breakfast.com
<ul></ul><p>Did you push your latest changes? I'd like to test.</p>
<p>I notice the code currently in the repo has a nasty case of the unsigned-comparison bug:</p>
<p><a class="external" href="https://code.soundsoftware.ac.uk/projects/pyin/repository/entry/LocalCandidatePYIN.cpp#L352">https://code.soundsoftware.ac.uk/projects/pyin/repository/entry/LocalCandidatePYIN.cpp#L352</a></p>
<p>(Comparing an unsigned value against -1 for the loop termination condition. See e.g. <a class="external" href="http://soundsoftware.ac.uk/c-pitfall-unsigned">http://soundsoftware.ac.uk/c-pitfall-unsigned</a> for more on this subject)</p> Tony: a tool for melody transcription - Bug #868: funny candidate pitch track glitcheshttps://code.soundsoftware.ac.uk/issues/868?journal_id=15952014-02-07T12:04:26ZMatthias Mauch
<ul></ul><blockquote>
<p>I notice the code currently in the repo has a nasty case of the unsigned-comparison bug:</p>
<p><a class="external" href="https://code.soundsoftware.ac.uk/projects/pyin/repository/entry/LocalCandidatePYIN.cpp#L352">https://code.soundsoftware.ac.uk/projects/pyin/repository/entry/LocalCandidatePYIN.cpp#L352</a></p>
</blockquote>
<p>That was indeed nasty. Made it less nasty. but it's still kinda a hack.</p>
<blockquote>
<p>(Comparing an unsigned value against -1 for the loop termination condition. See e.g. <a class="external" href="http://soundsoftware.ac.uk/c-pitfall-unsigned">http://soundsoftware.ac.uk/c-pitfall-unsigned</a> for more on this subject)</p>
</blockquote>
<p>Ok thanks.</p>
<p>I really want to find a more principled solution to the problem of multiple pitch tracks. Haven't yet.</p> Tony: a tool for melody transcription - Bug #868: funny candidate pitch track glitcheshttps://code.soundsoftware.ac.uk/issues/868?journal_id=16052014-02-18T18:54:08ZJustin Salamonjustin.salamon@nyu.edu
<ul><li><strong>File</strong> <a href="/attachments/download/982/Screen%20Shot%202014-02-18%20at%201.42.36%20PM.png">Screen Shot 2014-02-18 at 1.42.36 PM.png</a> added</li></ul><p>I was trying out Tony with a real 'test-case' - imagine pYin misses a small bit of melody, creating a discontinuity in the f0 curve, and I want to use Tony to fill in the missing gap, even if it's very small. I just tried doing this, and got the following back (see image attached). Any idea what's going on?</p> Tony: a tool for melody transcription - Bug #868: funny candidate pitch track glitcheshttps://code.soundsoftware.ac.uk/issues/868?journal_id=16062014-02-18T21:36:10ZJustin Salamonjustin.salamon@nyu.edu
<ul><li><strong>File</strong> <a href="/attachments/download/983/Screen%20Shot%202014-02-18%20at%204.20.07%20PM.png">Screen Shot 2014-02-18 at 4.20.07 PM.png</a> added</li></ul><p>Also, still some glitches? (see attached)</p> Tony: a tool for melody transcription - Bug #868: funny candidate pitch track glitcheshttps://code.soundsoftware.ac.uk/issues/868?journal_id=16082014-02-19T09:21:42ZMatthias Mauch
<ul></ul><p>Yes, that's sad but true.</p>
<p>I think there are two things we need to do here:</p>
<ul>
<li>get a more principled approach to actually obtaining the candidates -- this is a bit silly to do with pyin as it is, actually, so I will need to think about it more clearly.</li>
<li>make Tony understand the timestamps that pyin is using (pyin, knowing how YIN uses the spectrum, shifts the timestamps forward to coincide with where the temporal centroid of the YIN analysis is, i.e. one quarter block-size into the frame, and hence also returns them shifted forward... Tony doesn't know that yet).</li>
</ul>
<p>So this is work for me and Chris respectively, I think. I hope I can work on this soon.</p>
<p>Cheers,<br />Matthias</p> Tony: a tool for melody transcription - Bug #868: funny candidate pitch track glitcheshttps://code.soundsoftware.ac.uk/issues/868?journal_id=16142014-02-19T18:23:51ZMatthias Mauch
<ul></ul><p>I think I've done both now, see: <a class="external" href="https://code.soundsoftware.ac.uk/issues/870">https://code.soundsoftware.ac.uk/issues/870</a></p>
<p>Maybe that needs a review by Chris though...</p> Tony: a tool for melody transcription - Bug #868: funny candidate pitch track glitcheshttps://code.soundsoftware.ac.uk/issues/868?journal_id=36142019-11-22T14:24:37ZChris Cannamcannam@all-day-breakfast.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul>