comparison js/specification.js @ 2686:a005429f575b

#180. specification.js passes JSHint

             case "integer":
             case "decimal":
             case "short":
                 attribute = Number(attribute);
                 break;
-            case "string":
             default:
                 attribute = String(attribute);
                 break;
         }
         return attribute;

                         }
                         if (this.max !== undefined) {
                             node.setAttribute("max", this.max);
                         } else {
                             node.setAttribute("max", "undefined");
-                        }
+                        } /* falls through */
                     case "radio":
                         for (var i = 0; i < this.options.length; i++) {
                             var option = this.options[i];
                             var optionNode = doc.createElement("option");
                             optionNode.setAttribute("name", option.name);

                         }
                         break;
                     case "video":
                         if (this.mandatory !== undefined) {
                             node.setAttribute("mandatory", this.mandatory);
-                        }
+                        } /* falls through */
                     case "youtube":
                         if (this.url !== undefined) {
                             node.setAttribute("url", this.url);
                         }
                         break;

                         if (this.rightText) {
                             var maxText = doc.createElement("maxText");
                             maxText.textContent = this.rightText;
                             node.appendChild(maxText);
                         }
+                        break;
                     default:
                         break;
                 }
                 this.conditions.forEach(function (condition) {
                     var conditionDOM = doc.createElement("conditional");

                         this.min = undefined;
                         this.max = undefined;
                         this.step = undefined;
                         break;
                     case "commentquestion":
+                        this.type = "question";
+                        break;
                     default:
-                        this.type = "question";
-                        break;
+                        throw ("Unknown comment type " + xml.nodeName);
                 }
                 this.statement = xml.getElementsByTagName('statement')[0].textContent;
                 if (this.type == "radio" || this.type == "checkbox") {
                     var optNodes = xml.getElementsByTagName('option');
                     for (var i = 0; i < optNodes.length; i++) {

                         break;
                     case "slider":
                         node = root.createElement("commentslider");
                         break;
                     case "question":
+                        node = root.createElement("commentquestion");
+                        break;
                     default:
-                        node = root.createElement("commentquestion");
-                        break;
+                        throw ("Unknown type " + this.type);
                 }
                 node.id = this.id;
                 node.setAttribute("type", this.type);
                 if (this.name !== undefined) {
                     node.setAttribute("name", this.name);