Mercurial > hg > ugly-duckling
changeset 509:041468f553e1 tip master
Merge pull request #57 from LucasThompson/fix/session-stack-max-call-stack
Fix accidental recursion in PersistentStack
| author | Lucas Thompson <LucasThompson@users.noreply.github.com> |
|---|---|
| date | Mon, 27 Nov 2017 11:04:30 +0000 |
| parents | 0e6d4f994b73 (current diff) 7ac80ad913c1 (diff) |
| children | |
| files | |
| diffstat | 5 files changed, 84 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/lib-tests/jasmine.json Mon Nov 27 11:04:30 2017 +0000 @@ -0,0 +1,11 @@ +{ + "spec_dir": "lib-tests/lib/lib-tests/spec", + "spec_files": [ + "**/*[sS]pec.js" + ], + "helpers": [ + "helpers/**/*.js" + ], + "stopSpecOnExpectationFailure": false, + "random": false +}
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/lib-tests/spec/session.spec.ts Mon Nov 27 11:04:30 2017 +0000 @@ -0,0 +1,16 @@ +import { PersistentStack } from '../../src/app/Session'; +import * as jasmine from 'jasmine-core'; + +describe('PersistentStack', () => { + it('can add values to the front and maintain undo history', () => { + const stack = new PersistentStack<number>(); + stack.unshift(1); + stack.unshift(2); + expect(stack.get(0)).toBe(2); + expect(stack.get(1)).toBe(1); + stack.stepBack(); + expect(stack.get(0)).toBe(1); + expect(stack.get(1)).toBeUndefined(); + }); +}); +
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/lib-tests/tsconfig.json Mon Nov 27 11:04:30 2017 +0000 @@ -0,0 +1,53 @@ +{ + "compilerOptions": { + /* Basic Options */ + "target": "es2015", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */ + "module": "commonjs", /* Specify module code generation: 'commonjs', 'amd', 'system', 'umd' or 'es2015'. */ + "lib": ["es2016", "dom"], /* Specify library files to be included in the compilation: */ + // "allowJs": true, /* Allow javascript files to be compiled. */ + // "checkJs": true, /* Report errors in .js files. */ + // "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */ + // "declaration": true, /* Generates corresponding '.d.ts' file. */ + // "sourceMap": true, /* Generates corresponding '.map' file. */ + // "outFile": "./", /* Concatenate and emit output to single file. */ + "outDir": "./lib" /* Redirect output structure to the directory. */ + // "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */ + // "removeComments": true, /* Do not emit comments to output. */ + // "noEmit": true, /* Do not emit outputs. */ + // "importHelpers": true, /* Import emit helpers from 'tslib'. */ + // "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */ + // "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */ + + /* Strict Type-Checking Options */ + // "strict": true /* Enable all strict type-checking options. */ + // "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */ + // "strictNullChecks": true, /* Enable strict null checks. */ + // "noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */ + // "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */ + + /* Additional Checks */ + // "noUnusedLocals": true, /* Report errors on unused locals. */ + // "noUnusedParameters": true, /* Report errors on unused parameters. */ + // "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */ + // "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */ + + /* Module Resolution Options */ + // "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */ + // "baseUrl": "./", /* Base directory to resolve non-absolute module names. */ + // "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */ + // "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */ + // "typeRoots": [], /* List of folders to include type definitions from. */ + // "types": [], /* Type declaration files to be included in compilation. */ + // "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */ + + /* Source Map Options */ + // "sourceRoot": "./", /* Specify the location where debugger should locate TypeScript files instead of source locations. */ + // "mapRoot": "./", /* Specify the location where debugger should locate map files instead of generated locations. */ + // "inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */ + // "inlineSources": true, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */ + + /* Experimental Options */ + // "experimentalDecorators": true, /* Enables experimental support for ES7 decorators. */ + // "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */ + } +} \ No newline at end of file
--- a/package.json Thu Oct 12 13:43:47 2017 +0100 +++ b/package.json Mon Nov 27 11:04:30 2017 +0000 @@ -7,7 +7,9 @@ "start": "ng serve", "start-ssl": "ng serve --ssl true", "build": "node build-prod.js", - "test": "ng test", + "test": "npm run test-lib && ng test", + "build-lib-tests": "tsc -p ./lib-tests", + "test-lib": "npm run build-lib-tests && jasmine JASMINE_CONFIG_PATH=lib-tests/jasmine.json", "lint": "ng lint", "e2e": "ng e2e" },