# HG changeset patch
# User Lucas Thompson <dev@lucas.im>
# Date 1490372097 0
# Node ID 1db0bb28688bee2072024a8d74dc334387528dec
# Parent  b638c714bd1d8695fae1405e520488f81bcf4255
Introduce id field for analysis items, currently optional but arguably shouldn't be. Currently an incrementing counter uniquely identifies an item - not ideal.

diff -r b638c714bd1d -r 1db0bb28688b src/app/analysis-item/analysis-item.component.html
--- a/src/app/analysis-item/analysis-item.component.html	Fri Mar 24 15:27:07 2017 +0000
+++ b/src/app/analysis-item/analysis-item.component.html	Fri Mar 24 16:14:57 2017 +0000
@@ -6,7 +6,7 @@
   <md-card-content>
     <app-waveform
       [timeline]="timeline"
-      [trackIdPrefix]="title"
+      [trackIdPrefix]=" id || title"
       [isSubscribedToAudioService]="isActive && isRoot"
       [isSubscribedToExtractionService]="isActive && !isRoot"
       [isOneShotExtractor]="true"
diff -r b638c714bd1d -r 1db0bb28688b src/app/analysis-item/analysis-item.component.ts
--- a/src/app/analysis-item/analysis-item.component.ts	Fri Mar 24 15:27:07 2017 +0000
+++ b/src/app/analysis-item/analysis-item.component.ts	Fri Mar 24 16:14:57 2017 +0000
@@ -11,6 +11,7 @@
   extractorKey: string;
   title?: string;
   description?: string;
+  id?: string;
 }
 
 @Component({
@@ -24,4 +25,5 @@
   @Input() description: string;
   @Input() isActive: boolean;
   @Input() isRoot: boolean;
+  @Input() id: string;
 }
diff -r b638c714bd1d -r 1db0bb28688b src/app/app.component.ts
--- a/src/app/app.component.ts	Fri Mar 24 15:27:07 2017 +0000
+++ b/src/app/app.component.ts	Fri Mar 24 16:14:57 2017 +0000
@@ -21,6 +21,7 @@
   private onAudioDataSubscription: Subscription;
   private analyses: AnalysisItem[]; // TODO some immutable state container describing entire session
   private nRecordings: number; // TODO user control for naming a recording
+  private countingId: number; // TODO improve uniquely identifying items
   private rootAudioUri: string;
 
   constructor(private audioService: AudioPlayerService,
@@ -30,6 +31,8 @@
     this.analyses = [];
     this.canExtract = false;
     this.nRecordings = 0;
+    this.countingId = 1;
+
     iconRegistry.addSvgIcon(
       'duck',
       sanitizer.bypassSecurityTrustResourceUrl('assets/duck.svg')
@@ -76,7 +79,8 @@
       extractorKey: 'not:real',
       isRoot: true,
       title: title,
-      description: new Date().toLocaleString()
+      description: new Date().toLocaleString(),
+      id: `${this.countingId++}`
     });
   }
 
@@ -90,7 +94,8 @@
       extractorKey: outputInfo.combinedKey,
       isRoot: false,
       title: outputInfo.name,
-      description: outputInfo.outputId
+      description: outputInfo.outputId,
+      id: `${this.countingId++}`
     });
 
     this.piperService.collect({
diff -r b638c714bd1d -r 1db0bb28688b src/app/notebook-feed/notebook-feed.component.html
--- a/src/app/notebook-feed/notebook-feed.component.html	Fri Mar 24 15:27:07 2017 +0000
+++ b/src/app/notebook-feed/notebook-feed.component.html	Fri Mar 24 16:14:57 2017 +0000
@@ -6,6 +6,7 @@
         [title]="item.title"
         [description]="item.description"
         [isActive]="rootAudioUri === item.rootAudioUri"
-        [isRoot]="item.isRoot"></ugly-analysis-item>
+        [isRoot]="item.isRoot"
+        [id]="item.id"></ugly-analysis-item>
   </div>
 </template>