Mercurial > hg > ugly-duckling
diff src/app/app.component.ts @ 494:f52eb1b422f5
Display errors to user instead of logging to console.
author | Lucas Thompson <dev@lucas.im> |
---|---|
date | Thu, 06 Jul 2017 19:48:22 +0100 |
parents | c9f12a9c1d5c |
children | c39df81c4dae |
line wrap: on
line diff
--- a/src/app/app.component.ts Thu Jul 06 19:47:18 2017 +0100 +++ b/src/app/app.component.ts Thu Jul 06 19:48:22 2017 +0100 @@ -2,7 +2,8 @@ import { AudioPlayerService, AudioResourceError, - AudioResource + AudioResource, + AudioLoadResponse } from './services/audio-player/audio-player.service'; import { ExtractionResult, @@ -25,6 +26,7 @@ import {UrlResourceLifetimeManager} from './app.module'; import {createExtractionRequest} from './analysis-item/AnalysisItem'; import {PersistentStack} from './Session'; +import {NotificationService} from './services/notifications/notifications.service'; @Component({ selector: 'ugly-root', @@ -46,7 +48,8 @@ private sanitizer: DomSanitizer, @Inject( 'UrlResourceLifetimeManager' - ) private resourceManager: UrlResourceLifetimeManager) { + ) private resourceManager: UrlResourceLifetimeManager, + private notifier: NotificationService) { this.analyses = new PersistentStack<AnalysisItem>(); this.canExtract = false; this.nRecordings = 0; @@ -64,8 +67,10 @@ val => isPendingRootAudioItem(val) && val.uri === getRootAudioItem( this.analyses.get(0) ).uri; - const wasError = (resource as AudioResourceError).message != null; - if (wasError) { + const wasError = (res: AudioLoadResponse): + res is AudioResourceError => (res as any).message != null; + if (wasError(resource)) { + this.notifier.displayError(resource.message); this.analyses.findIndexAndUse( findCurrentAudio, index => this.analyses.remove(index) @@ -208,7 +213,7 @@ val => val.id === analysis.id, index => this.analyses.remove(index) ); - console.error(`Error whilst extracting: ${err}`); + this.notifier.displayError(`Error whilst extracting: ${err}`); }); } }