Mercurial > hg > svgui

changeset 1485:0e971e3d93e2 by-id

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Tidy; also don't show cancel buttons for alignments
author Chris Cannam
date Wed, 17 Jul 2019 13:12:56 +0100
parents b43ff1abdc02
children ac0a8addabcf
files layer/Colour3DPlotLayer.cpp layer/SliceLayer.cpp view/View.cpp
diffstat 3 files changed, 6 insertions(+), 12 deletions(-) [+]
line wrap: on
line diff
--- a/layer/Colour3DPlotLayer.cpp	Wed Jul 17 11:20:08 2019 +0100
+++ b/layer/Colour3DPlotLayer.cpp	Wed Jul 17 13:12:56 2019 +0100
@@ -173,7 +173,6 @@
     invalidatePeakCache();
 
     emit modelReplaced();
-//!!!    emit sliceableModelReplaced(oldModel, model);
 }
 
 void
--- a/layer/SliceLayer.cpp	Wed Jul 17 11:20:08 2019 +0100
+++ b/layer/SliceLayer.cpp	Wed Jul 17 13:12:56 2019 +0100
@@ -89,17 +89,7 @@
         setSliceableModel(replacement);
     }
 }
-/*!!!
-void
-SliceLayer::modelAboutToBeDeleted(Model *m)
-{
-    SVDEBUG << "SliceLayer::modelAboutToBeDeleted(" << m << ")" << endl;
 
-    if (m == m_sliceableModel) {
-        setSliceableModel(nullptr);
-    }
-}
-*/
 QString
 SliceLayer::getFeatureDescription(LayerGeometryProvider *v, QPoint &p) const
 {
--- a/view/View.cpp	Wed Jul 17 11:20:08 2019 +0100
+++ b/view/View.cpp	Wed Jul 17 13:12:56 2019 +0100
@@ -1747,7 +1747,6 @@
 
     QSettings settings;
     settings.beginGroup("View");
-    //!!! perhaps alignments in general should not be cancellable?
     bool showCancelButton = settings.value("showcancelbuttons", true).toBool();
     settings.endGroup();
     
@@ -1808,8 +1807,14 @@
                     (model && 
                      (wfm = ModelById::getAs<RangeSummarisableTimeValueModel>
                       (model->getSourceModel())))) {
+
                     completion = wfm->getAlignmentCompletion();
 
+                    // We don't allow cancelling alignment operations
+                    // - they aren't usually all that expensive, and
+                    // it would leave things in a very uncertain state
+                    showCancelButton = false;
+
 #ifdef DEBUG_PROGRESS_STUFF
                     SVCERR << "View[" << this << "]::checkProgress(" << object << "): "
                            << "alignment completion = " << completion << endl;