comparison widgets/Thumbwheel.cpp @ 192:fcc043f75c41

* Avoid unnecessary work and updates when an invisible thumbwheel changes

     if (m_rangeMapper) {
         int newValue = m_rangeMapper->getPositionForValue(mappedValue);
         bool changed = (m_mappedValue != mappedValue);
         m_mappedValue = mappedValue;
         m_noMappedUpdate = true;
-        std::cerr << "Thumbwheel::setMappedValue(" << mappedValue << "): new value is " << newValue << std::endl;
+        std::cerr << "Thumbwheel::setMappedValue(" << mappedValue << "): new value is " << newValue << " (visible " << isVisible() << ")" << std::endl;
         if (newValue != getValue()) {
             setValue(newValue);
             changed = true;
         }
         if (changed) emit valueChanged(newValue);

 
 void
 Thumbwheel::setValue(int value)
 {
     std::cerr << "Thumbwheel::setValue(" << value << ") (from " << m_value
-              << ", rotation " << m_rotation << ")" << std::endl;
+              << ", rotation " << m_rotation << ")" << " (visible " << isVisible() << ")" << std::endl;
 
     if (m_value != value) {
 
         m_atDefault = false;
 

         if (value > m_max) value = m_max;
         m_value = value;
     }
 
     m_rotation = float(m_value - m_min) / float(m_max - m_min);
-    update();
+    if (isVisible()) update();
 }
 
 void
 Thumbwheel::resetToDefault()
 {