comparison layer/SpectrogramLayer.cpp @ 1141:f19dcb288123 spectrogram-minor-refactor

Minor tidy, + go back to opaque-only spectrogram as intended

     if (r < 0) r = 0;
     if (r > 256) r = 256;
     int distance = r - m_colourRotation;
 
     if (distance != 0) {
-//!!!	rotatePalette(-distance);
 	m_colourRotation = r;
     }
-    
-    invalidateRenderers(); //!!! in theory we shouldn't have to do this... but...
+
+    // Initially the idea with colour rotation was that we would just
+    // rotate the palette of an already-generated cache. That's not
+    // really practical now that cacheing is handled in a separate
+    // class in which the main cache no longer has a palette.
+    invalidateRenderers();
     
     emit layerParametersChanged();
 }
 
 void

         }
 
         Layer::setLayerDormant(v, true);
 
 	invalidateRenderers();
-
-        //!!! in theory we should call invalidateFFTModel() if and
-        //!!! only if there are no remaining views in which we are not
-        //!!! dormant
 	
     } else {
 
         Layer::setLayerDormant(v, false);
     }

 {
 #ifdef DEBUG_SPECTROGRAM_REPAINT
     cerr << "SpectrogramLayer::cacheInvalid(" << from << ", " << to << ")" << endl;
 #endif
 
-    //!!! now in common with Colour3DPlotLayer:
     // We used to call invalidateMagnitudes(from, to) to invalidate
     // only those caches whose views contained some of the (from, to)
     // range. That's the right thing to do; it has been lost in
     // pulling out the image cache code, but it might not matter very
     // much, since the underlying models for spectrogram layers don't

         Colour3DPlotRenderer::Parameters params;
         params.colourScale = ColourScale(cparams);
         params.normalization = m_normalization;
         params.binDisplay = m_binDisplay;
         params.binScale = m_binScale;
-        params.alwaysOpaque = false; //!!! should be true though
+        params.alwaysOpaque = true;
         params.invertVertical = false;
         params.scaleFactor = 1.0;
         params.colourRotation = m_colourRotation;
 
         if (m_colourScale != ColourScaleType::Phase) {