comparison layer/SpectrogramLayer.cpp @ 1105:ea5ae9dd10ba spectrogram-minor-refactor

Convert ColourScaleType into an enum class

     m_colourRotation(0),
     m_initialRotation(0),
     m_minFrequency(10),
     m_maxFrequency(8000),
     m_initialMaxFrequency(8000),
-    m_colourScale(ColourScale::LogColourScale),
+    m_colourScale(ColourScaleType::Log),
     m_colourMap(0),
     m_binScale(BinScale::Linear),
     m_binDisplay(BinDisplay::AllBins),
     m_normalization(ColumnNormalization::None),
     m_normalizeVisibleArea(false),

 	setWindowSize(8192);
 	setWindowHopLevel(4);
         m_initialMaxFrequency = 1500;
 	setMaxFrequency(1500);
         setMinFrequency(40);
-	setColourScale(ColourScale::LinearColourScale);
+	setColourScale(ColourScaleType::Linear);
         setColourMap(ColourMapper::Sunset);
         setBinScale(BinScale::Log);
         colourConfigName = "spectrogram-melodic-colour";
         colourConfigDefault = int(ColourMapper::Sunset);
 //        setGain(20);

 	setWindowHopLevel(5);
         m_initialMaxFrequency = 2000;
 	setMaxFrequency(2000);
 	setMinFrequency(40);
 	setBinScale(BinScale::Log);
-	setColourScale(ColourScale::LinearColourScale);
+	setColourScale(ColourScaleType::Linear);
 	setBinDisplay(BinDisplay::PeakFrequencies);
         setNormalization(ColumnNormalization::Max1);
         colourConfigName = "spectrogram-melodic-colour";
         colourConfigDefault = int(ColourMapper::Sunset);
     }

 {
     invalidateImageCaches();
     invalidateFFTModel();
 }
 
-ColourScale::Scale
+ColourScaleType
 SpectrogramLayer::convertToColourScale(int value)
 {
     switch (value) {
-    case 0: return ColourScale::LinearColourScale;
-    case 1: return ColourScale::MeterColourScale;
-    case 2: return ColourScale::LogColourScale; //!!! db^2
-    case 3: return ColourScale::LogColourScale;
-    case 4: return ColourScale::PhaseColourScale;
-    default: return ColourScale::LinearColourScale;
+    case 0: return ColourScaleType::Linear;
+    case 1: return ColourScaleType::Meter;
+    case 2: return ColourScaleType::Log; //!!! db^2
+    case 3: return ColourScaleType::Log;
+    case 4: return ColourScaleType::Phase;
+    default: return ColourScaleType::Linear;
     }
 }
 
 int
-SpectrogramLayer::convertFromColourScale(ColourScale::Scale scale)
+SpectrogramLayer::convertFromColourScale(ColourScaleType scale)
 {
     switch (scale) {
-    case ColourScale::LinearColourScale: return 0;
-    case ColourScale::MeterColourScale: return 1;
-    case ColourScale::LogColourScale: return 3; //!!! + db^2
-    case ColourScale::PhaseColourScale: return 4;
-
-    case ColourScale::PlusMinusOneScale:
-    case ColourScale::AbsoluteScale:
+    case ColourScaleType::Linear: return 0;
+    case ColourScaleType::Meter: return 1;
+    case ColourScaleType::Log: return 3; //!!! + db^2
+    case ColourScaleType::Phase: return 4;
+
+    case ColourScaleType::PlusMinusOne:
+    case ColourScaleType::Absolute:
     default: return 0;
     }
 }
 
 std::pair<ColumnNormalization, bool>

             m_lastEmittedZoomStep = vs;
         }
     } else if (name == "Colour Scale") {
 	switch (value) {
 	default:
-	case 0: setColourScale(ColourScale::LinearColourScale); break;
-	case 1: setColourScale(ColourScale::MeterColourScale); break;
-	case 2: setColourScale(ColourScale::LogColourScale); break; //!!! dB^2
-	case 3: setColourScale(ColourScale::LogColourScale); break;
-	case 4: setColourScale(ColourScale::PhaseColourScale); break;
+	case 0: setColourScale(ColourScaleType::Linear); break;
+	case 1: setColourScale(ColourScaleType::Meter); break;
+	case 2: setColourScale(ColourScaleType::Log); break; //!!! dB^2
+	case 3: setColourScale(ColourScaleType::Log); break;
+	case 4: setColourScale(ColourScaleType::Phase); break;
 	}
     } else if (name == "Frequency Scale") {
 	switch (value) {
 	default:
 	case 0: setBinScale(BinScale::Linear); break;

     
     emit layerParametersChanged();
 }
 
 void
-SpectrogramLayer::setColourScale(ColourScale::Scale colourScale)
+SpectrogramLayer::setColourScale(ColourScaleType colourScale)
 {
     if (m_colourScale == colourScale) return;
 
     invalidateImageCaches();
     
     m_colourScale = colourScale;
     
     emit layerParametersChanged();
 }
 
-ColourScale::Scale
+ColourScaleType
 SpectrogramLayer::getColourScale() const
 {
     return m_colourScale;
 }
 

 
     if (m_normalizeVisibleArea) {
         min = m_viewMags[v->getId()].getMin();
         max = m_viewMags[v->getId()].getMax();
     } else if (m_normalization != ColumnNormalization::Max1) {
-        if (m_colourScale == ColourScale::LinearColourScale //||
-//            m_colourScale == MeterColourScale) {
+        if (m_colourScale == ColourScaleType::Linear //||
+//            m_colourScale == ColourScaleType::Meter) {
             ) {
             max = 0.1;
         }
     }
 

     if (max == 0.0) max = 1.0;
     if (max == min) min = max - 0.0001;
 
     switch (m_colourScale) {
 	
-    case ColourScale::LinearColourScale:
+    case ColourScaleType::Linear:
         value = int(((input - min) / (max - min)) * 255.0) + 1;
 	break;
 	
-    case ColourScale::MeterColourScale:
+    case ColourScaleType::Meter:
         value = AudioLevel::multiplier_to_preview
             ((input - min) / (max - min), 254) + 1;
 	break;
 
         //!!! check this

 	if (input < 0.0) input = 0.0;
 	if (input > 1.0) input = 1.0;
 	value = int(input * 255.0) + 1;
 	break;
 */	
-    case ColourScale::LogColourScale:
+    case ColourScaleType::Log:
         //!!! experiment with normalizing the visible area this way.
         //In any case, we need to have some indication of what the dB
         //scale is relative to.
         input = (input - min) / (max - min);
         if (input > 0.0) {

 	if (input < 0.0) input = 0.0;
 	if (input > 1.0) input = 1.0;
 	value = int(input * 255.0) + 1;
 	break;
 	
-    case ColourScale::PhaseColourScale:
+    case ColourScaleType::Phase:
 	value = int((input * 127.0 / M_PI) + 128);
 	break;
 
-    case ColourScale::PlusMinusOneScale:
-    case ColourScale::AbsoluteScale:
+    case ColourScaleType::PlusMinusOne:
+    case ColourScaleType::Absolute:
     default:
         ;
     }
 
     if (value > UCHAR_MAX) value = UCHAR_MAX;

         cparams.colourMap = m_colourMap;
         cparams.scale = m_colourScale;
         cparams.threshold = m_threshold;
         cparams.gain = m_gain;
 
-        if (m_colourScale != ColourScale::PhaseColourScale &&
+        if (m_colourScale != ColourScaleType::Phase &&
             m_normalization == ColumnNormalization::None) {
             cparams.gain *= 2.f / float(getFFTSize());
         }
         
         Colour3DPlotRenderer::Parameters params;

         }
         if (m_drawBuffer.width() < bufwid || m_drawBuffer.height() != h) {
             m_drawBuffer = QImage(bufwid, h, QImage::Format_Indexed8);
         }
         usePeaksCache = (increment * m_peakCacheDivisor) < zoomLevel;
-        if (m_colourScale == ColourScale::PhaseColourScale) usePeaksCache = false;
+        if (m_colourScale == ColourScaleType::Phase) usePeaksCache = false;
     }
 
     for (int pixel = 0; pixel < 256; ++pixel) {
         m_drawBuffer.setColor((unsigned char)pixel,
                               m_palette.getColour((unsigned char)pixel).rgb());

                 column = getColumnFromFFTModel(fft,
                                                sx,
                                                minbin,
                                                maxbin - minbin + 1);
 
-                if (m_colourScale != ColourScale::PhaseColourScale) {
+                if (m_colourScale != ColourScaleType::Phase) {
                     column = ColumnOp::fftScale(column, getFFTSize());
                 }
 
                 recordColumnExtents(column,
                                     sx,
                                     overallMag,
                                     overallMagChanged);
 
-                if (m_colourScale != ColourScale::PhaseColourScale) {
+                if (m_colourScale != ColourScaleType::Phase) {
                     column = ColumnOp::normalize(column, m_normalization);
                 }
 
                 preparedColumn = ColumnOp::applyGain(column, m_gain);
                 

                                         int minbin,
                                         int bincount) const
 {
     vector<float> values(bincount, 0.f);
     
-    if (m_colourScale == ColourScale::PhaseColourScale) {
+    if (m_colourScale == ColourScaleType::Phase) {
         fft->getPhasesAt(sx, values.data(), minbin, bincount);
     } else {
         fft->getMagnitudesAt(sx, values.data(), minbin, bincount);
     }
 

 SpectrogramLayer::getColumnFromGenericModel(DenseThreeDimensionalModel *model,
                                             int sx, // column number in model
                                             int minbin,
                                             int bincount) const
 {
-    if (m_colourScale == ColourScale::PhaseColourScale) {
+    if (m_colourScale == ColourScaleType::Phase) {
         throw std::logic_error("can't use phase scale with generic 3d model");
     }
 
     auto col = model->getColumn(sx);
         

                                                    sx,
                                                    minbin,
                                                    maxbin - minbin + 1);
                 }
 
-                if (m_colourScale != ColourScale::PhaseColourScale) {
+                if (m_colourScale != ColourScaleType::Phase) {
                     column = ColumnOp::fftScale(column, getFFTSize());
                 }
 
                 recordColumnExtents(column,
                                     sx,
                                     overallMag,
                                     overallMagChanged);
 
-                if (m_colourScale != ColourScale::PhaseColourScale) {
+                if (m_colourScale != ColourScaleType::Phase) {
                     column = ColumnOp::normalize(column, m_normalization);
                 }
 
                 if (m_binDisplay == BinDisplay::PeakBins) {
                     column = ColumnOp::peakPick(column);

     int toff = -textHeight + paint.fontMetrics().ascent() + 2;
 
     if (detailed && (h > textHeight * 3 + 10)) {
 
         int topLines = 2;
-        if (m_colourScale == ColourScale::PhaseColourScale) topLines = 1;
+        if (m_colourScale == ColourScaleType::Phase) topLines = 1;
 
 	int ch = h - textHeight * (topLines + 1) - 8;
 //	paint.drawRect(4, textHeight + 4, cw - 1, ch + 1);
 	paint.drawRect(4 + cw - cbw, textHeight * topLines + 4, cbw - 1, ch + 1);
 

         if (dBmin < dBmax - 60.f) dBmin = dBmax - 60.f;
         bottom = QString("%1").arg(lrint(dBmin));
 
         //!!! & phase etc
 
-        if (m_colourScale != ColourScale::PhaseColourScale) {
+        if (m_colourScale != ColourScaleType::Phase) {
             paint.drawText((cw + 6 - paint.fontMetrics().width("dBFS")) / 2,
                            2 + textHeight + toff, "dBFS");
         }
 
 //	paint.drawText((cw + 6 - paint.fontMetrics().width(top)) / 2,

     if (ok) {
         SVDEBUG << "SpectrogramLayer::setProperties: setting max freq to " << maxFrequency << endl;
         setMaxFrequency(maxFrequency);
     }
 
-    ColourScale::Scale colourScale = convertToColourScale
+    ColourScaleType colourScale = convertToColourScale
         (attributes.value("colourScale").toInt(&ok));
     if (ok) setColourScale(colourScale);
 
     int colourMap = attributes.value("colourScheme").toInt(&ok);
     if (ok) setColourMap(colourMap);