comparison layer/Colour3DPlotRenderer.cpp @ 1502:62aad7969f8b

Pass the cache pointer through rather than looking it up afresh from the model id for each column

 
 #include <utility>
 using namespace std::rel_ops;
 
 //#define DEBUG_COLOUR_PLOT_REPAINT 1
+//#define DEBUG_COLOUR_PLOT_CACHE_SELECTION 1
 
 using namespace std;
 
 Colour3DPlotRenderer::RenderResult
 Colour3DPlotRenderer::render(const LayerGeometryProvider *v, QPainter &paint, QRect rect)

     }
 }
 
 ColumnOp::Column
 Colour3DPlotRenderer::getColumn(int sx, int minbin, int nbins,
-                                int peakCacheIndex) const
+                                shared_ptr<DenseThreeDimensionalModel> source) const
 {
     // order:
     // get column -> scale -> normalise -> record extents ->
     // peak pick -> distribute/interpolate -> apply display gain
 

 
     ColumnOp::Column column;
     
     if (m_params.showDerivative && sx > 0) {
 
-        auto prev = getColumnRaw(sx - 1, minbin, nbins, peakCacheIndex);
-        column = getColumnRaw(sx, minbin, nbins, peakCacheIndex);
+        auto prev = getColumnRaw(sx - 1, minbin, nbins, source);
+        column = getColumnRaw(sx, minbin, nbins, source);
         
         for (int i = 0; i < nbins; ++i) {
             column[i] -= prev[i];
         }
 
     } else {
-        column = getColumnRaw(sx, minbin, nbins, peakCacheIndex);
+        column = getColumnRaw(sx, minbin, nbins, source);
     }
 
     if (m_params.colourScale.getScale() == ColourScaleType::Phase &&
         !m_sources.fft.isNone()) {
         return column;

     }
 }
 
 ColumnOp::Column
 Colour3DPlotRenderer::getColumnRaw(int sx, int minbin, int nbins,
-                                   int peakCacheIndex) const
+                                   shared_ptr<DenseThreeDimensionalModel> source) const
 {
     Profiler profiler("Colour3DPlotRenderer::getColumn");
 
     ColumnOp::Column column;
     ColumnOp::Column fullColumn;

             fullColumn = fftModel->getPhases(sx);
         }
     }
 
     if (fullColumn.empty()) {
-        
-        if (peakCacheIndex >= 0) {
-            auto peakCache = ModelById::getAs<Dense3DModelPeakCache>
-                (m_sources.peakCaches[peakCacheIndex]);
-            if (!peakCache) {
-                return vector<float>(nbins, 0.f);
-            }                
-            fullColumn = peakCache->getColumn(sx);
-        } else {
-            auto model = ModelById::getAs<DenseThreeDimensionalModel>
-                (m_sources.source);
-            if (!model) {
-                return vector<float>(nbins, 0.f);
-            }
-            fullColumn = model->getColumn(sx);
-        }
-    }
-
+        fullColumn = source->getColumn(sx);
+    }
+    
     column = vector<float>(fullColumn.data() + minbin,
                            fullColumn.data() + minbin + nbins);
     return column;
 }
 

             // order:
             // get column -> scale -> normalise -> record extents ->
             // peak pick -> distribute/interpolate -> apply display gain
 
             // this does the first three:
-            preparedColumn = getColumn(sx, minbin, nbins, -1);
+            preparedColumn = getColumn(sx, minbin, nbins, model);
             
             magRange.sample(preparedColumn);
 
             if (m_params.binDisplay == BinDisplay::PeakBins) {
                 preparedColumn = ColumnOp::peakPick(preparedColumn);

         auto peakCache = ModelById::getAs<Dense3DModelPeakCache>
             (m_sources.peakCaches[ix]);
         if (!peakCache) continue;
         int bpp = peakCache->getColumnsPerPeak();
         ZoomLevel equivZoom(ZoomLevel::FramesPerPixel, binResolution * bpp);
-#ifdef DEBUG_COLOUR_PLOT_REPAINT
+#ifdef DEBUG_COLOUR_PLOT_CACHE_SELECTION
         SVDEBUG << "render " << m_sources.source
                 << ": getPreferredPeakCache: zoomLevel = " << zoomLevel
                 << ", cache " << ix << " has bpp = " << bpp
                 << " for equivZoom = " << equivZoom << endl;
 #endif

                 binsPerPeak = bpp;
             }
         }
     }
 
-#ifdef DEBUG_COLOUR_PLOT_REPAINT
+#ifdef DEBUG_COLOUR_PLOT_CACHE_SELECTION
     SVDEBUG << "render " << m_sources.source
             << ": getPreferredPeakCache: zoomLevel = " << zoomLevel
             << ", binResolution " << binResolution 
             << ", peakCaches " << m_sources.peakCaches.size()
             << ": preferring peakCacheIndex " << peakCacheIndex

                 // get column -> scale -> normalise -> record extents ->
                 // peak pick -> distribute/interpolate -> apply display gain
 
                 // this does the first three:
                 ColumnOp::Column column = getColumn(sx, minbin, nbins,
-                                                    peakCacheIndex);
+                                                    sourceModel);
 
                 magRange.sample(column);
 
                 if (m_params.binDisplay == BinDisplay::PeakBins) {
                     column = ColumnOp::peakPick(column);

             if (sx < 0 || sx >= modelWidth) {
                 continue;
             }
 
             if (sx != psx) {
-                preparedColumn = getColumn(sx, minbin, nbins, -1);
+                preparedColumn = getColumn(sx, minbin, nbins, fft);
                 magRange.sample(preparedColumn);
                 psx = sx;
             }
 
             if (sx == sx0) {