comparison layer/Colour3DPlotRenderer.cpp @ 1135:628cd329c241 spectrogram-minor-refactor

Use a count of bins rather than min and max bins (because the name maxbin tells us nothing about whether the range is inclusive or not)

 
     const int buflen = 40;
     char labelbuf[buflen];
 
     int minbin = m_sources.verticalBinLayer->getIBinForY(v, h);
-    int maxbin = m_sources.verticalBinLayer->getIBinForY(v, 0) + 1;
+    if (minbin >= sh) minbin = sh - 1;
+    if (minbin < 0) minbin = 0;
+    
+    int nbins  = m_sources.verticalBinLayer->getIBinForY(v, 0) - minbin + 1;
+    if (minbin + nbins > sh) nbins = sh - minbin;
 
     int psx = -1;
 
     vector<float> preparedColumn;
 

             
             ColumnOp::Column fullColumn = model->getColumn(sx);
                 
             ColumnOp::Column column =
                 vector<float>(fullColumn.data() + minbin,
-                              fullColumn.data() + maxbin + 1);
+                              fullColumn.data() + minbin + nbins);
 
             column = ColumnOp::applyGain(column, m_params.scaleFactor);
 
 //                if (m_colourScale != ColourScaleType::Phase) {
             preparedColumn = ColumnOp::normalize(column, m_params.normalization);

 
 	bool showLabel = (rw > 10 &&
 			  paint.fontMetrics().width("0.000000") < rw - 3 &&
 			  paint.fontMetrics().height() < (h / sh));
         
-	for (int sy = minbin; sy <= maxbin; ++sy) {
+	for (int sy = minbin; sy < minbin + nbins; ++sy) {
 
             int ry0 = m_sources.verticalBinLayer->getIYForBin(v, sy);
             int ry1 = m_sources.verticalBinLayer->getIYForBin(v, sy + 1);
 
             if (m_params.invertVertical) {

     // peaks model exists if usePeaksCache)
     
     RenderTimer timer(timeConstrained ?
                       RenderTimer::FastRender :
                       RenderTimer::NoTimeout);
-    
-    int minbin = int(binfory[0] + 0.0001);
-    int maxbin = int(binfory[h-1]);
-    if (minbin < 0) minbin = 0;
-    if (maxbin < 0) maxbin = minbin+1;
 
     int divisor = 1;
     const DenseThreeDimensionalModel *sourceModel = m_sources.source;
     if (usePeaksCache) {
         divisor = m_sources.peaks->getColumnsPerPeak();
         sourceModel = m_sources.peaks;
     }
 
+    int sh = sourceModel->getHeight();
+    
+    int minbin = int(binfory[0] + 0.0001);
+    if (minbin >= sh) minbin = sh - 1;
+    if (minbin < 0) minbin = 0;
+
+    int nbins  = int(binfory[h-1]) - minbin + 1;
+    if (minbin + nbins > sh) nbins = sh - minbin;
+    
     int psx = -1;
 
     int start = 0;
     int finish = w;
     int step = 1;

                 // normalise -> peak pick -> distribute/interpolate ->
                 // apply display gain
 
                 ColumnOp::Column fullColumn = sourceModel->getColumn(sx);
 
-//                cerr << "x " << x << ", sx " << sx << ", col height " << fullColumn.size()
-//                     << ", minbin " << minbin << ", maxbin " << maxbin << endl;
+                cerr << "x " << x << ", sx " << sx << ", col height " << fullColumn.size()
+                     << ", minbin " << minbin << ", nbins " << nbins << endl;
                 
                 ColumnOp::Column column =
                     vector<float>(fullColumn.data() + minbin,
-                                  fullColumn.data() + maxbin + 1);
+                                  fullColumn.data() + minbin + nbins);
 
                 column = ColumnOp::applyGain(column, m_params.scaleFactor);
 
 //                if (m_colourScale != ColourScaleType::Phase) {
                     column = ColumnOp::normalize(column, m_params.normalization);

     
     RenderTimer timer(timeConstrained ?
                       RenderTimer::FastRender :
                       RenderTimer::NoTimeout);
 
+    const FFTModel *fft = m_sources.fft;
+
+    int sh = fft->getHeight();
+    
     int minbin = int(binfory[0] + 0.0001);
-    int maxbin = int(binfory[h-1]);
+    if (minbin >= sh) minbin = sh - 1;
     if (minbin < 0) minbin = 0;
-    if (maxbin < 0) maxbin = minbin+1;
-
-    const FFTModel *fft = m_sources.fft;
+
+    int nbins  = int(binfory[h-1]) - minbin + 1;
+    if (minbin + nbins > sh) nbins = sh - minbin;
 
     FFTModel::PeakSet peakfreqs;
 
     int psx = -1;
     

     vector<float> preparedColumn;
 
     int modelWidth = fft->getWidth();
     cerr << "modelWidth " << modelWidth << endl;
 
-    double minFreq = (double(minbin) * fft->getSampleRate()) / fft->getFFTSize();
-    double maxFreq = (double(maxbin) * fft->getSampleRate()) / fft->getFFTSize();
+    double minFreq =
+        (double(minbin) * fft->getSampleRate()) / fft->getFFTSize();
+    double maxFreq =
+        (double(minbin + nbins - 1) * fft->getSampleRate()) / fft->getFFTSize();
 
     bool logarithmic = (m_params.binScale == BinScale::Log);
     
     for (int x = start; x != finish; x += step) {
         

 
                 ColumnOp::Column fullColumn = fft->getColumn(sx);
                 
                 ColumnOp::Column column =
                     vector<float>(fullColumn.data() + minbin,
-                                  fullColumn.data() + maxbin + 1);
+                                  fullColumn.data() + minbin + nbins + 1);
 
                 column = ColumnOp::applyGain(column, m_params.scaleFactor);
                 
 //!!!                if (m_colourScale != ColourScaleType::Phase) {
                 preparedColumn = ColumnOp::normalize

             }
 
             if (sx == sx0) {
                 pixelPeakColumn = preparedColumn;
                 peakfreqs = fft->getPeakFrequencies(FFTModel::AllPeaks, sx,
-                                                    minbin, maxbin - 1);
+                                                    minbin, minbin + nbins - 1);
             } else {
                 for (int i = 0; in_range_for(pixelPeakColumn, i); ++i) {
                     pixelPeakColumn[i] = std::max(pixelPeakColumn[i],
                                                   preparedColumn[i]);
                 }

 
                 int bin = pi->first;
                 double freq = pi->second;
 
                 if (bin < minbin) continue;
-                if (bin > maxbin) break;
+                if (bin >= minbin + nbins) break;
             
                 double value = pixelPeakColumn[bin - minbin];
             
                 double y = v->getYForFrequency
                     (freq, minFreq, maxFreq, logarithmic);