comparison layer/LinearNumericalScale.cpp @ 864:3ca3b8fbbcee

Correct some really stupid fixed-length string stuff, including a genuine stack overflow that causes a crash on OS/X for certain colour 3d plot data.

     int n = 10;
 
     float val = minf;
     float inc = (maxf - val) / n;
 
-    char buffer[40];
+    const int buflen = 40;
+    char buffer[buflen];
 
     int w = getWidth(v, paint) + x0;
 
     float round = 1.f;
     int dp = 0;

 	if (prevy >= 0 && (prevy - y) < paint.fontMetrics().height()) {
 	    val += inc;
 	    continue;
         }
 
-	sprintf(buffer, "%.*f", dp, dispval);
+	snprintf(buffer, buflen, "%.*f", dp, dispval);
 
 	QString label = QString(buffer);
 
 	paint.drawLine(w - 5, y, w, y);