changeset 1317:ea28ee929034 3.0-integration

Remove resampler quality option (#1760)

--- a/base/Preferences.cpp	Fri Dec 02 09:14:11 2016 +0000
+++ b/base/Preferences.cpp	Mon Dec 05 16:39:03 2016 +0000
@@ -40,7 +40,6 @@
     m_tuningFrequency(440),
     m_propertyBoxLayout(VerticallyStacked),
     m_windowType(HanningWindow),
-    m_resampleQuality(1),
     m_runPluginsInProcess(true),
     m_omitRecentTemps(true),
     m_tempDirRoot(""),
@@ -66,7 +65,6 @@
         (settings.value("property-box-layout", int(VerticallyStacked)).toInt());
     m_windowType = WindowType
         (settings.value("window-type", int(HanningWindow)).toInt());
-    m_resampleQuality = settings.value("resample-quality", 1).toInt();
     m_runPluginsInProcess = settings.value("run-vamp-plugins-in-process", true).toBool();
     m_fixedSampleRate = settings.value("fixed-sample-rate", 0).toDouble();
     m_resampleOnLoad = settings.value("resample-on-load", false).toBool();
@@ -270,13 +268,6 @@
         return int(m_windowType);
     }
 
-    if (name == "Resample Quality") {
-        if (min) *min = 0;
-        if (max) *max = 2;
-        if (deflt) *deflt = 1;
-        return m_resampleQuality;
-    }
-
     if (name == "Run Vamp Plugins In Process") {
         return m_runPluginsInProcess;
     }
@@ -427,8 +418,6 @@
         setPropertyBoxLayout(value == 0 ? VerticallyStacked : Layered);
     } else if (name == "Window Type") {
         setWindowType(WindowType(value));
-    } else if (name == "Resample Quality") {
-        setResampleQuality(value);
     } else if (name == "Run Vamp Plugins In Process") {
         setRunPluginsInProcess(value ? true : false);
     } else if (name == "Omit Temporaries from Recent Files") {
@@ -523,19 +512,6 @@
 }
 
 void
-Preferences::setResampleQuality(int q)
-{
-    if (m_resampleQuality != q) {
-        m_resampleQuality = q;
-        QSettings settings;
-        settings.beginGroup("Preferences");
-        settings.setValue("resample-quality", q);
-        settings.endGroup();
-        emit propertyChanged("Resample Quality");
-    }
-}
-
-void
 Preferences::setRunPluginsInProcess(bool run)
 {
     if (m_runPluginsInProcess != run) {

--- a/base/Preferences.h	Fri Dec 02 09:14:11 2016 +0000
+++ b/base/Preferences.h	Mon Dec 05 16:39:03 2016 +0000
@@ -51,7 +51,6 @@
     SpectrogramXSmoothing getSpectrogramXSmoothing() const { return m_spectrogramXSmoothing; }
     double getTuningFrequency() const { return m_tuningFrequency; }
     WindowType getWindowType() const { return m_windowType; }
-    int getResampleQuality() const { return m_resampleQuality; }
 
     bool getRunPluginsInProcess() const { return m_runPluginsInProcess; }
     
@@ -118,7 +117,6 @@
     void setTuningFrequency(double freq);
     void setPropertyBoxLayout(PropertyBoxLayout layout);
     void setWindowType(WindowType type);
-    void setResampleQuality(int quality);
     void setRunPluginsInProcess(bool r);
     void setOmitTempsFromRecentFiles(bool omit);
     void setTemporaryDirectoryRoot(QString tempDirRoot);
@@ -157,7 +155,6 @@
     double m_tuningFrequency;
     PropertyBoxLayout m_propertyBoxLayout;
     WindowType m_windowType;
-    int m_resampleQuality;
     bool m_runPluginsInProcess;
     bool m_omitRecentTemps;
     QString m_tempDirRoot;