# HG changeset patch # User Chris Cannam # Date 1233594467 0 # Node ID 57f3eec559571cb05ae09b74a22034126bc84118 # Parent a38f0db6b41da241db16ea7e667f8ff31c0ddbac * Avoid crash in StorageAdviser if temporary directory cannot be opened diff -r a38f0db6b41d -r 57f3eec55957 base/StorageAdviser.cpp --- a/base/StorageAdviser.cpp Thu Jan 29 14:17:12 2009 +0000 +++ b/base/StorageAdviser.cpp Mon Feb 02 17:07:47 2009 +0000 @@ -45,7 +45,13 @@ return m_baseRecommendation; // for now } - QString path = TempDirectory::getInstance()->getPath(); + QString path; + try { + path = TempDirectory::getInstance()->getPath(); + } catch (std::exception e) { + std::cerr << "StorageAdviser::recommend: ERROR: Failed to get temporary directory path: " << e.what() << std::endl; + return Recommendation(UseMemory | ConserveSpace); + } int discFree = GetDiscSpaceMBAvailable(path.toLocal8Bit()); int memoryFree, memoryTotal; GetRealMemoryMBAvailable(memoryFree, memoryTotal);