# HG changeset patch
# User Chris Cannam
# Date 1171304149 0
# Node ID 0031495aba07c4579fba8ed0a9a0e33dbc96a337
# Parent  2854dc42931057fb5ce14fffb893fbc0c61ed7c2
...

diff -r 2854dc429310 -r 0031495aba07 data/fileio/MP3FileReader.cpp
--- a/data/fileio/MP3FileReader.cpp	Mon Feb 12 13:25:12 2007 +0000
+++ b/data/fileio/MP3FileReader.cpp	Mon Feb 12 18:15:49 2007 +0000
@@ -51,7 +51,11 @@
     m_fileSize = stat.st_size;
 
     int fd = -1;
-    if ((fd = ::open(path.toLocal8Bit().data(), O_RDONLY, 0)) < 0) {
+    if ((fd = ::open(path.toLocal8Bit().data(), O_RDONLY
+#ifdef _WIN32
+                     | O_BINARY
+#endif
+                     , 0)) < 0) {
 	m_error = QString("Failed to open file %1 for reading.").arg(path);
 	return;
     }	
@@ -71,12 +75,15 @@
     while (offset < m_fileSize) {
         sz = ::read(fd, filebuffer + offset, m_fileSize - offset);
         if (sz < 0) {
-            m_error = QString("Read error for file %1 (after %2 bytes)").arg(path).arg(offset);
+            m_error = QString("Read error for file %1 (after %2 bytes)")
+                .arg(path).arg(offset);
             delete[] filebuffer;
             ::close(fd);
             return;
         } else if (sz == 0) {
-            std::cerr << QString("MP3FileReader::MP3FileReader: Warning: read only %1 of %2 bytes").arg(offset).arg(m_fileSize).toStdString() << std::endl;
+            std::cerr << QString("MP3FileReader::MP3FileReader: Warning: reached EOF after only %1 of %2 bytes")
+                .arg(offset).arg(m_fileSize).toStdString() << std::endl;
+            m_fileSize = offset;
             break;
         }
         offset += sz;