Mercurial > hg > svcore

diff data/model/WritableWaveFileModel.cpp @ 1671:82d03c9661f9 single-point

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Rework isReady()/getCompletion() on models. Previously the new overhauled models were implementing getCompletion() but inheriting a version of isReady() (from the Model base) that didn't call it, referring only to isOK(). So they were reporting completion as soon as they had begun. Instead hoist getCompletion() to abstract base and call it from Model::isReady().
author Chris Cannam
date Wed, 27 Mar 2019 13:15:16 +0000
parents 70e172e6cc59
children 26da177d7266
line wrap: on
line diff
--- a/data/model/WritableWaveFileModel.cpp	Wed Mar 27 11:26:22 2019 +0000
+++ b/data/model/WritableWaveFileModel.cpp	Wed Mar 27 13:15:16 2019 +0000
@@ -221,15 +221,6 @@
     return (m_model && m_model->isOK());
 }
 
-bool
-WritableWaveFileModel::isReady(int *completion) const
-{
-    int c = getCompletion();
-    if (completion) *completion = c;
-    if (!isOK()) return false;
-    return (c == 100);
-}
-
 void
 WritableWaveFileModel::setWriteProportion(int proportion)
 {