Mercurial > hg > svcore

diff data/model/SparseOneDimensionalModel.h @ 1671:82d03c9661f9 single-point

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Rework isReady()/getCompletion() on models. Previously the new overhauled models were implementing getCompletion() but inheriting a version of isReady() (from the Model base) that didn't call it, referring only to isOK(). So they were reporting completion as soon as they had begun. Instead hoist getCompletion() to abstract base and call it from Model::isReady().
author Chris Cannam
date Wed, 27 Mar 2019 13:15:16 +0000
parents 353a2d15f213
children f97d64b8674f
line wrap: on
line diff
--- a/data/model/SparseOneDimensionalModel.h	Wed Mar 27 11:26:22 2019 +0000
+++ b/data/model/SparseOneDimensionalModel.h	Wed Mar 27 13:15:16 2019 +0000
@@ -81,8 +81,8 @@
     QString getDefaultPlayClipId() const override { return "tap"; }
     
     bool hasTextLabels() const { return m_haveTextLabels; }
-    
-    int getCompletion() const { return m_completion; }
+        
+    int getCompletion() const override { return m_completion; }
 
     void setCompletion(int completion, bool update = true) {