Mercurial > hg > svcore

diff plugin/FeatureExtractionPluginFactory.cpp @ 973:7aa9088e9bcd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fix various slightly dodgy derefs and the like (from coverity scan)
author Chris Cannam
date Wed, 03 Sep 2014 11:20:18 +0100
parents f5cd33909744
children a1cd5abcb38b
line wrap: on
line diff
--- a/plugin/FeatureExtractionPluginFactory.cpp	Wed Sep 03 11:10:22 2014 +0100
+++ b/plugin/FeatureExtractionPluginFactory.cpp	Wed Sep 03 11:20:18 2014 +0100
@@ -48,6 +48,8 @@
     Vamp::Plugin *p = m_plugin;
     delete m_plugin;
     m_plugin = 0;
+    // acceptable use after free here, as pluginDeleted uses p only as
+    // pointer key and does not deref it
     if (m_factory) m_factory->pluginDeleted(p);
 }