comparison data/model/FlexiNoteModel.h @ 1580:c01cbe41aeb5 fix-static-analysis

Use override throughout

         PlayParameterRepository::getInstance()->removePlayable(this);
     }
 
     float getValueQuantization() const { return m_valueQuantization; }
     void setValueQuantization(float q) { m_valueQuantization = q; }
-    float getValueMinimum() const { return 33; }
-    float getValueMaximum() const { return 88; }
-
-    QString getTypeName() const { return tr("FlexiNote"); }
-
-    virtual bool canPlay() const { return true; }
-
-    virtual QString getDefaultPlayClipId() const
+    float getValueMinimum() const override { return 33; }
+    float getValueMaximum() const override { return 88; }
+
+    QString getTypeName() const override { return tr("FlexiNote"); }
+
+    bool canPlay() const override { return true; }
+
+    QString getDefaultPlayClipId() const override
     {
         return "elecpiano";
     }
 
-    virtual void toXml(QTextStream &out,
+    void toXml(QTextStream &out,
                        QString indent = "",
-                       QString extraAttributes = "") const
+                       QString extraAttributes = "") const override
     {
         std::cerr << "FlexiNoteModel::toXml: extraAttributes = \"" 
                   << extraAttributes.toStdString() << std::endl;
 
         IntervalModel<FlexiNote>::toXml

 
     /**
      * TabularModel methods.  
      */
     
-    virtual int getColumnCount() const
+    int getColumnCount() const override
     {
         return 6;
     }
 
-    virtual QString getHeading(int column) const
+    QString getHeading(int column) const override
     {
         switch (column) {
         case 0: return tr("Time");
         case 1: return tr("Frame");
         case 2: return tr("Pitch");

         case 5: return tr("Label");
         default: return tr("Unknown");
         }
     }
 
-    virtual QVariant getData(int row, int column, int role) const
+    QVariant getData(int row, int column, int role) const override
     {
         if (column < 4) {
             return IntervalModel<FlexiNote>::getData(row, column, role);
         }
 

         case 5: return i->label;
         default: return QVariant();
         }
     }
 
-    virtual Command *getSetDataCommand(int row, int column, const QVariant &value, int role)
+    Command *getSetDataCommand(int row, int column, const QVariant &value, int role) override
     {
         if (column < 4) {
             return IntervalModel<FlexiNote>::getSetDataCommand
                 (row, column, value, role);
         }

 
         command->addPoint(point);
         return command->finish();
     }
 
-    virtual SortType getSortType(int column) const
+    SortType getSortType(int column) const override
     {
         if (column == 5) return SortAlphabetical;
         return SortNumeric;
     }
 
     /**
      * NoteExportable methods.
      */
 
     NoteList getNotes() const 
-    {
+    override {
         return getNotesWithin(getStartFrame(), getEndFrame());
     }
 
     NoteList getNotesWithin(sv_frame_t startFrame, sv_frame_t endFrame) const 
-    {    
+    override {    
             PointList points = getPoints(startFrame, endFrame);
         NoteList notes;
         for (PointList::iterator pli = points.begin(); pli != points.end(); ++pli) {
                 sv_frame_t duration = pli->duration;
             if (duration == 0 || duration == 1) {