comparison base/ById.cpp @ 1744:b92bdcd4954b by-id

Update FFT model to ById

             }
         }
     }
         
     void add(int id, std::shared_ptr<WithId> item) {
+        if (id == IdAlloc::NO_ID) {
+            throw std::logic_error("cannot add item with id of NO_ID");
+        }
         QMutexLocker locker(&m_mutex);
         if (m_items.find(id) != m_items.end()) {
             SVCERR << "ById::add: item with id " << id
                    << " is already recorded (existing item type is "
                    << typeid(*m_items.find(id)->second.get()).name()

         }
         m_items[id] = item;
     }
 
     void release(int id) {
+        if (id == IdAlloc::NO_ID) {
+            return;
+        }
         QMutexLocker locker(&m_mutex);
         if (m_items.find(id) == m_items.end()) {
             SVCERR << "ById::release: unknown item id " << id << endl;
             throw std::logic_error("unknown item id in release");
         }
         m_items.erase(id);
     }
     
     std::shared_ptr<WithId> get(int id) const {
+        if (id == IdAlloc::NO_ID) {
+            return {}; // this id cannot be added: avoid locking
+        }
         QMutexLocker locker(&m_mutex);
         const auto &itr = m_items.find(id);
         if (itr != m_items.end()) {
             return itr->second;
         } else {