comparison base/Event.h @ 1866:b4b11af915f4

If duration < 0, swap start time and duration rather than throwing an exception - this is too deep to be throwing an exception here, we end up with bugs like #1989 (Crash when trying to import CSV file with certain unexpected data in it) - and the meaning of negative duration is not actually ambiguous

     Event(sv_frame_t frame, float value, sv_frame_t duration, QString label) :
         m_haveValue(true), m_haveLevel(false), 
         m_haveDuration(true), m_haveReferenceFrame(false),
         m_value(value), m_level(0.f), m_frame(frame),
         m_duration(duration), m_referenceFrame(0), m_label(label) {
-        if (m_duration < 0) throw std::logic_error("duration must be >= 0");
+        if (m_duration < 0) {
+            m_frame += m_duration;
+            m_duration = -m_duration;
+        }
     }
         
     Event(sv_frame_t frame, float value, sv_frame_t duration,
           float level, QString label) :
         m_haveValue(true), m_haveLevel(true), 
         m_haveDuration(true), m_haveReferenceFrame(false),
         m_value(value), m_level(level), m_frame(frame),
         m_duration(duration), m_referenceFrame(0), m_label(label) {
-        if (m_duration < 0) throw std::logic_error("duration must be >= 0");
+        if (m_duration < 0) {
+            m_frame += m_duration;
+            m_duration = -m_duration;
+        }
     }
 
     Event(const Event &event) =default;
 
     // We would ideally like Event to be immutable - but we have to

 
     Event withDuration(sv_frame_t duration) const {
         Event p(*this);
         p.m_duration = duration;
         p.m_haveDuration = true;
-        if (duration < 0) throw std::logic_error("duration must be >= 0");
+        if (p.m_duration < 0) {
+            p.m_frame += p.m_duration;
+            p.m_duration = -p.m_duration;
+        }
         return p;
     }
     Event withoutDuration() const {
         Event p(*this);
         p.m_haveDuration = false;