comparison plugin/FeatureExtractionPluginFactory.cpp @ 1149:afed8be79032 3.0-integration

Show warning to the user when plugin population has problems

 
     return candidates;
 }
 
 vector<QString>
-FeatureExtractionPluginFactory::winnowPluginCandidates(vector<QString> candidates)
+FeatureExtractionPluginFactory::winnowPluginCandidates(vector<QString> candidates,
+                                                       QString &warningMessage)
 {
     vector<QString> good, bad;
     vector<PluginLoadStatus> badStatuses;
     
     for (QString c: candidates) {

             badStatuses.push_back(status);
         }
     }
     
     if (!bad.empty()) {
-        QString warningMessage = "<b>Failed to load plugins</b></p>Failed to load one or more plugin libraries:</p><ul>\n";
+        warningMessage =
+            QObject::tr("<b>Failed to load plugins</b>"
+                        "<p>Failed to load one or more plugin libraries:</p>\n");
+        warningMessage += "<ul>";
         for (int i = 0; i < bad.size(); ++i) {
             QString m;
             if (badStatuses[i] == PluginLoadFailedToLoadLibrary) {
-                m = "Failed to load library";
+                m = QObject::tr("Failed to load library");
             } else if (badStatuses[i] == PluginLoadFailedToFindDescriptor) {
-                m = "Failed to query plugins from library after loading";
+                m = QObject::tr("Failed to query plugins from library after loading");
             } else if (badStatuses[i] == PluginLoadFailedElsewhere) {
-                m = "Unknown failure";
+                m = QObject::tr("Unknown failure");
             } else {
-                m = "Success: internal error?";
+                m = QObject::tr("Success: internal error?");
             }
             warningMessage += QString("<li>%1 (%2)</li>\n")
                 .arg(bad[i])
                 .arg(m);
         }
         warningMessage += "</ul>";
-        cerr << warningMessage; //!!! for now!
     }
     return good;
 }
 
 vector<QString>
 FeatureExtractionPluginFactory::getPluginIdentifiers()
 {
     Profiler profiler("FeatureExtractionPluginFactory::getPluginIdentifiers");
 
     vector<QString> rv;
-    vector<QString> candidates = winnowPluginCandidates(getPluginCandidateFiles());
+    vector<QString> candidates = winnowPluginCandidates(getPluginCandidateFiles(),
+                                                        m_pluginScanError);
     
     for (QString soname : candidates) {
 
 #ifdef DEBUG_PLUGIN_SCAN_AND_INSTANTIATE
         SVDEBUG << "FeatureExtractionPluginFactory::getPluginIdentifiers: trying potential library " << soname << endl;

                      << soname
                      << " returns the same plugin identifier \""
                      << descriptor->identifier << "\" at indices "
                      << known[descriptor->identifier] << " and "
                      << index << endl;
-                SVDEBUG << "FeatureExtractionPluginFactory::getPluginIdentifiers: Avoiding this library (obsolete API?)" << endl;
+                cerr << "FeatureExtractionPluginFactory::getPluginIdentifiers: Avoiding this library (obsolete API?)" << endl;
                 ok = false;
                 break;
             } else {
                 known[descriptor->identifier] = index;
             }