comparison data/model/NoteModel.h @ 1671:82d03c9661f9 single-point

Rework isReady()/getCompletion() on models. Previously the new overhauled models were implementing getCompletion() but inheriting a version of isReady() (from the Model base) that didn't call it, referring only to isOK(). So they were reporting completion as soon as they had begun. Instead hoist getCompletion() to abstract base and call it from Model::isReady().

     void setValueQuantization(float q) { m_valueQuantization = q; }
 
     float getValueMinimum() const { return m_valueMinimum; }
     float getValueMaximum() const { return m_valueMaximum; }
     
-    int getCompletion() const { return m_completion; }
+    int getCompletion() const override { return m_completion; }
 
     void setCompletion(int completion, bool update = true) {
 
         {   QMutexLocker locker(&m_mutex);
             if (m_completion == completion) return;